Inspection of "Merge pull request #5314 from Arminek/seeing-shipp..." - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (429264)

by Kamil

created 2016-06-24 13:55 UTC

Doc Comments +3 added lines patch added patch discarded remove patch

@@ -20,16 +20,19 @@
 block discarded – undo
 {
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
     /**
      * @param string $description
+     * @return void
      */
     public function describeItAs($description);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/TaxCategory/UpdatePageInterface.php 1 patch

Doc Comments +1 added lines patch added patch discarded remove patch

@@ -25,6 +25,7 @@
 block discarded – undo
 
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Taxon/CreatePageInterface.php 1 patch

Doc Comments +6 added lines patch added patch discarded remove patch

@@ -33,17 +33,20 @@  discard block
 block discarded – undo
 
     /**
      * @param string $name
+     * @return void
      */
     public function deleteTaxonOnPageByName($name);
 
     /**
      * @param string $description
      * @param string $languageCode
+     * @return void
      */
     public function describeItAs($description, $languageCode);
 
     /**
      * @param TaxonInterface $taxon
+     * @return void
      */
     public function chooseParent(TaxonInterface $taxon);
 
@@ -57,17 +60,20 @@  discard block
 block discarded – undo
     /**
      * @param string $name
      * @param string $languageCode
+     * @return void
      */
     public function nameIt($name, $languageCode);
 
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $permalink
      * @param string $languageCode
+     * @return void
      */
     public function specifyPermalink($permalink, $languageCode);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Taxon/UpdatePageInterface.php 1 patch

Doc Comments +4 added lines patch added patch discarded remove patch

@@ -22,11 +22,13 @@  discard block
 block discarded – undo
     /**
      * @param string $description
      * @param string $languageCode
+     * @return void
      */
     public function describeItAs($description, $languageCode);
 
     /**
      * @param TaxonInterface $taxon
+     * @return void
      */
     public function chooseParent(TaxonInterface $taxon);
 
@@ -38,12 +40,14 @@  discard block
 block discarded – undo
     /**
      * @param string $name
      * @param string $languageCode
+     * @return void
      */
     public function nameIt($name, $languageCode);
 
     /**
      * @param string $permalink
      * @param string $languageCode
+     * @return void
      */
     public function specifyPermalink($permalink, $languageCode);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/TaxRate/CreatePageInterface.php 1 patch

Doc Comments +6 added lines patch added patch discarded remove patch

@@ -20,31 +20,37 @@
 block discarded – undo
 {
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
     /**
      * @param string $amount
+     * @return void
      */
     public function specifyAmount($amount);
 
     /**
      * @param string $name
+     * @return void
      */
     public function chooseZone($name);
 
     /**
      * @param string $name
+     * @return void
      */
     public function chooseCategory($name);
 
     /**
      * @param string $name
+     * @return void
      */
     public function chooseCalculator($name);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Zone/CreatePageInterface.php 1 patch

Doc Comments +7 added lines patch added patch discarded remove patch

@@ -18,15 +18,20 @@  discard block
 block discarded – undo
  */
 interface CreatePageInterface extends BaseCreatePageInterface
 {
+    /**
+     * @return void
+     */
     public function addMember();
 
     /**
      * @param string $message
+     * @return boolean
      */
     public function checkValidationMessageForMembers($message);
 
     /**
      * @param $name
+     * @return void
      */
     public function chooseMember($name);
 
@@ -44,11 +49,13 @@  discard block
 block discarded – undo
 
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Zone/UpdatePageInterface.php 1 patch

Doc Comments +2 added lines patch added patch discarded remove patch

@@ -21,6 +21,7 @@  discard block
 block discarded – undo
 {
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
@@ -43,6 +44,7 @@  discard block
 block discarded – undo
 
     /**
      * @param ZoneMemberInterface $zoneMember
+     * @return void
      */
     public function removeMember(ZoneMemberInterface $zoneMember);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/External/PaypalExpressCheckoutPageInterface.php 1 patch

Doc Comments +2 added lines patch added patch discarded remove patch

@@ -23,12 +23,14 @@
 block discarded – undo
     /**
      * @throws UnsupportedDriverActionException
      * @throws DriverException
+     * @return void
      */
     public function pay();
 
     /**
      * @throws UnsupportedDriverActionException
      * @throws DriverException
+     * @return void
      */
     public function cancel();
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Page.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -243,7 +243,7 @@
 block discarded – undo
     }
 
     /**
-     * @param string|array $selector
+     * @param string $selector
      * @param SelectorsHandler $selectorsHandler
      *
      * @return string

Please login to merge, or discard this patch.

		@@ -243,7 +243,7 @@
		block discarded – undo
243	243	}
244	244
245	245	/**
246		- * @param string\|array $selector
	246	+ * @param string $selector
247	247	* @param SelectorsHandler $selectorsHandler
248	248	*
249	249	* @return string

		@@ -20,16 +20,19 @@
		block discarded – undo
20	20	{
21	21	/**
22	22	* @param string $code
	23	+ * @return void
23	24	*/
24	25	public function specifyCode($code);
25	26
26	27	/**
27	28	* @param string $name
	29	+ * @return void
28	30	*/
29	31	public function nameIt($name);
30	32
31	33	/**
32	34	* @param string $description
	35	+ * @return void
33	36	*/
34	37	public function describeItAs($description);
35	38	}

		@@ -25,6 +25,7 @@
		block discarded – undo
25	25
26	26	/**
27	27	* @param string $name
	28	+ * @return void
28	29	*/
29	30	public function nameIt($name);
30	31	}

		@@ -33,17 +33,20 @@ discard block
		block discarded – undo
33	33
34	34	/**
35	35	* @param string $name
	36	+ * @return void
36	37	*/
37	38	public function deleteTaxonOnPageByName($name);
38	39
39	40	/**
40	41	* @param string $description
41	42	* @param string $languageCode
	43	+ * @return void
42	44	*/
43	45	public function describeItAs($description, $languageCode);
44	46
45	47	/**
46	48	* @param TaxonInterface $taxon
	49	+ * @return void
47	50	*/
48	51	public function chooseParent(TaxonInterface $taxon);
49	52
		@@ -57,17 +60,20 @@ discard block
		block discarded – undo
57	60	/**
58	61	* @param string $name
59	62	* @param string $languageCode
	63	+ * @return void
60	64	*/
61	65	public function nameIt($name, $languageCode);
62	66
63	67	/**
64	68	* @param string $code
	69	+ * @return void
65	70	*/
66	71	public function specifyCode($code);
67	72
68	73	/**
69	74	* @param string $permalink
70	75	* @param string $languageCode
	76	+ * @return void
71	77	*/
72	78	public function specifyPermalink($permalink, $languageCode);
73	79	}

		@@ -22,11 +22,13 @@ discard block
		block discarded – undo
22	22	/**
23	23	* @param string $description
24	24	* @param string $languageCode
	25	+ * @return void
25	26	*/
26	27	public function describeItAs($description, $languageCode);
27	28
28	29	/**
29	30	* @param TaxonInterface $taxon
	31	+ * @return void
30	32	*/
31	33	public function chooseParent(TaxonInterface $taxon);
32	34
		@@ -38,12 +40,14 @@ discard block
		block discarded – undo
38	40	/**
39	41	* @param string $name
40	42	* @param string $languageCode
	43	+ * @return void
41	44	*/
42	45	public function nameIt($name, $languageCode);
43	46
44	47	/**
45	48	* @param string $permalink
46	49	* @param string $languageCode
	50	+ * @return void
47	51	*/
48	52	public function specifyPermalink($permalink, $languageCode);
49	53	}

		@@ -20,31 +20,37 @@
		block discarded – undo
20	20	{
21	21	/**
22	22	* @param string $code
	23	+ * @return void
23	24	*/
24	25	public function specifyCode($code);
25	26
26	27	/**
27	28	* @param string $name
	29	+ * @return void
28	30	*/
29	31	public function nameIt($name);
30	32
31	33	/**
32	34	* @param string $amount
	35	+ * @return void
33	36	*/
34	37	public function specifyAmount($amount);
35	38
36	39	/**
37	40	* @param string $name
	41	+ * @return void
38	42	*/
39	43	public function chooseZone($name);
40	44
41	45	/**
42	46	* @param string $name
	47	+ * @return void
43	48	*/
44	49	public function chooseCategory($name);
45	50
46	51	/**
47	52	* @param string $name
	53	+ * @return void
48	54	*/
49	55	public function chooseCalculator($name);
50	56	}

		@@ -18,15 +18,20 @@ discard block
		block discarded – undo
18	18	*/
19	19	interface CreatePageInterface extends BaseCreatePageInterface
20	20	{
	21	+ /**
	22	+ * @return void
	23	+ */
21	24	public function addMember();
22	25
23	26	/**
24	27	* @param string $message
	28	+ * @return boolean
25	29	*/
26	30	public function checkValidationMessageForMembers($message);
27	31
28	32	/**
29	33	* @param $name
	34	+ * @return void
30	35	*/
31	36	public function chooseMember($name);
32	37
		@@ -44,11 +49,13 @@ discard block
		block discarded – undo
44	49
45	50	/**
46	51	* @param string $name
	52	+ * @return void
47	53	*/
48	54	public function nameIt($name);
49	55
50	56	/**
51	57	* @param string $code
	58	+ * @return void
52	59	*/
53	60	public function specifyCode($code);
54	61	}

		@@ -21,6 +21,7 @@ discard block
		block discarded – undo
21	21	{
22	22	/**
23	23	* @param string $name
	24	+ * @return void
24	25	*/
25	26	public function nameIt($name);
26	27
		@@ -43,6 +44,7 @@ discard block
		block discarded – undo
43	44
44	45	/**
45	46	* @param ZoneMemberInterface $zoneMember
	47	+ * @return void
46	48	*/
47	49	public function removeMember(ZoneMemberInterface $zoneMember);
48	50	}

		@@ -23,12 +23,14 @@
		block discarded – undo
23	23	/**
24	24	* @throws UnsupportedDriverActionException
25	25	* @throws DriverException
	26	+ * @return void
26	27	*/
27	28	public function pay();
28	29
29	30	/**
30	31	* @throws UnsupportedDriverActionException
31	32	* @throws DriverException
	33	+ * @return void
32	34	*/
33	35	public function cancel();
34	36	}

pamil / Sylius

Branch — master (429264)

Category

Doc Comments +3 added lines patch added patch discarded remove patch

Doc Comments +1 added lines patch added patch discarded remove patch

Doc Comments +6 added lines patch added patch discarded remove patch

Doc Comments +4 added lines patch added patch discarded remove patch

Doc Comments +6 added lines patch added patch discarded remove patch

Doc Comments +7 added lines patch added patch discarded remove patch

Doc Comments +2 added lines patch added patch discarded remove patch

Doc Comments +2 added lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch