pamil / Sylius

src/Sylius/Bundle/FixturesBundle/spec/Suite/SuiteSpec.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 namespace spec\Sylius\Bundle\FixturesBundle\Suite;
 
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 use Sylius\Bundle\FixturesBundle\Fixture\FixtureInterface;
 use Sylius\Bundle\FixturesBundle\Suite\Suite;
 use Sylius\Bundle\FixturesBundle\Suite\SuiteInterface;

src/Sylius/Bundle/FlowBundle/DependencyInjection/SyliusFlowExtension.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 namespace Sylius\Bundle\FlowBundle\DependencyInjection;
 
-use Symfony\Component\Config\Definition\Processor;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     public function load(array $config, ContainerBuilder $container)
     {
         $config = $this->processConfiguration($this->getConfiguration($config, $container), $config);
-        $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config/container'));
+        $loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config/container'));
 
         $container->setAlias('sylius.process_storage', $config['storage']);
 

src/Sylius/Bundle/FlowBundle/Process/Builder/ProcessBuilderInterface.php

Doc Comments +11 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
      * Add a step with given name.
      *
      * @param string               $name
-     * @param string|StepInterface $step Step alias or instance
+     * @param string $step Step alias or instance
      * 
      * @return ProcessBuilderInterface
      */
@@ -46,6 +46,7 @@ 
      * Remove step with given name.
      *
      * @param string $name
+     * @return void
      */
     public function remove($name);
 
@@ -62,6 +63,7 @@ 
      * Set display route.
      *
      * @param string $route
+     * @return ProcessBuilder
      */
     public function setDisplayRoute($route);
 
@@ -69,6 +71,7 @@ 
      * Set additional forward route params.
      *
      * @param array $params
+     * @return ProcessBuilder
      */
     public function setDisplayRouteParams(array $params);
 
@@ -76,6 +79,7 @@ 
      * Set forward route.
      *
      * @param string $route
+     * @return ProcessBuilder
      */
     public function setForwardRoute($route);
 
@@ -83,6 +87,7 @@ 
      * Set additional forward route params.
      *
      * @param array $params
+     * @return ProcessBuilder
      */
     public function setForwardRouteParams(array $params);
 
@@ -90,6 +95,7 @@ 
      * Set redirection route after completion.
      *
      * @param string $redirect
+     * @return ProcessBuilder
      */
     public function setRedirect($redirect);
 
@@ -97,13 +103,15 @@ 
      * Set redirection route params.
      *
      * @param array $params
+     * @return ProcessBuilder
      */
     public function setRedirectParams(array $params);
 
     /**
      * Validation of process, if returns false, process is suspended.
      *
-     * @param \Closure|ProcessValidatorInterface $validator
+     * @param \Prophecy\Argument\Token\AnyValueToken $validator
+     * @return ProcessBuilder
      */
     public function validate($validator);
 
@@ -112,6 +120,7 @@ 
      *
      * @param string        $alias
      * @param StepInterface $step
+     * @return void
      */
     public function registerStep($alias, StepInterface $step);
 

src/Sylius/Bundle/FlowBundle/Process/Context/ProcessContextInterface.php

Doc Comments +8 added lines

@@ -29,6 +29,7 @@ 
      *
      * @param ProcessInterface $process
      * @param StepInterface    $currentStep
+     * @return ProcessContext
      */
     public function initialize(ProcessInterface $process, StepInterface $currentStep);
 
@@ -78,11 +79,13 @@ 
      * Override the default next step.
      *
      * @param string $stepAlias
+     * @return void
      */
     public function setNextStepByName($stepAlias);
 
     /**
      * Close context and clear all the data.
+     * @return void
      */
     public function close();
 
@@ -104,6 +107,7 @@ 
      * Set storage.
      *
      * @param StorageInterface $storage
+     * @return void
      */
     public function setStorage(StorageInterface $storage);
 
@@ -118,6 +122,7 @@ 
      * Set current request.
      *
      * @param Request $request
+     * @return void
      */
     public function setRequest(Request $request);
 
@@ -139,6 +144,7 @@ 
      * Set a new history of step names.
      *
      * @param array $history
+     * @return void
      */
     public function setStepHistory(array $history);
 
@@ -146,6 +152,7 @@ 
      * Add the given name to the history of step names.
      *
      * @param string $stepName
+     * @return void
      */
     public function addStepToHistory($stepName);
 
@@ -153,6 +160,7 @@ 
      * Goes back from the end fo the history and deletes all step names until the current one is found.
      *
      * @throws NotFoundHttpException If the step name is not found in the history.
+     * @return void
      */
     public function rewindHistory();
 }

src/Sylius/Bundle/FlowBundle/Process/Coordinator/CoordinatorInterface.php

Doc Comments +3 added lines, -2 removed lines

@@ -42,7 +42,7 @@ 
      * @param string       $stepName
      * @param ParameterBag $queryParameters
      *
-     * @return Response|View
+     * @return RedirectResponse
      */
     public function display($scenarioAlias, $stepName, ParameterBag $queryParameters = null);
 
@@ -53,7 +53,7 @@ 
      * @param string $scenarioAlias
      * @param string $stepName
      *
-     * @return Response|View
+     * @return RedirectResponse
      */
     public function forward($scenarioAlias, $stepName);
 
@@ -62,6 +62,7 @@ 
      *
      * @param string                   $alias
      * @param ProcessScenarioInterface $scenario
+     * @return void
      */
     public function registerScenario($alias, ProcessScenarioInterface $scenario);
 

src/Sylius/Bundle/FlowBundle/Process/ProcessInterface.php

Doc Comments +10 added lines

@@ -32,6 +32,7 @@ 
      * Set scenario alias.
      *
      * @param string $scenarioAlias
+     * @return void
      */
     public function setScenarioAlias($scenarioAlias);
 
@@ -47,6 +48,7 @@ 
      * Set steps.
      *
      * @param StepInterface[] $steps
+     * @return void
      */
     public function setSteps(array $steps);
 
@@ -76,6 +78,7 @@ 
      *
      * @param string        $name
      * @param StepInterface $step
+     * @return void
      */
     public function addStep($name, StepInterface $step);
 
@@ -83,6 +86,7 @@ 
      * Remove step.
      *
      * @param string $name
+     * @return void
      */
     public function removeStep($name);
 
@@ -129,6 +133,7 @@ 
      * Set redirection after complete.
      *
      * @param string $redirect
+     * @return void
      */
     public function setRedirect($redirect);
 
@@ -143,6 +148,7 @@ 
      * Set redirection route params after complete.
      *
      * @param array $params
+     * @return void
      */
     public function setRedirectParams(array $params);
 
@@ -157,6 +163,7 @@ 
      * Set display route.
      *
      * @param string $route
+     * @return void
      */
     public function setDisplayRoute($route);
 
@@ -171,6 +178,7 @@ 
      * Set additional display route params.
      *
      * @param array $params
+     * @return void
      */
     public function setDisplayRouteParams(array $params);
 
@@ -185,6 +193,7 @@ 
      * Set forward route.
      *
      * @param string $route
+     * @return void
      */
     public function setForwardRoute($route);
 
@@ -199,6 +208,7 @@ 
      * Set additional forward route params.
      *
      * @param array $params
+     * @return void
      */
     public function setForwardRouteParams(array $params);
 

src/Sylius/Bundle/FlowBundle/Process/Scenario/ProcessScenarioInterface.php

Doc Comments +1 added lines

@@ -27,6 +27,7 @@
      * Builds the whole process.
      *
      * @param ProcessBuilderInterface $builder
+     * @return void
      */
     public function build(ProcessBuilderInterface $builder);
 }

src/Sylius/Bundle/FlowBundle/Process/Step/StepInterface.php

Doc Comments +1 added lines

@@ -28,6 +28,7 @@
      * Set step name.
      *
      * @param string $name
+     * @return void
      */
     public function setName($name);
 

src/Sylius/Bundle/FlowBundle/Validator/ProcessValidator.php

Doc Comments +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
     /**
      * Set validation.
      *
-     * @param callable $validation
+     * @param \Closure $validation
      *
      * @return $this
      */