Sylius\Component\Core\Promotion\Action\FixedDiscountPromotionActionCommand

Complexity

Total Complexity

10

Size/Duplication

Total Lines	108
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
B	execute()	0	24	4
A	getConfigurationFormType()	0	4	1
A	isConfigurationValid()	0	5	1
A	calculateAdjustmentAmount()	0	4	1
A	getAmountByCurrencyCode()	0	11	2

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sylius\Component\Core\Promotion\Action;

use Sylius\Component\Core\Distributor\ProportionalIntegerDistributorInterface;
use Sylius\Component\Core\Promotion\Applicator\UnitsPromotionAdjustmentsApplicatorInterface;
use Sylius\Component\Currency\Converter\CurrencyConverterInterface;
use Sylius\Component\Promotion\Model\PromotionInterface;
use Sylius\Component\Promotion\Model\PromotionSubjectInterface;
use Webmozart\Assert\Assert;

/**
 * @author Paweł Jędrzejewski <pawel@sylius.org>
 * @author Saša Stamenković <umpirsky@gmail.com>
 * @author Mateusz Zalewski <mateusz.zalewski@lakion.com>
 * @author Grzegorz Sadowski <grzegorz.sadowski@lakion.com>
 */
final class FixedDiscountPromotionActionCommand extends DiscountPromotionActionCommand
{
    const TYPE = 'order_fixed_discount';

    /**
     * @var ProportionalIntegerDistributorInterface
     */
    private $proportionalDistributor;

    /**
     * @var UnitsPromotionAdjustmentsApplicatorInterface
     */
    private $unitsPromotionAdjustmentsApplicator;

    /**
     * @var CurrencyConverterInterface
     */
    private $currencyConverter;

    /**
     * @param ProportionalIntegerDistributorInterface $proportionalIntegerDistributor
     * @param UnitsPromotionAdjustmentsApplicatorInterface $unitsPromotionAdjustmentsApplicator
     * @param CurrencyConverterInterface $currencyConverter
     */
    public function __construct(
        ProportionalIntegerDistributorInterface $proportionalIntegerDistributor,

The variable name $proportionalIntegerDistributor exceeds the maximum configured length of 20.

        UnitsPromotionAdjustmentsApplicatorInterface $unitsPromotionAdjustmentsApplicator,

The variable name $unitsPromotionAdjustmentsApplicator exceeds the maximum configured length of 20.

        CurrencyConverterInterface $currencyConverter
    ) {
        $this->proportionalDistributor = $proportionalIntegerDistributor;
        $this->unitsPromotionAdjustmentsApplicator = $unitsPromotionAdjustmentsApplicator;
        $this->currencyConverter = $currencyConverter;
    }

    /**
     * {@inheritdoc}
     */
    public function execute(PromotionSubjectInterface $subject, array $configuration, PromotionInterface $promotion)
    {
        if (!$this->isSubjectValid($subject)) {
            return;
        }

        $this->isConfigurationValid($configuration);

        $promotionAmount = $this->calculateAdjustmentAmount(
            $subject->getPromotionSubjectTotal(),
            $this->getAmountByCurrencyCode($configuration, $subject->getCurrencyCode())
        );
        if (0 === $promotionAmount) {
            return;
        }

        $itemsTotals = [];
        foreach ($subject->getItems() as $item) {
            $itemsTotals[] = $item->getTotal();
        }

        $splitPromotion = $this->proportionalDistributor->distribute($itemsTotals, $promotionAmount);
        $this->unitsPromotionAdjustmentsApplicator->apply($subject, $promotion, $splitPromotion);

$subject of type object<Sylius\Component\Promotion\Model\PromotionSubjectInterface> is not a sub-type of object<Sylius\Component\Core\Model\OrderInterface>. It seems like you assume a child interface of the interface Sylius\Component\Promotion\Model\PromotionSubjectInterface to be always present.

    }

    /**
     * {@inheritdoc}
     */
    public function getConfigurationFormType()
    {
        return 'sylius_promotion_action_fixed_discount_configuration';
    }

    /**
     * {@inheritdoc}
     */
    protected function isConfigurationValid(array $configuration)
    {
        Assert::keyExists($configuration, 'base_amount');
        Assert::integer($configuration['base_amount']);
    }

    /**
     * @param int $promotionSubjectTotal
     * @param int $targetPromotionAmount
     *
     * @return int
     */
    private function calculateAdjustmentAmount($promotionSubjectTotal, $targetPromotionAmount)

The variable name $promotionSubjectTotal exceeds the maximum configured length of 20.

The variable name $targetPromotionAmount exceeds the maximum configured length of 20.

    {
        return -1 * min($promotionSubjectTotal, $targetPromotionAmount);
    }

    /**
     * @param array $configuration
     * @param string $currencyCode
     *
     * @return int
     */
    private function getAmountByCurrencyCode(array $configuration, $currencyCode)
    {
        if (!isset($configuration['amounts'][$currencyCode])) {
            return $configuration['base_amount'];
        }

        return $this->currencyConverter->convertToBase(
            $configuration['amounts'][$currencyCode],
            $currencyCode
        );
    }
}