Inspection of "Upgrade PromotionBundle's form types to Symfony3 -..." - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — symfony3-fqcn-promotion ( 3a6e99...c2e0cd )

by Kamil

created 2016-11-26 20:02 UTC

Status

Doc Comments +3 added lines patch added patch discarded remove patch

@@ -39,6 +39,7 @@  discard block
 block discarded – undo
      * Sets all option values.
      *
      * @param Collection $optionValues
+     * @return void
      */
     public function setValues(Collection $optionValues);
 
@@ -46,6 +47,7 @@  discard block
 block discarded – undo
      * Adds option value.
      *
      * @param OptionValueInterface $optionValue
+     * @return void
      */
     public function addValue(OptionValueInterface $optionValue);
 
@@ -53,6 +55,7 @@  discard block
 block discarded – undo
      * Removes option value.
      *
      * @param OptionValueInterface $optionValue
+     * @return void
      */
     public function removeValue(OptionValueInterface $optionValue);
 

Please login to merge, or discard this patch.

src/Sylius/Bundle/CoreBundle/Form/Extension/CountryTypeExtension.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -93,7 +93,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @param $code
+     * @param string $code
      *
      * @return null|string
      */
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     private function getAvailableCountries()
     {

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Product/UpdateSimpleProductPageInterface.php 1 patch

Doc Comments +21 added lines patch added patch discarded remove patch

@@ -29,18 +29,21 @@  discard block
 block discarded – undo
     public function isCodeDisabled();
 
     /**
+     * @param string $locale
      * @return bool
      */
     public function isSlugReadOnlyIn($locale);
     
     /**
      * @param int $price
+     * @return void
      */
     public function specifyPrice($price);
 
     /**
      * @param string $name
      * @param string $localeCode
+     * @return void
      */
     public function nameItIn($name, $localeCode);
 
@@ -67,11 +70,18 @@  discard block
 block discarded – undo
 
     /**
      * @param TaxonInterface $taxon
+     * @return void
      */
     public function selectMainTaxon(TaxonInterface $taxon);
 
+    /**
+     * @return void
+     */
     public function disableTracking();
 
+    /**
+     * @return void
+     */
     public function enableTracking();
 
     /**
@@ -81,6 +91,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $locale
+     * @return void
      */
     public function enableSlugModification($locale);
 
@@ -94,20 +105,26 @@  discard block
 block discarded – undo
     /**
      * @param string $path
      * @param string $code
+     * @return void
      */
     public function attachImage($path, $code = null);
 
     /**
      * @param string $code
      * @param string $path
+     * @return void
      */
     public function changeImageWithCode($code, $path);
 
     /**
      * @param string $code
+     * @return void
      */
     public function removeImageWithCode($code);
 
+    /**
+     * @return void
+     */
     public function removeFirstImage();
 
     /**
@@ -130,6 +147,7 @@  discard block
 block discarded – undo
     /**
      * @param ProductAssociationTypeInterface $productAssociationType
      * @param string[] $productsNames
+     * @return void
      */
     public function associateProducts(ProductAssociationTypeInterface $productAssociationType, array $productsNames);
 
@@ -144,6 +162,7 @@  discard block
 block discarded – undo
     /**
      * @param string $productName
      * @param ProductAssociationTypeInterface $productAssociationType
+     * @return void
      */
     public function removeAssociatedProduct($productName, ProductAssociationTypeInterface $productAssociationType);
 
@@ -157,6 +176,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $locale
+     * @return void
      */
     public function activateLanguageTab($locale);
 
@@ -170,6 +190,7 @@  discard block
 block discarded – undo
     /**
      * @param string $slug
      * @param string $locale
+     * @return void
      */
     public function specifySlugIn($slug, $locale);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/DashboardPageInterface.php 1 patch

Doc Comments +4 added lines patch added patch discarded remove patch

@@ -26,10 +26,14 @@
 block discarded – undo
      */
     public function checkValidationMessageFor($element, $message);
 
+    /**
+     * @return void
+     */
     public function reset();
 
     /**
      * @param string $email
+     * @return void
      */
     public function specifyEmail($email);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/ShippingCategory/CreatePageInterface.php 1 patch

Doc Comments +1 added lines patch added patch discarded remove patch

@@ -27,6 +27,7 @@
 block discarded – undo
 
     /**
      * @param string $value
+     * @return void
      */
     public function setValue($value);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Product/CreateSimpleProductPageInterface.php 1 patch

Doc Comments +13 added lines patch added patch discarded remove patch

@@ -23,11 +23,13 @@  discard block
 block discarded – undo
 {
     /**
      * @param int $price
+     * @return void
      */
     public function specifyPrice($price);
 
     /**
      * @param string $name
+     * @return void
      */
     public function choosePricingCalculator($name);
 
@@ -35,62 +37,73 @@  discard block
 block discarded – undo
      * @param int $price
      * @param ChannelInterface $channel
      * @param CurrencyInterface $currency
+     * @return void
      */
     public function specifyPriceForChannelAndCurrency($price, ChannelInterface $channel, CurrencyInterface $currency);
 
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $name
      * @param string $localeCode
+     * @return void
      */
     public function nameItIn($name, $localeCode);
 
     /**
      * @param string $slug
      * @param string $locale
+     * @return void
      */
     public function specifySlugIn($slug, $locale);
 
     /**
      * @param string $attribute
      * @param string $value
+     * @return void
      */
     public function addAttribute($attribute, $value);
 
     /**
      * @param string $attribute
+     * @return void
      */
     public function removeAttribute($attribute);
 
     /**
      * @param string $path
      * @param string $code
+     * @return void
      */
     public function attachImage($path, $code = null);
 
     /**
      * @param ProductAssociationTypeInterface $productAssociationType
      * @param string[] $productsNames
+     * @return void
      */
     public function associateProducts(ProductAssociationTypeInterface $productAssociationType, array $productsNames);
 
     /**
      * @param string $productName
      * @param ProductAssociationTypeInterface $productAssociationType
+     * @return void
      */
     public function removeAssociatedProduct($productName, ProductAssociationTypeInterface $productAssociationType);
 
     /**
      * @param string $locale
+     * @return void
      */
     public function activateLanguageTab($locale);
 
     /**
      * @param string $shippingCategoryName
+     * @return void
      */
     public function selectShippingCategory($shippingCategoryName);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/ProductVariant/CreatePageInterface.php 1 patch

Doc Comments +9 added lines patch added patch discarded remove patch

@@ -55,11 +55,13 @@  discard block
 block discarded – undo
 
     /**
      * @param ProductVariantImageInterface $image
+     * @return void
      */
     public function addImage(ProductVariantImageInterface $image);
 
     /**
      * @param ProductVariantImageInterface $image
+     * @return void
      */
     public function removeImage(ProductVariantImageInterface $image);
 
@@ -70,6 +72,7 @@  discard block
 block discarded – undo
 
     /**
      * @param int $sold
+     * @return void
      */
     public function setSold($sold);
 
@@ -80,6 +83,7 @@  discard block
 block discarded – undo
 
     /**
      * @param float $weight
+     * @return void
      */
     public function setWeight($weight);
 
@@ -90,6 +94,7 @@  discard block
 block discarded – undo
 
     /**
      * @param float $width
+     * @return void
      */
     public function setWidth($width);
 
@@ -100,6 +105,7 @@  discard block
 block discarded – undo
 
     /**
      * @param float $height
+     * @return void
      */
     public function setHeight($height);
 
@@ -110,6 +116,7 @@  discard block
 block discarded – undo
 
     /**
      * @param float $depth
+     * @return void
      */
     public function setDepth($depth);
 
@@ -120,6 +127,7 @@  discard block
 block discarded – undo
 
     /**
      * @param int|null $originalPrice
+     * @return void
      */
     public function setOriginalPrice($originalPrice);
 
@@ -130,6 +138,7 @@  discard block
 block discarded – undo
 
     /**
      * @param TaxCategoryInterface $category
+     * @return void
      */
     public function setTaxCategory(TaxCategoryInterface $category = null);
 }

Please login to merge, or discard this patch.

Sylius/Bundle/ResourceBundle/Form/Registry/FormTypeRegistryInterface.php 1 patch

Doc Comments +1 added lines patch added patch discarded remove patch

@@ -27,6 +27,7 @@
 block discarded – undo
 
     /**
      * @param string $value
+     * @return void
      */
     public function setValue($value);
 }

Please login to merge, or discard this patch.

src/Sylius/Component/Core/Model/ProductInterface.php 1 patch

Doc Comments +3 added lines patch added patch discarded remove patch

@@ -39,6 +39,7 @@  discard block
 block discarded – undo
      * Sets all option values.
      *
      * @param Collection $optionValues
+     * @return void
      */
     public function setValues(Collection $optionValues);
 
@@ -46,6 +47,7 @@  discard block
 block discarded – undo
      * Adds option value.
      *
      * @param OptionValueInterface $optionValue
+     * @return void
      */
     public function addValue(OptionValueInterface $optionValue);
 
@@ -53,6 +55,7 @@  discard block
 block discarded – undo
      * Removes option value.
      *
      * @param OptionValueInterface $optionValue
+     * @return void
      */
     public function removeValue(OptionValueInterface $optionValue);
 

Please login to merge, or discard this patch.

		@@ -39,6 +39,7 @@ discard block
		block discarded – undo
39	39	* Sets all option values.
40	40	*
41	41	* @param Collection $optionValues
	42	+ * @return void
42	43	*/
43	44	public function setValues(Collection $optionValues);
44	45
		@@ -46,6 +47,7 @@ discard block
		block discarded – undo
46	47	* Adds option value.
47	48	*
48	49	* @param OptionValueInterface $optionValue
	50	+ * @return void
49	51	*/
50	52	public function addValue(OptionValueInterface $optionValue);
51	53
		@@ -53,6 +55,7 @@ discard block
		block discarded – undo
53	55	* Removes option value.
54	56	*
55	57	* @param OptionValueInterface $optionValue
	58	+ * @return void
56	59	*/
57	60	public function removeValue(OptionValueInterface $optionValue);
58	61

		@@ -93,7 +93,7 @@ discard block
		block discarded – undo
93	93	}
94	94
95	95	/**
96		- * @param $code
	96	+ * @param string $code
97	97	*
98	98	* @return null\|string
99	99	*/
		@@ -103,7 +103,7 @@ discard block
		block discarded – undo
103	103	}
104	104
105	105	/**
106		- * @return array
	106	+ * @return string[]
107	107	*/
108	108	private function getAvailableCountries()
109	109	{

		@@ -29,18 +29,21 @@ discard block
		block discarded – undo
29	29	public function isCodeDisabled();
30	30
31	31	/**
	32	+ * @param string $locale
32	33	* @return bool
33	34	*/
34	35	public function isSlugReadOnlyIn($locale);
35	36
36	37	/**
37	38	* @param int $price
	39	+ * @return void
38	40	*/
39	41	public function specifyPrice($price);
40	42
41	43	/**
42	44	* @param string $name
43	45	* @param string $localeCode
	46	+ * @return void
44	47	*/
45	48	public function nameItIn($name, $localeCode);
46	49
		@@ -67,11 +70,18 @@ discard block
		block discarded – undo
67	70
68	71	/**
69	72	* @param TaxonInterface $taxon
	73	+ * @return void
70	74	*/
71	75	public function selectMainTaxon(TaxonInterface $taxon);
72	76
	77	+ /**
	78	+ * @return void
	79	+ */
73	80	public function disableTracking();
74	81
	82	+ /**
	83	+ * @return void
	84	+ */
75	85	public function enableTracking();
76	86
77	87	/**
		@@ -81,6 +91,7 @@ discard block
		block discarded – undo
81	91
82	92	/**
83	93	* @param string $locale
	94	+ * @return void
84	95	*/
85	96	public function enableSlugModification($locale);
86	97
		@@ -94,20 +105,26 @@ discard block
		block discarded – undo
94	105	/**
95	106	* @param string $path
96	107	* @param string $code
	108	+ * @return void
97	109	*/
98	110	public function attachImage($path, $code = null);
99	111
100	112	/**
101	113	* @param string $code
102	114	* @param string $path
	115	+ * @return void
103	116	*/
104	117	public function changeImageWithCode($code, $path);
105	118
106	119	/**
107	120	* @param string $code
	121	+ * @return void
108	122	*/
109	123	public function removeImageWithCode($code);
110	124
	125	+ /**
	126	+ * @return void
	127	+ */
111	128	public function removeFirstImage();
112	129
113	130	/**
		@@ -130,6 +147,7 @@ discard block
		block discarded – undo
130	147	/**
131	148	* @param ProductAssociationTypeInterface $productAssociationType
132	149	* @param string[] $productsNames
	150	+ * @return void
133	151	*/
134	152	public function associateProducts(ProductAssociationTypeInterface $productAssociationType, array $productsNames);
135	153
		@@ -144,6 +162,7 @@ discard block
		block discarded – undo
144	162	/**
145	163	* @param string $productName
146	164	* @param ProductAssociationTypeInterface $productAssociationType
	165	+ * @return void
147	166	*/
148	167	public function removeAssociatedProduct($productName, ProductAssociationTypeInterface $productAssociationType);
149	168
		@@ -157,6 +176,7 @@ discard block
		block discarded – undo
157	176
158	177	/**
159	178	* @param string $locale
	179	+ * @return void
160	180	*/
161	181	public function activateLanguageTab($locale);
162	182
		@@ -170,6 +190,7 @@ discard block
		block discarded – undo
170	190	/**
171	191	* @param string $slug
172	192	* @param string $locale
	193	+ * @return void
173	194	*/
174	195	public function specifySlugIn($slug, $locale);
175	196	}

		@@ -26,10 +26,14 @@
		block discarded – undo
26	26	*/
27	27	public function checkValidationMessageFor($element, $message);
28	28
	29	+ /**
	30	+ * @return void
	31	+ */
29	32	public function reset();
30	33
31	34	/**
32	35	* @param string $email
	36	+ * @return void
33	37	*/
34	38	public function specifyEmail($email);
35	39	}

		@@ -27,6 +27,7 @@
		block discarded – undo
27	27
28	28	/**
29	29	* @param string $value
	30	+ * @return void
30	31	*/
31	32	public function setValue($value);
32	33	}

		@@ -23,11 +23,13 @@ discard block
		block discarded – undo
23	23	{
24	24	/**
25	25	* @param int $price
	26	+ * @return void
26	27	*/
27	28	public function specifyPrice($price);
28	29
29	30	/**
30	31	* @param string $name
	32	+ * @return void
31	33	*/
32	34	public function choosePricingCalculator($name);
33	35
		@@ -35,62 +37,73 @@ discard block
		block discarded – undo
35	37	* @param int $price
36	38	* @param ChannelInterface $channel
37	39	* @param CurrencyInterface $currency
	40	+ * @return void
38	41	*/
39	42	public function specifyPriceForChannelAndCurrency($price, ChannelInterface $channel, CurrencyInterface $currency);
40	43
41	44	/**
42	45	* @param string $code
	46	+ * @return void
43	47	*/
44	48	public function specifyCode($code);
45	49
46	50	/**
47	51	* @param string $name
48	52	* @param string $localeCode
	53	+ * @return void
49	54	*/
50	55	public function nameItIn($name, $localeCode);
51	56
52	57	/**
53	58	* @param string $slug
54	59	* @param string $locale
	60	+ * @return void
55	61	*/
56	62	public function specifySlugIn($slug, $locale);
57	63
58	64	/**
59	65	* @param string $attribute
60	66	* @param string $value
	67	+ * @return void
61	68	*/
62	69	public function addAttribute($attribute, $value);
63	70
64	71	/**
65	72	* @param string $attribute
	73	+ * @return void
66	74	*/
67	75	public function removeAttribute($attribute);
68	76
69	77	/**
70	78	* @param string $path
71	79	* @param string $code
	80	+ * @return void
72	81	*/
73	82	public function attachImage($path, $code = null);
74	83
75	84	/**
76	85	* @param ProductAssociationTypeInterface $productAssociationType
77	86	* @param string[] $productsNames
	87	+ * @return void
78	88	*/
79	89	public function associateProducts(ProductAssociationTypeInterface $productAssociationType, array $productsNames);
80	90
81	91	/**
82	92	* @param string $productName
83	93	* @param ProductAssociationTypeInterface $productAssociationType
	94	+ * @return void
84	95	*/
85	96	public function removeAssociatedProduct($productName, ProductAssociationTypeInterface $productAssociationType);
86	97
87	98	/**
88	99	* @param string $locale
	100	+ * @return void
89	101	*/
90	102	public function activateLanguageTab($locale);
91	103
92	104	/**
93	105	* @param string $shippingCategoryName
	106	+ * @return void
94	107	*/
95	108	public function selectShippingCategory($shippingCategoryName);
96	109	}

		@@ -55,11 +55,13 @@ discard block
		block discarded – undo
55	55
56	56	/**
57	57	* @param ProductVariantImageInterface $image
	58	+ * @return void
58	59	*/
59	60	public function addImage(ProductVariantImageInterface $image);
60	61
61	62	/**
62	63	* @param ProductVariantImageInterface $image
	64	+ * @return void
63	65	*/
64	66	public function removeImage(ProductVariantImageInterface $image);
65	67
		@@ -70,6 +72,7 @@ discard block
		block discarded – undo
70	72
71	73	/**
72	74	* @param int $sold
	75	+ * @return void
73	76	*/
74	77	public function setSold($sold);
75	78
		@@ -80,6 +83,7 @@ discard block
		block discarded – undo
80	83
81	84	/**
82	85	* @param float $weight
	86	+ * @return void
83	87	*/
84	88	public function setWeight($weight);
85	89
		@@ -90,6 +94,7 @@ discard block
		block discarded – undo
90	94
91	95	/**
92	96	* @param float $width
	97	+ * @return void
93	98	*/
94	99	public function setWidth($width);
95	100
		@@ -100,6 +105,7 @@ discard block
		block discarded – undo
100	105
101	106	/**
102	107	* @param float $height
	108	+ * @return void
103	109	*/
104	110	public function setHeight($height);
105	111
		@@ -110,6 +116,7 @@ discard block
		block discarded – undo
110	116
111	117	/**
112	118	* @param float $depth
	119	+ * @return void
113	120	*/
114	121	public function setDepth($depth);
115	122
		@@ -120,6 +127,7 @@ discard block
		block discarded – undo
120	127
121	128	/**
122	129	* @param int\|null $originalPrice
	130	+ * @return void
123	131	*/
124	132	public function setOriginalPrice($originalPrice);
125	133
		@@ -130,6 +138,7 @@ discard block
		block discarded – undo
130	138
131	139	/**
132	140	* @param TaxCategoryInterface $category
	141	+ * @return void
133	142	*/
134	143	public function setTaxCategory(TaxCategoryInterface $category = null);
135	144	}

pamil / Sylius

Push — symfony3-fqcn-promotion ( 3a6e99...c2e0cd )

Status

Category

Doc Comments +3 added lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +21 added lines patch added patch discarded remove patch

Doc Comments +4 added lines patch added patch discarded remove patch

Doc Comments +1 added lines patch added patch discarded remove patch

Doc Comments +13 added lines patch added patch discarded remove patch

Doc Comments +9 added lines patch added patch discarded remove patch

Doc Comments +1 added lines patch added patch discarded remove patch

Doc Comments +3 added lines patch added patch discarded remove patch