pamil / Sylius

app/migrations/Version20161219160441.php

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
 
         $this->addSql('CREATE TABLE sylius_product_association_type_translation (id INT AUTO_INCREMENT NOT NULL, translatable_id INT NOT NULL, name VARCHAR(255) DEFAULT NULL, locale VARCHAR(255) NOT NULL, INDEX IDX_4F618E52C2AC5D3 (translatable_id), UNIQUE INDEX sylius_product_association_type_translation_uniq_trans (translatable_id, locale), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB');
         $this->addSql('ALTER TABLE sylius_product_association_type_translation ADD CONSTRAINT FK_4F618E52C2AC5D3 FOREIGN KEY (translatable_id) REFERENCES sylius_product_association_type (id) ON DELETE CASCADE');
-        $this->addSql('INSERT INTO sylius_product_association_type_translation (translatable_id, name, locale) SELECT id, name, "'.$defaultLocale.'" from sylius_product_association_type WHERE sylius_product_association_type.name IS NOT null');
+        $this->addSql('INSERT INTO sylius_product_association_type_translation (translatable_id, name, locale) SELECT id, name, "' . $defaultLocale . '" from sylius_product_association_type WHERE sylius_product_association_type.name IS NOT null');
         $this->addSql('ALTER TABLE sylius_product_association_type DROP name');
     }
 
@@ -50,7 +50,7 @@ 
         $defaultLocale = $this->container->getParameter('locale');
 
         $this->addSql('ALTER TABLE sylius_product_association_type ADD name VARCHAR(255) NOT NULL COLLATE utf8_unicode_ci');
-        $this->addSql('UPDATE sylius_product_association_type SET name = (SELECT name FROM sylius_product_association_type_translation WHERE sylius_product_association_type_translation.translatable_id = sylius_product_association_type.id AND sylius_product_association_type_translation.locale = "'.$defaultLocale.'")');
+        $this->addSql('UPDATE sylius_product_association_type SET name = (SELECT name FROM sylius_product_association_type_translation WHERE sylius_product_association_type_translation.translatable_id = sylius_product_association_type.id AND sylius_product_association_type_translation.locale = "' . $defaultLocale . '")');
         $this->addSql('DROP TABLE sylius_product_association_type_translation');
     }
 }

src/Sylius/Behat/Page/Shop/Checkout/AddressPage.php

Doc Comments +2 added lines

@@ -429,6 +429,8 @@
     }
 
     /**
+     * @param integer $timeout
+     * @param string $elementName
      * @return bool
      */
     private function waitForElement($timeout, $elementName)

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Shop\Checkout;
 

src/Sylius/Behat/Context/Ui/Admin/ManagingProductsContext.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -16,13 +16,13 @@
 use Sylius\Behat\NotificationType;
 use Sylius\Behat\Page\Admin\Crud\CreatePageInterface;
 use Sylius\Behat\Page\Admin\Crud\UpdatePageInterface;
+use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
 use Sylius\Behat\Page\Admin\Product\CreateConfigurableProductPageInterface;
 use Sylius\Behat\Page\Admin\Product\CreateSimpleProductPageInterface;
 use Sylius\Behat\Page\Admin\Product\IndexPageInterface;
 use Sylius\Behat\Page\Admin\Product\IndexPerTaxonPageInterface;
 use Sylius\Behat\Page\Admin\Product\UpdateConfigurableProductPageInterface;
 use Sylius\Behat\Page\Admin\Product\UpdateSimpleProductPageInterface;
-use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
 use Sylius\Behat\Page\SymfonyPageInterface;
 use Sylius\Behat\Service\NotificationCheckerInterface;
 use Sylius\Behat\Service\Resolver\CurrentPageResolverInterface;

Doc Comments +1 added lines

@@ -248,6 +248,7 @@
      * @Then the product :productName should appear in the store
      * @Then the product :productName should be in the shop
      * @Then this product should still be named :productName
+     * @param string $productName
      */
     public function theProductShouldAppearInTheShop($productName)
     {

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Context\Ui\Admin;
 

src/Sylius/Component/Core/spec/Customer/Statistics/CustomerStatisticsSpec.php

Braces +4 added lines, -2 removed lines

@@ -46,7 +46,8 @@ 
         $this->getAllOrdersCount()->shouldReturn(0);
     }
 
-    function it_has_number_of_all_orders(ChannelInterface $channel) {
+    function it_has_number_of_all_orders(ChannelInterface $channel)
+    {
         $firstStatistics = new PerChannelCustomerStatistics(110, 120, $channel->getWrappedObject());
         $secondStatistics = new PerChannelCustomerStatistics(13, 120, $channel->getWrappedObject());
 
@@ -55,7 +56,8 @@ 
         $this->getAllOrdersCount()->shouldReturn(123);
     }
 
-    function it_has_an_array_of_statistics_per_channel(ChannelInterface $channel) {
+    function it_has_an_array_of_statistics_per_channel(ChannelInterface $channel)
+    {
         $firstStatistics = new PerChannelCustomerStatistics(110, 120, $channel->getWrappedObject());
         $secondStatistics = new PerChannelCustomerStatistics(13, 120, $channel->getWrappedObject());
 

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace spec\Sylius\Component\Core\Customer\Statistics;
 

src/Sylius/Bundle/ResourceBundle/test/src/Tests/Controller/ComicBookApiTest.php

Spacing +5 added lines, -5 removed lines

@@ -72,7 +72,7 @@ 
         }
 EOT;
 
-        $this->client->request('PUT', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
+        $this->client->request('PUT', '/v1/comic-books/' . $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
     }
@@ -92,7 +92,7 @@ 
         }
 EOT;
 
-        $this->client->request('PATCH', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
+        $this->client->request('PATCH', '/v1/comic-books/' . $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
     }
@@ -104,7 +104,7 @@ 
     {
         $objects = $this->loadFixturesFromFile('comic_books.yml');
 
-        $this->client->request('DELETE', '/v1/comic-books/'. $objects["comic-book1"]->getId());
+        $this->client->request('DELETE', '/v1/comic-books/' . $objects["comic-book1"]->getId());
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
     }
@@ -116,7 +116,7 @@ 
     {
         $objects = $this->loadFixturesFromFile('comic_books.yml');
 
-        $this->client->request('GET', '/v1/comic-books/'. $objects["comic-book1"]->getId());
+        $this->client->request('GET', '/v1/comic-books/' . $objects["comic-book1"]->getId());
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'comic-books/show_response');
     }
@@ -128,7 +128,7 @@ 
     {
         $objects = $this->loadFixturesFromFile('comic_books.yml');
 
-        $this->client->request('GET', '/v1.2/comic-books/'. $objects["comic-book1"]->getId());
+        $this->client->request('GET', '/v1.2/comic-books/' . $objects["comic-book1"]->getId());
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'comic-books/versioned_show_response');
     }

Indentation +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
         $objects = $this->loadFixturesFromFile('comic_books.yml');
 
         $data =
- <<<EOT
+    <<<EOT
         {
             "authorFirstName": "Joe",
             "authorLastName": "Kelly"

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -31,7 +31,7 @@ 
             "authorFirstName": "Joe",
             "authorLastName": "Kelly"
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/v1/comic-books/', [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
@@ -49,7 +49,7 @@ 
             "authorFirstName": "Joe",
             "authorLastName": "Kelly"
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/v1.2/comic-books/', [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
@@ -70,7 +70,7 @@ 
             "authorFirstName": "Joe",
             "authorLastName": "Kelly"
         }
-EOT;
+eot;
 
         $this->client->request('PUT', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
@@ -90,7 +90,7 @@ 
             "authorFirstName": "Joe",
             "authorLastName": "Kelly"
         }
-EOT;
+eot;
 
         $this->client->request('PATCH', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();

src/Sylius/Component/Product/Model/Product.php

Doc Comments +1 added lines

@@ -505,6 +505,7 @@
 
     /**
      * {@inheritdoc}
+     * @param string $localeCode
      */
     private function getAttributeInDifferentLocale(ProductAttributeValueInterface $attributeValue, $localeCode)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,11 +13,11 @@
 
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Collections\Collection;
-use Webmozart\Assert\Assert;
 use Sylius\Component\Attribute\Model\AttributeValueInterface;
 use Sylius\Component\Resource\Model\TimestampableTrait;
 use Sylius\Component\Resource\Model\ToggleableTrait;
 use Sylius\Component\Resource\Model\TranslatableTrait;
+use Webmozart\Assert\Assert;
 
 /**
  * @author Paweł Jędrzejewski <pawel@sylius.org>

Spacing +3 added lines, -3 removed lines

@@ -9,7 +9,7 @@ 
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Component\Product\Model;
 
@@ -100,7 +100,7 @@ 
     /**
      * @param string $code
      */
-    public function setCode(?string $code): void
+    public function setCode(?string $code) : void
     {
         $this->code = $code;
     }
@@ -132,7 +132,7 @@ 
     /**
      * {@inheritdoc}
      */
-    public function setSlug(?string $slug): void
+    public function setSlug(?string $slug) : void
     {
         $this->getTranslation()->setSlug($slug);
     }

app/migrations/Version20170109143010.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
         $defaultLocale = $this->container->getParameter('locale');
 
         $this->addSql('ALTER TABLE sylius_product_attribute_value ADD locale_code VARCHAR(255) NOT NULL');
-        $this->addSql('UPDATE sylius_product_attribute_value SET locale_code = "'.$defaultLocale.'"');
+        $this->addSql('UPDATE sylius_product_attribute_value SET locale_code = "' . $defaultLocale . '"');
     }
 
     /**

src/Sylius/Bundle/ProductBundle/Form/DataTransformer/ProductVariantToProductOptionsTransformer.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -15,8 +15,8 @@
 use Sylius\Component\Product\Model\ProductOptionValueInterface;
 use Sylius\Component\Product\Model\ProductVariantInterface;
 use Symfony\Component\Form\DataTransformerInterface;
-use Symfony\Component\Form\Exception\UnexpectedTypeException;
 use Symfony\Component\Form\Exception\TransformationFailedException;
+use Symfony\Component\Form\Exception\UnexpectedTypeException;
 
 /**
  * @author Paweł Jędrzejewski <pawel@sylius.org>

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Bundle\ProductBundle\Form\DataTransformer;
 

src/Sylius/Behat/Page/Admin/Account/LoginPageInterface.php

Doc Comments +5 added lines

@@ -25,15 +25,20 @@
      */
     public function hasValidationErrorWith($message);
 
+    /**
+     * @return void
+     */
     public function logIn();
 
     /**
      * @param string $password
+     * @return void
      */
     public function specifyPassword($password);
 
     /**
      * @param string $username
+     * @return void
      */
     public function specifyUsername($username);
 }

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Admin\Account;