Sylius\Component\Product\Checker\ProductVariantsParityChecker

Complexity

Total Complexity

8

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	checkParity()	0	15	5
A	matchOptions()	0	10	3

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sylius\Component\Product\Checker;

use Sylius\Component\Product\Model\ProductInterface;
use Sylius\Component\Product\Model\ProductVariantInterface;
use Webmozart\Assert\Assert;

/**
 * @author Łukasz Chruściel <lukasz.chrusciel@lakion.com>
 */
final class ProductVariantsParityChecker implements ProductVariantsParityCheckerInterface
{
    /**
     * {@inheritdoc}
     */
    public function checkParity(ProductVariantInterface $variant, ProductInterface $product)
    {
        foreach ($product->getVariants() as $existingVariant) {
            // This check is require, because this function has to look for any other different variant with same option values set
            if ($variant === $existingVariant || count($variant->getOptionValues()) !== count($product->getOptions())) {
                continue;
            }

            if ($this->matchOptions($variant, $existingVariant)) {
                return true;
            }
        }

        return false;
    }

    /**
     * @param ProductVariantInterface $variant
     * @param ProductVariantInterface $existingVariant
     *
     * @return bool
     */
    private function matchOptions(ProductVariantInterface $variant, ProductVariantInterface $existingVariant)

function matchOptions() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

    {
        foreach ($variant->getOptionValues() as $option) {
            if (!$existingVariant->hasOptionValue($option)) {
               return false;
            }
        }

        return true;
    }
}