pamil / Sylius

src/Sylius/Bundle/UserBundle/spec/Authentication/AuthenticationFailureHandlerSpec.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use PhpSpec\ObjectBehavior;
 use Sylius\Bundle\UserBundle\Authentication\AuthenticationFailureHandler;
 use Symfony\Component\HttpFoundation\JsonResponse;
-use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpKernel\HttpKernelInterface;
 use Symfony\Component\Security\Core\Exception\AuthenticationException;

src/Sylius/Bundle/UserBundle/spec/Doctrine/ORM/UserRepositorySpec.php

Unused Use Statements +1 added lines, -2 removed lines

@@ -15,9 +15,8 @@
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\Query;
-use Doctrine\ORM\Query\Expr;
-use Doctrine\ORM\Query\FilterCollection;
 use Doctrine\ORM\QueryBuilder;
+use Doctrine\ORM\Query\Expr;
 use Pagerfanta\Pagerfanta;
 use PhpSpec\ObjectBehavior;
 use Prophecy\Argument;

src/Sylius/Bundle/VariationBundle/spec/Form/Type/VariantTypeSpec.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use PhpSpec\ObjectBehavior;
 use Symfony\Component\Form\FormTypeInterface;
-use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
  * @author Paweł Jędrzejewski <pawel@sylius.org>

src/Sylius/Bundle/WebBundle/Behat/WebContext.php

Doc Comments +9 added lines

@@ -287,6 +287,8 @@ 
 
     /**
      * @Given /^I fill in the (billing|shipping) address to (.+)$/
+     * @param string $type
+     * @param string $country
      */
     public function iFillInCheckoutAddress($type, $country)
     {
@@ -312,6 +314,9 @@ 
         $this->iFillInAddressFields('sylius_address', $country);
     }
 
+    /**
+     * @param string $base
+     */
     protected function iFillInAddressFields($base, $country)
     {
         $this->fillField($base.'[firstName]', 'John');
@@ -324,6 +329,7 @@ 
 
     /**
      * @Given /^I select the "(?P<field>([^""]|\\")*)" radio button$/
+     * @param string $field
      */
     public function iSelectTheRadioButton($field)
     {
@@ -740,6 +746,9 @@ 
         $this->assertSession()->elementContains('css', '#enabled', 'yes');
     }
 
+    /**
+     * @param string $route
+     */
     private function assertRoute($route)
     {
         $this->assertSession()->addressEquals($this->generatePageUrl($route));

Spacing +12 added lines, -12 removed lines

@@ -314,12 +314,12 @@ 
 
     protected function iFillInAddressFields($base, $country)
     {
-        $this->fillField($base.'[firstName]', 'John');
-        $this->fillField($base.'[lastName]', 'Doe');
-        $this->fillField($base.'[street]', 'Pvt. Street 15');
-        $this->fillField($base.'[city]', 'Lodz');
-        $this->fillField($base.'[postcode]', '95-253');
-        $this->selectOption($base.'[countryCode]', $country);
+        $this->fillField($base . '[firstName]', 'John');
+        $this->fillField($base . '[lastName]', 'Doe');
+        $this->fillField($base . '[street]', 'Pvt. Street 15');
+        $this->fillField($base . '[city]', 'Lodz');
+        $this->fillField($base . '[postcode]', '95-253');
+        $this->selectOption($base . '[countryCode]', $country);
     }
 
     /**
@@ -360,7 +360,7 @@ 
      */
     public function iShouldNotSeeButton($button)
     {
-        $this->assertSession()->elementNotExists('css', '.delete-action-form input[value="'.strtoupper($button).'"]');
+        $this->assertSession()->elementNotExists('css', '.delete-action-form input[value="' . strtoupper($button) . '"]');
     }
 
     /**
@@ -368,8 +368,8 @@ 
      */
     public function iShouldNotSeeButtonInColumnInTable($button, $customer, $table)
     {
-        $this->assertSession()->elementExists('css', '#'.$table." tr[data-customer='$customer']");
-        $this->assertSession()->elementNotExists('css', '#'.$table." tr[data-customer='$customer'] form input[value=".strtoupper($button).']');
+        $this->assertSession()->elementExists('css', '#' . $table . " tr[data-customer='$customer']");
+        $this->assertSession()->elementNotExists('css', '#' . $table . " tr[data-customer='$customer'] form input[value=" . strtoupper($button) . ']');
     }
 
     /**
@@ -475,7 +475,7 @@ 
     {
         $order = $this->findOneBy('order', ['number' => $number]);
 
-        $this->getSession()->visit($this->generatePageUrl('sylius_account_order_'.$action, ['number' => $order->getNumber()]));
+        $this->getSession()->visit($this->generatePageUrl('sylius_account_order_' . $action, ['number' => $order->getNumber()]));
     }
 
     /**
@@ -484,7 +484,7 @@ 
      */
     public function iShouldBeOnTheOrderPage($action, $number)
     {
-        $this->assertSession()->addressEquals($this->generatePageUrl('sylius_account_order_'.$action, ['number' => $number]));
+        $this->assertSession()->addressEquals($this->generatePageUrl('sylius_account_order_' . $action, ['number' => $number]));
     }
 
     /**
@@ -758,7 +758,7 @@ 
      */
     protected function getFormCollectionDiv(DocumentElement $page, $collectionName)
     {
-        return $page->find('css', 'div[data-form-type="collection"][id*="'.$collectionName.'"]');
+        return $page->find('css', 'div[data-form-type="collection"][id*="' . $collectionName . '"]');
     }
 
     /**

src/Sylius/Bundle/WebBundle/Controller/Frontend/Account/AddressController.php

Doc Comments +4 added lines

@@ -166,6 +166,10 @@
         return $this->redirectToIndex();
     }
 
+    /**
+     * @param string $type
+     * @param string $message
+     */
     protected function addFlash($type, $message)
     {
         $translator = $this->get('translator');

src/Sylius/Component/Addressing/Model/Zone.php

Doc Comments +1 added lines, -1 removed lines

@@ -126,7 +126,7 @@
     /**
      * Returns all zone types available.
      *
-     * @return array of self::TYPE_*
+     * @return string[] of self::TYPE_*
      */
     public static function getTypes()
     {

src/Sylius/Component/Addressing/Model/ZoneInterface.php

Doc Comments +7 added lines, -1 removed lines

@@ -32,6 +32,7 @@ 
 
     /**
      * @param string $name
+     * @return void
      */
     public function setName($name);
 
@@ -42,6 +43,7 @@ 
 
     /**
      * @param string $type
+     * @return void
      */
     public function setType($type);
 
@@ -52,6 +54,7 @@ 
 
     /**
      * @param string $scope
+     * @return void
      */
     public function setScope($scope);
 
@@ -61,7 +64,8 @@ 
     public function getMembers();
 
     /**
-     * @param Collection|ZoneMemberInterface[] $members
+     * @param Collection $members
+     * @return void
      */
     public function setMembers(Collection $members);
 
@@ -72,11 +76,13 @@ 
 
     /**
      * @param ZoneMemberInterface $member
+     * @return void
      */
     public function addMember(ZoneMemberInterface $member);
 
     /**
      * @param ZoneMemberInterface $member
+     * @return void
      */
     public function removeMember(ZoneMemberInterface $member);
 

src/Sylius/Component/Archetype/Model/ArchetypeInterface.php

Doc Comments +9 added lines, -2 removed lines

@@ -42,12 +42,14 @@ 
     /**
      * Sets all prototype attributes.
      *
-     * @param Collection|AttributeInterface[] $attributes
+     * @param Collection $attributes
+     * @return void
      */
     public function setAttributes(Collection $attributes);
 
     /**
      * @param AttributeInterface $attribute
+     * @return void
      */
     public function addAttribute(AttributeInterface $attribute);
 
@@ -55,6 +57,7 @@ 
      * Removes attribute from prototype.
      *
      * @param AttributeInterface $attribute
+     * @return void
      */
     public function removeAttribute(AttributeInterface $attribute);
 
@@ -77,12 +80,14 @@ 
     /**
      * Sets all prototype options.
      *
-     * @param Collection|OptionInterface[] $options
+     * @param Collection $options
+     * @return void
      */
     public function setOptions(Collection $options);
 
     /**
      * @param OptionInterface $option
+     * @return void
      */
     public function addOption(OptionInterface $option);
 
@@ -90,6 +95,7 @@ 
      * Removes option from prototype.
      *
      * @param OptionInterface $option
+     * @return void
      */
     public function removeOption(OptionInterface $option);
 
@@ -109,6 +115,7 @@ 
 
     /**
      * @param null|ArchetypeInterface $parent
+     * @return void
      */
     public function setParent(ArchetypeInterface $parent = null);
 

src/Sylius/Component/Association/Model/AssociationType.php

Doc Comments -1 removed lines

@@ -37,7 +37,6 @@
     protected $name;
 
     /**
-     * @param string $name
      */
     public function __construct()
     {