pamil / Sylius

src/Sylius/Bundle/ProductBundle/DependencyInjection/Configuration.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 namespace Sylius\Bundle\ProductBundle\DependencyInjection;
 
-use Sylius\Bundle\CoreBundle\Form\Type\LegacyProductType;
 use Sylius\Bundle\ProductBundle\Form\Type\ProductTranslationType;
 use Sylius\Bundle\ProductBundle\Form\Type\ProductType;
 use Sylius\Bundle\ProductBundle\Form\Type\ProductVariantGenerationType;

src/Sylius/Bundle/ProductBundle/DependencyInjection/SyliusProductExtension.php

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use Sylius\Component\Product\Model\OptionValueTranslationInterface;
 use Sylius\Component\Product\Model\Variant;
 use Sylius\Component\Product\Model\VariantInterface;
-use Sylius\Component\Resource\Factory;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
      */
     public function load(array $config, ContainerBuilder $container)
     {
-        $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.xml');
         $loader->load('twig.xml');
     }

src/Sylius/Bundle/PromotionBundle/spec/Form/Type/ActionTypeSpec.php

Unused Use Statements -2 removed lines

@@ -16,11 +16,9 @@
 use Sylius\Bundle\PromotionBundle\Form\EventListener\BuildActionFormSubscriber;
 use Sylius\Bundle\PromotionBundle\Form\Type\ActionType;
 use Sylius\Bundle\PromotionBundle\Form\Type\Core\AbstractConfigurationType;
-use Sylius\Component\Promotion\Model\ActionInterface;
 use Sylius\Component\Registry\ServiceRegistryInterface;
 use Symfony\Component\Form\FormBuilder;
 use Symfony\Component\Form\FormFactoryInterface;
-use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
  * @author Saša Stamenković <umpirsky@gmail.com>

src/Sylius/Bundle/RbacBundle/spec/Doctrine/ORM/RoleRepositorySpec.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -14,8 +14,8 @@
 use Doctrine\ORM\AbstractQuery;
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\Mapping\ClassMetadata;
-use Doctrine\ORM\Query\Expr;
 use Doctrine\ORM\QueryBuilder;
+use Doctrine\ORM\Query\Expr;
 use PhpSpec\ObjectBehavior;
 use Prophecy\Argument;
 use Sylius\Component\Rbac\Model\RoleInterface;

src/Sylius/Bundle/RbacBundle/Twig/RbacExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
      *
      * @param string $permissionCode
      *
-     * @return string
+     * @return boolean
      */
     public function isGranted($permissionCode)
     {

src/Sylius/Bundle/ReportBundle/DataFetcher/TimePeriod.php

Doc Comments +1 added lines, -1 removed lines

@@ -101,7 +101,7 @@
      * @param string $interval
      * @param string $periodFormat
      * @param string $presentationFormat
-     * @param array  $groupBy
+     * @param string[]  $groupBy
      */
     private function setExtraConfiguration(
         array &$configuration,

src/Sylius/Bundle/ResourceBundle/Behat/FormContext.php

Doc Comments +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
      * @param  string           $label
      * @param  string           $collectionSelector
      *
-     * @return NodeElement|null
+     * @return NodeElement
      */
     protected function isInvalidCollectionField($position, $label, $collectionSelector = null)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -11,11 +11,11 @@
 
 namespace Sylius\Bundle\ResourceBundle\Behat;
 
+use Behat\MinkExtension\Context\RawMinkContext;
 use Behat\Mink\Element\Element;
 use Behat\Mink\Element\NodeElement;
 use Behat\Mink\Exception\ElementNotFoundException;
 use Behat\Mink\Selector\Xpath\Escaper;
-use Behat\MinkExtension\Context\RawMinkContext;
 
 /**
  * @author Arnaud Langlade <arn0d.dev@gmail.com>

src/Sylius/Bundle/ResourceBundle/Behat/WebContext.php

Doc Comments +14 added lines

@@ -46,6 +46,8 @@ 
     /**
      * @Given /^I am on the page of ([^""]*) with ([^""]*) "([^""]*)"$/
      * @Given /^I go to the page of ([^""]*) with ([^""]*) "([^""]*)"$/
+     * @param string $type
+     * @param string $property
      */
     public function iAmOnTheResourcePage($type, $property, $value)
     {
@@ -82,6 +84,8 @@ 
     /**
      * @Then /^I should be on the page of ([^""]*) with ([^""]*) "([^""]*)"$/
      * @Then /^I should still be on the page of ([^""]*) with ([^""]*) "([^""]*)"$/
+     * @param string $type
+     * @param string $property
      */
     public function iShouldBeOnTheResourcePage($type, $property, $value)
     {
@@ -125,6 +129,7 @@ 
 
     /**
      * @Given /^I am (building|viewing|editing) ([^""]*) with ([^""]*) "([^""]*)"$/
+     * @param string $property
      */
     public function iAmDoingSomethingWithResource($action, $type, $property, $value)
     {
@@ -167,6 +172,9 @@ 
 
     /**
      * @Then /^I should be (building|viewing|editing) ([^"]*) with ([^"]*) "([^""]*)"$/
+     * @param string $action
+     * @param string $type
+     * @param string $property
      */
     public function iShouldBeDoingSomethingWithResource($action, $type, $property, $value)
     {
@@ -221,6 +229,7 @@ 
 
     /**
      * @When /^I click "([^"]+)"$/
+     * @param string $link
      */
     public function iClick($link)
     {
@@ -470,6 +479,7 @@ 
 
     /**
      * @Given /^I wait (\d+) (seconds|second)$/
+     * @param integer $time
      */
     public function iWait($time)
     {
@@ -540,6 +550,8 @@ 
 
     /**
      * @Then /^I should see ([\w\s]+) "([^""]*)" as available choice$/
+     * @param string $fieldName
+     * @param string $fieldOption
      */
     public function iShouldSeeSelectWithOption($fieldName, $fieldOption)
     {
@@ -625,6 +637,8 @@ 
 
     /**
      * @Then /^I should see select "([^"]*)" with "([^"]*)" option selected$/
+     * @param string $fieldName
+     * @param string $fieldOption
      */
     public function iShouldSeeSelectWithOptionSelected($fieldName, $fieldOption)
     {

Spacing +5 added lines, -5 removed lines

@@ -149,7 +149,7 @@ 
             return;
         }
 
-        if('product option' === $type) {
+        if ('product option' === $type) {
             $this->iAmDoingSomethingWithResource($action, $type, 'code', $name);
 
             return;
@@ -327,7 +327,7 @@ 
     {
         $tableNode = new TableNode([
             [trim($columnName)],
-            [trim('%'.$value.'%')],
+            [trim('%' . $value . '%')],
         ]);
 
         $this->iShouldSeeTheFollowingRow($tableNode);
@@ -342,7 +342,7 @@ 
     {
         $tableNode = new TableNode([
             [trim($columnName)],
-            [trim('%'.$value.'%')],
+            [trim('%' . $value . '%')],
         ]);
 
         $this->iShouldNotSeeTheFollowingRow($tableNode);
@@ -441,7 +441,7 @@ 
         $this->waitForModalToAppear($attributesModalContainer);
 
         foreach ($attributes as $attribute) {
-            $this->getSession()->getPage()->checkField($attribute.' attribute');
+            $this->getSession()->getPage()->checkField($attribute . ' attribute');
         }
 
         $addAttributesButton->press();
@@ -461,7 +461,7 @@ 
         $this->assertSession()->elementExists('css', '#attribute-types-modal');
 
         $attributeTypesModalContainer = $this->getSession()->getPage()->find('css', '#attribute-types-modal');
-        $typeButton = $attributeTypesModalContainer->find('css', 'a#'.$type);
+        $typeButton = $attributeTypesModalContainer->find('css', 'a#' . $type);
 
         $this->waitForModalToAppear($attributeTypesModalContainer);
 

src/Sylius/Bundle/ResourceBundle/Controller/RedirectHandler.php

Doc Comments +1 added lines

@@ -80,6 +80,7 @@
 
     /**
      * {@inheritdoc}
+     * @param string|null $url
      */
     public function redirect(RequestConfiguration $configuration, $url, $status = 302)
     {

Spacing +2 added lines, -2 removed lines

@@ -85,11 +85,11 @@
     {
         if ($configuration->isHeaderRedirection()) {
             return new Response('', 200, [
-                'X-SYLIUS-LOCATION' => $url.$configuration->getRedirectHash(),
+                'X-SYLIUS-LOCATION' => $url . $configuration->getRedirectHash(),
             ]);
         }
 
-        return new RedirectResponse($url.$configuration->getRedirectHash(), $status);
+        return new RedirectResponse($url . $configuration->getRedirectHash(), $status);
     }
 
     /**