pamil / Sylius

src/Sylius/Bundle/CoreBundle/Test/Services/PaymentMethodNameToGatewayConverter.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
      *
      * @throws \RuntimeException
      *
-     * @return string
+     * @return integer
      */
     private function tryToMapPaymentMethodName($paymentMethodName)
     {

src/Sylius/Bundle/FlowBundle/Process/Builder/ProcessBuilderInterface.php

Doc Comments +11 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
      * Add a step with given name.
      *
      * @param string               $name
-     * @param string|StepInterface $step Step alias or instance
+     * @param string $step Step alias or instance
      * 
      * @return ProcessBuilderInterface
      */
@@ -46,6 +46,7 @@ 
      * Remove step with given name.
      *
      * @param string $name
+     * @return void
      */
     public function remove($name);
 
@@ -62,6 +63,7 @@ 
      * Set display route.
      *
      * @param string $route
+     * @return ProcessBuilder
      */
     public function setDisplayRoute($route);
 
@@ -69,6 +71,7 @@ 
      * Set additional forward route params.
      *
      * @param array $params
+     * @return ProcessBuilder
      */
     public function setDisplayRouteParams(array $params);
 
@@ -76,6 +79,7 @@ 
      * Set forward route.
      *
      * @param string $route
+     * @return ProcessBuilder
      */
     public function setForwardRoute($route);
 
@@ -83,6 +87,7 @@ 
      * Set additional forward route params.
      *
      * @param array $params
+     * @return ProcessBuilder
      */
     public function setForwardRouteParams(array $params);
 
@@ -90,6 +95,7 @@ 
      * Set redirection route after completion.
      *
      * @param string $redirect
+     * @return ProcessBuilder
      */
     public function setRedirect($redirect);
 
@@ -97,13 +103,15 @@ 
      * Set redirection route params.
      *
      * @param array $params
+     * @return ProcessBuilder
      */
     public function setRedirectParams(array $params);
 
     /**
      * Validation of process, if returns false, process is suspended.
      *
-     * @param \Closure|ProcessValidatorInterface $validator
+     * @param \Prophecy\Argument\Token\AnyValueToken $validator
+     * @return ProcessBuilder
      */
     public function validate($validator);
 
@@ -112,6 +120,7 @@ 
      *
      * @param string        $alias
      * @param StepInterface $step
+     * @return void
      */
     public function registerStep($alias, StepInterface $step);
 

src/Sylius/Bundle/FlowBundle/Process/Context/ProcessContextInterface.php

Doc Comments +8 added lines

@@ -29,6 +29,7 @@ 
      *
      * @param ProcessInterface $process
      * @param StepInterface    $currentStep
+     * @return ProcessContext
      */
     public function initialize(ProcessInterface $process, StepInterface $currentStep);
 
@@ -78,11 +79,13 @@ 
      * Override the default next step.
      *
      * @param string $stepAlias
+     * @return void
      */
     public function setNextStepByName($stepAlias);
 
     /**
      * Close context and clear all the data.
+     * @return void
      */
     public function close();
 
@@ -104,6 +107,7 @@ 
      * Set storage.
      *
      * @param StorageInterface $storage
+     * @return void
      */
     public function setStorage(StorageInterface $storage);
 
@@ -118,6 +122,7 @@ 
      * Set current request.
      *
      * @param Request $request
+     * @return void
      */
     public function setRequest(Request $request);
 
@@ -139,6 +144,7 @@ 
      * Set a new history of step names.
      *
      * @param array $history
+     * @return void
      */
     public function setStepHistory(array $history);
 
@@ -146,6 +152,7 @@ 
      * Add the given name to the history of step names.
      *
      * @param string $stepName
+     * @return void
      */
     public function addStepToHistory($stepName);
 
@@ -153,6 +160,7 @@ 
      * Goes back from the end fo the history and deletes all step names until the current one is found.
      *
      * @throws NotFoundHttpException If the step name is not found in the history.
+     * @return void
      */
     public function rewindHistory();
 }

src/Sylius/Bundle/FlowBundle/Process/Coordinator/CoordinatorInterface.php

Doc Comments +3 added lines, -2 removed lines

@@ -42,7 +42,7 @@ 
      * @param string       $stepName
      * @param ParameterBag $queryParameters
      *
-     * @return Response|View
+     * @return RedirectResponse
      */
     public function display($scenarioAlias, $stepName, ParameterBag $queryParameters = null);
 
@@ -53,7 +53,7 @@ 
      * @param string $scenarioAlias
      * @param string $stepName
      *
-     * @return Response|View
+     * @return RedirectResponse
      */
     public function forward($scenarioAlias, $stepName);
 
@@ -62,6 +62,7 @@ 
      *
      * @param string                   $alias
      * @param ProcessScenarioInterface $scenario
+     * @return void
      */
     public function registerScenario($alias, ProcessScenarioInterface $scenario);
 

src/Sylius/Bundle/FlowBundle/Validator/ProcessValidator.php

Doc Comments +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
     /**
      * Set validation.
      *
-     * @param callable $validation
+     * @param \Closure $validation
      *
      * @return $this
      */

src/Sylius/Bundle/GridBundle/Doctrine/ORM/ExpressionBuilder.php

Doc Comments +1 added lines

@@ -187,6 +187,7 @@
 
     /**
      * {@inheritdoc}
+     * @param string $field
      */
     private function getFieldName($field)
     {

Spacing +7 added lines, -7 removed lines

@@ -76,7 +76,7 @@ 
     {
         $this->queryBuilder->setParameter($field, $value);
 
-        return $this->queryBuilder->expr()->eq($this->getFieldName($field), ':'.$field);
+        return $this->queryBuilder->expr()->eq($this->getFieldName($field), ':' . $field);
     }
 
     /**
@@ -86,7 +86,7 @@ 
     {
         $this->queryBuilder->setParameter($field, $value);
 
-        return $this->queryBuilder->expr()->neq($this->getFieldName($field), ':'.$field);
+        return $this->queryBuilder->expr()->neq($this->getFieldName($field), ':' . $field);
     }
 
     /**
@@ -94,7 +94,7 @@ 
      */
     public function lessThan($field, $value)
     {
-        $this->queryBuilder->andWhere($this->getFieldName($field).' < :'.$field)->setParameter($field, $value);
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' < :' . $field)->setParameter($field, $value);
     }
 
     /**
@@ -102,7 +102,7 @@ 
      */
     public function lessThanOrEqual($field, $value)
     {
-        $this->queryBuilder->andWhere($this->getFieldName($field).' =< :'.$field)->setParameter($field, $value);
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' =< :' . $field)->setParameter($field, $value);
     }
 
     /**
@@ -110,7 +110,7 @@ 
      */
     public function greaterThan($field, $value)
     {
-        $this->queryBuilder->andWhere($this->getFieldName($field).' > :'.$field)->setParameter($field, $value);
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' > :' . $field)->setParameter($field, $value);
     }
 
     /**
@@ -118,7 +118,7 @@ 
      */
     public function greaterThanOrEqual($field, $value)
     {
-        $this->queryBuilder->andWhere($this->getFieldName($field).' => :%s'.$field)->setParameter($field, $value);
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' => :%s' . $field)->setParameter($field, $value);
     }
 
     /**
@@ -191,7 +191,7 @@ 
     private function getFieldName($field)
     {
         if (false === strpos($field, '.')) {
-            return $this->queryBuilder->getRootAlias().'.'.$field;
+            return $this->queryBuilder->getRootAlias() . '.' . $field;
         }
 
         return $field;

src/Sylius/Bundle/GridBundle/Doctrine/PHPCRODM/ExpressionVisitor.php

Doc Comments +3 added lines

@@ -175,6 +175,9 @@
         return Driver::QB_SOURCE_ALIAS . '.' . $field;
     }
 
+    /**
+     * @param string $field
+     */
     private function getInConstraint(AbstractNode $parentNode, $field, array $values)
     {
         $orNode = $parentNode->orx();

Unused Use Statements +3 added lines, -4 removed lines

@@ -11,14 +11,13 @@
 
 namespace Sylius\Bundle\GridBundle\Doctrine\PHPCRODM;
 
-use Sylius\Component\Grid\Data\ExpressionBuilderInterface;
-use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
-use Doctrine\Common\Collections\Expr\CompositeExpression;
 use Doctrine\Common\Collections\Expr\Comparison;
+use Doctrine\Common\Collections\Expr\CompositeExpression;
+use Doctrine\Common\Collections\Expr\Expression;
 use Doctrine\Common\Collections\Expr\Value;
 use Doctrine\ODM\PHPCR\Query\Builder\AbstractNode;
 use Doctrine\ODM\PHPCR\Query\Builder\OperandFactory;
-use Doctrine\Common\Collections\Expr\Expression;
+use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
 use Sylius\Bundle\GridBundle\Doctrine\PHPCRODM\ExtraComparison;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -105,7 +105,7 @@ 
      */
     public function walkCompositeExpression(CompositeExpression $expr, AbstractNode $parentNode)
     {
-        switch($expr->getType()) {
+        switch ($expr->getType()) {
             case CompositeExpression::TYPE_AND:
                 $node = $parentNode->andX();
                 break;
@@ -128,7 +128,7 @@ 
                 break;
             }
 
-            switch($expr->getType()) {
+            switch ($expr->getType()) {
                 case CompositeExpression::TYPE_AND:
                     $parentNode = $parentNode->andX();
                     break;

src/Sylius/Bundle/GridBundle/spec/Doctrine/PHPCRODM/DriverSpec.php

Unused Use Statements +3 added lines, -4 removed lines

@@ -11,14 +11,13 @@
 
 namespace spec\Sylius\Bundle\GridBundle\Doctrine\PHPCRODM;
 
-use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
-use Sylius\Component\Grid\Data\DriverInterface;
-use Sylius\Component\Grid\Parameters;
 use Doctrine\ODM\PHPCR\DocumentManagerInterface;
 use Doctrine\ODM\PHPCR\DocumentRepository;
 use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
+use PhpSpec\ObjectBehavior;
 use Sylius\Bundle\GridBundle\Doctrine\PHPCRODM\DataSource;
+use Sylius\Component\Grid\Data\DriverInterface;
+use Sylius\Component\Grid\Parameters;
 
 /**
  * @mixin Driver

src/Sylius/Bundle/GridBundle/spec/Doctrine/PHPCRODM/ExpressionBuilderSpec.php

Unused Use Statements +2 added lines, -3 removed lines

@@ -11,11 +11,10 @@
 
 namespace spec\Sylius\Bundle\GridBundle\Doctrine\PHPCRODM;
 
-use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
+use Doctrine\Common\Collections\Expr\Comparison;
 use Doctrine\Common\Collections\ExpressionBuilder as CollectionsExpressionBuilder;
+use PhpSpec\ObjectBehavior;
 use Sylius\Bundle\GridBundle\Doctrine\PHPCRODM\ExpressionBuilder;
-use Doctrine\Common\Collections\Expr\Comparison;
 use Sylius\Bundle\GridBundle\Doctrine\PHPCRODM\ExtraComparison;
 
 class ExpressionBuilderSpec extends ObjectBehavior

Braces +10 added lines, -20 removed lines

@@ -33,8 +33,7 @@ 
     function it_builds_andx(
         Comparison $comparison,
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->andX([$comparison]);
         $expressionBuilder->andX([$comparison])->shouldHaveBeenCalled();
     }
@@ -42,64 +41,56 @@ 
     function it_builds_orx(
         Comparison $comparison,
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->orX([$comparison]);
         $expressionBuilder->orX([$comparison])->shouldHaveBeenCalled();
     }
 
     function it_builds_equals(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->equals('o.foo', 'value');
         $expressionBuilder->eq('o.foo', 'value')->shouldHaveBeenCalled();
     }
 
     function it_builds_not_equals(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->notEquals('o.foo', 'value');
         $expressionBuilder->neq('o.foo', 'value')->shouldHaveBeenCalled();
     }
 
     function it_builds_less_than_or_equal(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->lessThanOrEqual('o.foo', 'value');
         $expressionBuilder->lte('o.foo', 'value')->shouldHaveBeenCalled();
     }
 
     function it_builds_greater_than(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->greaterThan('o.foo', 'value');
         $expressionBuilder->gt('o.foo', 'value')->shouldHaveBeenCalled();
     }
 
     function it_builds_greater_than_or_equal(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->greaterThanOrequal('o.foo', 'value');
         $expressionBuilder->gte('o.foo', 'value')->shouldHaveBeenCalled();
     }
 
     function it_builds_in(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->in('o.foo', ['value']);
         $expressionBuilder->in('o.foo', ['value'])->shouldHaveBeenCalled();
     }
 
     function it_builds_not_in(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->notIn('o.foo', ['value']);
         $expressionBuilder->notIn('o.foo', ['value'])->shouldHaveBeenCalled();
     }
@@ -120,8 +111,7 @@ 
 
     function it_builds_like(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->like('o.foo', 'value');
         $expressionBuilder->contains('o.foo', 'value')->shouldHaveBeenCalled();
     }