Complex classes like ManagingProductVariantsContext often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ManagingProductVariantsContext, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
29 | final class ManagingProductVariantsContext implements Context |
||
30 | { |
||
31 | /** @var SharedStorageInterface */ |
||
32 | private $sharedStorage; |
||
33 | |||
34 | /** @var CreatePageInterface */ |
||
35 | private $createPage; |
||
36 | |||
37 | /** @var IndexPageInterface */ |
||
38 | private $indexPage; |
||
39 | |||
40 | /** @var UpdatePageInterface */ |
||
41 | private $updatePage; |
||
42 | |||
43 | /** @var GeneratePageInterface */ |
||
44 | private $generatePage; |
||
45 | |||
46 | /** @var CurrentPageResolverInterface */ |
||
47 | private $currentPageResolver; |
||
48 | |||
49 | /** @var NotificationCheckerInterface */ |
||
50 | private $notificationChecker; |
||
51 | |||
52 | public function __construct( |
||
69 | |||
70 | /** |
||
71 | * @Given /^I want to create a new variant of (this product)$/ |
||
72 | */ |
||
73 | public function iWantToCreateANewProduct(ProductInterface $product) |
||
77 | |||
78 | /** |
||
79 | * @When I specify its code as :code |
||
80 | * @When I do not specify its code |
||
81 | */ |
||
82 | public function iSpecifyItsCodeAs($code = null) |
||
86 | |||
87 | /** |
||
88 | * @When I name it :name in :language |
||
89 | */ |
||
90 | public function iNameItIn($name, $language) |
||
94 | |||
95 | /** |
||
96 | * @When I add it |
||
97 | * @When I try to add it |
||
98 | */ |
||
99 | public function iAddIt() |
||
103 | |||
104 | /** |
||
105 | * @When I change its :optionName option to :optionValue |
||
106 | */ |
||
107 | public function iChangeItsOptionTo(string $optionName, string $optionValue): void |
||
111 | |||
112 | /** |
||
113 | * @When I disable its inventory tracking |
||
114 | */ |
||
115 | public function iDisableItsTracking() |
||
119 | |||
120 | /** |
||
121 | * @When I enable its inventory tracking |
||
122 | */ |
||
123 | public function iEnableItsTracking() |
||
127 | |||
128 | /** |
||
129 | * @When /^I set its(?:| default) price to "(?:€|£|\$)([^"]+)" for "([^"]+)" channel$/ |
||
130 | * @When I do not set its price |
||
131 | */ |
||
132 | public function iSetItsPriceTo(?string $price = null, $channelName = null) |
||
136 | |||
137 | /** |
||
138 | * @When I remove its price for :channel channel |
||
139 | */ |
||
140 | public function iRemoveItsPriceForChannel(string $channelName): void |
||
144 | |||
145 | /** |
||
146 | * @When /^I set its original price to "(?:€|£|\$)([^"]+)" for "([^"]+)" channel$/ |
||
147 | */ |
||
148 | public function iSetItsOriginalPriceTo(string $originalPrice, string $channelName): void |
||
152 | |||
153 | /** |
||
154 | * @When I set its height, width, depth and weight to :number |
||
155 | */ |
||
156 | public function iSetItsDimensionsTo($value) |
||
160 | |||
161 | /** |
||
162 | * @When I do not specify its current stock |
||
163 | */ |
||
164 | public function iDoNetSetItsCurrentStockTo() |
||
168 | |||
169 | /** |
||
170 | * @When I choose :calculatorName calculator |
||
171 | */ |
||
172 | public function iChooseCalculator($calculatorName) |
||
176 | |||
177 | /** |
||
178 | * @When I set its :optionName option to :optionValue |
||
179 | */ |
||
180 | public function iSetItsOptionAs($optionName, $optionValue) |
||
184 | |||
185 | /** |
||
186 | * @When I set the position of :name to :position |
||
187 | */ |
||
188 | public function iSetThePositionOfTo($name, int $position) |
||
192 | |||
193 | /** |
||
194 | * @When I save my new configuration |
||
195 | */ |
||
196 | public function iSaveMyNewConfiguration() |
||
200 | |||
201 | /** |
||
202 | * @When I do not want to have shipping required for this product |
||
203 | */ |
||
204 | public function iDoNotWantToHaveShippingRequiredForThisProduct() |
||
208 | |||
209 | /** |
||
210 | * @When I check (also) the :productVariantName product variant |
||
211 | */ |
||
212 | public function iCheckTheProductVariantName(string $productVariantName): void |
||
216 | |||
217 | /** |
||
218 | * @When I delete them |
||
219 | */ |
||
220 | public function iDeleteThem(): void |
||
224 | |||
225 | /** |
||
226 | * @Then /^the (variant with code "[^"]+") should be priced at (?:€|£|\$)([^"]+) for channel "([^"]+)"$/ |
||
227 | */ |
||
228 | public function theVariantWithCodeShouldBePricedAtForChannel(ProductVariantInterface $productVariant, string $price, $channelName) |
||
234 | |||
235 | /** |
||
236 | * @Then /^the (variant with code "[^"]+") should be named "([^"]+)" in ("([^"]+)" locale)$/ |
||
237 | */ |
||
238 | public function theVariantWithCodeShouldBeNamedIn(ProductVariantInterface $productVariant, $name, $language) |
||
244 | |||
245 | /** |
||
246 | * @Then /^the (variant with code "[^"]+") should have an original price of (?:€|£|\$)([^"]+) for channel "([^"]+)"$/ |
||
247 | */ |
||
248 | public function theVariantWithCodeShouldHaveAnOriginalPriceOfForChannel(ProductVariantInterface $productVariant, $originalPrice, $channelName) |
||
257 | |||
258 | /** |
||
259 | * @When /^I delete the ("[^"]+" variant of product "[^"]+")$/ |
||
260 | * @When /^I try to delete the ("[^"]+" variant of product "[^"]+")$/ |
||
261 | */ |
||
262 | public function iDeleteTheVariantOfProduct(ProductVariantInterface $productVariant) |
||
268 | |||
269 | /** |
||
270 | * @Then I should be notified that this variant is in use and cannot be deleted |
||
271 | */ |
||
272 | public function iShouldBeNotifiedOfFailure() |
||
279 | |||
280 | /** |
||
281 | * @When /^I want to modify the ("[^"]+" product variant)$/ |
||
282 | */ |
||
283 | public function iWantToModifyAProduct(ProductVariantInterface $productVariant) |
||
287 | |||
288 | /** |
||
289 | * @Then the code field should be disabled |
||
290 | */ |
||
291 | public function theCodeFieldShouldBeDisabled() |
||
295 | |||
296 | /** |
||
297 | * @Then I should be notified that :element is required |
||
298 | */ |
||
299 | public function iShouldBeNotifiedThatIsRequired($element) |
||
303 | |||
304 | /** |
||
305 | * @Then I should be notified that code has to be unique |
||
306 | */ |
||
307 | public function iShouldBeNotifiedThatCodeHasToBeUnique() |
||
311 | |||
312 | /** |
||
313 | * @Then I should be notified that current stock is required |
||
314 | */ |
||
315 | public function iShouldBeNotifiedThatOnHandIsRequired() |
||
319 | |||
320 | /** |
||
321 | * @Then I should be notified that height, width, depth and weight cannot be lower than 0 |
||
322 | */ |
||
323 | public function iShouldBeNotifiedThatIsHeightWidthDepthWeightCannotBeLowerThan() |
||
330 | |||
331 | /** |
||
332 | * @Then I should be notified that price cannot be lower than 0 |
||
333 | */ |
||
334 | public function iShouldBeNotifiedThatPriceCannotBeLowerThen(): void |
||
341 | |||
342 | /** |
||
343 | * @Then I should be notified that this variant already exists |
||
344 | */ |
||
345 | public function iShouldBeNotifiedThatThisVariantAlreadyExists() |
||
352 | |||
353 | /** |
||
354 | * @Then /^I should be notified that code is required for the (\d)(?:st|nd|rd|th) variant$/ |
||
355 | */ |
||
356 | public function iShouldBeNotifiedThatCodeIsRequiredForVariant($position) |
||
363 | |||
364 | /** |
||
365 | * @Then /^I should be notified that prices in all channels must be defined for the (\d)(?:st|nd|rd|th) variant$/ |
||
366 | */ |
||
367 | public function iShouldBeNotifiedThatPricesInAllChannelsMustBeDefinedForTheVariant($position) |
||
374 | |||
375 | /** |
||
376 | * @Then /^I should be notified that variant code must be unique within this product for the (\d)(?:st|nd|rd|th) variant$/ |
||
377 | */ |
||
378 | public function iShouldBeNotifiedThatVariantCodeMustBeUniqueWithinThisProductForYheVariant($position) |
||
385 | |||
386 | /** |
||
387 | * @Then I should be notified that prices in all channels must be defined |
||
388 | */ |
||
389 | public function iShouldBeNotifiedThatPricesInAllChannelsMustBeDefined() |
||
396 | |||
397 | /** |
||
398 | * @When I choose to show this product in the :channel channel |
||
399 | */ |
||
400 | public function iChooseToShowThisProductInTheChannel(string $channel): void |
||
404 | |||
405 | /** |
||
406 | * @When I choose to show this product in this channel |
||
407 | */ |
||
408 | public function iChooseToShowThisProductInThisChannel(): void |
||
412 | |||
413 | /** |
||
414 | * @When I save my changes |
||
415 | * @When I try to save my changes |
||
416 | */ |
||
417 | public function iSaveMyChanges() |
||
421 | |||
422 | /** |
||
423 | * @Then /^inventory of (this variant) should not be tracked$/ |
||
424 | */ |
||
425 | public function thisProductVariantShouldNotBeTracked(ProductVariantInterface $productVariant) |
||
431 | |||
432 | /** |
||
433 | * @Then /^inventory of (this variant) should be tracked$/ |
||
434 | */ |
||
435 | public function thisProductVariantShouldBeTracked(ProductVariantInterface $productVariant) |
||
441 | |||
442 | /** |
||
443 | * @When I generate it |
||
444 | * @When I try to generate it |
||
445 | */ |
||
446 | public function iClickGenerate() |
||
450 | |||
451 | /** |
||
452 | * @When /^I specify that the (\d)(?:st|nd|rd|th) variant is identified by "([^"]+)" code and costs "(?:€|£|\$)([^"]+)" in ("[^"]+") channel$/ |
||
453 | */ |
||
454 | public function iSpecifyThereAreVariantsIdentifiedByCodeWithCost($nthVariant, $code, int $price, $channelName) |
||
459 | |||
460 | /** |
||
461 | * @When /^I specify that the (\d)(?:st|nd|rd|th) variant is identified by "([^"]+)" code$/ |
||
462 | */ |
||
463 | public function iSpecifyThereAreVariantsIdentifiedByCode($nthVariant, $code) |
||
467 | |||
468 | /** |
||
469 | * @When /^I specify that the (\d)(?:st|nd|rd|th) variant costs "(?:€|£|\$)([^"]+)" in ("[^"]+") channel$/ |
||
470 | */ |
||
471 | public function iSpecifyThereAreVariantsWithCost($nthVariant, int $price, $channelName) |
||
475 | |||
476 | /** |
||
477 | * @When /^I remove (\d)(?:st|nd|rd|th) variant from the list$/ |
||
478 | */ |
||
479 | public function iRemoveVariantFromTheList($nthVariant) |
||
483 | |||
484 | /** |
||
485 | * @Then I should be notified that it has been successfully generated |
||
486 | */ |
||
487 | public function iShouldBeNotifiedThatItHasBeenSuccessfullyGenerated() |
||
491 | |||
492 | /** |
||
493 | * @Then I should not be able to generate any variants |
||
494 | */ |
||
495 | public function iShouldNotBeAbleToGenerateAnyVariants(): void |
||
499 | |||
500 | /** |
||
501 | * @When I set its shipping category as :shippingCategoryName |
||
502 | */ |
||
503 | public function iSetItsShippingCategoryAs($shippingCategoryName) |
||
507 | |||
508 | /** |
||
509 | * @When I do not specify any information about variants |
||
510 | */ |
||
511 | public function iDoNotSpecifyAnyInformationAboutVariants() |
||
515 | |||
516 | /** |
||
517 | * @When I change its quantity of inventory to :amount |
||
518 | */ |
||
519 | public function iChangeItsQuantityOfInventoryTo(int $amount) |
||
523 | |||
524 | /** |
||
525 | * @Then /^the (variant with code "[^"]+") should not have shipping required$/ |
||
526 | */ |
||
527 | public function theVariantWithCodeShouldNotHaveShippingRequired(ProductVariantInterface $productVariant) |
||
533 | |||
534 | /** |
||
535 | * @Then I should be notified that on hand quantity must be greater than the number of on hold units |
||
536 | */ |
||
537 | public function iShouldBeNotifiedThatOnHandQuantityMustBeGreaterThanTheNumberOfOnHoldUnits() |
||
544 | |||
545 | /** |
||
546 | * @Then I should be notified that variants cannot be generated from options without any values |
||
547 | */ |
||
548 | public function iShouldBeNotifiedThatVariantsCannotBeGeneratedFromOptionsWithoutAnyValues(): void |
||
552 | |||
553 | /** |
||
554 | * @Then I should not have configured price for :channelName channel |
||
555 | */ |
||
556 | public function iShouldNotHaveConfiguredPriceForChannel(string $channelName): void |
||
565 | |||
566 | /** |
||
567 | * @Then I should see the :optionName option as :valueName |
||
568 | */ |
||
569 | public function iShouldSeeTheOptionAs(string $optionName, string $valueName): void |
||
573 | |||
574 | /** |
||
575 | * @When /^I want to generate new variants for (this product)$/ |
||
576 | * @When /^I try to generate new variants for (this product)$/ |
||
577 | */ |
||
578 | public function iTryToGenerateNewVariantsForThisProduct(ProductInterface $product): void |
||
582 | |||
583 | /** |
||
584 | * @Then I should not be able to show this product in shop |
||
585 | */ |
||
586 | public function iShouldNotBeAbleToShowThisProductInShop(): void |
||
590 | |||
591 | /** |
||
592 | * @param string $element |
||
593 | * @param string $message |
||
594 | */ |
||
595 | private function assertValidationMessage($element, $message) |
||
602 | } |
||
603 |
It seems like the method you are trying to call exists only in some of the possible types.
Let’s take a look at an example:
Available Fixes
Add an additional type-check:
Only allow a single type to be passed if the variable comes from a parameter: