SuiteLoader - Code Metrics - Inspection of "Merge pull request #5219 from pamil/fixtures-bundl..." - Sylius/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ab8175...d69783 )

by Kamil

created 2016-06-17 20:31 UTC

SuiteLoader A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	3
c	2
b	0
f	1
lcom	1
cbo	2
dl	0
loc	29
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	load()	0	10	2

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sylius\Bundle\FixturesBundle\Loader;

use Sylius\Bundle\FixturesBundle\Fixture\FixtureInterface;
use Sylius\Bundle\FixturesBundle\Suite\SuiteInterface;

/**
 * @author Kamil Kokot <[email protected]>
 */
final class SuiteLoader implements SuiteLoaderInterface
{
    /**
     * @var FixtureLoaderInterface
     */
    private $fixtureLoader;

    /**
     * @param FixtureLoaderInterface $fixtureLoader
     */
    public function __construct(FixtureLoaderInterface $fixtureLoader)
    {
        $this->fixtureLoader = $fixtureLoader;
    }

    /**
     * {@inheritdoc}
     */
    public function load(SuiteInterface $suite)
    {
        /**
         * @var FixtureInterface $fixture
         * @var array $fixtureOptions
         */
        foreach ($suite->getFixtures() as $fixture => $fixtureOptions) {
            $this->fixtureLoader->load($suite, $fixture, $fixtureOptions);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sylius package.
5			*
6			* (c) Paweł Jędrzejewski
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sylius\Bundle\FixturesBundle\Loader;
13
14			use Sylius\Bundle\FixturesBundle\Fixture\FixtureInterface;
15			use Sylius\Bundle\FixturesBundle\Suite\SuiteInterface;
16
17			/**
18			* @author Kamil Kokot <[email protected]>
19			*/
20			final class SuiteLoader implements SuiteLoaderInterface
21			{
22			/**
23			* @var FixtureLoaderInterface
24			*/
25			private $fixtureLoader;
26
27			/**
28			* @param FixtureLoaderInterface $fixtureLoader
29			*/
30			public function __construct(FixtureLoaderInterface $fixtureLoader)
31			{
32			$this->fixtureLoader = $fixtureLoader;
33			}
34
35			/**
36			* {@inheritdoc}
37			*/
38			public function load(SuiteInterface $suite)
39			{
40			/**
41			* @var FixtureInterface $fixture
42			* @var array $fixtureOptions
43			*/
44			foreach ($suite->getFixtures() as $fixture => $fixtureOptions) {
45			$this->fixtureLoader->load($suite, $fixture, $fixtureOptions);
			0 ignored issues – show Documentation introduced 2016-06-09 16:42 UTC by Report Bug Copy Issue Report `$fixture` is of type `integer\|string`, but the function expects a `object<Sylius\Bundle\Fix...xture\FixtureInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
46			}
47			}
48			}
49

Sylius / Sylius

Push — master ( ab8175...d69783 )

SuiteLoader A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like