| Conditions | 6 |
| Paths | 18 |
| Total Lines | 107 |
| Code Lines | 65 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 47 | protected function addResourceListeners(ContainerBuilder $container, MetadataInterface $metadata) |
||
| 48 | { |
||
| 49 | $defaultOptions = [ |
||
| 50 | // if no parent is given default to the parent path given here. |
||
| 51 | 'parent_path_default' => null, |
||
| 52 | |||
| 53 | // auto-create the parent path if it does not exist. |
||
| 54 | 'parent_path_autocreate' => false, |
||
| 55 | |||
| 56 | // set true to always override the parent path. |
||
| 57 | 'parent_path_force' => false, |
||
| 58 | |||
| 59 | // automatically replace invalid characters in the node name |
||
| 60 | // with a blank space. |
||
| 61 | 'name_filter' => true, |
||
| 62 | |||
| 63 | // automatically resolve same-name-sibling conflicts. |
||
| 64 | 'name_resolver' => true, |
||
| 65 | ]; |
||
| 66 | $metadataOptions = $metadata->hasParameter('options') ? $metadata->getParameter('options') : []; |
||
| 67 | |||
| 68 | if ($diff = array_diff(array_keys($metadataOptions), array_keys($defaultOptions))) { |
||
| 69 | throw new InvalidArgumentException(sprintf( |
||
| 70 | 'Unknown PHPCR-ODM configuration options: "%s"', |
||
| 71 | implode('", "', $diff) |
||
| 72 | )); |
||
| 73 | } |
||
| 74 | |||
| 75 | $options = array_merge( |
||
| 76 | $defaultOptions, |
||
| 77 | $metadataOptions |
||
| 78 | ); |
||
| 79 | |||
| 80 | $createEventName = sprintf('%s.%s.pre_%s', $metadata->getApplicationName(), $metadata->getName(), 'create'); |
||
| 81 | $updateEventName = sprintf('%s.%s.pre_%s', $metadata->getApplicationName(), $metadata->getName(), 'update'); |
||
| 82 | |||
| 83 | if ($options['parent_path_default']) { |
||
| 84 | $defaultPath = new Definition(DefaultParentListener::class); |
||
| 85 | $defaultPath->setArguments([ |
||
| 86 | new Reference($metadata->getServiceId('manager')), |
||
| 87 | $options['parent_path_default'], |
||
| 88 | $options['parent_path_autocreate'], |
||
| 89 | $options['parent_path_force'] |
||
| 90 | ]); |
||
| 91 | $defaultPath->addTag('kernel.event_listener', [ |
||
| 92 | 'event' => $createEventName, |
||
| 93 | 'method' => 'onPreCreate' |
||
| 94 | ]); |
||
| 95 | |||
| 96 | $container->setDefinition( |
||
| 97 | sprintf( |
||
| 98 | '%s.resource.%s.doctrine.odm.phpcr.event_listener.default_path', |
||
| 99 | $metadata->getApplicationName(), |
||
| 100 | $metadata->getName() |
||
| 101 | ), |
||
| 102 | $defaultPath |
||
| 103 | ); |
||
| 104 | } |
||
| 105 | |||
| 106 | if ($options['name_filter']) { |
||
| 107 | $nameFilter = new Definition(NameFilterListener::class); |
||
| 108 | $nameFilter->setArguments([ |
||
| 109 | new Reference($metadata->getServiceId('manager')) |
||
| 110 | ]); |
||
| 111 | $nameFilter->addTag('kernel.event_listener', [ |
||
| 112 | 'event' => $createEventName, |
||
| 113 | 'method' => 'onEvent' |
||
| 114 | ]); |
||
| 115 | $nameFilter->addTag('kernel.event_listener', [ |
||
| 116 | 'event' => $updateEventName, |
||
| 117 | 'method' => 'onEvent' |
||
| 118 | ]); |
||
| 119 | |||
| 120 | $container->setDefinition( |
||
| 121 | sprintf( |
||
| 122 | '%s.resource.%s.doctrine.odm.phpcr.event_listener.name_filter', |
||
| 123 | $metadata->getApplicationName(), |
||
| 124 | $metadata->getName() |
||
| 125 | ), |
||
| 126 | $nameFilter |
||
| 127 | ); |
||
| 128 | } |
||
| 129 | |||
| 130 | if ($options['name_resolver']) { |
||
| 131 | $nameResolver = new Definition(NameResolverListener::class); |
||
| 132 | $nameResolver->setArguments([ |
||
| 133 | new Reference($metadata->getServiceId('manager')) |
||
| 134 | ]); |
||
| 135 | $nameResolver->addTag('kernel.event_listener', [ |
||
| 136 | 'event' => $createEventName, |
||
| 137 | 'method' => 'onEvent' |
||
| 138 | ]); |
||
| 139 | $nameResolver->addTag('kernel.event_listener', [ |
||
| 140 | 'event' => $updateEventName, |
||
| 141 | 'method' => 'onEvent' |
||
| 142 | ]); |
||
| 143 | |||
| 144 | $container->setDefinition( |
||
| 145 | sprintf( |
||
| 146 | '%s.resource.%s.doctrine.odm.phpcr.event_listener.name_resolver', |
||
| 147 | $metadata->getApplicationName(), |
||
| 148 | $metadata->getName() |
||
| 149 | ), |
||
| 150 | $nameResolver |
||
| 151 | ); |
||
| 152 | } |
||
| 153 | } |
||
| 154 | |||
| 213 |