pamil / Sylius

src/Sylius/Behat/Context/Ui/Admin/ManagingProductsContext.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -16,13 +16,13 @@
 use Sylius\Behat\NotificationType;
 use Sylius\Behat\Page\Admin\Crud\CreatePageInterface;
 use Sylius\Behat\Page\Admin\Crud\UpdatePageInterface;
+use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
 use Sylius\Behat\Page\Admin\Product\CreateConfigurableProductPageInterface;
 use Sylius\Behat\Page\Admin\Product\CreateSimpleProductPageInterface;
 use Sylius\Behat\Page\Admin\Product\IndexPageInterface;
 use Sylius\Behat\Page\Admin\Product\IndexPerTaxonPageInterface;
 use Sylius\Behat\Page\Admin\Product\UpdateConfigurableProductPageInterface;
 use Sylius\Behat\Page\Admin\Product\UpdateSimpleProductPageInterface;
-use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
 use Sylius\Behat\Page\SymfonyPageInterface;
 use Sylius\Behat\Service\NotificationCheckerInterface;
 use Sylius\Behat\Service\Resolver\CurrentPageResolverInterface;

Doc Comments +1 added lines

@@ -248,6 +248,7 @@
      * @Then the product :productName should appear in the store
      * @Then the product :productName should be in the shop
      * @Then this product should still be named :productName
+     * @param string $productName
      */
     public function theProductShouldAppearInTheShop($productName)
     {

src/Sylius/Component/Core/spec/Customer/Statistics/CustomerStatisticsSpec.php

Braces +4 added lines, -2 removed lines

@@ -46,7 +46,8 @@ 
         $this->getAllOrdersCount()->shouldReturn(0);
     }
 
-    function it_has_number_of_all_orders(ChannelInterface $channel) {
+    function it_has_number_of_all_orders(ChannelInterface $channel)
+    {
         $firstStatistics = new PerChannelCustomerStatistics(110, 120, $channel->getWrappedObject());
         $secondStatistics = new PerChannelCustomerStatistics(13, 120, $channel->getWrappedObject());
 
@@ -55,7 +56,8 @@ 
         $this->getAllOrdersCount()->shouldReturn(123);
     }
 
-    function it_has_an_array_of_statistics_per_channel(ChannelInterface $channel) {
+    function it_has_an_array_of_statistics_per_channel(ChannelInterface $channel)
+    {
         $firstStatistics = new PerChannelCustomerStatistics(110, 120, $channel->getWrappedObject());
         $secondStatistics = new PerChannelCustomerStatistics(13, 120, $channel->getWrappedObject());
 

tests/Controller/CustomerApiTest.php

Spacing +9 added lines, -9 removed lines

@@ -187,7 +187,7 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $customers = $this->loadFixturesFromFile('resources/customers.yml');
 
-        $this->client->request('GET', '/api/v1/customers/'.$customers['customer_Barry']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/v1/customers/' . $customers['customer_Barry']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'customer/show_response', Response::HTTP_OK);
@@ -201,7 +201,7 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $customers = $this->loadFixturesFromFile('resources/customers.yml');
 
-        $this->client->request('GET', '/api/v1/customers/'.$customers['customer_Roy']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/v1/customers/' . $customers['customer_Roy']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'customer/show_with_user_response', Response::HTTP_OK);
@@ -239,7 +239,7 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $customers = $this->loadFixturesFromFile('resources/customers.yml');
 
-        $this->client->request('PUT', '/api/v1/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType);
+        $this->client->request('PUT', '/api/v1/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'customer/update_validation_fail_response', Response::HTTP_BAD_REQUEST);
@@ -263,12 +263,12 @@ 
         }
 EOT;
 
-        $this->client->request('PUT', '/api/v1/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
+        $this->client->request('PUT', '/api/v1/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/v1/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/v1/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'customer/update_response', Response::HTTP_OK);
@@ -303,12 +303,12 @@ 
         }
 EOT;
 
-        $this->client->request('PATCH', '/api/v1/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
+        $this->client->request('PATCH', '/api/v1/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/v1/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/v1/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'customer/partial_update_response', Response::HTTP_OK);
@@ -346,12 +346,12 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $customers = $this->loadFixturesFromFile('resources/customers.yml');
 
-        $this->client->request('DELETE', '/api/v1/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType);
+        $this->client->request('DELETE', '/api/v1/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/v1/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/v1/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'error/not_found_response', Response::HTTP_NOT_FOUND);

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -73,7 +73,7 @@ 
                 "enabled": "true"
             }
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/v1/customers/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -96,7 +96,7 @@ 
             "email": "john.diggle@yahoo.com",
             "gender": "m"
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/v1/customers/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -122,7 +122,7 @@ 
                 "plainPassword" : "testPassword"
             }
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/v1/customers/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -261,7 +261,7 @@ 
             "email": "john.diggle@example.com",
             "gender": "m"
         }
-EOT;
+eot;
 
         $this->client->request('PUT', '/api/v1/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -301,7 +301,7 @@ 
             "firstName": "John",
             "lastName": "Doe"
         }
-EOT;
+eot;
 
         $this->client->request('PATCH', '/api/v1/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
 

tests/Controller/ProvinceApiTest.php

Spacing +3 added lines, -3 removed lines

@@ -46,7 +46,7 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $countryData = $this->loadFixturesFromFile('resources/countries.yml');
 
-        $this->client->request('GET', '/api/v1/countries/'.$countryData['country_BE']->getCode().'/provinces/'.$countryData['province_BE_limburg']->getCode(), [], [], static::$authorizedHeaderWithContentType);
+        $this->client->request('GET', '/api/v1/countries/' . $countryData['country_BE']->getCode() . '/provinces/' . $countryData['province_BE_limburg']->getCode(), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'province/show_response', Response::HTTP_OK);
@@ -60,12 +60,12 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $countryData = $this->loadFixturesFromFile('resources/countries.yml');
 
-        $this->client->request('DELETE', '/api/v1/countries/'.$countryData['country_BE']->getCode().'/provinces/'.$countryData['province_BE_limburg']->getCode(), [], [], static::$authorizedHeaderWithContentType);
+        $this->client->request('DELETE', '/api/v1/countries/' . $countryData['country_BE']->getCode() . '/provinces/' . $countryData['province_BE_limburg']->getCode(), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/v1/countries/'.$countryData['country_BE']->getCode().'/provinces/'.$countryData['province_BE_limburg']->getCode(), [], [], static::$authorizedHeaderWithContentType);
+        $this->client->request('GET', '/api/v1/countries/' . $countryData['country_BE']->getCode() . '/provinces/' . $countryData['province_BE_limburg']->getCode(), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'error/not_found_response', Response::HTTP_NOT_FOUND);

src/Sylius/Bundle/ResourceBundle/test/src/Tests/Controller/ComicBookApiTest.php

Spacing +5 added lines, -5 removed lines

@@ -72,7 +72,7 @@ 
         }
 EOT;
 
-        $this->client->request('PUT', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
+        $this->client->request('PUT', '/v1/comic-books/' . $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
     }
@@ -92,7 +92,7 @@ 
         }
 EOT;
 
-        $this->client->request('PATCH', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
+        $this->client->request('PATCH', '/v1/comic-books/' . $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
     }
@@ -104,7 +104,7 @@ 
     {
         $objects = $this->loadFixturesFromFile('comic_books.yml');
 
-        $this->client->request('DELETE', '/v1/comic-books/'. $objects["comic-book1"]->getId());
+        $this->client->request('DELETE', '/v1/comic-books/' . $objects["comic-book1"]->getId());
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
     }
@@ -116,7 +116,7 @@ 
     {
         $objects = $this->loadFixturesFromFile('comic_books.yml');
 
-        $this->client->request('GET', '/v1/comic-books/'. $objects["comic-book1"]->getId());
+        $this->client->request('GET', '/v1/comic-books/' . $objects["comic-book1"]->getId());
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'comic-books/show_response');
     }
@@ -128,7 +128,7 @@ 
     {
         $objects = $this->loadFixturesFromFile('comic_books.yml');
 
-        $this->client->request('GET', '/v1.2/comic-books/'. $objects["comic-book1"]->getId());
+        $this->client->request('GET', '/v1.2/comic-books/' . $objects["comic-book1"]->getId());
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'comic-books/versioned_show_response');
     }

Indentation +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
         $objects = $this->loadFixturesFromFile('comic_books.yml');
 
         $data =
- <<<EOT
+    <<<EOT
         {
             "authorFirstName": "Joe",
             "authorLastName": "Kelly"

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -31,7 +31,7 @@ 
             "authorFirstName": "Joe",
             "authorLastName": "Kelly"
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/v1/comic-books/', [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
@@ -49,7 +49,7 @@ 
             "authorFirstName": "Joe",
             "authorLastName": "Kelly"
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/v1.2/comic-books/', [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
@@ -70,7 +70,7 @@ 
             "authorFirstName": "Joe",
             "authorLastName": "Kelly"
         }
-EOT;
+eot;
 
         $this->client->request('PUT', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
@@ -90,7 +90,7 @@ 
             "authorFirstName": "Joe",
             "authorLastName": "Kelly"
         }
-EOT;
+eot;
 
         $this->client->request('PATCH', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();

src/Sylius/Component/Product/Model/Product.php

Doc Comments +1 added lines

@@ -505,6 +505,7 @@
 
     /**
      * {@inheritdoc}
+     * @param string $localeCode
      */
     private function getAttributeInDifferentLocale(ProductAttributeValueInterface $attributeValue, $localeCode)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,11 +13,11 @@
 
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Collections\Collection;
-use Webmozart\Assert\Assert;
 use Sylius\Component\Attribute\Model\AttributeValueInterface;
 use Sylius\Component\Resource\Model\TimestampableTrait;
 use Sylius\Component\Resource\Model\ToggleableTrait;
 use Sylius\Component\Resource\Model\TranslatableTrait;
+use Webmozart\Assert\Assert;
 
 /**
  * @author Paweł Jędrzejewski <pawel@sylius.org>

app/migrations/Version20170109143010.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
         $defaultLocale = $this->container->getParameter('locale');
 
         $this->addSql('ALTER TABLE sylius_product_attribute_value ADD locale_code VARCHAR(255) NOT NULL');
-        $this->addSql('UPDATE sylius_product_attribute_value SET locale_code = "'.$defaultLocale.'"');
+        $this->addSql('UPDATE sylius_product_attribute_value SET locale_code = "' . $defaultLocale . '"');
     }
 
     /**

src/Sylius/Bundle/ProductBundle/Form/DataTransformer/ProductVariantToProductOptionsTransformer.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -15,8 +15,8 @@
 use Sylius\Component\Product\Model\ProductOptionValueInterface;
 use Sylius\Component\Product\Model\ProductVariantInterface;
 use Symfony\Component\Form\DataTransformerInterface;
-use Symfony\Component\Form\Exception\UnexpectedTypeException;
 use Symfony\Component\Form\Exception\TransformationFailedException;
+use Symfony\Component\Form\Exception\UnexpectedTypeException;
 
 /**
  * @author Paweł Jędrzejewski <pawel@sylius.org>

src/Sylius/Component/Mailer/Event/EmailSendEvent.php

Doc Comments +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
     protected $data;
 
     /**
-     * @param mixed $message
+     * @param \Swift_Message $message
      * @param array $recipients
      * @param EmailInterface $email
      * @param array $data
@@ -54,7 +54,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getRecipients()
     {