View GitHub Repository Sylius

Schedule Inspection
Subscribe
Completed
Push — travis-trusty ( dc96d8...990048 )
by Kamil
18:15
created
Status
Category
Toggle Patches
Sylius/Behat/Page/Admin/Product/CreateConfigurableProductPageInterface.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch 
@@ -20,23 +20,27 @@
 
 block discarded – undo
20 20 
 {
21 21 
     /**
22 22 
      * @param string $optionName
23 
+     * @return void
23 24 
      */
24 25 
     public function selectOption($optionName);
25 26
26 27 
     /**
27 28 
      * @param string $code
29 
+     * @return void
28 30 
      */
29 31 
     public function specifyCode($code);
30 32
31 33 
     /**
32 34 
      * @param string $name
33 35 
      * @param string $localeCode
36 
+     * @return void
34 37 
      */
35 38 
     public function nameItIn($name, $localeCode);
36 39
37 40 
     /**
38 41 
      * @param string $path
39 42 
      * @param string $type
43 
+     * @return void
40 44 
      */
41 45 
     public function attachImage($path, $type = null);
42 46 
 }
Please login to merge, or discard this patch.
Sylius/Behat/Page/Admin/Product/UpdateConfigurableProductPageInterface.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch 
@@ -27,6 +27,7 @@  discard block
 
 block discarded – undo
27 27 
     /**
28 28 
      * @param string $name
29 29 
      * @param string $localeCode
30 
+     * @return void
30 31 
      */
31 32 
     public function nameItIn($name, $localeCode);
32 33 
 
@@ -49,11 +50,13 @@  discard block
 
 block discarded – undo
49 50
50 51 
     /**
51 52 
      * @param TaxonInterface $taxon
53 
+     * @return void
52 54 
      */
53 55 
     public function selectMainTaxon(TaxonInterface $taxon);
54 56
55 57 
     /**
56 58 
      * @param string $channelName
59 
+     * @return void
57 60 
      */
58 61 
     public function checkChannel($channelName);
59 62 
 
@@ -67,24 +70,31 @@  discard block
 
 block discarded – undo
67 70 
     /**
68 71 
      * @param string $path
69 72 
      * @param string $type
73 
+     * @return void
70 74 
      */
71 75 
     public function attachImage($path, $type = null);
72 76
73 77 
     /**
74 78 
      * @param string $type
75 79 
      * @param string $path
80 
+     * @return void
76 81 
      */
77 82 
     public function changeImageWithType($type, $path);
78 83
79 84 
     /**
80 85 
      * @param string $type
86 
+     * @return void
81 87 
      */
82 88 
     public function removeImageWithType($type);
83 89
90 
+    /**
91 
+     * @return void
92 
+     */
84 93 
     public function removeFirstImage();
85 94
86 95 
     /**
87 96 
      * @param string $type
97 
+     * @return void
88 98 
      */
89 99 
     public function modifyFirstImageType($type);
90 100
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Taxon/CreatePageInterface.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch 
@@ -35,12 +35,14 @@  discard block
 
 block discarded – undo
35 35
36 36 
     /**
37 37 
      * @param string $name
38 
+     * @return void
38 39 
      */
39 40 
     public function deleteTaxonOnPageByName($name);
40 41
41 42 
     /**
42 43 
      * @param string $description
43 44 
      * @param string $languageCode
45 
+     * @return void
44 46 
      */
45 47 
     public function describeItAs($description, $languageCode);
46 48 
 
@@ -54,23 +56,27 @@  discard block
 
 block discarded – undo
54 56 
     /**
55 57 
      * @param string $name
56 58 
      * @param string $languageCode
59 
+     * @return void
57 60 
      */
58 61 
     public function nameIt($name, $languageCode);
59 62
60 63 
     /**
61 64 
      * @param string $code
65 
+     * @return void
62 66 
      */
63 67 
     public function specifyCode($code);
64 68
65 69 
     /**
66 70 
      * @param string $slug
67 71 
      * @param string $languageCode
72 
+     * @return void
68 73 
      */
69 74 
     public function specifySlug($slug, $languageCode);
70 75
71 76 
     /**
72 77 
      * @param string $path
73 78 
      * @param string $type
79 
+     * @return void
74 80 
      */
75 81 
     public function attachImage($path, $type = null);
76 82 
 
@@ -85,6 +91,7 @@  discard block
 
 block discarded – undo
85 91
86 92 
     /**
87 93 
      * @param string $locale
94 
+     * @return void
88 95 
      */
89 96 
     public function activateLanguageTab($locale);
90 97 
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Taxon/UpdatePageInterface.php 1 patch
Doc Comments   +13 added lines patch added patch discarded remove patch 
@@ -23,11 +23,13 @@  discard block
 
 block discarded – undo
23 23 
     /**
24 24 
      * @param string $description
25 25 
      * @param string $languageCode
26 
+     * @return void
26 27 
      */
27 28 
     public function describeItAs($description, $languageCode);
28 29
29 30 
     /**
30 31 
      * @param TaxonInterface $taxon
32 
+     * @return void
31 33 
      */
32 34 
     public function chooseParent(TaxonInterface $taxon);
33 35 
 
@@ -39,18 +41,21 @@  discard block
 
 block discarded – undo
39 41 
     /**
40 42 
      * @param string $name
41 43 
      * @param string $languageCode
44 
+     * @return void
42 45 
      */
43 46 
     public function nameIt($name, $languageCode);
44 47
45 48 
     /**
46 49 
      * @param string $slug
47 50 
      * @param string $languageCode
51 
+     * @return void
48 52 
      */
49 53 
     public function specifySlug($slug, $languageCode);
50 54
51 55 
     /**
52 56 
      * @param string $path
53 57 
      * @param string $type
58 
+     * @return void
54 59 
      */
55 60 
     public function attachImage($path, $type = null);
56 61 
 
@@ -70,13 +75,18 @@  discard block
 
 block discarded – undo
70 75
71 76 
     /**
72 77 
      * @param string $type
78 
+     * @return void
73 79 
      */
74 80 
     public function removeImageWithType($type);
75 81
82 
+    /**
83 
+     * @return void
84 
+     */
76 85 
     public function removeFirstImage();
77 86
78 87 
     /**
79 88 
      * @param string $languageCode
89 
+     * @return void
80 90 
      */
81 91 
     public function enableSlugModification($languageCode = 'en_US');
82 92 
 
@@ -88,11 +98,13 @@  discard block
 
 block discarded – undo
88 98 
     /**
89 99 
      * @param string $type
90 100 
      * @param string $path
101 
+     * @return void
91 102 
      */
92 103 
     public function changeImageWithType($type, $path);
93 104
94 105 
     /**
95 106 
      * @param string $type
107 
+     * @return void
96 108 
      */
97 109 
     public function modifyFirstImageType($type);
98 110 
 
@@ -126,6 +138,7 @@  discard block
 
 block discarded – undo
126 138
127 139 
     /**
128 140 
      * @param string $locale
141 
+     * @return void
129 142 
      */
130 143 
     public function activateLanguageTab($locale);
131 144 
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Context/Setup/TaxonomyContext.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -136,7 +136,7 @@
 
 block discarded – undo
136 136
137 137 
         /** @var ImageInterface $taxonImage */
138 138 
         $taxonImage = $this->taxonImageFactory->createNew();
139 
-        $taxonImage->setFile(new UploadedFile($filesPath.$imagePath, basename($imagePath)));
139 
+        $taxonImage->setFile(new UploadedFile($filesPath . $imagePath, basename($imagePath)));
140 140 
         $taxonImage->setType($imageType);
141 141 
         $this->imageUploader->upload($taxonImage);
142 142
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Taxon/CreatePage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -113,7 +113,7 @@
 
 block discarded – undo
113 113
114 114 
         $imageForm = $this->getLastImageElement();
115 115 
         $imageForm->fillField('Type', $type);
116 
-        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath.$path);
116 
+        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath . $path);
117 117 
     }
118 118
119 119 
     /**
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Taxon/UpdatePage.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -75,7 +75,7 @@  discard block
 
 block discarded – undo
75 75 
             $imageForm->fillField('Type', $type);
76 76 
         }
77 77
78 
-        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath.$path);
78 
+        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath . $path);
79 79 
     }
80 80
81 81 
     /**
 
@@ -146,7 +146,7 @@  discard block
 
 block discarded – undo
146 146 
         $filesPath = $this->getParameter('files_path');
147 147
148 148 
         $imageForm = $this->getImageElementByType($type);
149 
-        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath.$path);
149 
+        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath . $path);
150 150 
     }
151 151
152 152 
     /**
 
@@ -304,7 +304,7 @@  discard block
 
 block discarded – undo
304 304 
     private function getImageElementByType($type)
305 305 
     {
306 306 
         $images = $this->getElement('images');
307 
-        $typeInput = $images->find('css', 'input[value="'.$type.'"]');
307 
+        $typeInput = $images->find('css', 'input[value="' . $type . '"]');
308 308
309 309 
         if (null === $typeInput) {
310 310 
             return null;
Please login to merge, or discard this patch.
Doc Comments   +1 added lines patch added patch discarded remove patch 
@@ -199,6 +199,7 @@
 
 block discarded – undo
199 199
200 200 
     /**
201 201 
      * {@inheritdoc}
202 
+     * @param string $name
202 203 
      */
203 204 
     protected function getElement($name, array $parameters = [])
204 205 
     {
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Product/CreateSimpleProductPage.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -107,7 +107,7 @@
 
 block discarded – undo
107 107 
             $imageForm->fillField('Type', $type);
108 108 
         }
109 109
110 
-        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath.$path);
110 
+        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath . $path);
111 111 
     }
112 112
113 113 
     /**
Please login to merge, or discard this patch.
Doc Comments   +1 added lines patch added patch discarded remove patch 
@@ -199,6 +199,7 @@
 
 block discarded – undo
199 199
200 200 
     /**
201 201 
      * {@inheritdoc}
202 
+     * @param string $name
202 203 
      */
203 204 
     protected function getElement($name, array $parameters = [])
204 205 
     {
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Product/UpdateConfigurableProductPage.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -75,7 +75,7 @@  discard block
 
 block discarded – undo
75 75 
             $imageForm->fillField('Type', $type);
76 76 
         }
77 77
78 
-        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath.$path);
78 
+        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath . $path);
79 79 
     }
80 80
81 81 
     /**
 
@@ -146,7 +146,7 @@  discard block
 
 block discarded – undo
146 146 
         $filesPath = $this->getParameter('files_path');
147 147
148 148 
         $imageForm = $this->getImageElementByType($type);
149 
-        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath.$path);
149 
+        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath . $path);
150 150 
     }
151 151
152 152 
     /**
 
@@ -304,7 +304,7 @@  discard block
 
 block discarded – undo
304 304 
     private function getImageElementByType($type)
305 305 
     {
306 306 
         $images = $this->getElement('images');
307 
-        $typeInput = $images->find('css', 'input[value="'.$type.'"]');
307 
+        $typeInput = $images->find('css', 'input[value="' . $type . '"]');
308 308
309 309 
         if (null === $typeInput) {
310 310 
             return null;
Please login to merge, or discard this patch.