| Conditions | 1 |
| Paths | 1 |
| Total Lines | 61 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 4 | ||
| Bugs | 2 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 52 | private function configureConfigurationSubMenu(ItemInterface $menu) |
||
| 53 | { |
||
| 54 | $configurationSubMenu = $menu |
||
| 55 | ->addChild('configuration') |
||
| 56 | ->setLabel('sylius.menu.admin.main.configuration.header') |
||
| 57 | ; |
||
| 58 | |||
| 59 | $configurationSubMenu |
||
| 60 | ->addChild('tax_categories', ['route' => 'sylius_admin_tax_category_index']) |
||
| 61 | ->setLabel('sylius.menu.admin.main.configuration.tax_categories') |
||
| 62 | ->setLabelAttribute('icon', 'tags') |
||
| 63 | ; |
||
| 64 | |||
| 65 | $configurationSubMenu |
||
| 66 | ->addChild('countries', ['route' => 'sylius_admin_country_index']) |
||
| 67 | ->setLabel('sylius.menu.admin.main.configuration.countries') |
||
| 68 | ->setLabelAttribute('icon', 'flag') |
||
| 69 | ; |
||
| 70 | |||
| 71 | $configurationSubMenu |
||
| 72 | ->addChild('locale', ['route' => 'sylius_admin_locale_index']) |
||
| 73 | ->setLabel('sylius.menu.admin.main.configuration.locales') |
||
| 74 | ->setLabelAttribute('icon', 'translate') |
||
| 75 | ; |
||
| 76 | |||
| 77 | $configurationSubMenu |
||
| 78 | ->addChild('payment_methods', ['route' => 'sylius_admin_payment_method_index']) |
||
| 79 | ->setLabel('sylius.menu.admin.main.configuration.payment_methods') |
||
| 80 | ->setLabelAttribute('icon', 'payment') |
||
| 81 | ; |
||
| 82 | |||
| 83 | $configurationSubMenu |
||
| 84 | ->addChild('shipping_methods', ['route' => 'sylius_admin_shipping_method_index']) |
||
| 85 | ->setLabel('sylius.menu.admin.main.configuration.shipping_methods') |
||
| 86 | ->setLabelAttribute('icon', 'shipping') |
||
| 87 | ; |
||
| 88 | |||
| 89 | $configurationSubMenu |
||
| 90 | ->addChild('tax_rates', ['route' => 'sylius_admin_tax_rate_index']) |
||
| 91 | ->setLabel('sylius.menu.admin.main.configuration.tax_rates') |
||
| 92 | ->setLabelAttribute('icon', 'dollar') |
||
| 93 | ; |
||
| 94 | |||
| 95 | $configurationSubMenu |
||
| 96 | ->addChild('zones', ['route' => 'sylius_admin_zone_index']) |
||
| 97 | ->setLabel('sylius.menu.admin.main.configuration.zones') |
||
| 98 | ->setLabelAttribute('icon', 'world') |
||
| 99 | ; |
||
| 100 | |||
| 101 | $configurationSubMenu |
||
| 102 | ->addChild('currencies', ['route' => 'sylius_admin_currency_index']) |
||
| 103 | ->setLabel('sylius.menu.admin.main.configuration.currencies') |
||
| 104 | ->setLabelAttribute('icon', 'money') |
||
| 105 | ; |
||
| 106 | |||
| 107 | $configurationSubMenu |
||
| 108 | ->addChild('channels', ['route' => 'sylius_admin_channel_index']) |
||
| 109 | ->setLabel('sylius.menu.admin.main.configuration.channels') |
||
| 110 | ->setLabelAttribute('icon', 'random') |
||
| 111 | ; |
||
| 112 | } |
||
| 113 | |||
| 177 |