OrderItemsSubtotalExtension::__construct() - Code Metrics - Inspection of "Merge branch '1.6' into 1.7" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.7 ( 1627e8...895c05 )

by Kamil

created 2020-04-10 14:02 UTC

OrderItemsSubtotalExtension::__construct() A

↳ Parent: OrderItemsSubtotalExtension

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Sylius\Bundle\ShopBundle\Twig;

use Sylius\Bundle\ShopBundle\Calculator\OrderItemsSubtotalCalculator;
use Sylius\Bundle\ShopBundle\Calculator\OrderItemsSubtotalCalculatorInterface;
use Sylius\Component\Core\Model\OrderInterface;
use Twig\Extension\AbstractExtension;
use Twig\TwigFunction;

class OrderItemsSubtotalExtension extends AbstractExtension
{
    /** @var OrderItemsSubtotalCalculatorInterface */
    private $calculator;

    public function __construct(?OrderItemsSubtotalCalculatorInterface $calculator = null)
    {
        if (null === $calculator) {
            $calculator = new OrderItemsSubtotalCalculator();

            @trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                'Not passing a calculator is deprecated since 1.6. Argument will no longer be optional from 2.0.',
                \E_USER_DEPRECATED
            );
        }

        $this->calculator = $calculator;
    }

    public function getFunctions(): array
    {
        return [
            new TwigFunction('sylius_order_items_subtotal', [$this, 'getSubtotal']),
        ];
    }

    public function getSubtotal(OrderInterface $order): int
    {
        return $this->calculator->getSubtotal($order);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sylius package.
5			*
6			* (c) Paweł Jędrzejewski
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Sylius\Bundle\ShopBundle\Twig;
15
16			use Sylius\Bundle\ShopBundle\Calculator\OrderItemsSubtotalCalculator;
17			use Sylius\Bundle\ShopBundle\Calculator\OrderItemsSubtotalCalculatorInterface;
18			use Sylius\Component\Core\Model\OrderInterface;
19			use Twig\Extension\AbstractExtension;
20			use Twig\TwigFunction;
21
22			class OrderItemsSubtotalExtension extends AbstractExtension
23			{
24			/** @var OrderItemsSubtotalCalculatorInterface */
25			private $calculator;
26
27			public function __construct(?OrderItemsSubtotalCalculatorInterface $calculator = null)
28			{
29			if (null === $calculator) {
30			$calculator = new OrderItemsSubtotalCalculator();
31
32			@trigger_error(
			0 ignored issues – show Security Best Practice introduced 2020-04-10 14:45 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
33			'Not passing a calculator is deprecated since 1.6. Argument will no longer be optional from 2.0.',
34			\E_USER_DEPRECATED
35			);
36			}
37
38			$this->calculator = $calculator;
39			}
40
41			public function getFunctions(): array
42			{
43			return [
44			new TwigFunction('sylius_order_items_subtotal', [$this, 'getSubtotal']),
45			];
46			}
47
48			public function getSubtotal(OrderInterface $order): int
49			{
50			return $this->calculator->getSubtotal($order);
51			}
52			}
53

pamil / Sylius

Push — 1.7 ( 1627e8...895c05 )

OrderItemsSubtotalExtension::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like