pamil / Sylius

src/Sylius/Behat/Context/Setup/PromotionContext.php

Doc Comments +4 added lines, -2 removed lines

@@ -352,6 +352,7 @@ 
 
     /**
      * @Given /^([^"]+) gives ("[^"]+%") discount on shipping to every order$/
+     * @param integer $discount
      */
     public function itGivesPercentageDiscountOnShippingToEveryOrder(PromotionInterface $promotion, $discount)
     {
@@ -675,6 +676,7 @@ 
 
     /**
      * @Given /^([^"]+) gives ("[^"]+%") discount on shipping to every order over ("(?:€|£|\$)[^"]+")$/
+     * @param integer $discount
      */
     public function itGivesDiscountOnShippingToEveryOrderOver(
         PromotionInterface $promotion,
@@ -697,7 +699,7 @@ 
     }
 
     /**
-     * @param array $taxonCodes
+     * @param string[] $taxonCodes
      *
      * @return array
      */
@@ -707,7 +709,7 @@ 
     }
 
     /**
-     * @param array $productCodes
+     * @param string[] $productCodes
      *
      * @return array
      */

src/Sylius/Behat/Page/Admin/Promotion/CreatePageInterface.php

Doc Comments +22 added lines

@@ -22,16 +22,19 @@ 
 {
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
     /**
      * @param string $ruleName
+     * @return void
      */
     public function addRule($ruleName);
 
@@ -39,6 +42,7 @@ 
      * @param string $option
      * @param string $value
      * @param bool $multiple
+     * @return void
      */
     public function selectRuleOption($option, $value, $multiple = false);
 
@@ -46,12 +50,14 @@ 
      * @param string $option
      * @param string $value
      * @param bool $multiple
+     * @return void
      */
     public function selectAutocompleteRuleOption($option, $value, $multiple = false);
 
     /**
      * @param string $option
      * @param string $value
+     * @return void
      */
     public function fillRuleOption($option, $value);
 
@@ -59,11 +65,13 @@ 
      * @param string $channelName
      * @param string $option
      * @param string $value
+     * @return void
      */
     public function fillRuleOptionForChannel($channelName, $option, $value);
 
     /**
      * @param string $actionName
+     * @return void
      */
     public function addAction($actionName);
 
@@ -71,12 +79,14 @@ 
      * @param string $option
      * @param string $value
      * @param bool $multiple
+     * @return void
      */
     public function selectActionOption($option, $value, $multiple = false);
 
     /**
      * @param string $option
      * @param string $value
+     * @return void
      */
     public function fillActionOption($option, $value);
 
@@ -84,30 +94,41 @@ 
      * @param string $channelName
      * @param string $option
      * @param string $value
+     * @return void
      */
     public function fillActionOptionForChannel($channelName, $option, $value);
 
     /**
      * @param string $limit
+     * @return void
      */
     public function fillUsageLimit($limit);
 
+    /**
+     * @return void
+     */
     public function makeExclusive();
 
+    /**
+     * @return void
+     */
     public function checkCouponBased();
 
     /**
      * @param string $name
+     * @return void
      */
     public function checkChannel($name);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setStartsAt(\DateTime $dateTime);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setEndsAt(\DateTime $dateTime);
 
@@ -122,6 +143,7 @@ 
      * @param string $option
      * @param string $value
      * @param bool $multiple
+     * @return void
      */
     public function selectAutoCompleteFilterOption($option, $value, $multiple = false);
 }

src/Sylius/Behat/Page/Admin/Promotion/UpdatePageInterface.php

Doc Comments +14 added lines

@@ -22,6 +22,7 @@ 
 
     /**
      * @param int|null $priority
+     * @return void
      */
     public function setPriority($priority);
 
@@ -32,6 +33,7 @@ 
 
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
@@ -49,35 +51,47 @@ 
 
     /**
      * @param string $limit
+     * @return void
      */
     public function fillUsageLimit($limit);
 
+    /**
+     * @return void
+     */
     public function makeExclusive();
 
+    /**
+     * @return void
+     */
     public function checkCouponBased();
 
     /**
      * @param string $name
+     * @return void
      */
     public function checkChannel($name);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setStartsAt(\DateTime $dateTime);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setEndsAt(\DateTime $dateTime);
 
     /**
      * {@inheritdoc}
+     * @return boolean
      */
     public function hasStartsAt(\DateTime $dateTime);
 
     /**
      * {@inheritdoc}
+     * @return boolean
      */
     public function hasEndsAt(\DateTime $dateTime);
 }

tests/Controller/AdminUserApiTest.php

Spacing +1 added lines, -1 removed lines

@@ -340,7 +340,7 @@
         $this->client->request('DELETE', $this->getAdminUserUrl($user['admin']), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
-        $this->assertResponse($response, 'admin_user/deletion_fail_response',  Response::HTTP_UNPROCESSABLE_ENTITY);
+        $this->assertResponse($response, 'admin_user/deletion_fail_response', Response::HTTP_UNPROCESSABLE_ENTITY);
     }
 
     /**

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -76,7 +76,7 @@ 
             "plainPassword": "youShallNotPass",
             "localeCode": "en_US"
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/v1/users/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -103,7 +103,7 @@ 
             "localeCode": "en_US",
             "enabled": "true"
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/v1/users/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -233,7 +233,7 @@ 
             "localeCode": "fr_FR",
             "enabled": "true"
         }
-EOT;
+eot;
 
         $this->client->request('PUT', $this->getAdminUserUrl($users['admin1']), [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -273,7 +273,7 @@ 
             "firstName": "John",
             "lastName": "Doe"
         }
-EOT;
+eot;
 
         $this->client->request('PATCH', $this->getAdminUserUrl($users['admin1']), [], [], static::$authorizedHeaderWithContentType, $data);
 

tests/Controller/PromotionApiTest.php

Upper-Lower-Casing +9 added lines, -9 removed lines

@@ -230,7 +230,7 @@ 
             "code": "christmas-promotion",
             "name": "Christmas Promotion"
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -255,7 +255,7 @@ 
                 "MOB"
             ]
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -283,7 +283,7 @@ 
                 "time": "11:00"
             }
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -323,7 +323,7 @@ 
                 }
             ]
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -387,7 +387,7 @@ 
                 }
             ]
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -409,7 +409,7 @@ 
             "name": "Christmas Promotion",
             "couponBased": true
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -431,7 +431,7 @@ 
             "exclusive": true,
             "priority": 0
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -453,7 +453,7 @@ 
             "name": "Monday promotion",
             "priority": 0
         }
-EOT;
+eot;
         $this->client->request('PUT', $this->getPromotionUrl($promotion), [], [], static::$authorizedHeaderWithContentType, $data);
         $response = $this->client->getResponse();
 
@@ -479,7 +479,7 @@ 
         {
             "exclusive": true
         }
-EOT;
+eot;
         $this->client->request('PATCH', $this->getPromotionUrl($promotion), [], [], static::$authorizedHeaderWithContentType, $data);
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);

src/Sylius/Bundle/ProductBundle/Doctrine/ORM/ProductRepository.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
         return $this->createQueryBuilder('o')
             ->innerJoin('o.translations', 'translation', 'WITH', 'translation.locale = :locale')
             ->andWhere('translation.name LIKE :name')
-            ->setParameter('name', '%'.$phrase.'%')
+            ->setParameter('name', '%' . $phrase . '%')
             ->setParameter('locale', $locale)
             ->getQuery()
             ->getResult()

src/Sylius/Behat/Page/Admin/Promotion/CreatePage.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 namespace Sylius\Behat\Page\Admin\Promotion;
 
-use Behat\Mink\Driver\Selenium2Driver;
 use Behat\Mink\Element\NodeElement;
 use Behat\Mink\Exception\ElementNotFoundException;
 use Sylius\Behat\Behaviour\NamesIt;

src/Sylius/Bundle/ProductBundle/Doctrine/ORM/ProductVariantRepository.php

Spacing +1 added lines, -1 removed lines

@@ -145,7 +145,7 @@
                 'translation.name LIKE :phrase',
                 'o.code LIKE :phrase'
             ))
-            ->setParameter('phrase', '%'.$phrase.'%')
+            ->setParameter('phrase', '%' . $phrase . '%')
             ->setParameter('locale', $locale)
             ->setParameter('productCode', $productCode)
             ->getQuery()

src/Sylius/Bundle/ResourceBundle/Form/Type/FixedCollectionType.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     }
 
     /**
-     * @return callable
+     * @return \Closure
      */
     private function optionalCallableNormalizer()
     {