ArrayToDefinitionConverterSpec::it_converts_an_array_to_grid_definition() - Code Metrics - Inspection of "XXX" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — beta3 ( 7f704a )

by Kamil

created 2017-07-17 11:11 UTC

it_converts_an_array_to_grid_definition() B

↳ Parent: ArrayToDefinitionConverterSpec

Complexity

Conditions	1
Paths	1

Size

Total Lines	82
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	82
rs	8.7769
c	0
b	0
f	0
cc	1
eloc	55
nc	1
nop	1

How to fix Long Method

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace spec\Sylius\Component\Grid\Definition;

use PhpSpec\ObjectBehavior;
use Prophecy\Argument;
use Sylius\Component\Grid\Definition\Action;
use Sylius\Component\Grid\Definition\ActionGroup;
use Sylius\Component\Grid\Definition\ArrayToDefinitionConverter;
use Sylius\Component\Grid\Definition\ArrayToDefinitionConverterInterface;
use Sylius\Component\Grid\Definition\Field;
use Sylius\Component\Grid\Definition\Filter;
use Sylius\Component\Grid\Definition\Grid;
use Sylius\Component\Grid\Event\GridDefinitionConverterEvent;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

/**
 * @author Paweł Jędrzejewski <[email protected]>
 */
final class ArrayToDefinitionConverterSpec extends ObjectBehavior
{
    function let(EventDispatcherInterface $eventDispatcher)
    {
        $this->beConstructedWith($eventDispatcher);
    }

    function it_is_initializable()
    {
        $this->shouldHaveType(ArrayToDefinitionConverter::class);
    }

    function it_implements_array_to_definition_converter()
    {
        $this->shouldImplement(ArrayToDefinitionConverterInterface::class);
    }

    function it_converts_an_array_to_grid_definition(EventDispatcherInterface $eventDispatcher)
    {
        $grid = Grid::fromCodeAndDriverConfiguration(
            'sylius_admin_tax_category',
            'doctrine/orm',
            ['resource' => 'sylius.tax_category']
        );

        $grid->setSorting(['code' => 'desc']);

        $grid->setLimits([9, 18]);

        $codeField = Field::fromNameAndType('code', 'string');
        $codeField->setLabel('System Code');
        $codeField->setPath('method.code');
        $codeField->setOptions(['template' => 'bar.html.twig']);
        $codeField->setSortable('code');

        $grid->addField($codeField);

        $viewAction = Action::fromNameAndType('view', 'link');
        $viewAction->setLabel('Display Tax Category');
        $viewAction->setOptions(['foo' => 'bar']);
        $defaultActionGroup = ActionGroup::named('default');
        $defaultActionGroup->addAction($viewAction);

        $grid->addActionGroup($defaultActionGroup);

        $filter = Filter::fromNameAndType('enabled', 'boolean');
        $filter->setOptions(['fields' => ['firstName', 'lastName']]);
        $filter->setCriteria('true');
        $grid->addFilter($filter);

        $eventDispatcher
            ->dispatch('sylius.grid.admin_tax_category', Argument::type(GridDefinitionConverterEvent::class))
            ->shouldBeCalled()
        ;

        $definitionArray = [
            'driver' => [
                'name' => 'doctrine/orm',
                'options' => ['resource' => 'sylius.tax_category'],
            ],
            'sorting' => [
                'code' => 'desc',
            ],
            'limits' => [9, 18],
            'fields' => [
                'code' => [
                    'type' => 'string',
                    'label' => 'System Code',
                    'path' => 'method.code',
                    'sortable' => 'code',
                    'options' => [
                        'template' => 'bar.html.twig'
                    ],
                ],
            ],
            'filters' => [
                'enabled' => [
                    'type' => 'boolean',
                    'options' => [
                        'fields' => ['firstName', 'lastName']
                    ],
                    'default_value' => 'true',
                ]
            ],
            'actions' => [
                'default' => [
                    'view' => [
                        'type' => 'link',
                        'label' => 'Display Tax Category',
                        'options' => [
                            'foo' => 'bar',
                        ],
                    ]
                ]
            ]
        ];

        $this->convert('sylius_admin_tax_category', $definitionArray)->shouldBeSameGridAs($grid);
    }

    public function getMatchers()
    {
        return [
            'beSameGridAs' => function ($subject, $key) {
                return serialize($subject) === serialize($key);
            },
        ];
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sylius package.
5			*
6			* (c) Paweł Jędrzejewski
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace spec\Sylius\Component\Grid\Definition;
13
14			use PhpSpec\ObjectBehavior;
15			use Prophecy\Argument;
16			use Sylius\Component\Grid\Definition\Action;
17			use Sylius\Component\Grid\Definition\ActionGroup;
18			use Sylius\Component\Grid\Definition\ArrayToDefinitionConverter;
19			use Sylius\Component\Grid\Definition\ArrayToDefinitionConverterInterface;
20			use Sylius\Component\Grid\Definition\Field;
21			use Sylius\Component\Grid\Definition\Filter;
22			use Sylius\Component\Grid\Definition\Grid;
23			use Sylius\Component\Grid\Event\GridDefinitionConverterEvent;
24			use Symfony\Component\EventDispatcher\EventDispatcherInterface;
25
26			/**
27			* @author Paweł Jędrzejewski <[email protected]>
28			*/
29			final class ArrayToDefinitionConverterSpec extends ObjectBehavior
30			{
31			function let(EventDispatcherInterface $eventDispatcher)
32			{
33			$this->beConstructedWith($eventDispatcher);
34			}
35
36			function it_is_initializable()
37			{
38			$this->shouldHaveType(ArrayToDefinitionConverter::class);
39			}
40
41			function it_implements_array_to_definition_converter()
42			{
43			$this->shouldImplement(ArrayToDefinitionConverterInterface::class);
44			}
45
46			function it_converts_an_array_to_grid_definition(EventDispatcherInterface $eventDispatcher)
47			{
48			$grid = Grid::fromCodeAndDriverConfiguration(
49			'sylius_admin_tax_category',
50			'doctrine/orm',
51			['resource' => 'sylius.tax_category']
52			);
53
54			$grid->setSorting(['code' => 'desc']);
55
56			$grid->setLimits([9, 18]);
57
58			$codeField = Field::fromNameAndType('code', 'string');
59			$codeField->setLabel('System Code');
60			$codeField->setPath('method.code');
61			$codeField->setOptions(['template' => 'bar.html.twig']);
62			$codeField->setSortable('code');
63
64			$grid->addField($codeField);
65
66			$viewAction = Action::fromNameAndType('view', 'link');
67			$viewAction->setLabel('Display Tax Category');
68			$viewAction->setOptions(['foo' => 'bar']);
69			$defaultActionGroup = ActionGroup::named('default');
70			$defaultActionGroup->addAction($viewAction);
71
72			$grid->addActionGroup($defaultActionGroup);
73
74			$filter = Filter::fromNameAndType('enabled', 'boolean');
75			$filter->setOptions(['fields' => ['firstName', 'lastName']]);
76			$filter->setCriteria('true');
77			$grid->addFilter($filter);
78
79			$eventDispatcher
80			->dispatch('sylius.grid.admin_tax_category', Argument::type(GridDefinitionConverterEvent::class))
81			->shouldBeCalled()
82			;
83
84			$definitionArray = [
85			'driver' => [
86			'name' => 'doctrine/orm',
87			'options' => ['resource' => 'sylius.tax_category'],
88			],
89			'sorting' => [
90			'code' => 'desc',
91			],
92			'limits' => [9, 18],
93			'fields' => [
94			'code' => [
95			'type' => 'string',
96			'label' => 'System Code',
97			'path' => 'method.code',
98			'sortable' => 'code',
99			'options' => [
100			'template' => 'bar.html.twig'
101			],
102			],
103			],
104			'filters' => [
105			'enabled' => [
106			'type' => 'boolean',
107			'options' => [
108			'fields' => ['firstName', 'lastName']
109			],
110			'default_value' => 'true',
111			]
112			],
113			'actions' => [
114			'default' => [
115			'view' => [
116			'type' => 'link',
117			'label' => 'Display Tax Category',
118			'options' => [
119			'foo' => 'bar',
120			],
121			]
122			]
123			]
124			];
125
126			$this->convert('sylius_admin_tax_category', $definitionArray)->shouldBeSameGridAs($grid);
127			}
128
129			public function getMatchers()
130			{
131			return [
132			'beSameGridAs' => function ($subject, $key) {
133			return serialize($subject) === serialize($key);
134			},
135			];
136			}
137			}
138

pamil / Sylius

Push — beta3 ( 7f704a )

it_converts_an_array_to_grid_definition() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like