Completed
Push — 1.0-random-codebase-fixes ( e0fefc )
by Kamil
22:20
created
src/Sylius/Behat/Service/SharedStorageInterface.php 2 patches
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,11 +33,12 @@  discard block
 block discarded – undo
33 33
     /**
34 34
      * @param string $key
35 35
      * @param mixed $resource
36
+     * @return void
36 37
      */
37 38
     public function set($key, $resource);
38 39
 
39 40
     /**
40
-     * @return mixed
41
+     * @return string
41 42
      */
42 43
     public function getLatestResource();
43 44
 
@@ -45,6 +46,7 @@  discard block
 block discarded – undo
45 46
      * @param array $clipboard
46 47
      *
47 48
      * @throws \RuntimeException
49
+     * @return void
48 50
      */
49 51
     public function setClipboard(array $clipboard);
50 52
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace Sylius\Behat\Service;
15 15
 
Please login to merge, or discard this patch.
src/Sylius/Bundle/ReviewBundle/Form/Type/ReviewType.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,8 +13,8 @@
 block discarded – undo
13 13
 
14 14
 use Sylius\Bundle\ResourceBundle\Form\Type\AbstractResourceType;
15 15
 use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
16
-use Symfony\Component\Form\Extension\Core\Type\TextareaType;
17 16
 use Symfony\Component\Form\Extension\Core\Type\TextType;
17
+use Symfony\Component\Form\Extension\Core\Type\TextareaType;
18 18
 use Symfony\Component\Form\FormBuilderInterface;
19 19
 use Symfony\Component\OptionsResolver\OptionsResolver;
20 20
 use Symfony\Component\Validator\Constraints\Valid;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace Sylius\Bundle\ReviewBundle\Form\Type;
15 15
 
Please login to merge, or discard this patch.
src/Sylius/Bundle/CoreBundle/Form/Extension/CartTypeExtension.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,8 @@
 block discarded – undo
47 47
     {
48 48
         $resolver->setNormalizer('validation_groups', function (Options $options, array $validationGroups) {
49 49
             return function (FormInterface $form) use ($validationGroups) {
50
-                if ((bool) $form->get('promotionCoupon')->getNormData()) { // Validate the coupon if it was sent
50
+                if ((bool) $form->get('promotionCoupon')->getNormData()) {
51
+// Validate the coupon if it was sent
51 52
                     $validationGroups[] = 'sylius_promotion_coupon';
52 53
                 }
53 54
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace Sylius\Bundle\CoreBundle\Form\Extension;
15 15
 
Please login to merge, or discard this patch.
src/Sylius/Bundle/FixturesBundle/spec/Suite/SuiteSpec.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -84,6 +84,7 @@
 block discarded – undo
84 84
 
85 85
     /**
86 86
      * @param Collaborator[] ...$collaborators
87
+     * @param FixtureInterface $collaborators
87 88
      *
88 89
      * @return \Generator
89 90
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace spec\Sylius\Bundle\FixturesBundle\Suite;
15 15
 
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/ShippingMethod/UpdatePageInterface.php 2 patches
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -31,10 +31,19 @@
 block discarded – undo
31 31
      */
32 32
     public function isAvailableInChannel($channelName);
33 33
 
34
+    /**
35
+     * @return void
36
+     */
34 37
     public function enable();
35 38
 
39
+    /**
40
+     * @return void
41
+     */
36 42
     public function disable();
37 43
 
44
+    /**
45
+     * @return void
46
+     */
38 47
     public function removeZone();
39 48
 
40 49
     /**
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace Sylius\Behat\Page\Admin\ShippingMethod;
15 15
 
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Shop/Checkout/SelectShippingPageInterface.php 2 patches
Doc Comments   +11 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,6 +20,7 @@  discard block
 block discarded – undo
20 20
 {
21 21
     /**
22 22
      * @param string $shippingMethod
23
+     * @return void
23 24
      */
24 25
     public function selectShippingMethod($shippingMethod);
25 26
 
@@ -48,14 +49,23 @@  discard block
 block discarded – undo
48 49
      */
49 50
     public function getItemSubtotal($itemName);
50 51
 
52
+    /**
53
+     * @return void
54
+     */
51 55
     public function nextStep();
52 56
 
57
+    /**
58
+     * @return void
59
+     */
53 60
     public function changeAddress();
54 61
 
62
+    /**
63
+     * @return void
64
+     */
55 65
     public function changeAddressByStepLabel();
56 66
 
57 67
     /**
58
-     * @return mixed string
68
+     * @return string string
59 69
      */
60 70
     public function getPurchaserEmail();
61 71
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace Sylius\Behat\Page\Shop\Checkout;
15 15
 
Please login to merge, or discard this patch.
app/migrations/Version20161214153137.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 
34 34
         $this->addSql('CREATE TABLE sylius_product_variant_translation (id INT AUTO_INCREMENT NOT NULL, translatable_id INT NOT NULL, name VARCHAR(255) DEFAULT NULL, locale VARCHAR(255) NOT NULL, INDEX IDX_8DC18EDC2C2AC5D3 (translatable_id), UNIQUE INDEX sylius_product_variant_translation_uniq_trans (translatable_id, locale), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB');
35 35
         $this->addSql('ALTER TABLE sylius_product_variant_translation ADD CONSTRAINT FK_8DC18EDC2C2AC5D3 FOREIGN KEY (translatable_id) REFERENCES sylius_product_variant (id) ON DELETE CASCADE');
36
-        $this->addSql('INSERT INTO sylius_product_variant_translation (translatable_id, name, locale) SELECT id, name, "'.$defaultLocale.'" from sylius_product_variant WHERE sylius_product_variant.name IS NOT null');
36
+        $this->addSql('INSERT INTO sylius_product_variant_translation (translatable_id, name, locale) SELECT id, name, "' . $defaultLocale . '" from sylius_product_variant WHERE sylius_product_variant.name IS NOT null');
37 37
         $this->addSql('ALTER TABLE sylius_product_variant DROP name');
38 38
     }
39 39
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $this->abortIf($this->connection->getDatabasePlatform()->getName() != 'mysql', 'Migration can only be executed safely on \'mysql\'.');
48 48
 
49 49
         $this->addSql('ALTER TABLE sylius_product_variant ADD name VARCHAR(255) DEFAULT NULL COLLATE utf8_unicode_ci');
50
-        $this->addSql('UPDATE sylius_product_variant SET name = (SELECT name FROM sylius_product_variant_translation WHERE sylius_product_variant_translation.translatable_id = sylius_product_variant.id AND sylius_product_variant_translation.locale = "'.$defaultLocale.'")');
50
+        $this->addSql('UPDATE sylius_product_variant SET name = (SELECT name FROM sylius_product_variant_translation WHERE sylius_product_variant_translation.translatable_id = sylius_product_variant.id AND sylius_product_variant_translation.locale = "' . $defaultLocale . '")');
51 51
         $this->addSql('DROP TABLE sylius_product_variant_translation');
52 52
     }
53 53
 }
Please login to merge, or discard this patch.
app/migrations/Version20161219160441.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
         $this->addSql('CREATE TABLE sylius_product_association_type_translation (id INT AUTO_INCREMENT NOT NULL, translatable_id INT NOT NULL, name VARCHAR(255) DEFAULT NULL, locale VARCHAR(255) NOT NULL, INDEX IDX_4F618E52C2AC5D3 (translatable_id), UNIQUE INDEX sylius_product_association_type_translation_uniq_trans (translatable_id, locale), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB');
38 38
         $this->addSql('ALTER TABLE sylius_product_association_type_translation ADD CONSTRAINT FK_4F618E52C2AC5D3 FOREIGN KEY (translatable_id) REFERENCES sylius_product_association_type (id) ON DELETE CASCADE');
39
-        $this->addSql('INSERT INTO sylius_product_association_type_translation (translatable_id, name, locale) SELECT id, name, "'.$defaultLocale.'" from sylius_product_association_type WHERE sylius_product_association_type.name IS NOT null');
39
+        $this->addSql('INSERT INTO sylius_product_association_type_translation (translatable_id, name, locale) SELECT id, name, "' . $defaultLocale . '" from sylius_product_association_type WHERE sylius_product_association_type.name IS NOT null');
40 40
         $this->addSql('ALTER TABLE sylius_product_association_type DROP name');
41 41
     }
42 42
 
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
         $defaultLocale = $this->container->getParameter('locale');
51 51
 
52 52
         $this->addSql('ALTER TABLE sylius_product_association_type ADD name VARCHAR(255) NOT NULL COLLATE utf8_unicode_ci');
53
-        $this->addSql('UPDATE sylius_product_association_type SET name = (SELECT name FROM sylius_product_association_type_translation WHERE sylius_product_association_type_translation.translatable_id = sylius_product_association_type.id AND sylius_product_association_type_translation.locale = "'.$defaultLocale.'")');
53
+        $this->addSql('UPDATE sylius_product_association_type SET name = (SELECT name FROM sylius_product_association_type_translation WHERE sylius_product_association_type_translation.translatable_id = sylius_product_association_type.id AND sylius_product_association_type_translation.locale = "' . $defaultLocale . '")');
54 54
         $this->addSql('DROP TABLE sylius_product_association_type_translation');
55 55
     }
56 56
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Shop/Checkout/AddressPage.php 2 patches
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -429,6 +429,8 @@
 block discarded – undo
429 429
     }
430 430
 
431 431
     /**
432
+     * @param integer $timeout
433
+     * @param string $elementName
432 434
      * @return bool
433 435
      */
434 436
     private function waitForElement($timeout, $elementName)
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace Sylius\Behat\Page\Shop\Checkout;
15 15
 
Please login to merge, or discard this patch.