Complex classes like ManagingProductVariantsContext often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ManagingProductVariantsContext, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 29 | final class ManagingProductVariantsContext implements Context |
||
| 30 | { |
||
| 31 | /** @var SharedStorageInterface */ |
||
| 32 | private $sharedStorage; |
||
| 33 | |||
| 34 | /** @var CreatePageInterface */ |
||
| 35 | private $createPage; |
||
| 36 | |||
| 37 | /** @var IndexPageInterface */ |
||
| 38 | private $indexPage; |
||
| 39 | |||
| 40 | /** @var UpdatePageInterface */ |
||
| 41 | private $updatePage; |
||
| 42 | |||
| 43 | /** @var GeneratePageInterface */ |
||
| 44 | private $generatePage; |
||
| 45 | |||
| 46 | /** @var CurrentPageResolverInterface */ |
||
| 47 | private $currentPageResolver; |
||
| 48 | |||
| 49 | /** @var NotificationCheckerInterface */ |
||
| 50 | private $notificationChecker; |
||
| 51 | |||
| 52 | public function __construct( |
||
| 69 | |||
| 70 | /** |
||
| 71 | * @Given /^I want to create a new variant of (this product)$/ |
||
| 72 | */ |
||
| 73 | public function iWantToCreateANewProduct(ProductInterface $product) |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @When I specify its code as :code |
||
| 80 | * @When I do not specify its code |
||
| 81 | */ |
||
| 82 | public function iSpecifyItsCodeAs($code = null) |
||
| 86 | |||
| 87 | /** |
||
| 88 | * @When I name it :name in :language |
||
| 89 | */ |
||
| 90 | public function iNameItIn($name, $language) |
||
| 94 | |||
| 95 | /** |
||
| 96 | * @When I add it |
||
| 97 | * @When I try to add it |
||
| 98 | */ |
||
| 99 | public function iAddIt() |
||
| 103 | |||
| 104 | /** |
||
| 105 | * @When I disable its inventory tracking |
||
| 106 | */ |
||
| 107 | public function iDisableItsTracking() |
||
| 111 | |||
| 112 | /** |
||
| 113 | * @When I enable its inventory tracking |
||
| 114 | */ |
||
| 115 | public function iEnableItsTracking() |
||
| 119 | |||
| 120 | /** |
||
| 121 | * @When /^I set its(?:| default) price to "(?:€|£|\$)([^"]+)" for "([^"]+)" channel$/ |
||
| 122 | * @When I do not set its price |
||
| 123 | */ |
||
| 124 | public function iSetItsPriceTo(?string $price = null, $channelName = null) |
||
| 128 | |||
| 129 | /** |
||
| 130 | * @When /^I set its original price to "(?:€|£|\$)([^"]+)" for "([^"]+)" channel$/ |
||
| 131 | */ |
||
| 132 | public function iSetItsOriginalPriceTo($originalPrice, $channelName) |
||
| 136 | |||
| 137 | /** |
||
| 138 | * @When I set its height, width, depth and weight to :number |
||
| 139 | */ |
||
| 140 | public function iSetItsDimensionsTo($value) |
||
| 144 | |||
| 145 | /** |
||
| 146 | * @When I do not specify its current stock |
||
| 147 | */ |
||
| 148 | public function iDoNetSetItsCurrentStockTo() |
||
| 152 | |||
| 153 | /** |
||
| 154 | * @When I choose :calculatorName calculator |
||
| 155 | */ |
||
| 156 | public function iChooseCalculator($calculatorName) |
||
| 160 | |||
| 161 | /** |
||
| 162 | * @When I set its :optionName option to :optionValue |
||
| 163 | */ |
||
| 164 | public function iSetItsOptionAs($optionName, $optionValue) |
||
| 168 | |||
| 169 | /** |
||
| 170 | * @When I set the position of :name to :position |
||
| 171 | */ |
||
| 172 | public function iSetThePositionOfTo($name, int $position) |
||
| 176 | |||
| 177 | /** |
||
| 178 | * @When I save my new configuration |
||
| 179 | */ |
||
| 180 | public function iSaveMyNewConfiguration() |
||
| 184 | |||
| 185 | /** |
||
| 186 | * @When I do not want to have shipping required for this product |
||
| 187 | */ |
||
| 188 | public function iDoNotWantToHaveShippingRequiredForThisProduct() |
||
| 192 | |||
| 193 | /** |
||
| 194 | * @When I check (also) the :productVariantName product variant |
||
| 195 | */ |
||
| 196 | public function iCheckTheProductVariantName(string $productVariantName): void |
||
| 200 | |||
| 201 | /** |
||
| 202 | * @When I delete them |
||
| 203 | */ |
||
| 204 | public function iDeleteThem(): void |
||
| 208 | |||
| 209 | /** |
||
| 210 | * @Then /^the (variant with code "[^"]+") should be priced at (?:€|£|\$)([^"]+) for channel "([^"]+)"$/ |
||
| 211 | */ |
||
| 212 | public function theVariantWithCodeShouldBePricedAtForChannel(ProductVariantInterface $productVariant, string $price, $channelName) |
||
| 218 | |||
| 219 | /** |
||
| 220 | * @Then /^the (variant with code "[^"]+") should be named "([^"]+)" in ("([^"]+)" locale)$/ |
||
| 221 | */ |
||
| 222 | public function theVariantWithCodeShouldBeNamedIn(ProductVariantInterface $productVariant, $name, $language) |
||
| 228 | |||
| 229 | /** |
||
| 230 | * @Then /^the (variant with code "[^"]+") should have an original price of (?:€|£|\$)([^"]+) for channel "([^"]+)"$/ |
||
| 231 | */ |
||
| 232 | public function theVariantWithCodeShouldHaveAnOriginalPriceOfForChannel(ProductVariantInterface $productVariant, $originalPrice, $channelName) |
||
| 241 | |||
| 242 | /** |
||
| 243 | * @When /^I delete the ("[^"]+" variant of product "[^"]+")$/ |
||
| 244 | * @When /^I try to delete the ("[^"]+" variant of product "[^"]+")$/ |
||
| 245 | */ |
||
| 246 | public function iDeleteTheVariantOfProduct(ProductVariantInterface $productVariant) |
||
| 252 | |||
| 253 | /** |
||
| 254 | * @Then I should be notified that this variant is in use and cannot be deleted |
||
| 255 | */ |
||
| 256 | public function iShouldBeNotifiedOfFailure() |
||
| 263 | |||
| 264 | /** |
||
| 265 | * @When /^I want to modify the ("[^"]+" product variant)$/ |
||
| 266 | */ |
||
| 267 | public function iWantToModifyAProduct(ProductVariantInterface $productVariant) |
||
| 271 | |||
| 272 | /** |
||
| 273 | * @Then the code field should be disabled |
||
| 274 | */ |
||
| 275 | public function theCodeFieldShouldBeDisabled() |
||
| 279 | |||
| 280 | /** |
||
| 281 | * @Then I should be notified that :element is required |
||
| 282 | */ |
||
| 283 | public function iShouldBeNotifiedThatIsRequired($element) |
||
| 287 | |||
| 288 | /** |
||
| 289 | * @Then I should be notified that code has to be unique |
||
| 290 | */ |
||
| 291 | public function iShouldBeNotifiedThatCodeHasToBeUnique() |
||
| 295 | |||
| 296 | /** |
||
| 297 | * @Then I should be notified that current stock is required |
||
| 298 | */ |
||
| 299 | public function iShouldBeNotifiedThatOnHandIsRequired() |
||
| 303 | |||
| 304 | /** |
||
| 305 | * @Then I should be notified that height, width, depth and weight cannot be lower than 0 |
||
| 306 | */ |
||
| 307 | public function iShouldBeNotifiedThatIsHeightWidthDepthWeightCannotBeLowerThan() |
||
| 314 | |||
| 315 | /** |
||
| 316 | * @Then I should be notified that price cannot be lower than 0.01 |
||
| 317 | */ |
||
| 318 | public function iShouldBeNotifiedThatPriceCannotBeLowerThen() |
||
| 325 | |||
| 326 | /** |
||
| 327 | * @Then I should be notified that this variant already exists |
||
| 328 | */ |
||
| 329 | public function iShouldBeNotifiedThatThisVariantAlreadyExists() |
||
| 336 | |||
| 337 | /** |
||
| 338 | * @Then /^I should be notified that code is required for the (\d)(?:st|nd|rd|th) variant$/ |
||
| 339 | */ |
||
| 340 | public function iShouldBeNotifiedThatCodeIsRequiredForVariant($position) |
||
| 347 | |||
| 348 | /** |
||
| 349 | * @Then /^I should be notified that prices in all channels must be defined for the (\d)(?:st|nd|rd|th) variant$/ |
||
| 350 | */ |
||
| 351 | public function iShouldBeNotifiedThatPricesInAllChannelsMustBeDefinedForTheVariant($position) |
||
| 358 | |||
| 359 | /** |
||
| 360 | * @Then /^I should be notified that variant code must be unique within this product for the (\d)(?:st|nd|rd|th) variant$/ |
||
| 361 | */ |
||
| 362 | public function iShouldBeNotifiedThatVariantCodeMustBeUniqueWithinThisProductForYheVariant($position) |
||
| 369 | |||
| 370 | /** |
||
| 371 | * @Then I should be notified that prices in all channels must be defined |
||
| 372 | */ |
||
| 373 | public function iShouldBeNotifiedThatPricesInAllChannelsMustBeDefined() |
||
| 380 | |||
| 381 | /** |
||
| 382 | * @When I save my changes |
||
| 383 | * @When I try to save my changes |
||
| 384 | */ |
||
| 385 | public function iSaveMyChanges() |
||
| 389 | |||
| 390 | /** |
||
| 391 | * @Then /^inventory of (this variant) should not be tracked$/ |
||
| 392 | */ |
||
| 393 | public function thisProductVariantShouldNotBeTracked(ProductVariantInterface $productVariant) |
||
| 399 | |||
| 400 | /** |
||
| 401 | * @Then /^inventory of (this variant) should be tracked$/ |
||
| 402 | */ |
||
| 403 | public function thisProductVariantShouldBeTracked(ProductVariantInterface $productVariant) |
||
| 409 | |||
| 410 | /** |
||
| 411 | * @When I generate it |
||
| 412 | * @When I try to generate it |
||
| 413 | */ |
||
| 414 | public function iClickGenerate() |
||
| 415 | { |
||
| 416 | $this->generatePage->generate(); |
||
| 417 | } |
||
| 418 | |||
| 419 | /** |
||
| 420 | * @When /^I specify that the (\d)(?:st|nd|rd|th) variant is identified by "([^"]+)" code and costs "(?:€|£|\$)([^"]+)" in ("[^"]+") channel$/ |
||
| 421 | */ |
||
| 422 | public function iSpecifyThereAreVariantsIdentifiedByCodeWithCost($nthVariant, $code, int $price, $channelName) |
||
| 423 | { |
||
| 424 | $this->generatePage->specifyCode($nthVariant - 1, $code); |
||
| 425 | $this->generatePage->specifyPrice($nthVariant - 1, $price, $channelName); |
||
| 426 | } |
||
| 427 | |||
| 428 | /** |
||
| 429 | * @When /^I specify that the (\d)(?:st|nd|rd|th) variant is identified by "([^"]+)" code$/ |
||
| 430 | */ |
||
| 431 | public function iSpecifyThereAreVariantsIdentifiedByCode($nthVariant, $code) |
||
| 432 | { |
||
| 433 | $this->generatePage->specifyCode($nthVariant - 1, $code); |
||
| 434 | } |
||
| 435 | |||
| 436 | /** |
||
| 437 | * @When /^I specify that the (\d)(?:st|nd|rd|th) variant costs "(?:€|£|\$)([^"]+)" in ("[^"]+") channel$/ |
||
| 438 | */ |
||
| 439 | public function iSpecifyThereAreVariantsWithCost($nthVariant, int $price, $channelName) |
||
| 440 | { |
||
| 441 | $this->generatePage->specifyPrice($nthVariant - 1, $price, $channelName); |
||
| 442 | } |
||
| 443 | |||
| 444 | /** |
||
| 445 | * @When /^I remove (\d)(?:st|nd|rd|th) variant from the list$/ |
||
| 446 | */ |
||
| 447 | public function iRemoveVariantFromTheList($nthVariant) |
||
| 448 | { |
||
| 449 | $this->generatePage->removeVariant($nthVariant - 1); |
||
| 450 | } |
||
| 451 | |||
| 452 | /** |
||
| 453 | * @Then I should be notified that it has been successfully generated |
||
| 454 | */ |
||
| 455 | public function iShouldBeNotifiedThatItHasBeenSuccessfullyGenerated() |
||
| 456 | { |
||
| 457 | $this->notificationChecker->checkNotification('Success Product variants have been successfully generated.', NotificationType::success()); |
||
| 458 | } |
||
| 459 | |||
| 460 | /** |
||
| 461 | * @Then I should not be able to generate any variants |
||
| 462 | */ |
||
| 463 | public function iShouldNotBeAbleToGenerateAnyVariants(): void |
||
| 464 | { |
||
| 465 | Assert::false($this->generatePage->isGenerationPossible()); |
||
| 466 | } |
||
| 467 | |||
| 468 | /** |
||
| 469 | * @When I set its shipping category as :shippingCategoryName |
||
| 470 | */ |
||
| 471 | public function iSetItsShippingCategoryAs($shippingCategoryName) |
||
| 475 | |||
| 476 | /** |
||
| 477 | * @When I do not specify any information about variants |
||
| 478 | */ |
||
| 479 | public function iDoNotSpecifyAnyInformationAboutVariants() |
||
| 483 | |||
| 484 | /** |
||
| 485 | * @When I change its quantity of inventory to :amount |
||
| 486 | */ |
||
| 487 | public function iChangeItsQuantityOfInventoryTo(int $amount) |
||
| 491 | |||
| 492 | /** |
||
| 493 | * @Then /^the (variant with code "[^"]+") should not have shipping required$/ |
||
| 494 | */ |
||
| 495 | public function theVariantWithCodeShouldNotHaveShippingRequired(ProductVariantInterface $productVariant) |
||
| 501 | |||
| 502 | /** |
||
| 503 | * @Then I should be notified that on hand quantity must be greater than the number of on hold units |
||
| 504 | */ |
||
| 505 | public function iShouldBeNotifiedThatOnHandQuantityMustBeGreaterThanTheNumberOfOnHoldUnits() |
||
| 512 | |||
| 513 | /** |
||
| 514 | * @Then I should be notified that variants cannot be generated from options without any values |
||
| 515 | */ |
||
| 516 | public function iShouldBeNotifiedThatVariantsCannotBeGeneratedFromOptionsWithoutAnyValues(): void |
||
| 517 | { |
||
| 518 | $this->notificationChecker->checkNotification('Cannot generate variants for a product without options values', NotificationType::failure()); |
||
| 519 | } |
||
| 520 | |||
| 521 | /** |
||
| 522 | * @When /^I want to generate new variants for (this product)$/ |
||
| 523 | * @When /^I try to generate new variants for (this product)$/ |
||
| 524 | */ |
||
| 525 | public function iTryToGenerateNewVariantsForThisProduct(ProductInterface $product): void |
||
| 529 | |||
| 530 | /** |
||
| 531 | * @param string $element |
||
| 532 | * @param string $message |
||
| 533 | */ |
||
| 534 | private function assertValidationMessage($element, $message) |
||
| 541 | } |
||
| 542 |
It seems like the method you are trying to call exists only in some of the possible types.
Let’s take a look at an example:
Available Fixes
Add an additional type-check:
Only allow a single type to be passed if the variable comes from a parameter: