RequestConfigurationFactory::create() - Code Metrics - Inspection of "Skip modifying virtual proxies properties in TestA..." - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — typehint/addressing ( 01567d...0d3293 )

by Kamil

created 2017-07-31 06:08 UTC

RequestConfigurationFactory::create() A

↳ Parent: RequestConfigurationFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
nc	1
cc	1
eloc	4
nop	2

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Sylius\Bundle\ResourceBundle\Controller;

use Sylius\Component\Resource\Metadata\MetadataInterface;
use Symfony\Component\HttpFoundation\Request;

/**
 * @author Paweł Jędrzejewski <[email protected]>
 */
final class RequestConfigurationFactory implements RequestConfigurationFactoryInterface
{
    const API_VERSION_HEADER = 'Accept';
    const API_GROUPS_HEADER = 'Accept';

    const API_VERSION_REGEXP = '/(v|version)=(?P<version>[0-9\.]+)/i';
    const API_GROUPS_REGEXP = '/(g|groups)=(?P<groups>[a-z,_\s]+)/i';

    /**
     * @var ParametersParserInterface
     */
    private $parametersParser;

    /**
     * @var string
     */
    private $configurationClass;

    /**
     * @var array
     */
    private $defaultParameters;

    /**
     * @param ParametersParserInterface $parametersParser
     * @param string $configurationClass
     * @param array $defaultParameters
     */
    public function __construct(ParametersParserInterface $parametersParser, $configurationClass, array $defaultParameters = [])
    {
        $this->parametersParser = $parametersParser;
        $this->configurationClass = $configurationClass;
        $this->defaultParameters = $defaultParameters;
    }

    /**
     * {@inheritdoc}
     */
    public function create(MetadataInterface $metadata, Request $request)
    {
        $parameters = array_merge($this->defaultParameters, $this->parseApiParameters($request));
        $parameters = $this->parametersParser->parseRequestValues($parameters, $request);

        return new $this->configurationClass($metadata, $request, new Parameters($parameters));
    }

    /**
     * @param Request $request
     *
     * @return array
     *
     * @throws \InvalidArgumentException
     */
    private function parseApiParameters(Request $request)
    {
        $parameters = [];

        $apiVersionHeaders = $request->headers->get(self::API_VERSION_HEADER, null, false);
        foreach ($apiVersionHeaders as $apiVersionHeader) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (preg_match(self::API_VERSION_REGEXP, $apiVersionHeader, $matches)) {
                $parameters['serialization_version'] = $matches['version'];
            }
        }

        $apiGroupsHeaders = $request->headers->get(self::API_GROUPS_HEADER, null, false);
        foreach ($apiGroupsHeaders as $apiGroupsHeader) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (preg_match(self::API_GROUPS_REGEXP, $apiGroupsHeader, $matches)) {
                $parameters['serialization_groups'] = array_map('trim', explode(',', $matches['groups']));
            }
        }

        return array_merge($request->attributes->get('_sylius', []), $parameters);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sylius package.
5			*
6			* (c) Paweł Jędrzejewski
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Sylius\Bundle\ResourceBundle\Controller;
15
16			use Sylius\Component\Resource\Metadata\MetadataInterface;
17			use Symfony\Component\HttpFoundation\Request;
18
19			/**
20			* @author Paweł Jędrzejewski <[email protected]>
21			*/
22			final class RequestConfigurationFactory implements RequestConfigurationFactoryInterface
23			{
24			const API_VERSION_HEADER = 'Accept';
25			const API_GROUPS_HEADER = 'Accept';
26
27			const API_VERSION_REGEXP = '/(v\|version)=(?P<version>[0-9\.]+)/i';
28			const API_GROUPS_REGEXP = '/(g\|groups)=(?P<groups>[a-z,_\s]+)/i';
29
30			/**
31			* @var ParametersParserInterface
32			*/
33			private $parametersParser;
34
35			/**
36			* @var string
37			*/
38			private $configurationClass;
39
40			/**
41			* @var array
42			*/
43			private $defaultParameters;
44
45			/**
46			* @param ParametersParserInterface $parametersParser
47			* @param string $configurationClass
48			* @param array $defaultParameters
49			*/
50			public function __construct(ParametersParserInterface $parametersParser, $configurationClass, array $defaultParameters = [])
51			{
52			$this->parametersParser = $parametersParser;
53			$this->configurationClass = $configurationClass;
54			$this->defaultParameters = $defaultParameters;
55			}
56
57			/**
58			* {@inheritdoc}
59			*/
60			public function create(MetadataInterface $metadata, Request $request)
61			{
62			$parameters = array_merge($this->defaultParameters, $this->parseApiParameters($request));
63			$parameters = $this->parametersParser->parseRequestValues($parameters, $request);
64
65			return new $this->configurationClass($metadata, $request, new Parameters($parameters));
66			}
67
68			/**
69			* @param Request $request
70			*
71			* @return array
72			*
73			* @throws \InvalidArgumentException
74			*/
75			private function parseApiParameters(Request $request)
76			{
77			$parameters = [];
78
79			$apiVersionHeaders = $request->headers->get(self::API_VERSION_HEADER, null, false);
80			foreach ($apiVersionHeaders as $apiVersionHeader) {
			0 ignored issues – show Bug introduced 2017-07-26 15:13 UTC by Report Bug Copy Issue Report The expression `$apiVersionHeaders` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
81			if (preg_match(self::API_VERSION_REGEXP, $apiVersionHeader, $matches)) {
82			$parameters['serialization_version'] = $matches['version'];
83			}
84			}
85
86			$apiGroupsHeaders = $request->headers->get(self::API_GROUPS_HEADER, null, false);
87			foreach ($apiGroupsHeaders as $apiGroupsHeader) {
			0 ignored issues – show Bug introduced 2017-07-26 15:13 UTC by Report Bug Copy Issue Report The expression `$apiGroupsHeaders` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
88			if (preg_match(self::API_GROUPS_REGEXP, $apiGroupsHeader, $matches)) {
89			$parameters['serialization_groups'] = array_map('trim', explode(',', $matches['groups']));
90			}
91			}
92
93			return array_merge($request->attributes->get('_sylius', []), $parameters);
94			}
95			}
96

pamil / Sylius

Push — typehint/addressing ( 01567d...0d3293 )

RequestConfigurationFactory::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like