Palmtree\Curl\Curl

Complexity

Total Complexity

17

Size/Duplication

Total Lines	121
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	7
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getCurlOpts()	0	3	1
A	execute()	0	26	5
A	getRequest()	0	3	1
A	getResponse()	0	7	2
A	getUrl()	0	3	1
A	getContents()	0	5	1
A	__construct()	0	7	1
A	post()	0	5	1
A	__toString()	0	6	2
A	postJson()	0	10	2

<?php

namespace Palmtree\Curl;

use Palmtree\Curl\Exception\BadMethodCallException;
use Palmtree\Curl\Exception\CurlErrorException;

class Curl
{
    /** @var string */
    private $url;
    /** @var resource */
    private $handle;
    /** @var Request */
    private $request;
    /** @var Response */
    private $response;
    /** @var CurlOpts */
    private $curlOpts = [];

    public function __construct(string $url, array $curlOpts = [])
    {
        $this->url     = $url;
        $this->handle  = \curl_init($url);

It seems like curl_init($url) can also be of type false. However, the property $handle is declared as type resource. Maybe add an additional type check?

        $this->request = new Request();

        $this->curlOpts = new CurlOpts($curlOpts);
    }

    /** @throws CurlErrorException */
    public static function getContents(string $url, array $curlOpts = []): string
    {
        $curl = new self($url, $curlOpts);

        return $curl->getResponse()->getBody();
    }

    /**
     * @param string|array $data
     *
     * @throws CurlErrorException
     */
    public function post($data): Response
    {
        $this->getRequest()->setBody($data);

        return $this->execute();
    }

    /**
     * @param string|mixed $json
     *
     * @throws CurlErrorException
     */
    public function postJson($json): Response
    {
        if (!\is_string($json)) {
            $json = \json_encode($json);
        }

        $this->getRequest()->addHeader('Content-Type', 'application/json');
        $this->getRequest()->addHeader('Content-Length', \strlen($json));

        return $this->post($json);
    }

    /** @throws CurlErrorException */
    public function execute(): Response
    {
        if ($this->response !== null) {
            throw new BadMethodCallException('Request already executed');
        }

        \curl_setopt_array($this->handle, $this->curlOpts->toArray());

        if ($headers = $this->getRequest()->getHeaderStrings()) {
            \curl_setopt($this->handle, CURLOPT_HTTPHEADER, $headers);
        }

        if ($body = $this->getRequest()->getBody()) {
            \curl_setopt($this->handle, CURLOPT_POST, true);
            \curl_setopt($this->handle, CURLOPT_POSTFIELDS, $body);
        }

        $response = \curl_exec($this->handle);

        if ($errorNumber = \curl_errno($this->handle)) {
            throw new CurlErrorException(\curl_error($this->handle), $errorNumber);
        }

        $this->response = new Response($response, \curl_getinfo($this->handle, CURLINFO_HTTP_CODE));

It seems like $response can also be of type boolean; however, parameter $response of Palmtree\Curl\Response::__construct() does only seem to accept string, maybe add an additional type check?

        return $this->response;
    }

    public function getRequest(): Request
    {
        return $this->request;
    }

    /**
     * @throws CurlErrorException
     */
    public function getResponse(): Response
    {
        if ($this->response === null) {
            $this->execute();
        }

        return $this->response;
    }

    public function getUrl(): string
    {
        return $this->url;
    }

    public function getCurlOpts(): CurlOpts
    {
        return $this->curlOpts;
    }

    public function __toString(): string
    {
        try {
            return $this->getResponse()->getBody();
        } catch (CurlErrorException $e) {
            return '';
        }
    }
}