Palmtree\CanonicalUrlBundle\Twig\Extension\CanonicalLinkExtension

Complexity

Total Complexity

5

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

88.24%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getFunctions()	0	10	1
A	renderLinkTag()	0	8	1
A	generateUrl()	0	10	2

<?php

namespace Palmtree\CanonicalUrlBundle\Twig\Extension;

use Palmtree\CanonicalUrlBundle\Service\CanonicalUrlGenerator;
use Symfony\Component\HttpFoundation\RequestStack;

class CanonicalLinkExtension extends \Twig_Extension
{
    /** @var CanonicalUrlGenerator */
    protected $canonicalUrlGenerator;
    /** @var RequestStack */
    protected $requestStack;

    /**
     * CanonicalLinkExtension constructor.
     * @param CanonicalUrlGenerator $canonicalUrlGenerator
     * @param RequestStack          $requestStack
     */
    public function __construct(CanonicalUrlGenerator $canonicalUrlGenerator, RequestStack $requestStack)
    {
        $this->canonicalUrlGenerator = $canonicalUrlGenerator;
        $this->requestStack          = $requestStack;
    }

    /**
     * @return array
     */
    public function getFunctions()
    {
        return [
            new \Twig_Function('palmtree_canonical_url', [$this, 'generateUrl']),
            new \Twig_Function('palmtree_canonical_link_tag', [$this, 'renderLinkTag'], [
                'needs_environment' => true,
                'is_safe'           => ['html'],
            ]),
        ];
    }

    /**
     * @param \Twig_Environment $environment
     * @param string            $href
     *
     * @return string
     */
    public function renderLinkTag(\Twig_Environment $environment, $href = null)
    {
        $output = $environment->render('@PalmtreeCanonicalUrl/canonical_link_tag.html.twig', [
            'href' => $href,
        ]);

        return $output;
    }

    /**
     * @param string       $route
     * @param string|array $parameters
     *
     * @return string
     */
    public function generateUrl($route = null, $parameters = null)
    {
        if (!$route) {

The expression $route of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            $request = $this->requestStack->getCurrentRequest();

            $route = $request->attributes->get('_route');
        }

        return $this->canonicalUrlGenerator->generateUrl($route, $parameters);

It seems like $parameters defined by parameter $parameters on line 61 can also be of type null; however, Palmtree\CanonicalUrlBundle\Service\CanonicalUrlGenerator::generateUrl() does only seem to accept array|string, maybe add an additional type check?

    }
}