Palmtree\CanonicalUrlBundle\Service\CanonicalUrlGenerator

Complexity

Total Complexity

7

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

80%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	generateUrl()	0	18	3
A	getParameters()	0	12	3

<?php

namespace Palmtree\CanonicalUrlBundle\Service;

use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Routing\RouterInterface;

class CanonicalUrlGenerator
{
    /** @var RouterInterface */
    protected $router;
    /** @var string */
    protected $siteUrl;
    /** @var bool */
    protected $trailingSlash;

    /**
     * CanonicalUrlService constructor.
     * @param RouterInterface $router
     * @param array           $config
     */
    public function __construct(RouterInterface $router, array $config = [])
    {
        $this->router = $router;

        $this->siteUrl       = $config['site_url'];
        $this->trailingSlash = $config['trailing_slash'];
    }

    /**
     * Returns the canonical URL for a route.
     *
     * @param string       $route
     * @param array|string $parameters
     *
     * @return string
     */
    public function generateUrl($route, $parameters = [])
    {
        if (!$route) {
            return '';
        }

        $parameters = $this->getParameters($parameters);

It seems like $parameters defined by $this->getParameters($parameters) on line 44 can also be of type string; however, Palmtree\CanonicalUrlBundle\Service\CanonicalUrlGenerator::getParameters() does only seem to accept array, maybe add an additional type check?

        try {
            $uri = $this->router->generate($route, $parameters, UrlGeneratorInterface::ABSOLUTE_PATH);
        } catch (\Exception $exception) {
            return '';
        }

        $url = rtrim($this->siteUrl, '/') . '/' . ltrim($uri, '/');

        return $url;
    }

    /**
     * @param array $parameters
     * @return array|string
     */
    protected function getParameters($parameters = [])
    {
        if (is_string($parameters)) {
            parse_str($parameters, $parameters);
        }

        if (!$parameters) {
            $parameters = [];
        }

        return $parameters;
    }
}