StaticEnum::findParentClassForConst() - Code Metrics - Inspection of "Create static enum to represent singleton-based en..." - paillechat/php-enum - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Pavel

created 2018-01-26 08:19 UTC

StaticEnum::findParentClassForConst() A

↳ Parent: StaticEnum

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Paillechat\Enum;

abstract class StaticEnum extends Enum
{
    /** @var StaticEnum[][] */
    private static $instances = [];

    private static $constReflections = [];

    final protected static function createNamedInstance(string $name, $value)
    {
        $class = self::findParentClassForConst($name);

        $key = self::getConstKey($class, $name);

        if (!array_key_exists($key, self::$instances)) {
            self::$instances[$key] = parent::createNamedInstance($name, $value);
        }

        return self::$instances[$key];

    }

    private static function getConstantReflection(string $class, string $name): \ReflectionClassConstant
    {
        $key = self::getConstKey($class, $name);
        if (!array_key_exists($key, self::$constReflections)) {
            $refl = self::getEnumReflection(static::class);

            self::$constReflections[$key] = $refl->getReflectionConstant($name);
        }

        return self::$constReflections[$key];
    }

    private static function getConstKey(string $class, string $name): string
    {
        return $class.'::'.$name;
    }

    private static function findParentClassForConst(string $name): string
    {
        return self::getConstantReflection(static::class, $name)->getDeclaringClass()->getName();
    }
}


1		<?php
2
3		namespace Paillechat\Enum;
4
5		abstract class StaticEnum extends Enum
6		{
7		/** @var StaticEnum[][] */
8		private static $instances = [];
9
10		private static $constReflections = [];
11
12	4	final protected static function createNamedInstance(string $name, $value)
13		{
14	4	$class = self::findParentClassForConst($name);
15
16	4	$key = self::getConstKey($class, $name);
17
18	4	if (!array_key_exists($key, self::$instances)) {
19	3	self::$instances[$key] = parent::createNamedInstance($name, $value);
20		}
21
22	4	return self::$instances[$key];
		0 ignored issues – show Bug Compatibility introduced 2018-01-26 08:23 UTC by Report Bug Copy Issue Report The expression `self::$instances[$key];` of type `Paillechat\Enum\StaticEn...llechat\Enum\StaticEnum` adds the type `Paillechat\Enum\StaticEnum[]` to the return on line 22 which is incompatible with the return type of the parent method `Paillechat\Enum\Enum::createNamedInstance` of type `Paillechat\Enum\Enum`. Loading history...
23		}
24
25	4	private static function getConstantReflection(string $class, string $name): \ReflectionClassConstant
26		{
27	4	$key = self::getConstKey($class, $name);
28	4	if (!array_key_exists($key, self::$constReflections)) {
29	4	$refl = self::getEnumReflection(static::class);
30
31	4	self::$constReflections[$key] = $refl->getReflectionConstant($name);
32		}
33
34	4	return self::$constReflections[$key];
35		}
36
37	4	private static function getConstKey(string $class, string $name): string
38		{
39	4	return $class.'::'.$name;
40		}
41
42	4	private static function findParentClassForConst(string $name): string
43		{
44	4	return self::getConstantReflection(static::class, $name)->getDeclaringClass()->getName();
45		}
46		}
47

paillechat / php-enum

Pull Request — master (#4)

StaticEnum::findParentClassForConst() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like