Issues in Server.php (develop) - Issues in develop - pageon/stitcher-core - Measure and Improve Code Quality continuously with Scrutinizer

Issues (29)

Security Analysis 1 potential vulnerability

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting (1)

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Stitcher/Application/Server.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Stitcher\Application;

use GuzzleHttp\Psr7\Request;
use GuzzleHttp\Psr7\Response;
use GuzzleHttp\Psr7\ServerRequest;
use Pageon\Http\HeaderContainer;
use Stitcher\Exception\ErrorHandler;
use Stitcher\Exception\Http;
use Stitcher\Exception\StitcherException;

abstract class Server
{
    /** @var Router */
    protected $router;

    /** @var Request */
    protected $request;

    /** @var HeaderContainer */
    protected $headerContainer;

    /** @var \Stitcher\Exception\ErrorHandler */
    protected $errorHandler;

    abstract protected function handleStaticRoute(): ?Response;

    public function setRouter(Router $router): Server
    {
        $this->router = $router;

        return $this;
    }

    public function setHeaderContainer(HeaderContainer $headerContainer): Server
    {
        $this->headerContainer = $headerContainer;

        return $this;
    }

    public function setErrorHandler(ErrorHandler $errorHandler): Server
    {
        $this->errorHandler = $errorHandler;

        return $this;
    }

    public function run(): string
    {
        $response = $this->createResponse();

        return $this->handleResponse($response);
    }

    protected function getRequest(): Request
    {
        if (! $this->request) {
            $this->request = ServerRequest::fromGlobals();

        }

        return $this->request;
    }

    protected function getCurrentPath(): string
    {
        $path = $this->getRequest()->getUri()->getPath();

        return $path === '' ? '/' : $path;
    }

    protected function handleDynamicRoute(): ?Response
    {
        if (! $this->router) {
            return null;
        }

        return $this->router->dispatch($this->getRequest());
    }

    protected function createResponse(): Response
    {
        if (
            $this->router
            && $redirectTo = $this->router->getRedirectForUrl($this->getCurrentPath())
        ) {
            return $this->createRedirectResponse($redirectTo);
        }

        try {
            $response = $this->handleStaticRoute();

            if (! $response) {
                $response = $this->handleDynamicRoute();
            }
        } catch (StitcherException $e) {
            $response = $this->createErrorResponse($e);
        }

        return $response ?? $this->createErrorResponse(
                Http::notFound(
                    $this->getCurrentPath()
                )
            );
    }

    protected function createRedirectResponse(string $targetUrl): Response
    {
        return new Response(301, ['Location' => $targetUrl]);
    }

    protected function createErrorResponse(StitcherException $exception): Response
    {
        $statusCode = $exception instanceof Http ? $exception->statusCode() : 500;

        $responseBody = $this->errorHandler->handle($statusCode, $exception);

        return new Response($statusCode, [], $responseBody);
    }

    protected function handleResponse(Response $response): string
    {
        foreach ($response->getHeaders() as $name => $headers) {
            header($name . ':'. implode(', ', $headers));
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
        }

        if ($this->headerContainer) {
            foreach ($this->headerContainer as $header) {
                header((string) $header);
            }
        }

        http_response_code($response->getStatusCode());

        return $response->getBody()->getContents();
    }
}


1			<?php
2
3			namespace Stitcher\Application;
4
5			use GuzzleHttp\Psr7\Request;
6			use GuzzleHttp\Psr7\Response;
7			use GuzzleHttp\Psr7\ServerRequest;
8			use Pageon\Http\HeaderContainer;
9			use Stitcher\Exception\ErrorHandler;
10			use Stitcher\Exception\Http;
11			use Stitcher\Exception\StitcherException;
12
13			abstract class Server
14			{
15			/** @var Router */
16			protected $router;
17
18			/** @var Request */
19			protected $request;
20
21			/** @var HeaderContainer */
22			protected $headerContainer;
23
24			/** @var \Stitcher\Exception\ErrorHandler */
25			protected $errorHandler;
26
27			abstract protected function handleStaticRoute(): ?Response;
28
29			public function setRouter(Router $router): Server
30			{
31			$this->router = $router;
32
33			return $this;
34			}
35
36			public function setHeaderContainer(HeaderContainer $headerContainer): Server
37			{
38			$this->headerContainer = $headerContainer;
39
40			return $this;
41			}
42
43			public function setErrorHandler(ErrorHandler $errorHandler): Server
44			{
45			$this->errorHandler = $errorHandler;
46
47			return $this;
48			}
49
50			public function run(): string
51			{
52			$response = $this->createResponse();
53
54			return $this->handleResponse($response);
55			}
56
57			protected function getRequest(): Request
58			{
59			if (! $this->request) {
60			$this->request = ServerRequest::fromGlobals();
			0 ignored issues – show Documentation Bug introduced 2018-01-19 14:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\GuzzleHttp\Psr7\ServerRequest::fromGlobals()` of type `object<Psr\Http\Message\ServerRequestInterface>` is incompatible with the declared type `object<GuzzleHttp\Psr7\Request>` of property `$request`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
61			}
62
63			return $this->request;
64			}
65
66			protected function getCurrentPath(): string
67			{
68			$path = $this->getRequest()->getUri()->getPath();
69
70			return $path === '' ? '/' : $path;
71			}
72
73			protected function handleDynamicRoute(): ?Response
74			{
75			if (! $this->router) {
76			return null;
77			}
78
79			return $this->router->dispatch($this->getRequest());
80			}
81
82			protected function createResponse(): Response
83			{
84			if (
85			$this->router
86			&& $redirectTo = $this->router->getRedirectForUrl($this->getCurrentPath())
87			) {
88			return $this->createRedirectResponse($redirectTo);
89			}
90
91			try {
92			$response = $this->handleStaticRoute();
93
94			if (! $response) {
95			$response = $this->handleDynamicRoute();
96			}
97			} catch (StitcherException $e) {
98			$response = $this->createErrorResponse($e);
99			}
100
101			return $response ?? $this->createErrorResponse(
102			Http::notFound(
103			$this->getCurrentPath()
104			)
105			);
106			}
107
108			protected function createRedirectResponse(string $targetUrl): Response
109			{
110			return new Response(301, ['Location' => $targetUrl]);
111			}
112
113			protected function createErrorResponse(StitcherException $exception): Response
114			{
115			$statusCode = $exception instanceof Http ? $exception->statusCode() : 500;
116
117			$responseBody = $this->errorHandler->handle($statusCode, $exception);
118
119			return new Response($statusCode, [], $responseBody);
120			}
121
122			protected function handleResponse(Response $response): string
123			{
124			foreach ($response->getHeaders() as $name => $headers) {
125			header($name . ':'. implode(', ', $headers));
			0 ignored issues – show Security Response Splitting introduced 2019-01-11 09:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$name . ':' . implode(', ', $headers)` can contain request data and is used in response header context(s) leading to a potential security vulnerability. 4 paths for user data to reach this point 1. Path: Read from `$_SERVER,` and `$value` is assigned in src/getallheaders.php on line 20 Read from `$_SERVER,` and `$value` is assigned in vendor/src/getallheaders.php on line 20 `$headers` is assigned in vendor/src/getallheaders.php on line 25 getallheaders() returns tainted data, and `$headers` is assigned in vendor/src/ServerRequest.php on line 169 `$headers` is passed to ServerRequest::__construct() in vendor/src/ServerRequest.php on line 174 `$headers` is passed to Request::__construct() in vendor/src/ServerRequest.php on line 75 `$headers` is passed to MessageTrait::setHeaders() in vendor/src/Request.php on line 45 `$value` is assigned in vendor/src/MessageTrait.php on line 146 Data is passed through array_map() in vendor/src/MessageTrait.php on line 181 `$value` is assigned in vendor/src/MessageTrait.php on line 151 `$value` is passed through array_merge(), and MessageTrait::$headers is assigned in vendor/src/MessageTrait.php on line 155 Tainted property MessageTrait::$headers is read in vendor/src/MessageTrait.php on line 41 MessageTrait::getHeaders() returns tainted data, and `$name` is assigned in src/Stitcher/Application/Server.php on line 124 2. Path: Fetching key `PHP_AUTH_USER` from `$_SERVER,` and `$_SERVER['PHP_AUTH_USER'] . ':' . $basic_pass` is escaped by base64_encode() for all (base64-encoded) context(s), and `$headers` is assigned in src/getallheaders.php on line 37 Fetching key `PHP_AUTH_USER` from `$_SERVER,` and `$_SERVER['PHP_AUTH_USER'] . ':' . $basic_pass` is escaped by base64_encode() for all (base64-encoded) context(s), and `$headers` is assigned in vendor/src/getallheaders.php on line 37 getallheaders() returns tainted data, and `$headers` is assigned in vendor/src/ServerRequest.php on line 169 `$headers` is passed to ServerRequest::__construct() in vendor/src/ServerRequest.php on line 174 `$headers` is passed to Request::__construct() in vendor/src/ServerRequest.php on line 75 `$headers` is passed to MessageTrait::setHeaders() in vendor/src/Request.php on line 45 `$value` is assigned in vendor/src/MessageTrait.php on line 146 Data is passed through array_map() in vendor/src/MessageTrait.php on line 181 `$value` is assigned in vendor/src/MessageTrait.php on line 151 `$value` is passed through array_merge(), and MessageTrait::$headers is assigned in vendor/src/MessageTrait.php on line 155 Tainted property MessageTrait::$headers is read in vendor/src/MessageTrait.php on line 41 MessageTrait::getHeaders() returns tainted data, and `$name` is assigned in src/Stitcher/Application/Server.php on line 124 3. Path: Fetching key `PHP_AUTH_PW` from `$_SERVER,` and `$basic_pass` is assigned in src/getallheaders.php on line 36 Fetching key `PHP_AUTH_PW` from `$_SERVER,` and `$basic_pass` is assigned in vendor/src/getallheaders.php on line 36 `$_SERVER['PHP_AUTH_USER'] . ':' . $basic_pass` is escaped by base64_encode() for all (base64-encoded) context(s), and `$headers` is assigned in vendor/src/getallheaders.php on line 37 getallheaders() returns tainted data, and `$headers` is assigned in vendor/src/ServerRequest.php on line 169 `$headers` is passed to ServerRequest::__construct() in vendor/src/ServerRequest.php on line 174 `$headers` is passed to Request::__construct() in vendor/src/ServerRequest.php on line 75 `$headers` is passed to MessageTrait::setHeaders() in vendor/src/Request.php on line 45 `$value` is assigned in vendor/src/MessageTrait.php on line 146 Data is passed through array_map() in vendor/src/MessageTrait.php on line 181 `$value` is assigned in vendor/src/MessageTrait.php on line 151 `$value` is passed through array_merge(), and MessageTrait::$headers is assigned in vendor/src/MessageTrait.php on line 155 Tainted property MessageTrait::$headers is read in vendor/src/MessageTrait.php on line 41 MessageTrait::getHeaders() returns tainted data, and `$name` is assigned in src/Stitcher/Application/Server.php on line 124 4. Path: Fetching key `PHP_AUTH_DIGEST` from `$_SERVER,` and `$headers` is assigned in src/getallheaders.php on line 39 Fetching key `PHP_AUTH_DIGEST` from `$_SERVER,` and `$headers` is assigned in vendor/src/getallheaders.php on line 39 getallheaders() returns tainted data, and `$headers` is assigned in vendor/src/ServerRequest.php on line 169 `$headers` is passed to ServerRequest::__construct() in vendor/src/ServerRequest.php on line 174 `$headers` is passed to Request::__construct() in vendor/src/ServerRequest.php on line 75 `$headers` is passed to MessageTrait::setHeaders() in vendor/src/Request.php on line 45 `$value` is assigned in vendor/src/MessageTrait.php on line 146 Data is passed through array_map() in vendor/src/MessageTrait.php on line 181 `$value` is assigned in vendor/src/MessageTrait.php on line 151 `$value` is passed through array_merge(), and MessageTrait::$headers is assigned in vendor/src/MessageTrait.php on line 155 Tainted property MessageTrait::$headers is read in vendor/src/MessageTrait.php on line 41 MessageTrait::getHeaders() returns tainted data, and `$name` is assigned in src/Stitcher/Application/Server.php on line 124 Response Splitting Attacks Allowing an attacker to set a response header, opens your application to response splitting attacks; effectively allowing an attacker to send any response, he would like. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
126			}
127
128			if ($this->headerContainer) {
129			foreach ($this->headerContainer as $header) {
130			header((string) $header);
131			}
132			}
133
134			http_response_code($response->getStatusCode());
135
136			return $response->getBody()->getContents();
137			}
138			}
139

pageon / stitcher-core

Issues (29)

Security Analysis 1 potential vulnerability

src/Stitcher/Application/Server.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

4 paths for user data to reach this point

Response Splitting Attacks

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like