Brendt\Stitcher\Site\Http\Htaccess

Complexity

Total Complexity

21

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	2
A	parse()	0	3	1
C	getHeaderBlock()	0	22	7
C	getPageBlock()	0	26	7
A	clearPageBlocks()	0	10	4

<?php

namespace Brendt\Stitcher\Site\Http;

use Brendt\Stitcher\Exception\ConfigurationException;
use Brendt\Stitcher\Site\Page;
use Symfony\Component\Filesystem\Filesystem;
use Tivie\HtaccessParser\Parser;
use Tivie\HtaccessParser\Token\Block;

class Htaccess
{
    /**
     * @var Filesystem
     */
    private $fs;

    /**
     * @var Parser
     */
    private $parser;

    /**
     * @var array
     */
    private $contents;

    /**
     * Htaccess constructor.
     *
     * @param string $path
     *
     * @throws ConfigurationException
     */
    function __construct(string $path) {

It is generally recommended to explicitly declare the visibility for methods.

        $this->fs = new Filesystem();

        if (!$this->fs->exists($path)) {
            $this->fs->dumpFile($path, __DIR__ . '/../../../../.htaccess');
        }

        $this->parser = new Parser(new \SplFileObject($path));
        $this->parser->ignoreWhitelines(false);
        $this->contents = $this->parser->parse();

It seems like $this->parser->parse() can also be of type object<ArrayAccess>. However, the property $contents is declared as type array. Maybe add an additional type check?

    }

    /**
     * Parse the modified .htaccess
     *
     * @return string
     */
    public function parse() : string {
        return (string) $this->contents;
    }

    /**
     * Get or create the headers block
     *
     * @return Block
     */
    public function &getHeaderBlock() : Block {
        $headerBlock = null;

        foreach ($this->contents as $content) {
            if ($content instanceof Block
                && strtolower($content->getName()) === 'ifmodule'
                && count($content->getArguments())
                && $content->getArguments()[0] === 'mod_headers.c'
            ) {
                $headerBlock = $content;

                break;
            }
        }

        if (!$headerBlock) {
            $headerBlock = new Block('ifmodule', 'mod_headers.c');
            $this->contents->append($headerBlock);

The method append cannot be called on $this->contents (of type array).

        }

        return $headerBlock;
    }

    /**
     * Get or create a page block within the headers block
     *
     * @param Page $page
     *
     * @return mixed|null|Block
     */
    public function &getPageBlock(Page $page) {
        $pageBlock = null;
        $headerBlock = $this->getHeaderBlock();
        $pageId = trim($page->getId(), '/');
        $pageName = '"^\/' . $pageId . '.html$"';

        foreach ($headerBlock as $content) {
            if ($content instanceof Block
                && strtolower($content->getName()) === 'filesmatch'
                && count($content->getArguments())
                && $content->getArguments()[0] === $pageName
            ) {
                $pageBlock = $content;

                break;
            }
        }

        if (!$pageBlock) {
            $pageBlock = new Block('filesmatch');
            $pageBlock->addArgument($pageName);
            $headerBlock->addChild($pageBlock);
        }

        return $pageBlock;
    }

    public function clearPageBlocks() {
        $pageBlock = null;

$pageBlock is not used, you could remove the assignment.

        $headerBlock = $this->getHeaderBlock();

        foreach ($headerBlock as $content) {
            if ($content instanceof Block && strtolower($content->getName()) === 'filesmatch') {
                $headerBlock->removeChild($content);
            }
        }
    }
}