Config::get() - Code Metrics - Inspection of "Code cleanup" - pageon/stitcher-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( f39ca2...6ce970 )

by Brent

created 2017-12-03 08:25 UTC

Config::get() A

↳ Parent: Config

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

namespace Pageon;

use Dotenv\Dotenv;
use Dotenv\Exception\InvalidPathException;
use Illuminate\Support\Arr;
use Iterator;
use Stitcher\Exception\InvalidConfiguration;
use Stitcher\File;
use Symfony\Component\Finder\Finder;

class Config
{
    protected static $env;
    protected static $loadedConfigfiguration = [];

    public static function init()
    {
        self::$env = new Dotenv(File::path());

        try {
            self::$env->load();
        } catch (InvalidPathException $e) {
            throw InvalidConfiguration::dotEnvNotFound(File::path());
        }

        $configurationFiles = Finder::create()->files()->in(File::path('config'))->name('*.php')->getIterator();

        $loadedConfiguration = self::load($configurationFiles);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        self::$loadedConfigfiguration = Arr::dot($loadedConfiguration);
    }

    public static function get(string $key)
    {
        return self::$loadedConfigfiguration[$key] ?? null;
    }

    public static function all(): array
    {
        return self::$loadedConfigfiguration;
    }

    protected static function load(Iterator $configurationFiles): array
    {
        $loadedConfiguration = [];

        foreach ($configurationFiles as $configurationFile) {
            $loadedFileConfiguration = require $configurationFile;

            if (!is_array($loadedFileConfiguration)) {
                continue;
            }

            $loadedConfiguration = array_merge($loadedConfiguration, $loadedFileConfiguration);
        }

        return $loadedConfiguration;
    }
}


1		<?php
2
3		namespace Pageon;
4
5		use Dotenv\Dotenv;
6		use Dotenv\Exception\InvalidPathException;
7		use Illuminate\Support\Arr;
8		use Iterator;
9		use Stitcher\Exception\InvalidConfiguration;
10		use Stitcher\File;
11		use Symfony\Component\Finder\Finder;
12
13		class Config
14		{
15		protected static $env;
16		protected static $loadedConfigfiguration = [];
17
18	6	public static function init()
19		{
20	6	self::$env = new Dotenv(File::path());
21
22		try {
23	6	self::$env->load();
24		} catch (InvalidPathException $e) {
25		throw InvalidConfiguration::dotEnvNotFound(File::path());
26		}
27
28	6	$configurationFiles = Finder::create()->files()->in(File::path('config'))->name('*.php')->getIterator();
29
30	6	$loadedConfiguration = self::load($configurationFiles);
		0 ignored issues – show Bug introduced 2017-12-03 08:28 UTC by Report Bug Copy Issue Report It seems like `$configurationFiles` defined by `\Symfony\Component\Finde...'.php')->getIterator()` on line `28` can also be of type `array<integer,object<Sym...nt\Finder\SplFileInfo>>`; however, `Pageon\Config::load()` does only seem to accept `object<Iterator>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
31
32	6	self::$loadedConfigfiguration = Arr::dot($loadedConfiguration);
33	6	}
34
35	4	public static function get(string $key)
36		{
37	4	return self::$loadedConfigfiguration[$key] ?? null;
38		}
39
40	1	public static function all(): array
41		{
42	1	return self::$loadedConfigfiguration;
43		}
44
45	6	protected static function load(Iterator $configurationFiles): array
46		{
47	6	$loadedConfiguration = [];
48
49	6	foreach ($configurationFiles as $configurationFile) {
50	6	$loadedFileConfiguration = require $configurationFile;
51
52	6	if (!is_array($loadedFileConfiguration)) {
53		continue;
54		}
55
56	6	$loadedConfiguration = array_merge($loadedConfiguration, $loadedFileConfiguration);
57		}
58
59	6	return $loadedConfiguration;
60		}
61		}
62

pageon / stitcher-core

Push — develop ( f39ca2...6ce970 )

Config::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like