Issues in pg-product-variation-simulator.js (master) - Issues in master - pagantis/woocommerce - Measure and Improve Code Quality continuously with Scrutinizer

Issues (235)

assets/js/pg-product-variation-simulator.js (5 issues)

Labels

Severity

Minor 5

/* global variationSimulatorData   */

if (typeof variationSimulatorData == 'undefined'){
  throw new Error("variationSimulatorData is undefined");
}

window.lastPrice = '';
function updateSimulator()
{
    if (window.WCSimulatorId !== '')
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
    {
        var updateSelector = variationSimulatorData.variationSelector;
        if (updateSelector === 'default') {
            updateSelector = 'div.woocommerce-variation-price span.price span.woocommerce-Price-amount';
        }

        var productType = variationSimulatorData.productType;

        if (productType !=='variable')
        {
            clearInterval(window.variationInterval);

        }
        else
        {
            var priceDOM = document.querySelector(updateSelector);
            if (priceDOM != null) {

                var newPrice = priceDOM.innerText;
                if (newPrice !== window.lastPrice) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                    window.lastPrice = newPrice;
                    window.pgSDK.simulator.update(window.WCSimulatorId, {itemAmountSelector: updateSelector})
                }

            } else {
                return false;
            }
        }
    }
}
window.variationInterval = setInterval(function () {
    updateSimulator();
}, 5000);

1			/* global variationSimulatorData */
2
3			if (typeof variationSimulatorData == 'undefined'){
4			throw new Error("variationSimulatorData is undefined");
5			}
6
7			window.lastPrice = '';
8			function updateSimulator()
9			{
10			if (window.WCSimulatorId !== '')
			0 ignored issues – show Complexity Best Practice introduced 2020-09-15 20:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no return statement if `window.WCSimulatorId !== ""` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
11			{
12			var updateSelector = variationSimulatorData.variationSelector;
13			if (updateSelector === 'default') {
14			updateSelector = 'div.woocommerce-variation-price span.price span.woocommerce-Price-amount';
15			}
16
17			var productType = variationSimulatorData.productType;
18
19			if (productType !=='variable')
20			{
21			clearInterval(window.variationInterval);
			0 ignored issues – show Best Practice introduced 2020-09-15 20:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
22			}
23			else
24			{
25			var priceDOM = document.querySelector(updateSelector);
26			if (priceDOM != null) {
			0 ignored issues – show Best Practice introduced 2020-09-15 20:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this Comparing `priceDOM` to `null` using the `!=` operator is not safe. Consider using `!==` instead. Loading history...
27			var newPrice = priceDOM.innerText;
28			if (newPrice !== window.lastPrice) {
			0 ignored issues – show Complexity Best Practice introduced 2020-09-15 20:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no return statement if `newPrice !== window.lastPrice` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
29			window.lastPrice = newPrice;
30			window.pgSDK.simulator.update(window.WCSimulatorId, {itemAmountSelector: updateSelector})
31			}
			0 ignored issues – show Best Practice introduced 2020-09-15 20:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
32			} else {
33			return false;
34			}
35			}
36			}
37			}
38			window.variationInterval = setInterval(function () {
39			updateSimulator();
40			}, 5000);

pagantis / woocommerce

Issues (235)

assets/js/pg-product-variation-simulator.js (5 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like