WcPaylater::updateExtraConfig()

Complexity

Conditions	10
Paths	16

Size

Total Lines	50
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

<?php
    public function updateExtraConfig($data)
    {
        global $wpdb;
        $tableName = $wpdb->prefix.self::CONFIG_TABLE;
        $response = array('status'=>null);

        $filters   = ($data->get_params());
        $secretKey = $filters['secret'];
        $cfg  = get_option('woocommerce_paylater_settings');

The function get_option was not found. Maybe you did not declare it correctly or list all dependencies?

        $privateKey = isset($cfg['pmt_private_key']) ? $cfg['pmt_private_key'] : null;
        if ($privateKey != $secretKey) {
            $response['status'] = 401;
            $response['result'] = 'Unauthorized';
        } elseif ($_SERVER['REQUEST_METHOD'] == 'POST') {
            if (count($_POST)) {
                foreach ($_POST as $config => $value) {
                    if (isset($this->defaultConfigs[$config]) && $response['status']==null) {
                        $result = $wpdb->update(

The assignment to $result is dead and can be removed.

                            $tableName,
                            array('value' => $value),
                            array('config' => $config),
                            array('%s'),
                            array('%s')
                        );
                    } else {
                        $response['status'] = 400;
                        $response['result'] = 'Bad request';
                    }
                }
            } else {
                $response['status'] = 422;
                $response['result'] = 'Empty data';
            }
        }

        if ($response['status']==null) {
            $tableName = $wpdb->prefix.self::CONFIG_TABLE;
            $dbResult = $wpdb->get_results("select config, value from $tableName", ARRAY_A);

The constant ARRAY_A was not found. Maybe you did not declare it correctly or list all dependencies?

            foreach ($dbResult as $value) {
                $formattedResult[$value['config']] = $value['value'];
            }
            $response['result'] = $formattedResult;

The variable $formattedResult seems to be defined by a foreach iteration on line 294. Are you sure the iterator is never empty, otherwise this variable is not defined?

        }

        $result = json_encode($response['result']);
        header("HTTP/1.1 ".$response['status'], true, $response['status']);
        header('Content-Type: application/json', true);
        header('Content-Length: '.strlen($result));
        echo($result);
        exit();

Using exit here is not recommended.

    }