Httpful\Handlers\CsvHandler

Complexity

Total Complexity

7

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	serialize()	0	14	3
A	parse()	0	14	4

<?php
/**
 * Mime Type: text/csv
 * @author Raja Kapur <rajak@twistedthrottle.com>
 */

namespace Httpful\Handlers;

class CsvHandler extends MimeHandlerAdapter
{
    /**
     * @param string $body
     * @return mixed
     * @throws \Exception
     */
    public function parse($body)
    {
        if (empty($body))
            return null;

        $parsed = array();
        $fp = fopen('data://text/plain;base64,' . base64_encode($body), 'r');
        while (($r = fgetcsv($fp)) !== FALSE) {

It seems like $fp can also be of type false; however, parameter $handle of fgetcsv() does only seem to accept resource, maybe add an additional type check?

            $parsed[] = $r;
        }

        if (empty($parsed))
            throw new \Exception("Unable to parse response as CSV");
        return $parsed;
    }

    /**
     * @param mixed $payload
     * @return string
     */
    public function serialize($payload)
    {
        $fp = fopen('php://temp/maxmemory:'. (6*1024*1024), 'r+');
        $i = 0;
        foreach ($payload as $fields) {
            if($i++ == 0) {
                fputcsv($fp, array_keys($fields));

It seems like $fp can also be of type false; however, parameter $handle of fputcsv() does only seem to accept resource, maybe add an additional type check?

            }
            fputcsv($fp, $fields);
        }
        rewind($fp);

It seems like $fp can also be of type false; however, parameter $handle of rewind() does only seem to accept resource, maybe add an additional type check?

        $data = stream_get_contents($fp);

It seems like $fp can also be of type false; however, parameter $handle of stream_get_contents() does only seem to accept resource, maybe add an additional type check?

        fclose($fp);

It seems like $fp can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        return $data;
    }
}