PagantisLogModuleFrontController::postProcess() - Code Metrics - Inspection of "Merge pull request #67 from pagantis/INT-915" - pagantis/prestashop - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ebe6e6...69cc20 )

by Raúl

created 2020-02-17 13:58 UTC

PagantisLogModuleFrontController::postProcess() B

↳ Parent: PagantisLogModuleFrontController

Complexity

Conditions	9
Paths	9

Size

Total Lines	26
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	18
nc	9
nop	0
dl	0
loc	26
rs	8.0555
c	0
b	0
f	0

<?php
/**
 * This file is part of the official Pagantis module for PrestaShop.
 *
 * @author    Pagantis <[email protected]>
 * @copyright 2019 Pagantis
 * @license   proprietary
 */

/**
 * Class PagantisLogModuleFrontController
 */
class PagantisLogModuleFrontController extends ModuleFrontController
filter:
    dependency_paths: ["lib/*"]
{
    /**
     * @var string $message
     */
    protected $message;

    /**
     * @var bool $error
     */
    protected $error = false;

    /**
     * Controller index method:
     */
    public function postProcess()
    {
        if (!$this->authorize()) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
            return;
        };
        $limit = 200;
        $where = '';
        if (Tools::getValue('limit', false) && is_numeric(Tools::getValue('limit'))) {
filter:
    dependency_paths: ["lib/*"]
            $limit = Tools::getValue('limit');
        }
        if (Tools::getValue('from', false)) {
            $where = 'WHERE createdAt >= \'' . Tools::getValue('from') . '\'';
        }
        $sql = 'SELECT * FROM ' . _DB_PREFIX_ . 'pagantis_log ' . $where . ' ORDER BY id desc LIMIT ' . $limit;

        if ($results = Db::getInstance()->ExecuteS($sql)) {
filter:
    dependency_paths: ["lib/*"]
            foreach ($results as $row) {
                $data = (is_null(json_decode($row['log']))) ? $row['log'] : json_decode($row['log']);
                if (is_array($data)) {
                    $data['timestamp'] = $row['createdAt'];
                } else {
                    $data = array("message" => $data, 'timestamp' => $row['createdAt']);
                }
                $this->message[] = $data;
            }
        }
        $this->jsonResponse();
    }

    /**
     * Send a jsonResponse
     */
    public function jsonResponse()
    {
        $result = json_encode($this->message);

        header('HTTP/1.1 200 Ok', true, 200);
        header('Content-Type: application/json', true);
        header('Content-Length: ' . Tools::strlen($result));

        echo $result;
        exit();

    }

    /**
     * @return bool|null
     */
    public function authorize()
    {
        $privateKey = Configuration::get('pagantis_private_key');
filter:
    dependency_paths: ["lib/*"]

        if (Tools::getValue('secret', false) == $privateKey) {
            return true;
        }

        header('HTTP/1.1 403 Forbidden', true, 403);
        header('Content-Type: application/json', true);

        exit();
    }
}


1			<?php
2			/**
3			* This file is part of the official Pagantis module for PrestaShop.
4			*
5			* @author Pagantis <[email protected]>
6			* @copyright 2019 Pagantis
7			* @license proprietary
8			*/
9
10			/**
11			* Class PagantisLogModuleFrontController
12			*/
13			class PagantisLogModuleFrontController extends ModuleFrontController
			0 ignored issues – show Bug introduced 2018-08-24 08:55 UTC by Report Bug Copy Issue Report The type `ModuleFrontController` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
14			{
15			/**
16			* @var string $message
17			*/
18			protected $message;
19
20			/**
21			* @var bool $error
22			*/
23			protected $error = false;
24
25			/**
26			* Controller index method:
27			*/
28			public function postProcess()
29			{
30			if (!$this->authorize()) {
			0 ignored issues – show Bug Best Practice introduced 2019-01-22 10:42 UTC by Report Bug Copy Issue Report The expression `$this->authorize()` of type `null\|true` is loosely compared to `false`; this is ambiguous if the boolean can be false. You might want to explicitly use `!== null` instead. If an expression can have both `false`, and `null` as possible values. It is generally a good practice to always use strict comparison to clearly distinguish between those two values. $a = canBeFalseAndNull(); // Instead of if ( ! $a) { } // Better use one of the explicit versions: if ($a !== null) { } if ($a !== false) { } if ($a !== null && $a !== false) { } Loading history...
31			return;
32			};
33			$limit = 200;
34			$where = '';
35			if (Tools::getValue('limit', false) && is_numeric(Tools::getValue('limit'))) {
			0 ignored issues – show Bug introduced 2020-02-17 12:20 UTC by Report Bug Copy Issue Report The type `Tools` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
36			$limit = Tools::getValue('limit');
37			}
38			if (Tools::getValue('from', false)) {
39			$where = 'WHERE createdAt >= \'' . Tools::getValue('from') . '\'';
40			}
41			$sql = 'SELECT * FROM ' . _DB_PREFIX_ . 'pagantis_log ' . $where . ' ORDER BY id desc LIMIT ' . $limit;
			0 ignored issues – show Bug introduced 2020-02-17 12:20 UTC by Report Bug Copy Issue Report The constant `_DB_PREFIX_` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
42			if ($results = Db::getInstance()->ExecuteS($sql)) {
			0 ignored issues – show Bug introduced 2020-01-07 10:18 UTC by Report Bug Copy Issue Report The type `Db` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
43			foreach ($results as $row) {
44			$data = (is_null(json_decode($row['log']))) ? $row['log'] : json_decode($row['log']);
45			if (is_array($data)) {
46			$data['timestamp'] = $row['createdAt'];
47			} else {
48			$data = array("message" => $data, 'timestamp' => $row['createdAt']);
49			}
50			$this->message[] = $data;
51			}
52			}
53			$this->jsonResponse();
54			}
55
56			/**
57			* Send a jsonResponse
58			*/
59			public function jsonResponse()
60			{
61			$result = json_encode($this->message);
62
63			header('HTTP/1.1 200 Ok', true, 200);
64			header('Content-Type: application/json', true);
65			header('Content-Length: ' . Tools::strlen($result));
66
67			echo $result;
68			exit();
			0 ignored issues – show Best Practice introduced 2020-01-07 10:18 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
69			}
70
71			/**
72			* @return bool\|null
73			*/
74			public function authorize()
75			{
76			$privateKey = Configuration::get('pagantis_private_key');
			0 ignored issues – show Bug introduced 2019-01-22 10:42 UTC by Report Bug Copy Issue Report The type `Configuration` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
77
78			if (Tools::getValue('secret', false) == $privateKey) {
79			return true;
80			}
81
82			header('HTTP/1.1 403 Forbidden', true, 403);
83			header('Content-Type: application/json', true);
84
85			exit();
86			}
87			}
88

pagantis / prestashop

Push — master ( ebe6e6...69cc20 )

PagantisLogModuleFrontController::postProcess() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like