Pagantis::loadSQLFile()

Complexity

Conditions	8
Paths	20

Size

Total Lines	31
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function loadSQLFile($sql_file)
    {
        try {
            $tableName = _DB_PREFIX_.'pagantis_order';

The constant _DB_PREFIX_ was not found. Maybe you did not declare it correctly or list all dependencies?

            $sql = ("SHOW TABLES LIKE '$tableName'");
            $results = Db::getInstance()->ExecuteS($sql);
            if (is_array($results) && count($results) === 1) {
                $query = "select COLUMN_TYPE FROM information_schema.COLUMNS where TABLE_NAME='$tableName' AND COLUMN_NAME='ps_order_id'";
                $results = $results = Db::getInstance()->ExecuteS($query);

The assignment to $results is dead and can be removed.

                if (is_array($results) && count($results) === 0) {
                    $sql = "ALTER TABLE $tableName ADD COLUMN ps_order_id VARCHAR(60) AFTER order_id";
                    Db::getInstance()->Execute($sql);
                }
                return false;
            }
        } catch (\Exception $exception) {
            // do nothing
        }

        $sql_content = Tools::file_get_contents($sql_file);

The type Tools was not found. Maybe you did not declare it correctly or list all dependencies?

        $sql_content = str_replace('PREFIX_', _DB_PREFIX_, $sql_content);
        $sql_requests = preg_split("/;\s*[\r\n]+/", $sql_content);

        $result = true;
        foreach ($sql_requests as $request) {
            if (!empty($request)) {
                $result &= Db::getInstance()->execute(trim($request));
            }
        }

        return $result;

The expression return $result also could return the type integer which is incompatible with the documented return type boolean.

    }