| Conditions | 13 | 
| Paths | 13 | 
| Total Lines | 162 | 
| Code Lines | 130 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 13 | ||
| Bugs | 0 | Features | 0 | 
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php  | 
            ||
| 94 | function execute()  | 
            ||
| 95 |     { | 
            ||
| 96 | global $order, $oscTemplate;  | 
            ||
| 97 | |||
| 98 | ob_start();  | 
            ||
| 99 | $productId = $GLOBALS["HTTP_GET_VARS"]["products_id"];  | 
            ||
| 100 | $checkoutPage = strpos($_SERVER[REQUEST_URI], "checkout_payment.php") > 0;  | 
            ||
| 101 | |||
| 102 |         if (isset($productId) && $checkoutPage!='1') { | 
            ||
| 103 | $productPrice = $this->getProductPrice();  | 
            ||
| 104 | $pagantisDisplayMinAmount = $this->extraConfig['PAGANTIS_DISPLAY_MIN_AMOUNT'];  | 
            ||
| 105 | $pagantisDisplayMaxAmount = $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_MAX_AMOUNT'];  | 
            ||
| 106 | if (($productPrice > (int)$pagantisDisplayMaxAmount && (int)$pagantisDisplayMaxAmount != '0') ||  | 
            ||
| 107 |                 $productPrice < (int)$pagantisDisplayMinAmount) { | 
            ||
| 108 | return false;  | 
            ||
| 109 | }  | 
            ||
| 110 | }  | 
            ||
| 111 | //Show promoted html  | 
            ||
| 112 |         if ($this->isPromoted($productId) && $checkoutPage!='1') { | 
            ||
| 113 |             echo "<style> #promotedText{margin-left: 10%;} .pmt-no-interest{color: #00c1d5 }</style>"; | 
            ||
| 114 | echo "<div id='promotedText' style='display:none'><br/>".$this->extraConfig['PAGANTIS_PROMOTED_PRODUCT_CODE']."</div>";  | 
            ||
| 115 | echo '<script>'. PHP_EOL;  | 
            ||
| 116 | echo ' function loadPromoted()'. PHP_EOL;  | 
            ||
| 117 |             echo '        {'. PHP_EOL; | 
            ||
| 118 | echo 'var positionSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR']. '\';'. PHP_EOL;  | 
            ||
| 119 |             echo 'if (positionSelector === \'default\') {'. PHP_EOL; | 
            ||
| 120 | echo 'positionSelector = \'.buttonSet\''. PHP_EOL;  | 
            ||
| 121 | echo '}'. PHP_EOL;  | 
            ||
| 122 | echo 'var docFather = document.querySelector(positionSelector);'.PHP_EOL;  | 
            ||
| 123 |             echo 'if (typeof docFather != \'undefined\') {'. PHP_EOL; | 
            ||
| 124 |             echo 'var promotedNode = document.getElementById("promotedText");'.PHP_EOL; | 
            ||
| 125 | echo 'docFather.appendChild(promotedNode);'.PHP_EOL;  | 
            ||
| 126 | echo 'promotedNode.style.display=""' . PHP_EOL;  | 
            ||
| 127 | echo ' clearInterval(window.OSPromotedId);'. PHP_EOL;  | 
            ||
| 128 | echo ' return true;'. PHP_EOL;  | 
            ||
| 129 | echo ' }'. PHP_EOL;  | 
            ||
| 130 | echo ' return false;'. PHP_EOL;  | 
            ||
| 131 | echo ' }'. PHP_EOL;  | 
            ||
| 132 |             echo '       window.OSPromotedId = setInterval(function () {'. PHP_EOL; | 
            ||
| 133 | echo ' loadPromoted();'. PHP_EOL;  | 
            ||
| 134 | echo ' }, 2000);'. PHP_EOL;  | 
            ||
| 135 | echo '</script>'. PHP_EOL;  | 
            ||
| 136 | }  | 
            ||
| 137 | |||
| 138 |         if (isset($productId) || $checkoutPage) { | 
            ||
| 139 | $simulatorCode = 'pgSDK';  | 
            ||
| 140 | |||
| 141 | //Promoted amount on checkout page  | 
            ||
| 142 | $promotedAmount = 0;  | 
            ||
| 143 |             foreach ((array)$order->products as $item) { | 
            ||
| 144 |                 $productId = explode('{', $item['id'], 1); | 
            ||
| 145 | $productId = array_shift($productId);  | 
            ||
| 146 | $promotedProduct = $this->isPromoted($productId);  | 
            ||
| 147 |                 if ($promotedProduct) { | 
            ||
| 148 | $promotedAmount+=number_format(($item['price'] * $item['qty']), 2);  | 
            ||
| 149 | }  | 
            ||
| 150 | }  | 
            ||
| 151 | |||
| 152 | echo "<script src='".$this->sdkFile."'></script>". PHP_EOL;  | 
            ||
| 153 |             echo '<style>#bodyContent>form>div>iframe {float: right; width: 280px !important; margin-right: -90px;} .contentContainer {clear: both;}</style>'. PHP_EOL; | 
            ||
| 154 | echo '<script>'. PHP_EOL;  | 
            ||
| 155 | echo ' function loadSimulator()'. PHP_EOL;  | 
            ||
| 156 |             echo '        {'. PHP_EOL; | 
            ||
| 157 |             echo '           if (typeof '.$simulatorCode.' != \'undefined\') {'. PHP_EOL; | 
            ||
| 158 | echo ' var sdk = '.$simulatorCode.';'. PHP_EOL;  | 
            ||
| 159 | echo ' var positionSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR']. '\';'. PHP_EOL;  | 
            ||
| 160 | echo ' var priceSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR']. '\';'. PHP_EOL;  | 
            ||
| 161 | echo ' var checkoutPriceSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR']. '\';'. PHP_EOL;  | 
            ||
| 162 | echo ' var quantitySelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR']. '\';'. PHP_EOL;  | 
            ||
| 163 | echo ' var checkoutPage = \'' . $checkoutPage.'\';'. PHP_EOL;  | 
            ||
| 164 | echo ' var promotedAmount = \'' . $promotedAmount.'\';'. PHP_EOL;  | 
            ||
| 165 | echo ' var langCode = \'' . $this->langCode.'\';'. PHP_EOL;  | 
            ||
| 166 | |||
| 167 |             echo '               if (positionSelector === \'default\') {'. PHP_EOL; | 
            ||
| 168 | echo ' positionSelector = \'#bodyContent>form>div\''. PHP_EOL;  | 
            ||
| 169 | echo ' }'. PHP_EOL;  | 
            ||
| 170 | |||
| 171 |             echo '               if (priceSelector === \'default\') {'. PHP_EOL; | 
            ||
| 172 | echo ' priceSelector = \'#bodyContent>form>div>h1:first-child\''. PHP_EOL;  | 
            ||
| 173 | echo ' }'. PHP_EOL;  | 
            ||
| 174 | |||
| 175 |             echo '               if (checkoutPriceSelector == \'default\' && checkoutPage == \'1\')  {'. PHP_EOL; | 
            ||
| 176 | echo ' priceSelector = \'#columnRight > .infoBoxContainer > .infoBoxContents > tbody > tr:last-child > td\';'. PHP_EOL;  | 
            ||
| 177 | echo ' }'. PHP_EOL;  | 
            ||
| 178 | |||
| 179 |             echo '               product_simulator = {};'. PHP_EOL; | 
            ||
| 180 | echo ' product_simulator.locale = \'' . strtolower($this->langCode) . '\';'. PHP_EOL;  | 
            ||
| 181 | echo ' product_simulator.country = \'' . strtolower($this->langCode) . '\';'. PHP_EOL;  | 
            ||
| 182 | echo ' product_simulator.publicKey = \'' . $this->pk . '\';'. PHP_EOL;  | 
            ||
| 183 | echo ' product_simulator.selector = positionSelector;'. PHP_EOL;  | 
            ||
| 184 | echo ' product_simulator.numInstalments = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_START_INSTALLMENTS'] . '\';'. PHP_EOL;  | 
            ||
| 185 | echo ' product_simulator.type = ' . $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_TYPE'] . ';'. PHP_EOL;  | 
            ||
| 186 | echo ' product_simulator.skin = ' . $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_SKIN'] . ';'. PHP_EOL;  | 
            ||
| 187 | echo ' product_simulator.position = ' . $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'] . ';'. PHP_EOL;  | 
            ||
| 188 |             echo '               product_simulator.amountParserConfig = {};'. PHP_EOL; | 
            ||
| 189 | echo ' product_simulator.amountParserConfig.thousandSeparator = "' . $this->extraConfig['PAGANTIS_SIMULATOR_THOUSANDS_SEPARATOR'] . '";'. PHP_EOL;  | 
            ||
| 190 | echo ' product_simulator.amountParserConfig.decimalSeparator = "' . $this->extraConfig['PAGANTIS_SIMULATOR_DECIMAL_SEPARATOR'] . '";'. PHP_EOL;  | 
            ||
| 191 | |||
| 192 | //Amount in product page  | 
            ||
| 193 | echo ' var promotedProduct = \'' . $this->isPromoted($productId) .'\';'. PHP_EOL;  | 
            ||
| 194 |             echo '               if(checkoutPage != \'1\' ) {'. PHP_EOL; | 
            ||
| 195 | echo ' product_simulator.itemAmountSelector = priceSelector;'. PHP_EOL;  | 
            ||
| 196 |             echo '                   if(promotedProduct == \'1\') { ' . PHP_EOL; | 
            ||
| 197 | echo ' product_simulator.itemPromotedAmountSelector = priceSelector;'. PHP_EOL;  | 
            ||
| 198 | echo ' }' . PHP_EOL;  | 
            ||
| 199 | echo ' }';  | 
            ||
| 200 | |||
| 201 | //Amount in checkout page  | 
            ||
| 202 |             echo '               if(checkoutPage == \'1\' ) { ' . PHP_EOL; | 
            ||
| 203 | echo ' product_simulator.totalAmountSelector = priceSelector;'. PHP_EOL;  | 
            ||
| 204 |             echo '                  if(promotedAmount != \'0\' && checkoutPage == \'1\' ) { ' . PHP_EOL; | 
            ||
| 205 | echo ' product_simulator.totalPromotedAmount = promotedAmount;'. PHP_EOL;  | 
            ||
| 206 | echo ' }' . PHP_EOL;  | 
            ||
| 207 | echo ' product_simulator.selector = \'.buttonSet\';' . PHP_EOL;  | 
            ||
| 208 | echo ' product_simulator.type = ' .$this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_TYPE_CHECKOUT'] . PHP_EOL;  | 
            ||
| 209 | echo ' }' . PHP_EOL;  | 
            ||
| 210 | echo ' sdk.simulator.init(product_simulator);'. PHP_EOL;  | 
            ||
| 211 | echo ' clearInterval(window.OSSimulatorId);'. PHP_EOL;  | 
            ||
| 212 | echo ' return true;'. PHP_EOL;  | 
            ||
| 213 | echo ' }'. PHP_EOL;  | 
            ||
| 214 | echo ' return false;'. PHP_EOL;  | 
            ||
| 215 | echo ' }'. PHP_EOL;  | 
            ||
| 216 | |||
| 217 | //Invoke to main method  | 
            ||
| 218 |             echo '       window.OSSimulatorId = setInterval(function () {'. PHP_EOL; | 
            ||
| 219 | echo ' loadSimulator();'. PHP_EOL;  | 
            ||
| 220 | echo ' }, 2500);'. PHP_EOL;  | 
            ||
| 221 | echo '</script>'. PHP_EOL;  | 
            ||
| 222 | |||
| 223 | //Checkout simulator  | 
            ||
| 224 |             if ($checkoutPage) { | 
            ||
| 225 | echo '<script>' . PHP_EOL;  | 
            ||
| 226 | |||
| 227 | echo 'function checkSelected(value)'. PHP_EOL;  | 
            ||
| 228 |                 echo '{ '. PHP_EOL; | 
            ||
| 229 |                 echo 'var simulator = document.getElementsByClassName("buttonSet");'  . PHP_EOL; | 
            ||
| 230 |                 echo ' if(simulator == "undefined") { return false;  } '. PHP_EOL; | 
            ||
| 231 |                 echo 'var pagantisCheckbox = document.querySelector("input[value=\'pagantis\']"); ' . PHP_EOL; | 
            ||
| 232 | echo 'var grandparentNode = pagantisCheckbox.parentNode.parentNode;' . PHP_EOL;  | 
            ||
| 233 |                 echo 'if(grandparentNode == value) { var status="" } ' . PHP_EOL; | 
            ||
| 234 |                 echo 'else { var status="none";} '. PHP_EOL; | 
            ||
| 235 | echo 'simulator[0].style.display=status; ' . PHP_EOL;  | 
            ||
| 236 | echo '}'. PHP_EOL;  | 
            ||
| 237 | |||
| 238 | echo 'function showSimulator()'. PHP_EOL;  | 
            ||
| 239 |                 echo '{'. PHP_EOL; | 
            ||
| 240 |                 echo 'var elements = document.querySelectorAll("tr[class^=\'moduleRow\']");' . PHP_EOL; | 
            ||
| 241 |                 echo 'if(elements == null) { return false };' . PHP_EOL; | 
            ||
| 242 |                 echo 'for(var i = 0, max = elements.length; i < max; i++) { elements[i].onclick = function() { | 
            ||
| 243 | checkSelected(this);  | 
            ||
| 244 | } }' . PHP_EOL;  | 
            ||
| 245 | echo 'clearInterval(window.OSdisplayId);';  | 
            ||
| 246 | echo 'return true;'. PHP_EOL;  | 
            ||
| 247 | echo '};'. PHP_EOL;  | 
            ||
| 248 | |||
| 249 |                 echo '       window.OSdisplayId = setInterval(function () {'. PHP_EOL; | 
            ||
| 250 | echo ' showSimulator();'. PHP_EOL;  | 
            ||
| 251 | echo ' }, 2000);'. PHP_EOL;  | 
            ||
| 252 | echo '</script>'. PHP_EOL;  | 
            ||
| 253 | }  | 
            ||
| 254 | }  | 
            ||
| 255 | $oscTemplate->addBlock(ob_get_clean(), $this->group);  | 
            ||
| 256 | }  | 
            ||
| 314 | 
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.