pagantis / oscommerce

config/configure_admin.php

Spacing +14 added lines, -14 removed lines

@@ -17,21 +17,21 @@
 define('DIR_WS_HTTPS_CATALOG', '/');
 define('DIR_FS_CATALOG', '/var/www/html/');
 define('DIR_WS_IMAGES', 'images/');
-define('DIR_WS_ICONS', DIR_WS_IMAGES . 'icons/');
-define('DIR_WS_CATALOG_IMAGES', DIR_WS_CATALOG . 'images/');
+define('DIR_WS_ICONS', DIR_WS_IMAGES.'icons/');
+define('DIR_WS_CATALOG_IMAGES', DIR_WS_CATALOG.'images/');
 define('DIR_WS_INCLUDES', 'includes/');
-define('DIR_WS_BOXES', DIR_WS_INCLUDES . 'boxes/');
-define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES . 'functions/');
-define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/');
-define('DIR_WS_MODULES', DIR_WS_INCLUDES . 'modules/');
-define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES . 'languages/');
-define('DIR_WS_CATALOG_LANGUAGES', DIR_WS_CATALOG . 'includes/languages/');
-define('DIR_FS_CATALOG_LANGUAGES', DIR_FS_CATALOG . 'includes/languages/');
-define('DIR_FS_CATALOG_IMAGES', DIR_FS_CATALOG . 'images/');
-define('DIR_FS_CATALOG_MODULES', DIR_FS_CATALOG . 'includes/modules/');
-define('DIR_FS_BACKUP', DIR_FS_ADMIN . 'backups/');
-define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG . 'download/');
-define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG . 'pub/');
+define('DIR_WS_BOXES', DIR_WS_INCLUDES.'boxes/');
+define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES.'functions/');
+define('DIR_WS_CLASSES', DIR_WS_INCLUDES.'classes/');
+define('DIR_WS_MODULES', DIR_WS_INCLUDES.'modules/');
+define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES.'languages/');
+define('DIR_WS_CATALOG_LANGUAGES', DIR_WS_CATALOG.'includes/languages/');
+define('DIR_FS_CATALOG_LANGUAGES', DIR_FS_CATALOG.'includes/languages/');
+define('DIR_FS_CATALOG_IMAGES', DIR_FS_CATALOG.'images/');
+define('DIR_FS_CATALOG_MODULES', DIR_FS_CATALOG.'includes/modules/');
+define('DIR_FS_BACKUP', DIR_FS_ADMIN.'backups/');
+define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG.'download/');
+define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG.'pub/');
 
 define('DB_SERVER', getenv('OSCOMMERCE_DB_HOST'));
 define('DB_SERVER_USERNAME', getenv('OSCOMMERCE_DB_USER'));

config/configure.php

Spacing +7 added lines, -7 removed lines

@@ -9,17 +9,17 @@
 define('DIR_WS_HTTP_CATALOG', '/');
 define('DIR_WS_HTTPS_CATALOG', '/');
 define('DIR_WS_IMAGES', 'images/');
-define('DIR_WS_ICONS', DIR_WS_IMAGES . 'icons/');
+define('DIR_WS_ICONS', DIR_WS_IMAGES.'icons/');
 define('DIR_WS_INCLUDES', 'includes/');
-define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES . 'functions/');
-define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/');
-define('DIR_WS_MODULES', DIR_WS_INCLUDES . 'modules/');
-define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES . 'languages/');
+define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES.'functions/');
+define('DIR_WS_CLASSES', DIR_WS_INCLUDES.'classes/');
+define('DIR_WS_MODULES', DIR_WS_INCLUDES.'modules/');
+define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES.'languages/');
 
 define('DIR_WS_DOWNLOAD_PUBLIC', 'pub/');
 define('DIR_FS_CATALOG', '/var/www/html');
-define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG . 'download/');
-define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG . 'pub/');
+define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG.'download/');
+define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG.'pub/');
 
 define('DB_SERVER', getenv('OSCOMMERCE_DB_HOST'));
 define('DB_SERVER_USERNAME', getenv('OSCOMMERCE_DB_USER'));

catalog/ext/modules/payment/pagantis/bypass.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
     $destUrl = $_POST['formUrl'];
 } elseif ($_POST['cancelUrl']) {
     $destUrl = $_POST['cancelUrl'];
-} else {
+}else {
     $destUrl = $_SERVER['HTTP_REFERER'];
 }
 

catalog/ext/modules/payment/pagantis/configController.php

Indentation +14 added lines, -14 removed lines

@@ -9,20 +9,20 @@
  * @var array $defaultConfigs
  */
 $defaultConfigs = array('PMT_TITLE'=>'Instant Financing',
-                               'PMT_SIMULATOR_DISPLAY_TYPE'=>'pmtSDK.simulator.types.SIMPLE',
-                               'PMT_SIMULATOR_DISPLAY_SKIN'=>'pmtSDK.simulator.skins.BLUE',
-                               'PMT_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
-                               'PMT_SIMULATOR_START_INSTALLMENTS'=>3,
-                               'PMT_SIMULATOR_MAX_INSTALLMENTS'=>12,
-                               'PMT_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
-                               'PMT_SIMULATOR_DISPLAY_CSS_POSITION'=>'pmtSDK.simulator.positions.INNER',
-                               'PMT_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
-                               'PMT_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
-                               'PMT_FORM_DISPLAY_TYPE'=>0,
-                               'PMT_DISPLAY_MIN_AMOUNT'=>1,
-                               'PMT_URL_OK'=>'',
-                               'PMT_URL_KO'=>'',
-                               'PMT_TITLE_EXTRA' => 'Paga hasta en 12 cómodas cuotas con Paga+Tarde. Solicitud totalmente 
+                                'PMT_SIMULATOR_DISPLAY_TYPE'=>'pmtSDK.simulator.types.SIMPLE',
+                                'PMT_SIMULATOR_DISPLAY_SKIN'=>'pmtSDK.simulator.skins.BLUE',
+                                'PMT_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
+                                'PMT_SIMULATOR_START_INSTALLMENTS'=>3,
+                                'PMT_SIMULATOR_MAX_INSTALLMENTS'=>12,
+                                'PMT_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
+                                'PMT_SIMULATOR_DISPLAY_CSS_POSITION'=>'pmtSDK.simulator.positions.INNER',
+                                'PMT_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
+                                'PMT_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
+                                'PMT_FORM_DISPLAY_TYPE'=>0,
+                                'PMT_DISPLAY_MIN_AMOUNT'=>1,
+                                'PMT_URL_OK'=>'',
+                                'PMT_URL_KO'=>'',
+                                'PMT_TITLE_EXTRA' => 'Paga hasta en 12 cómodas cuotas con Paga+Tarde. Solicitud totalmente 
                             online y sin papeleos,¡y la respuesta es inmediata!'
 );
 

Spacing +4 added lines, -4 removed lines

@@ -41,22 +41,22 @@
 } elseif ($_SERVER['REQUEST_METHOD'] == 'POST') {
     if (count($_POST)) {
         foreach ($_POST as $config => $value) {
-            if (isset($defaultConfigs[$config]) && $response['status']==null) {
+            if (isset($defaultConfigs[$config]) && $response['status'] == null) {
                 $updateQuery = "update ".TABLE_PAGANTIS_CONFIG." set value='$value' where config='$config'";
                 $resultsSelect = tep_db_query($updateQuery);
-            } else {
+            }else {
                 $response['status'] = 400;
                 $response['result'] = 'Bad request';
             }
         }
-    } else {
+    }else {
         $response['status'] = 422;
         $response['result'] = 'Empty data';
     }
 }
 
 $formattedResult = array();
-if ($response['status']==null) {
+if ($response['status'] == null) {
     $query = "select * from ".TABLE_PAGANTIS_CONFIG;
     $resultsSelect = tep_db_query($query);
     while ($orderRow = tep_db_fetch_array($resultsSelect)) {

catalog/ext/modules/payment/pagantis/logController.php

Spacing +7 added lines, -7 removed lines

@@ -11,8 +11,8 @@ 
 $orderRow = tep_db_fetch_array($resultsSelect);
 $privateKey = $orderRow['configuration_value'];
 
-if ($secretKey!='' && $privateKey!='') {
-    $query ="select log, createdAt from ".TABLE_PAGANTIS_LOG;
+if ($secretKey != '' && $privateKey != '') {
+    $query = "select log, createdAt from ".TABLE_PAGANTIS_LOG;
 
     $where = array();
     if (isset($_GET['from'])) {
@@ -24,16 +24,16 @@ 
     }
 
 
-    if (count($where)>0) {
-        $query.=" where ";
+    if (count($where) > 0) {
+        $query .= " where ";
         foreach ((array)$where as $clause) {
-            $query.=" $clause AND";
+            $query .= " $clause AND";
         }
         $query = substr($query, 0, -3);
     }
 
     $limit = ($_GET['limit']) ? $_GET['limit'] : 50;
-    $query.=" order by createdAt desc limit $limit";
+    $query .= " order by createdAt desc limit $limit";
 
     $response = array();
     $resultsSelect = tep_db_query($query);
@@ -44,7 +44,7 @@ 
             $response[$i]['log']       = $orderRow['log'];
             $i++;
         }
-    } else {
+    }else {
         $response['result'] = 'Error';
     }
 

catalog/ext/modules/payment/pagantis/callback.php

Spacing +2 added lines, -2 removed lines

@@ -16,8 +16,8 @@
         tep_session_register($var);
     }
     $destUrl = tep_href_link(FILENAME_CHECKOUT_PROCESS, '', 'SSL', true, false);
-    $destUrl.="?order_id=$_GET[order_id]&from=notify";
-} else {
+    $destUrl .= "?order_id=$_GET[order_id]&from=notify";
+}else {
     $destUrl = tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL', true, false);
 }
 

test/PagantisOscommerceTest.php

Spacing +8 added lines, -8 removed lines

@@ -64,12 +64,12 @@ 
         $faker = Factory::create();
         $this->configuration['dni'] = $this->getDNI();
         $this->configuration['firstname'] = $faker->firstName;
-        $this->configuration['lastname'] = $faker->lastName . ' ' . $faker->lastName;
+        $this->configuration['lastname'] = $faker->lastName.' '.$faker->lastName;
         $this->configuration['company'] = $faker->company;
         $this->configuration['zip'] = '28'.$faker->randomNumber(3, true);
         $this->configuration['address'] = $faker->streetAddress;
-        $this->configuration['phone'] = '6' . $faker->randomNumber(8);
-        $this->configuration['email'] = date('ymd') . '@pagantis.com';
+        $this->configuration['phone'] = '6'.$faker->randomNumber(8);
+        $this->configuration['email'] = date('ymd').'@pagantis.com';
         parent::__construct($name, $data, $dataName);
     }
     /**
@@ -77,12 +77,12 @@ 
      */
     protected function getDNI()
     {
-        $dni = '0000' . rand(pow(10, 4-1), pow(10, 4)-1);
-        $value = (int) ($dni / 23);
+        $dni = '0000'.rand(pow(10, 4 - 1), pow(10, 4) - 1);
+        $value = (int)($dni / 23);
         $value *= 23;
-        $value= $dni - $value;
-        $letter= "TRWAGMYFPDXBNJZSQVHLCKEO";
-        $dniLetter= substr($letter, $value, 1);
+        $value = $dni - $value;
+        $letter = "TRWAGMYFPDXBNJZSQVHLCKEO";
+        $dniLetter = substr($letter, $value, 1);
         return $dni.$dniLetter;
     }
 

catalog/includes/modules/payment/pagantis.php

Indentation +1 added lines, -1 removed lines

@@ -156,7 +156,7 @@
         try {
             include_once('./ext/modules/payment/pagantis/vendor/autoload.php');
             global $order, $customer_id, $sendto, $billto, $cart, $languages_id, $currency, $currencies, $shipping,
-                   $payment, $comments, $customer_default_address_id, $cartID;
+                    $payment, $comments, $customer_default_address_id, $cartID;
             $global_vars = array();
             $global_vars['customer_id'] = serialize($customer_id);
             $global_vars['sendTo'] = serialize($sendto);

Spacing +54 added lines, -54 removed lines

@@ -75,8 +75,8 @@ 
 
         if (strpos($_SERVER[REQUEST_URI], "checkout_payment.php") <= 0) {
             $this->title = MODULE_PAYMENT_PAGANTIS_TEXT_ADMIN_TITLE; // Payment module title in Admin
-        } else {
-            $this->title = MODULE_PAYMENT_PAGANTIS_TEXT_CHECKOUT .'<br/><br/><div class="buttonSet" style="display:none"></div><br/>'; // Payment module title in Catalog
+        }else {
+            $this->title = MODULE_PAYMENT_PAGANTIS_TEXT_CHECKOUT.'<br/><br/><div class="buttonSet" style="display:none"></div><br/>'; // Payment module title in Catalog
         }
 
         if (defined('MODULE_PAYMENT_PAGANTIS_LANG_CODE')) {
@@ -92,12 +92,12 @@ 
                 "%s://%s%s%s",
                 isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off' ? 'https' : 'http',
                 $_SERVER['SERVER_NAME'],
-                isset($_SERVER['SERVER_PORT']) ? ":" . $_SERVER['SERVER_PORT'] : '',
+                isset($_SERVER['SERVER_PORT']) ? ":".$_SERVER['SERVER_PORT'] : '',
                 $_SERVER['REQUEST_URI']
             )
         );
 
-        $this->form_action_url = $this->base_url . '/ext/modules/payment/pagantis/bypass.php';
+        $this->form_action_url = $this->base_url.'/ext/modules/payment/pagantis/bypass.php';
 
         if (defined('MODULE_PAYMENT_PAGANTIS_ERROR_MESSAGE')) {
             $this->errorMessage = strtoupper(MODULE_PAYMENT_PAGANTIS_ERROR_MESSAGE);
@@ -211,12 +211,12 @@ 
             $national_id = $this->getNationalId();
             $tax_id = $this->getTaxId();
 
-            $fullName = $order->billing['firstname'] . ' ' . $order->billing['lastname'];
+            $fullName = $order->billing['firstname'].' '.$order->billing['lastname'];
             if ($fullName == ' ') {
-                $fullName = $order->customer['firstname'] . ' ' . $order->customer['lastname'];
+                $fullName = $order->customer['firstname'].' '.$order->customer['lastname'];
             }
             if ($fullName == ' ') {
-                $fullName = $order->delivery['firstname'] . ' ' . $order->delivery['lastname'];
+                $fullName = $order->delivery['firstname'].' '.$order->delivery['lastname'];
             }
             $fullName = utf8_encode($fullName);
             $userAddress = new Address();
@@ -287,7 +287,7 @@ 
                     ->setQuantity(intval($item['qty']))
                     ->setDescription($item['name']);
                 if ($promotedProduct) {
-                    $promotedAmount+=$product->getAmount();
+                    $promotedAmount += $product->getAmount();
                     $promotedMessage = $product->getDescription()."-Price:".$item['final_price']."-Qty:".$product->getQuantity();
                     $metadataOrder->addMetadata('promotedProduct', $promotedMessage);
                 }
@@ -307,9 +307,9 @@ 
             );
 
             $cancelUrl = trim(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL', false));
-            if ($this->extraConfig['PAGANTIS_URL_KO']!='') {
+            if ($this->extraConfig['PAGANTIS_URL_KO'] != '') {
                 $koUrl = $this->extraConfig['PAGANTIS_URL_KO'];
-            } else {
+            }else {
                 $koUrl = $cancelUrl;
             }
 
@@ -347,25 +347,25 @@ 
             if ($pagantisOrder instanceof \Pagantis\OrdersApiClient\Model\Order) {
                 $url = $pagantisOrder->getActionUrls()->getForm();
                 $this->insertRow($this->os_order_reference, $pagantisOrder->getId(), serialize($global_vars));
-            } else {
+            }else {
                 throw new OrderNotFoundException();
             }
 
             if ($url == "") {
                 throw new UnknownException(_("No ha sido posible obtener una respuesta de Pagantis"));
-            } else {
+            }else {
                 $output = "\n";
-                $output .= tep_draw_hidden_field("formUrl", $url) . "\n";
-                $output .= tep_draw_hidden_field("cancelUrl", $cancelUrl) . "\n";
+                $output .= tep_draw_hidden_field("formUrl", $url)."\n";
+                $output .= tep_draw_hidden_field("cancelUrl", $cancelUrl)."\n";
                 return $output;
 
             } //TODO IFRAME
         } catch (\Exception $exception) {
             $this->insertLog($exception);
             $output = "\n";
-            $output .= tep_draw_hidden_field("cancelUrl", $cancelUrl) . "\n";
-            $output .= tep_draw_hidden_field("errorMessage", $exception->getMessage()) . "\n";
-            $output .= tep_draw_hidden_field("errorCode", $exception->getCode()) . "\n";
+            $output .= tep_draw_hidden_field("cancelUrl", $cancelUrl)."\n";
+            $output .= tep_draw_hidden_field("errorMessage", $exception->getMessage())."\n";
+            $output .= tep_draw_hidden_field("errorCode", $exception->getCode())."\n";
             $output .= "<p>".$this->errorMessage.", <a href='$cancelUrl' style='text-decoration:underline'><b>";
             $output .= $this->errorLinkMessage." </b></a></p>";
 
@@ -429,7 +429,7 @@ 
             return 'failed';
         }
 
-        tep_db_query("insert into " . TABLE_CONFIGURATION . "
+        tep_db_query("insert into ".TABLE_CONFIGURATION."
         (
             configuration_title,
             configuration_key,
@@ -452,7 +452,7 @@ 
             ',
             now()
         )");
-        tep_db_query("insert into " . TABLE_CONFIGURATION . "
+        tep_db_query("insert into ".TABLE_CONFIGURATION."
         (
             configuration_title,
             configuration_key,
@@ -472,7 +472,7 @@ 
             '0',
             now()
         )");
-        tep_db_query("insert into " . TABLE_CONFIGURATION . "
+        tep_db_query("insert into ".TABLE_CONFIGURATION."
         (
             configuration_title,
             configuration_key,
@@ -492,7 +492,7 @@ 
             '0',
             now()
         )");
-        tep_db_query("insert into " . TABLE_CONFIGURATION . "
+        tep_db_query("insert into ".TABLE_CONFIGURATION."
         (
             configuration_title,
             configuration_key,
@@ -524,14 +524,14 @@ 
      */
     private function installPagantisTables()
     {
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_LOG . " ( 
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_LOG." ( 
                           id int NOT NULL AUTO_INCREMENT, 
                           log text NOT NULL, 
                           createdAt timestamp DEFAULT CURRENT_TIMESTAMP, 
                           UNIQUE KEY id (id))";
         tep_db_query($sql);
 
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_CONFIG . " (
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_CONFIG." (
                             id int NOT NULL AUTO_INCREMENT, 
                             config varchar(60) NOT NULL, 
                             value varchar(200) NOT NULL, 
@@ -539,10 +539,10 @@ 
         tep_db_query($sql);
 
         // check if table has records
-        $check_query = tep_db_query("select value from " . TABLE_PAGANTIS_CONFIG);
+        $check_query = tep_db_query("select value from ".TABLE_PAGANTIS_CONFIG);
         if (tep_db_num_rows($check_query) === 0) {
             foreach ((array)$this->defaultConfigs as $configKey => $configValue) {
-                $query = "INSERT INTO " . TABLE_PAGANTIS_CONFIG . "
+                $query = "INSERT INTO ".TABLE_PAGANTIS_CONFIG."
                 (
                     config,
                     value
@@ -556,7 +556,7 @@ 
             }
         }
 
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_ORDERS . " (
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_ORDERS." (
                             id int NOT NULL AUTO_INCREMENT, 
                             os_order_id varchar(50), 
                             os_order_reference varchar(50) NOT NULL,
@@ -565,7 +565,7 @@ 
                             UNIQUE KEY id(id))";
         tep_db_query($sql);
 
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_CONCURRENCY . " (
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_CONCURRENCY." (
                             id varchar(50) NOT NULL,
                             `timestamp` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
                             UNIQUE KEY id(id))";
@@ -577,29 +577,29 @@ 
      */
     public function remove()
     {
-        $checkTable = tep_db_query("SHOW TABLES LIKE '" . TABLE_PAGANTIS_LOG . "'");
+        $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_LOG."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_LOG);
+            tep_db_query("drop table ".TABLE_PAGANTIS_LOG);
         }
 
-        $checkTable = tep_db_query("SHOW TABLES LIKE '" . TABLE_PAGANTIS_CONFIG . "'");
+        $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_CONFIG."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_CONFIG);
+            tep_db_query("drop table ".TABLE_PAGANTIS_CONFIG);
         }
 
-        $checkTable = tep_db_query("SHOW TABLES LIKE '" . TABLE_PAGANTIS_ORDERS . "'");
+        $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_ORDERS."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_ORDERS);
+            tep_db_query("drop table ".TABLE_PAGANTIS_ORDERS);
         }
 
-        $checkTable = tep_db_query("SHOW TABLES LIKE '" . TABLE_PAGANTIS_CONCURRENCY . "'");
+        $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_CONCURRENCY."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_CONCURRENCY);
+            tep_db_query("drop table ".TABLE_PAGANTIS_CONCURRENCY);
         }
 
-        tep_db_query("DELETE FROM ". TABLE_CONFIGURATION ." where configuration_key in ('MODULE_PAYMENT_PAGANTIS_STATUS','MODULE_PAYMENT_PAGANTIS_PK','MODULE_PAYMENT_PAGANTIS_SK')");
+        tep_db_query("DELETE FROM ".TABLE_CONFIGURATION." where configuration_key in ('MODULE_PAYMENT_PAGANTIS_STATUS','MODULE_PAYMENT_PAGANTIS_PK','MODULE_PAYMENT_PAGANTIS_SK')");
 
-        $query = "delete from " . TABLE_CONFIGURATION . " where configuration_key like '%_PAGANTIS_%'";
+        $query = "delete from ".TABLE_CONFIGURATION." where configuration_key like '%_PAGANTIS_%'";
         tep_db_query($query);
 
         $this->uninstallSimulator();
@@ -654,13 +654,13 @@ 
      */
     private function insertRow($orderId, $pagantisOrderId, $globalVars)
     {
-        $query = "select * from " . TABLE_PAGANTIS_ORDERS . " where os_order_reference='$orderId'";
+        $query = "select * from ".TABLE_PAGANTIS_ORDERS." where os_order_reference='$orderId'";
         $resultsSelect = tep_db_query($query);
         $countResults = tep_db_num_rows($resultsSelect);
         if ($countResults == 0) {
-            $query = "INSERT INTO " . TABLE_PAGANTIS_ORDERS . " 
+            $query = "INSERT INTO ".TABLE_PAGANTIS_ORDERS." 
                 (os_order_reference, pagantis_order_id, globals) values ('$orderId', '$pagantisOrderId','$globalVars')";
-        } else {
+        }else {
             $query = "UPDATE ".TABLE_PAGANTIS_ORDERS." set pagantis_order_id='$pagantisOrderId' 
                         where os_order_reference='$orderId'";
         }
@@ -698,7 +698,7 @@ 
 
         if ($this->extraConfig['PAGANTIS_PROMOTION'] == '') {
             $promotedProducts = array();
-        } else {
+        }else {
             $promotedProducts = array_values((array)unserialize($this->extraConfig['PAGANTIS_PROMOTION']));
         }
 
@@ -711,17 +711,17 @@ 
     private function getDescription()
     {
         $descriptionCode = "<img src=\"images/icon_info.gif\" border=\"0\" alt=\"Info\" title=\"Info\">&nbsp;<strong>Module version:</strong> $this->version<br/><br/>";
-        $descriptionCode.= "<img src=\"images/icon_info.gif\" border=\"0\">&nbsp;<a href='https://developer.pagantis.com/' target=\"_blank\" style=\"text-decoration: underline; font-weight: bold;\">View Online Documentation</a><br/><br/>";
-        $descriptionCode.= "<img src='images/icon_popup.gif'  border='0'>        <a href='http://pagantis.com' target='_blank' style='text-decoration: underline; font-weight: bold;'>Visit Pagantis Website</a><br/><br/><br/>";
+        $descriptionCode .= "<img src=\"images/icon_info.gif\" border=\"0\">&nbsp;<a href='https://developer.pagantis.com/' target=\"_blank\" style=\"text-decoration: underline; font-weight: bold;\">View Online Documentation</a><br/><br/>";
+        $descriptionCode .= "<img src='images/icon_popup.gif'  border='0'>        <a href='http://pagantis.com' target='_blank' style='text-decoration: underline; font-weight: bold;'>Visit Pagantis Website</a><br/><br/><br/>";
 
         if (MODULE_PAYMENT_PAGANTIS_STATUS == 'True') {
             $pagantisPromotionUrl = $this->base_url.'/admin/promotion.php';
             $linkDescription = "Si deseas ofrecer financiación sin intereses para alguno de tus productos ";
-            $descriptionCode.= "<img src='images/icon_info.gif' border='0'/> $linkDescription<a href='$pagantisPromotionUrl' style='text-decoration: underline; font-weight: bold;'>haz click aquí</a>";
+            $descriptionCode .= "<img src='images/icon_info.gif' border='0'/> $linkDescription<a href='$pagantisPromotionUrl' style='text-decoration: underline; font-weight: bold;'>haz click aquí</a>";
 
             $pagantisAllowedCountriesUrl = $this->base_url.'/admin/allowedCountries.php';
             $linkDescription = "Para gestionar paises en los que operar con Pagantis ";
-            $descriptionCode.= "<br/><br/><img src='images/icon_info.gif' border='0'/> $linkDescription<a href='$pagantisAllowedCountriesUrl' style='text-decoration: underline; font-weight: bold;'>haz click aquí</a>";
+            $descriptionCode .= "<br/><br/><img src='images/icon_info.gif' border='0'/> $linkDescription<a href='$pagantisAllowedCountriesUrl' style='text-decoration: underline; font-weight: bold;'>haz click aquí</a>";
         }
 
         return $descriptionCode;
@@ -732,18 +732,18 @@ 
      */
     private function installSimulator()
     {
-        $checkSimulator = tep_db_query("select configuration_key, configuration_value from " .TABLE_CONFIGURATION ." 
+        $checkSimulator = tep_db_query("select configuration_key, configuration_value from ".TABLE_CONFIGURATION." 
                                     where configuration_key like 'MODULE_HEADER_TAGS_INSTALLED'
                                     and configuration_value like '%ht_pagantis.php%';");
         if (tep_db_num_rows($checkSimulator) > 0) {
             return true;
         }
 
-        $query = "UPDATE " . TABLE_CONFIGURATION . " set configuration_value = concat(configuration_value, ';ht_pagantis.php')
+        $query = "UPDATE ".TABLE_CONFIGURATION." set configuration_value = concat(configuration_value, ';ht_pagantis.php')
                         where configuration_key like 'MODULE_HEADER_TAGS_INSTALLED'";
         tep_db_query($query);
 
-        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Enable Pagantis Module', 'MODULE_HEADER_TAGS_PAGANTIS_STATUS', 'True', '', '6', '1', 'tep_cfg_select_option(array(\'True\', \'False\'), ', now())");
+        tep_db_query("insert into ".TABLE_CONFIGURATION." (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Enable Pagantis Module', 'MODULE_HEADER_TAGS_PAGANTIS_STATUS', 'True', '', '6', '1', 'tep_cfg_select_option(array(\'True\', \'False\'), ', now())");
     }
 
     /**
@@ -751,18 +751,18 @@ 
      */
     private function uninstallSimulator()
     {
-        $checkSimulator = tep_db_query("select configuration_key, configuration_value from " .TABLE_CONFIGURATION ." 
+        $checkSimulator = tep_db_query("select configuration_key, configuration_value from ".TABLE_CONFIGURATION." 
                                     where configuration_key like 'MODULE_HEADER_TAGS_INSTALLED'
                                     and configuration_value like '%ht_pagantis.php%';");
         if (tep_db_num_rows($checkSimulator) == 0) {
             return true;
         }
 
-        $query = "UPDATE " . TABLE_CONFIGURATION . " set configuration_value = REPLACE(configuration_value, ';ht_pagantis.php', '')
+        $query = "UPDATE ".TABLE_CONFIGURATION." set configuration_value = REPLACE(configuration_value, ';ht_pagantis.php', '')
                         where configuration_key like 'MODULE_HEADER_TAGS_INSTALLED'";
         tep_db_query($query);
 
-        $query = "delete from " . TABLE_CONFIGURATION . " where configuration_key = 'MODULE_HEADER_TAGS_PAGANTIS_STATUS'";
+        $query = "delete from ".TABLE_CONFIGURATION." where configuration_key = 'MODULE_HEADER_TAGS_PAGANTIS_STATUS'";
         tep_db_query($query);
     }
 
@@ -772,7 +772,7 @@ 
     private function insertLog($exception)
     {
         if ($exception instanceof \Exception) {
-            $logEntry= new LogEntry();
+            $logEntry = new LogEntry();
             $logEntryJson = $logEntry->error($exception)->toJson();
             $logEntryJson = addslashes($logEntryJson);
 
@@ -791,7 +791,7 @@ 
             return $order->customer['national_id'];
         } elseif (isset($order->billing['piva'])) {
             return $order->billing['piva'];
-        } else {
+        }else {
             return null;
         }
     }
@@ -806,7 +806,7 @@ 
             return $order->customer['tax_id'];
         } elseif (isset($order->billing['cf'])) {
             return $order->billing['cf'];
-        } else {
+        }else {
             return null;
         }
     }

catalog/admin/promotion.php

Spacing +4 added lines, -4 removed lines

@@ -3,12 +3,12 @@ 
 require('includes/application_top.php');
 
 define('TABLE_PAGANTIS_CONFIG', 'pagantis_config');
-define('TABLE_PRODUCTS_DESCRIPTIONS','products_description');
+define('TABLE_PRODUCTS_DESCRIPTIONS', 'products_description');
 
 //Check if module is installed
-$result = tep_db_query("select * from " . TABLE_CONFIGURATION . " where configuration_key='MODULE_PAYMENT_PAGANTIS_STATUS'");
+$result = tep_db_query("select * from ".TABLE_CONFIGURATION." where configuration_key='MODULE_PAYMENT_PAGANTIS_STATUS'");
 $resultSelect = tep_db_fetch_array($result);
-if (tep_db_num_rows($result) == 0 || $resultSelect['configuration_value'] !=='True') {
+if (tep_db_num_rows($result) == 0 || $resultSelect['configuration_value'] !== 'True') {
     tep_redirect('/admin/index.php');
 }
 
@@ -31,7 +31,7 @@ 
     $resultSelect = tep_db_fetch_array($result);
     if ($resultSelect['value'] == '') {
         $promotedProducts = array();
-    } else {
+    }else {
         $promotedProducts = array_values((array)unserialize($resultSelect['value']));
     }
 }