pagantis /
oscommerce
| Conditions | 10 |
| Paths | 26 |
| Total Lines | 144 |
| Code Lines | 116 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 6 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 83 | function execute() |
||
| 84 | { |
||
| 85 | global $languages_id, $order; |
||
| 86 | |||
| 87 | $productId = $GLOBALS["HTTP_GET_VARS"]["products_id"]; |
||
| 88 | $checkoutPage = strpos($_SERVER[REQUEST_URI], "checkout_payment.php") > 0; |
||
| 89 | |||
| 90 | //Show promoted html |
||
| 91 | if ($this->isPromoted($productId) && $checkoutPage!='1') { |
||
| 92 | echo "<div id='promotedText' style='display:none'><br/>".$this->extraConfig['PAGANTIS_PROMOTED_PRODUCT_CODE']."</div>"; |
||
| 93 | echo '<script>'. PHP_EOL; |
||
| 94 | echo ' function loadPromoted()'. PHP_EOL; |
||
| 95 | echo ' {'. PHP_EOL; |
||
| 96 | echo 'var positionSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR']. '\';'. PHP_EOL; |
||
| 97 | echo 'if (positionSelector === \'default\') {'. PHP_EOL; |
||
| 98 | echo 'positionSelector = \'.buttonSet\''. PHP_EOL; |
||
| 99 | echo '}'. PHP_EOL; |
||
| 100 | echo 'var docFather = document.querySelector(positionSelector);'.PHP_EOL; |
||
| 101 | echo 'if (typeof docFather != \'undefined\') {'. PHP_EOL; |
||
| 102 | echo 'var promotedNode = document.getElementById("promotedText");'.PHP_EOL; |
||
| 103 | echo 'docFather.appendChild(promotedNode);'.PHP_EOL; |
||
| 104 | echo 'promotedNode.style.display=""' . PHP_EOL; |
||
| 105 | echo ' clearInterval(window.OSPromotedId);'. PHP_EOL; |
||
| 106 | echo ' return true;'. PHP_EOL; |
||
| 107 | echo ' }'. PHP_EOL; |
||
| 108 | echo ' return false;'. PHP_EOL; |
||
| 109 | echo ' }'. PHP_EOL; |
||
| 110 | echo ' window.OSPromotedId = setInterval(function () {'. PHP_EOL; |
||
| 111 | echo ' loadPromoted();'. PHP_EOL; |
||
| 112 | echo ' }, 2000);'. PHP_EOL; |
||
| 113 | echo '</script>'. PHP_EOL; |
||
| 114 | } |
||
| 115 | |||
| 116 | if (isset($productId) || $checkoutPage) { |
||
| 117 | $simulatorCode = 'pgSDK'; |
||
| 118 | if ($this->langCode == 'es' || $this->langCode == null) { |
||
| 119 | $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'] = 'pmtSDK.simulator.positions.INNER'; |
||
| 120 | $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_TYPE'] = 'pmtSDK.simulator.types.SIMPLE'; |
||
| 121 | $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_SKIN'] = 'pmtSDK.simulator.skins.BLUE'; |
||
| 122 | $simulatorCode = 'pmtSDK'; |
||
| 123 | } |
||
| 124 | |||
| 125 | //Promoted amount on checkout Pae |
||
| 126 | $promotedAmount = 0; |
||
| 127 | foreach ((array)$order->products as $item) { |
||
| 128 | $productId = explode('{', $item['id'], 1); |
||
| 129 | $productId = array_shift($productId); |
||
| 130 | $promotedProduct = $this->isPromoted($productId); |
||
| 131 | if ($promotedProduct) { |
||
| 132 | $promotedAmount+=number_format(($item['price'] * $item['qty']), 2); |
||
| 133 | } |
||
| 134 | } |
||
| 135 | |||
| 136 | echo "<script src='".$this->sdkFile."'></script>". PHP_EOL; |
||
| 137 | echo '<script>'. PHP_EOL; |
||
| 138 | echo ' function loadSimulator()'. PHP_EOL; |
||
| 139 | echo ' {'. PHP_EOL; |
||
| 140 | echo ' if (typeof '.$simulatorCode.' != \'undefined\') {'. PHP_EOL; |
||
| 141 | echo ' var positionSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR']. '\';'. PHP_EOL; |
||
| 142 | echo ' var priceSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR']. '\';'. PHP_EOL; |
||
| 143 | echo ' var checkoutPriceSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR']. '\';'. PHP_EOL; |
||
| 144 | echo ' var quantitySelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR']. '\';'. PHP_EOL; |
||
| 145 | echo ' var checkoutPage = \'' . $checkoutPage.'\';'. PHP_EOL; |
||
| 146 | echo ' var promotedAmount = \'' . $promotedAmount.'\';'. PHP_EOL; |
||
| 147 | |||
| 148 | echo ' if (positionSelector === \'default\') {'. PHP_EOL; |
||
| 149 | echo ' positionSelector = \'.buttonSet\''. PHP_EOL; |
||
| 150 | echo ' }'. PHP_EOL; |
||
| 151 | |||
| 152 | echo ' if (priceSelector === \'default\') {'. PHP_EOL; |
||
| 153 | echo ' priceSelector = \'#bodyContent>form>div>h1\''. PHP_EOL; |
||
| 154 | echo ' }'. PHP_EOL; |
||
| 155 | |||
| 156 | echo ' if (checkoutPriceSelector == \'default\' && checkoutPage == \'1\') {'. PHP_EOL; |
||
| 157 | echo ' priceSelector = \'#columnRight > .infoBoxContainer > .infoBoxContents > tbody > tr:last-child > td\';'. PHP_EOL; |
||
| 158 | echo ' }'. PHP_EOL; |
||
| 159 | echo ' '.$simulatorCode.'.product_simulator = {};'. PHP_EOL; |
||
| 160 | echo ' '.$simulatorCode.'.product_simulator.id = \'product-simulator\';'. PHP_EOL; |
||
| 161 | echo ' '.$simulatorCode.'.product_simulator.publicKey = \'' . $this->pk . '\';'. PHP_EOL; |
||
| 162 | echo ' '.$simulatorCode.'.product_simulator.selector = positionSelector;'. PHP_EOL; |
||
| 163 | echo ' '.$simulatorCode.'.product_simulator.numInstalments = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_START_INSTALLMENTS'] . '\';'. PHP_EOL; |
||
| 164 | echo ' '.$simulatorCode.'.product_simulator.type = ' . $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_TYPE'] . ';'. PHP_EOL; |
||
| 165 | echo ' '.$simulatorCode.'.product_simulator.skin = ' . $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_SKIN'] . ';'. PHP_EOL; |
||
| 166 | echo ' '.$simulatorCode.'.product_simulator.position = ' . $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'] . ';'. PHP_EOL; |
||
| 167 | |||
| 168 | //Amount in product page |
||
| 169 | echo ' var promotedProduct = \'' . $this->isPromoted($productId) .'\';'. PHP_EOL; |
||
| 170 | echo ' if(checkoutPage != \'1\' ) {'; |
||
| 171 | echo ' '.$simulatorCode.'.product_simulator.itemAmountSelector = priceSelector;'. PHP_EOL; |
||
| 172 | echo ' if(promotedProduct == \'1\') { ' . PHP_EOL; |
||
| 173 | echo ' '.$simulatorCode.'.product_simulator.itemPromotedAmountSelector = priceSelector;'. PHP_EOL; |
||
| 174 | echo ' }' . PHP_EOL; |
||
| 175 | echo ' }'; |
||
| 176 | |||
| 177 | //Amount in checkout page |
||
| 178 | echo ' if(checkoutPage == \'1\' ) { ' . PHP_EOL; |
||
| 179 | echo ' '.$simulatorCode.'.product_simulator.totalAmountSelector = priceSelector;'. PHP_EOL; |
||
| 180 | echo ' if(promotedAmount != \'0\' && checkoutPage == \'1\' ) { ' . PHP_EOL; |
||
| 181 | echo ' ' .$simulatorCode.'.product_simulator.totalPromotedAmount = promotedAmount;'. PHP_EOL; |
||
| 182 | echo ' }' . PHP_EOL; |
||
| 183 | echo ' }' . PHP_EOL; |
||
| 184 | echo ' '.$simulatorCode.'.simulator.init('.$simulatorCode.'.product_simulator);'. PHP_EOL; |
||
| 185 | echo ' clearInterval(window.OSSimulatorId);'. PHP_EOL; |
||
| 186 | echo ' return true;'. PHP_EOL; |
||
| 187 | echo ' }'. PHP_EOL; |
||
| 188 | echo ' return false;'. PHP_EOL; |
||
| 189 | echo ' }'. PHP_EOL; |
||
| 190 | echo ' window.OSSimulatorId = setInterval(function () {'. PHP_EOL; |
||
| 191 | echo ' loadSimulator();'. PHP_EOL; |
||
| 192 | echo ' }, 2000);'. PHP_EOL; |
||
| 193 | echo '</script>'. PHP_EOL; |
||
| 194 | |||
| 195 | //Checkout simulator |
||
| 196 | if ($checkoutPage) { |
||
| 197 | echo '<script>' . PHP_EOL; |
||
| 198 | echo 'function checkSelected(value)'. PHP_EOL; |
||
| 199 | echo '{ '. PHP_EOL; |
||
| 200 | echo 'var simulator = document.getElementsByClassName("buttonSet");' . PHP_EOL; |
||
| 201 | echo ' if(simulator == "undefined") { return false; } '. PHP_EOL; |
||
| 202 | echo 'var pagantisCheckbox = document.querySelector("input[value=\'pagantis\']"); ' . PHP_EOL; |
||
| 203 | echo 'var grandparentNode = pagantisCheckbox.parentNode.parentNode;' . PHP_EOL; |
||
| 204 | echo 'if(grandparentNode == value) { var status="" } ' . PHP_EOL; |
||
| 205 | echo 'else { var status="none";} '. PHP_EOL; |
||
| 206 | echo 'simulator[0].style.display=status; ' . PHP_EOL; |
||
| 207 | echo '}'. PHP_EOL; |
||
| 208 | |||
| 209 | echo 'function showSimulator()'. PHP_EOL; |
||
| 210 | echo '{'. PHP_EOL; |
||
| 211 | echo 'var elements = document.querySelectorAll("tr[class^=\'moduleRow\']");' . PHP_EOL; |
||
| 212 | echo 'if(elements == null) { return false };' . PHP_EOL; |
||
| 213 | |||
| 214 | echo 'for(var i = 0, max = elements.length; i < max; i++) { elements[i].onclick = function() { |
||
| 215 | checkSelected(this); |
||
| 216 | } }' . PHP_EOL; |
||
| 217 | echo 'clearInterval(window.OSdisplayId);'; |
||
| 218 | echo 'return true;'. PHP_EOL; |
||
| 219 | echo '};'. PHP_EOL; |
||
| 220 | |||
| 221 | echo ' window.OSdisplayId = setInterval(function () {'. PHP_EOL; |
||
| 222 | echo ' showSimulator();'. PHP_EOL; |
||
| 223 | echo ' }, 2000);'. PHP_EOL; |
||
| 224 | |||
| 225 | |||
| 226 | echo '</script>'. PHP_EOL; |
||
| 227 | } |
||
| 290 | ?> |
||
Loading history...
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.