pagantis / oscommerce

catalog/ext/modules/payment/pagantis/callback.php

Spacing +2 added lines, -2 removed lines

@@ -16,8 +16,8 @@
         tep_session_register($var);
     }
     $destUrl = tep_href_link(FILENAME_CHECKOUT_PROCESS, '', 'SSL', true, false);
-    $destUrl.="?order_id=$_GET[order_id]&from=notify";
-} else {
+    $destUrl .= "?order_id=$_GET[order_id]&from=notify";
+}else {
     $destUrl = tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL', true, false);
 }
 

catalog/ext/modules/payment/pagantis/notifyController.php

Spacing +11 added lines, -11 removed lines

@@ -75,7 +75,7 @@ 
 
             if ($this->origin == 'notify') {
                 $jsonResponse->printResponse();
-            } else {
+            }else {
                 if ($exception->getMessage() == AlreadyProcessedException::ERROR_MESSAGE) {
                     return;
                 }
@@ -108,7 +108,7 @@ 
 
         if ($this->origin == 'notify') {
             $jsonResponse->printResponse();
-        } else {
+        }else {
             return $jsonResponse;
         }
     }
@@ -180,12 +180,12 @@ 
         try {
             $this->checkPagantisStatus(array('AUTHORIZED'));
         } catch (\Exception $e) {
-            if ($this->findOscommerceOrderId()!='') {
+            if ($this->findOscommerceOrderId() != '') {
                 throw new AlreadyProcessedException();
-            } else {
+            }else {
                 if ($this->pagantisOrder instanceof \Pagantis\OrdersApiClient\Model\Order) {
                     $status = $this->pagantisOrder->getStatus();
-                } else {
+                }else {
                     $status = '-';
                 }
                 throw new WrongStatusException($status);
@@ -200,7 +200,7 @@ 
     {
         global $order;
 
-        if ($order->info['order_status']!=='1') {
+        if ($order->info['order_status'] !== '1') {
             throw new AlreadyProcessedException();
         }
     }
@@ -277,7 +277,7 @@ 
             if ($orderId == null) {
                 $query = "delete from ".TABLE_PAGANTIS_CONCURRENCY." where  timestamp<".(time() - 5);
                 tep_db_query($query);
-            } elseif ($orderId!='') {
+            } elseif ($orderId != '') {
                 $query = "delete from ".TABLE_PAGANTIS_CONCURRENCY." where id='$orderId'";
                 tep_db_query($query);
             }
@@ -329,12 +329,12 @@ 
             if (!$payed) {
                 if ($this->pagantisOrder instanceof \Pagantis\OrdersApiClient\Model\Order) {
                     $status = $this->pagantisOrder->getStatus();
-                } else {
+                }else {
                     $status = '-';
                 }
                 throw new WrongStatusException($status);
             }
-        } else {
+        }else {
             throw new OrderNotFoundException();
         }
     }
@@ -367,7 +367,7 @@ 
         tep_db_query($query);
 
         $comment = "Pagantis id=$this->pagantisOrderId/Via=".ucfirst($this->origin);
-        $query = "insert into ".TABLE_ORDERS_STATUS_HISTORY ."(comments, orders_id, orders_status_id, customer_notified, date_added) values
+        $query = "insert into ".TABLE_ORDERS_STATUS_HISTORY."(comments, orders_id, orders_status_id, customer_notified, date_added) values
             ('$comment', ".$insert_id.", '2', -1, now() )";
         tep_db_query($query);
 
@@ -392,7 +392,7 @@ 
     private function insertLog($exception)
     {
         if ($exception instanceof \Exception) {
-            $logEntry= new LogEntry();
+            $logEntry = new LogEntry();
             $logEntryJson = $logEntry->error($exception)->toJson();
 
             $query = "insert into ".TABLE_PAGANTIS_LOG."(log) values ('$logEntryJson')";

test/PagantisOscommerceTest.php

Spacing +8 added lines, -8 removed lines

@@ -79,12 +79,12 @@ 
 //            $faker->numberBetween(1, 12). '/1975'
 //        ;
         $this->configuration['firstname'] = $faker->firstName;
-        $this->configuration['lastname'] = $faker->lastName . ' ' . $faker->lastName;
+        $this->configuration['lastname'] = $faker->lastName.' '.$faker->lastName;
         $this->configuration['company'] = $faker->company;
         $this->configuration['zip'] = '28'.$faker->randomNumber(3, true);
         $this->configuration['street'] = $faker->streetAddress;
-        $this->configuration['phone'] = '6' . $faker->randomNumber(8);
-        $this->configuration['email'] = date('ymd') . '@pagantis.com';
+        $this->configuration['phone'] = '6'.$faker->randomNumber(8);
+        $this->configuration['email'] = date('ymd').'@pagantis.com';
         parent::__construct($name, $data, $dataName);
     }
     /**
@@ -92,12 +92,12 @@ 
      */
     protected function getDNI()
     {
-        $dni = '0000' . rand(pow(10, 4-1), pow(10, 4)-1);
-        $value = (int) ($dni / 23);
+        $dni = '0000'.rand(pow(10, 4 - 1), pow(10, 4) - 1);
+        $value = (int)($dni / 23);
         $value *= 23;
-        $value= $dni - $value;
-        $letter= "TRWAGMYFPDXBNJZSQVHLCKEO";
-        $dniLetter= substr($letter, $value, 1);
+        $value = $dni - $value;
+        $letter = "TRWAGMYFPDXBNJZSQVHLCKEO";
+        $dniLetter = substr($letter, $value, 1);
         return $dni.$dniLetter;
     }
 

test/Buy/AbstractBuy.php

Spacing +5 added lines, -5 removed lines

@@ -96,7 +96,7 @@ 
         sleep(3);
         $productLinkElement->click();
         $this->assertSame(
-            self::PRODUCT_NAME . ', ' . self::TITLE,
+            self::PRODUCT_NAME.', '.self::TITLE,
             $this->webDriver->getTitle()
         );
     }
@@ -121,7 +121,7 @@ 
         );
 
         $this->assertTrue(
-            (bool) WebDriverExpectedCondition::visibilityOfElementLocated($reviewStepSearch)
+            (bool)WebDriverExpectedCondition::visibilityOfElementLocated($reviewStepSearch)
         );
     }
 
@@ -140,7 +140,7 @@ 
             WebDriverExpectedCondition::visibilityOfElementLocated($checkoutStepPaymentMethodSearch)
         );
         $this->assertTrue(
-            (bool) WebDriverExpectedCondition::visibilityOfElementLocated($checkoutStepPaymentMethodSearch)
+            (bool)WebDriverExpectedCondition::visibilityOfElementLocated($checkoutStepPaymentMethodSearch)
         );
     }
 
@@ -190,9 +190,9 @@ 
         $paymentFormElement = WebDriverBy::className('FieldsPreview-desc');
         $condition = WebDriverExpectedCondition::visibilityOfElementLocated($paymentFormElement);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool) $condition);
+        $this->assertTrue((bool)$condition);
         $this->assertSame(
-            $this->configuration['firstname'] . ' ' . $this->configuration['lastname'],
+            $this->configuration['firstname'].' '.$this->configuration['lastname'],
             $this->findByClass('FieldsPreview-desc')->getText()
         );
     }

test/Buy/BuyRegisteredTest.php

Spacing +4 added lines, -4 removed lines

@@ -75,7 +75,7 @@ 
         $checkoutStepShippingMethodSearch = WebDriverBy::id('checkout-shipping-method-load');
         $condition = WebDriverExpectedCondition::visibilityOfElementLocated($checkoutStepShippingMethodSearch);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool) $condition);
+        $this->assertTrue((bool)$condition);
     }
 
     /**
@@ -90,7 +90,7 @@ 
         $billingAddressSelector = WebDriverBy::id('billing-address-select');
         $condition = WebDriverExpectedCondition::visibilityOfElementLocated($billingAddressSelector);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool) $condition);
+        $this->assertTrue((bool)$condition);
     }
 
     /**
@@ -152,7 +152,7 @@ 
      */
     protected function checkPagantisOrderId()
     {
-        $orderId=0;
+        $orderId = 0;
         $notifyUrl = self::OSCURL.self::NOTIFICATION_FOLDER.'?order='.$orderId;
         $this->assertNotEmpty($notifyUrl, $notifyUrl);
         $response = Request::post($notifyUrl)->expects('json')->send();
@@ -162,7 +162,7 @@ 
         $this->assertEquals(
             $response->body->merchant_order_id,
             $orderId,
-            $response->body->merchant_order_id.'!='. $orderId
+            $response->body->merchant_order_id.'!='.$orderId
         );
         $this->assertContains(
             NoIdentificationException::ERROR_MESSAGE,

test/Buy/CancelBuyRegisteredTest.php

Spacing +2 added lines, -2 removed lines

@@ -39,7 +39,7 @@ 
         $checkoutStepShippingMethodSearch = WebDriverBy::id('checkout-shipping-method-load');
         $condition = WebDriverExpectedCondition::visibilityOfElementLocated($checkoutStepShippingMethodSearch);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool) $condition);
+        $this->assertTrue((bool)$condition);
     }
 
     /**
@@ -54,7 +54,7 @@ 
         $billingAddressSelector = WebDriverBy::id('billing-address-select');
         $condition = WebDriverExpectedCondition::visibilityOfElementLocated($billingAddressSelector);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool) $condition);
+        $this->assertTrue((bool)$condition);
     }
 
     /**