pagantis / oscommerce

test/basic/BasicTest.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
         $this->webDriver->get(self::OSCURL);
         $condition = WebDriverExpectedCondition::titleContains(self::TITLE);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool) $condition);
+        $this->assertTrue((bool)$condition);
         $this->quit();
     }
 
@@ -42,7 +42,7 @@ 
         $this->webDriver->get(self::OSCURL_BACKOFFICE);
         $condition = WebDriverExpectedCondition::titleContains(self::ADMIN_TITLE);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool) $condition);
+        $this->assertTrue((bool)$condition);
         $this->quit();
     }
 }
\ No newline at end of file

catalog/includes/modules/payment/pagantis.php

Spacing +54 added lines, -54 removed lines

@@ -75,8 +75,8 @@ 
 
         if (strpos($_SERVER[REQUEST_URI], "checkout_payment.php") <= 0) {
             $this->title = MODULE_PAYMENT_PAGANTIS_TEXT_ADMIN_TITLE; // Payment module title in Admin
-        } else {
-            $this->title = MODULE_PAYMENT_PAGANTIS_TEXT_CHECKOUT .'<br/><br/><div class="buttonSet" style="display:none"></div><br/>'; // Payment module title in Catalog
+        }else {
+            $this->title = MODULE_PAYMENT_PAGANTIS_TEXT_CHECKOUT.'<br/><br/><div class="buttonSet" style="display:none"></div><br/>'; // Payment module title in Catalog
         }
 
         if (defined('MODULE_PAYMENT_PAGANTIS_LANG_CODE')) {
@@ -92,12 +92,12 @@ 
                 "%s://%s%s%s",
                 isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off' ? 'https' : 'http',
                 $_SERVER['SERVER_NAME'],
-                isset($_SERVER['SERVER_PORT']) ? ":" . $_SERVER['SERVER_PORT'] : '',
+                isset($_SERVER['SERVER_PORT']) ? ":".$_SERVER['SERVER_PORT'] : '',
                 $_SERVER['REQUEST_URI']
             )
         );
 
-        $this->form_action_url = $this->base_url . '/ext/modules/payment/pagantis/bypass.php';
+        $this->form_action_url = $this->base_url.'/ext/modules/payment/pagantis/bypass.php';
 
         if (defined('MODULE_PAYMENT_PAGANTIS_ERROR_MESSAGE')) {
             $this->errorMessage = strtoupper(MODULE_PAYMENT_PAGANTIS_ERROR_MESSAGE);
@@ -211,12 +211,12 @@ 
             $national_id = $this->getNationalId();
             $tax_id = $this->getTaxId();
 
-            $fullName = $order->billing['firstname'] . ' ' . $order->billing['lastname'];
+            $fullName = $order->billing['firstname'].' '.$order->billing['lastname'];
             if ($fullName == ' ') {
-                $fullName = $order->customer['firstname'] . ' ' . $order->customer['lastname'];
+                $fullName = $order->customer['firstname'].' '.$order->customer['lastname'];
             }
             if ($fullName == ' ') {
-                $fullName = $order->delivery['firstname'] . ' ' . $order->delivery['lastname'];
+                $fullName = $order->delivery['firstname'].' '.$order->delivery['lastname'];
             }
             $fullName = utf8_encode($fullName);
             $userAddress = new Address();
@@ -287,7 +287,7 @@ 
                     ->setQuantity(intval($item['qty']))
                     ->setDescription($item['name']);
                 if ($promotedProduct) {
-                    $promotedAmount+=$product->getAmount();
+                    $promotedAmount += $product->getAmount();
                     $promotedMessage = $product->getDescription()."-Price:".$item['final_price']."-Qty:".$product->getQuantity();
                     $metadataOrder->addMetadata('promotedProduct', $promotedMessage);
                 }
@@ -307,9 +307,9 @@ 
             );
 
             $cancelUrl = trim(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL', false));
-            if ($this->extraConfig['PAGANTIS_URL_KO']!='') {
+            if ($this->extraConfig['PAGANTIS_URL_KO'] != '') {
                 $koUrl = $this->extraConfig['PAGANTIS_URL_KO'];
-            } else {
+            }else {
                 $koUrl = $cancelUrl;
             }
 
@@ -347,25 +347,25 @@ 
             if ($pagantisOrder instanceof \Pagantis\OrdersApiClient\Model\Order) {
                 $url = $pagantisOrder->getActionUrls()->getForm();
                 $this->insertRow($this->os_order_reference, $pagantisOrder->getId(), serialize($global_vars));
-            } else {
+            }else {
                 throw new OrderNotFoundException();
             }
 
             if ($url == "") {
                 throw new UnknownException(_("No ha sido posible obtener una respuesta de Pagantis"));
-            } else {
+            }else {
                 $output = "\n";
-                $output .= tep_draw_hidden_field("formUrl", $url) . "\n";
-                $output .= tep_draw_hidden_field("cancelUrl", $cancelUrl) . "\n";
+                $output .= tep_draw_hidden_field("formUrl", $url)."\n";
+                $output .= tep_draw_hidden_field("cancelUrl", $cancelUrl)."\n";
                 return $output;
 
             } //TODO IFRAME
         } catch (\Exception $exception) {
             $this->insertLog($exception);
             $output = "\n";
-            $output .= tep_draw_hidden_field("cancelUrl", $cancelUrl) . "\n";
-            $output .= tep_draw_hidden_field("errorMessage", $exception->getMessage()) . "\n";
-            $output .= tep_draw_hidden_field("errorCode", $exception->getCode()) . "\n";
+            $output .= tep_draw_hidden_field("cancelUrl", $cancelUrl)."\n";
+            $output .= tep_draw_hidden_field("errorMessage", $exception->getMessage())."\n";
+            $output .= tep_draw_hidden_field("errorCode", $exception->getCode())."\n";
             $output .= "<p>".$this->errorMessage.", <a href='$cancelUrl' style='text-decoration:underline'><b>";
             $output .= $this->errorLinkMessage." </b></a></p>";
 
@@ -429,7 +429,7 @@ 
             return 'failed';
         }
 
-        tep_db_query("insert into " . TABLE_CONFIGURATION . "
+        tep_db_query("insert into ".TABLE_CONFIGURATION."
         (
             configuration_title,
             configuration_key,
@@ -452,7 +452,7 @@ 
             ',
             now()
         )");
-        tep_db_query("insert into " . TABLE_CONFIGURATION . "
+        tep_db_query("insert into ".TABLE_CONFIGURATION."
         (
             configuration_title,
             configuration_key,
@@ -472,7 +472,7 @@ 
             '0',
             now()
         )");
-        tep_db_query("insert into " . TABLE_CONFIGURATION . "
+        tep_db_query("insert into ".TABLE_CONFIGURATION."
         (
             configuration_title,
             configuration_key,
@@ -492,7 +492,7 @@ 
             '0',
             now()
         )");
-        tep_db_query("insert into " . TABLE_CONFIGURATION . "
+        tep_db_query("insert into ".TABLE_CONFIGURATION."
         (
             configuration_title,
             configuration_key,
@@ -524,14 +524,14 @@ 
      */
     private function installPagantisTables()
     {
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_LOG . " ( 
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_LOG." ( 
                           id int NOT NULL AUTO_INCREMENT, 
                           log text NOT NULL, 
                           createdAt timestamp DEFAULT CURRENT_TIMESTAMP, 
                           UNIQUE KEY id (id))";
         tep_db_query($sql);
 
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_CONFIG . " (
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_CONFIG." (
                             id int NOT NULL AUTO_INCREMENT, 
                             config varchar(60) NOT NULL, 
                             value varchar(200) NOT NULL, 
@@ -539,10 +539,10 @@ 
         tep_db_query($sql);
 
         // check if table has records
-        $check_query = tep_db_query("select value from " . TABLE_PAGANTIS_CONFIG);
+        $check_query = tep_db_query("select value from ".TABLE_PAGANTIS_CONFIG);
         if (tep_db_num_rows($check_query) === 0) {
             foreach ((array)$this->defaultConfigs as $configKey => $configValue) {
-                $query = "INSERT INTO " . TABLE_PAGANTIS_CONFIG . "
+                $query = "INSERT INTO ".TABLE_PAGANTIS_CONFIG."
                 (
                     config,
                     value
@@ -556,7 +556,7 @@ 
             }
         }
 
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_ORDERS . " (
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_ORDERS." (
                             id int NOT NULL AUTO_INCREMENT, 
                             os_order_id varchar(50), 
                             os_order_reference varchar(50) NOT NULL,
@@ -565,7 +565,7 @@ 
                             UNIQUE KEY id(id))";
         tep_db_query($sql);
 
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_CONCURRENCY . " (
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_CONCURRENCY." (
                             id varchar(50) NOT NULL,
                             `timestamp` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
                             UNIQUE KEY id(id))";
@@ -577,29 +577,29 @@ 
      */
     public function remove()
     {
-        $checkTable = tep_db_query("SHOW TABLES LIKE '" . TABLE_PAGANTIS_LOG . "'");
+        $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_LOG."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_LOG);
+            tep_db_query("drop table ".TABLE_PAGANTIS_LOG);
         }
 
-        $checkTable = tep_db_query("SHOW TABLES LIKE '" . TABLE_PAGANTIS_CONFIG . "'");
+        $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_CONFIG."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_CONFIG);
+            tep_db_query("drop table ".TABLE_PAGANTIS_CONFIG);
         }
 
-        $checkTable = tep_db_query("SHOW TABLES LIKE '" . TABLE_PAGANTIS_ORDERS . "'");
+        $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_ORDERS."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_ORDERS);
+            tep_db_query("drop table ".TABLE_PAGANTIS_ORDERS);
         }
 
-        $checkTable = tep_db_query("SHOW TABLES LIKE '" . TABLE_PAGANTIS_CONCURRENCY . "'");
+        $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_CONCURRENCY."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_CONCURRENCY);
+            tep_db_query("drop table ".TABLE_PAGANTIS_CONCURRENCY);
         }
 
-        tep_db_query("DELETE FROM ". TABLE_CONFIGURATION ." where configuration_key in ('MODULE_PAYMENT_PAGANTIS_STATUS','MODULE_PAYMENT_PAGANTIS_PK','MODULE_PAYMENT_PAGANTIS_SK')");
+        tep_db_query("DELETE FROM ".TABLE_CONFIGURATION." where configuration_key in ('MODULE_PAYMENT_PAGANTIS_STATUS','MODULE_PAYMENT_PAGANTIS_PK','MODULE_PAYMENT_PAGANTIS_SK')");
 
-        $query = "delete from " . TABLE_CONFIGURATION . " where configuration_key like '%_PAGANTIS_%'";
+        $query = "delete from ".TABLE_CONFIGURATION." where configuration_key like '%_PAGANTIS_%'";
         tep_db_query($query);
 
         $this->uninstallSimulator();
@@ -654,13 +654,13 @@ 
      */
     private function insertRow($orderId, $pagantisOrderId, $globalVars)
     {
-        $query = "select * from " . TABLE_PAGANTIS_ORDERS . " where os_order_reference='$orderId'";
+        $query = "select * from ".TABLE_PAGANTIS_ORDERS." where os_order_reference='$orderId'";
         $resultsSelect = tep_db_query($query);
         $countResults = tep_db_num_rows($resultsSelect);
         if ($countResults == 0) {
-            $query = "INSERT INTO " . TABLE_PAGANTIS_ORDERS . " 
+            $query = "INSERT INTO ".TABLE_PAGANTIS_ORDERS." 
                 (os_order_reference, pagantis_order_id, globals) values ('$orderId', '$pagantisOrderId','$globalVars')";
-        } else {
+        }else {
             $query = "UPDATE ".TABLE_PAGANTIS_ORDERS." set pagantis_order_id='$pagantisOrderId' 
                         where os_order_reference='$orderId'";
         }
@@ -698,7 +698,7 @@ 
 
         if ($this->extraConfig['PAGANTIS_PROMOTION'] == '') {
             $promotedProducts = array();
-        } else {
+        }else {
             $promotedProducts = array_values((array)unserialize($this->extraConfig['PAGANTIS_PROMOTION']));
         }
 
@@ -711,17 +711,17 @@ 
     private function getDescription()
     {
         $descriptionCode = "<img src=\"images/icon_info.gif\" border=\"0\" alt=\"Info\" title=\"Info\">&nbsp;<strong>Module version:</strong> $this->version<br/><br/>";
-        $descriptionCode.= "<img src=\"images/icon_info.gif\" border=\"0\">&nbsp;<a href='https://developer.pagantis.com/' target=\"_blank\" style=\"text-decoration: underline; font-weight: bold;\">View Online Documentation</a><br/><br/>";
-        $descriptionCode.= "<img src='images/icon_popup.gif'  border='0'>        <a href='http://pagantis.com' target='_blank' style='text-decoration: underline; font-weight: bold;'>Visit Pagantis Website</a><br/><br/><br/>";
+        $descriptionCode .= "<img src=\"images/icon_info.gif\" border=\"0\">&nbsp;<a href='https://developer.pagantis.com/' target=\"_blank\" style=\"text-decoration: underline; font-weight: bold;\">View Online Documentation</a><br/><br/>";
+        $descriptionCode .= "<img src='images/icon_popup.gif'  border='0'>        <a href='http://pagantis.com' target='_blank' style='text-decoration: underline; font-weight: bold;'>Visit Pagantis Website</a><br/><br/><br/>";
 
         if (MODULE_PAYMENT_PAGANTIS_STATUS == 'True') {
             $pagantisPromotionUrl = $this->base_url.'/admin/promotion.php';
             $linkDescription = "Si deseas ofrecer financiación sin intereses para alguno de tus productos ";
-            $descriptionCode.= "<img src='images/icon_info.gif' border='0'/> $linkDescription<a href='$pagantisPromotionUrl' style='text-decoration: underline; font-weight: bold;'>haz click aquí</a>";
+            $descriptionCode .= "<img src='images/icon_info.gif' border='0'/> $linkDescription<a href='$pagantisPromotionUrl' style='text-decoration: underline; font-weight: bold;'>haz click aquí</a>";
 
             $pagantisAllowedCountriesUrl = $this->base_url.'/admin/allowedCountries.php';
             $linkDescription = "Para gestionar paises en los que operar con Pagantis ";
-            $descriptionCode.= "<br/><br/><img src='images/icon_info.gif' border='0'/> $linkDescription<a href='$pagantisAllowedCountriesUrl' style='text-decoration: underline; font-weight: bold;'>haz click aquí</a>";
+            $descriptionCode .= "<br/><br/><img src='images/icon_info.gif' border='0'/> $linkDescription<a href='$pagantisAllowedCountriesUrl' style='text-decoration: underline; font-weight: bold;'>haz click aquí</a>";
         }
 
         return $descriptionCode;
@@ -732,18 +732,18 @@ 
      */
     private function installSimulator()
     {
-        $checkSimulator = tep_db_query("select configuration_key, configuration_value from " .TABLE_CONFIGURATION ." 
+        $checkSimulator = tep_db_query("select configuration_key, configuration_value from ".TABLE_CONFIGURATION." 
                                     where configuration_key like 'MODULE_HEADER_TAGS_INSTALLED'
                                     and configuration_value like '%ht_pagantis.php%';");
         if (tep_db_num_rows($checkSimulator) > 0) {
             return true;
         }
 
-        $query = "UPDATE " . TABLE_CONFIGURATION . " set configuration_value = concat(configuration_value, ';ht_pagantis.php')
+        $query = "UPDATE ".TABLE_CONFIGURATION." set configuration_value = concat(configuration_value, ';ht_pagantis.php')
                         where configuration_key like 'MODULE_HEADER_TAGS_INSTALLED'";
         tep_db_query($query);
 
-        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Enable Pagantis Module', 'MODULE_HEADER_TAGS_PAGANTIS_STATUS', 'True', '', '6', '1', 'tep_cfg_select_option(array(\'True\', \'False\'), ', now())");
+        tep_db_query("insert into ".TABLE_CONFIGURATION." (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Enable Pagantis Module', 'MODULE_HEADER_TAGS_PAGANTIS_STATUS', 'True', '', '6', '1', 'tep_cfg_select_option(array(\'True\', \'False\'), ', now())");
     }
 
     /**
@@ -751,18 +751,18 @@ 
      */
     private function uninstallSimulator()
     {
-        $checkSimulator = tep_db_query("select configuration_key, configuration_value from " .TABLE_CONFIGURATION ." 
+        $checkSimulator = tep_db_query("select configuration_key, configuration_value from ".TABLE_CONFIGURATION." 
                                     where configuration_key like 'MODULE_HEADER_TAGS_INSTALLED'
                                     and configuration_value like '%ht_pagantis.php%';");
         if (tep_db_num_rows($checkSimulator) == 0) {
             return true;
         }
 
-        $query = "UPDATE " . TABLE_CONFIGURATION . " set configuration_value = REPLACE(configuration_value, ';ht_pagantis.php', '')
+        $query = "UPDATE ".TABLE_CONFIGURATION." set configuration_value = REPLACE(configuration_value, ';ht_pagantis.php', '')
                         where configuration_key like 'MODULE_HEADER_TAGS_INSTALLED'";
         tep_db_query($query);
 
-        $query = "delete from " . TABLE_CONFIGURATION . " where configuration_key = 'MODULE_HEADER_TAGS_PAGANTIS_STATUS'";
+        $query = "delete from ".TABLE_CONFIGURATION." where configuration_key = 'MODULE_HEADER_TAGS_PAGANTIS_STATUS'";
         tep_db_query($query);
     }
 
@@ -772,7 +772,7 @@ 
     private function insertLog($exception)
     {
         if ($exception instanceof \Exception) {
-            $logEntry= new LogEntry();
+            $logEntry = new LogEntry();
             $logEntryJson = $logEntry->error($exception)->toJson();
             $logEntryJson = addslashes($logEntryJson);
 
@@ -791,7 +791,7 @@ 
             return $order->customer['national_id'];
         } elseif (isset($order->billing['piva'])) {
             return $order->billing['piva'];
-        } else {
+        }else {
             return null;
         }
     }
@@ -806,7 +806,7 @@ 
             return $order->customer['tax_id'];
         } elseif (isset($order->billing['cf'])) {
             return $order->billing['cf'];
-        } else {
+        }else {
             return null;
         }
     }

catalog/ext/modules/payment/pagantis/notifyController.php

Spacing +25 added lines, -25 removed lines

@@ -86,22 +86,22 @@ 
             $jsonResponse->setException($exception);
             $this->insertLog($exception);
 
-            if ($this->extraConfig['PAGANTIS_URL_KO'] =! '') {
+            if ($this->extraConfig['PAGANTIS_URL_KO'] = !'') {
                 $koUrl = $this->extraConfig['PAGANTIS_URL_KO'];
-            } else {
+            }else {
                 $koUrl = trim(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL', false));
             }
 
             if ($this->origin == 'notify') {
                 $jsonResponse->printResponse();
-            } else {
+            }else {
                 if ($exception->getMessage() == AlreadyProcessedException::ERROR_MESSAGE) {
-                    if ($this->extraConfig['PAGANTIS_URL_OK']!='') {
+                    if ($this->extraConfig['PAGANTIS_URL_OK'] != '') {
                         $confirmationUrl = $this->extraConfig['PAGANTIS_URL_OK'];
-                        $confirmationUrl.="?order_id=$this->merchantOrderId";
-                    } else {
+                        $confirmationUrl .= "?order_id=$this->merchantOrderId";
+                    }else {
                         $confirmationUrl = trim(tep_href_link(FILENAME_ACCOUNT_HISTORY_INFO, '', 'SSL', false));
-                        $confirmationUrl.="?order_id=$this->merchantOrderId";
+                        $confirmationUrl .= "?order_id=$this->merchantOrderId";
                     }
 
                     header("Location: $confirmationUrl");
@@ -136,7 +136,7 @@ 
 
         if ($this->origin == 'notify') {
             $jsonResponse->printResponse();
-        } else {
+        }else {
             return $jsonResponse;
         }
     }
@@ -213,12 +213,12 @@ 
         try {
             $this->checkPagantisStatus(array('AUTHORIZED'));
         } catch (\Exception $e) {
-            if ($this->findOscommerceOrderId()!='') {
+            if ($this->findOscommerceOrderId() != '') {
                 throw new AlreadyProcessedException();
-            } else {
+            }else {
                 if ($this->pagantisOrder instanceof \Pagantis\OrdersApiClient\Model\Order) {
                     $status = $this->pagantisOrder->getStatus();
-                } else {
+                }else {
                     $status = '-';
                 }
                 throw new WrongStatusException($status);
@@ -233,7 +233,7 @@ 
     {
         global $order;
 
-        if ($order->info['order_status']!=='1') {
+        if ($order->info['order_status'] !== '1') {
             throw new AlreadyProcessedException();
         }
     }
@@ -264,7 +264,7 @@ 
             $this->pagantisOrder = $this->orderClient->getOrder($this->pagantisOrderId);
             if ($this->pagantisOrder->getStatus() !== Order::STATUS_CONFIRMED) {
                 throw new UnknownException($e->getMessage());
-            } else {
+            }else {
                 $logMessage = 'Concurrency issue: Order_id '.$this->pagantisOrderId.' was confirmed by other process';
                 $this->insertLog(null, $logMessage);
             }
@@ -322,7 +322,7 @@ 
                     self::CONCURRENCY_TIMEOUT
                 );
                 tep_db_query($query);
-            } elseif ($orderId!='') {
+            } elseif ($orderId != '') {
                 $query = "delete from ".TABLE_PAGANTIS_CONCURRENCY." where id='$orderId'";
                 tep_db_query($query);
             }
@@ -343,7 +343,7 @@ 
             if (isset($orderRow['timestamp'])) {
                 if ($this->origin == 'notify') {
                     throw new ConcurrencyException();
-                } else {
+                }else {
                     $query = sprintf(
                         "SELECT TIMESTAMPDIFF(SECOND,NOW()-INTERVAL %s SECOND, timestamp) as rest FROM %s %s",
                         self::CONCURRENCY_TIMEOUT,
@@ -353,7 +353,7 @@ 
                     $resultsSelect = tep_db_query($query);
                     $resultsArray = tep_db_fetch_array($resultsSelect);
                     $restSeconds = isset($resultsArray['rest']) ? ($resultsArray['rest']) : 0;
-                    $expirationSec = ($restSeconds>self::CONCURRENCY_TIMEOUT)? self::CONCURRENCY_TIMEOUT : $restSeconds;
+                    $expirationSec = ($restSeconds > self::CONCURRENCY_TIMEOUT) ? self::CONCURRENCY_TIMEOUT : $restSeconds;
                     if ($expirationSec > 0) {
                         sleep($expirationSec + 1);
                     }
@@ -368,8 +368,8 @@ 
                     $os_order_id = tep_db_fetch_array($resultsSelect);
                     if (isset($os_order_id['os_order_id'])) {
                         $redirectUrl = trim(tep_href_link(FILENAME_ACCOUNT_HISTORY_INFO, '', 'SSL', false));
-                        $redirectUrl.="?order_id=$this->oscommerceOrderId";
-                    } else {
+                        $redirectUrl .= "?order_id=$this->oscommerceOrderId";
+                    }else {
                         $redirectUrl = trim(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL', false));
                     }
 
@@ -385,7 +385,7 @@ 
                     header("Location: $redirectUrl");
                     exit;
                 }
-            } else {
+            }else {
                 $query = "INSERT INTO ".TABLE_PAGANTIS_CONCURRENCY." (id) VALUES ('$this->oscommerceOrderId');";
                 tep_db_query($query);
             }
@@ -415,12 +415,12 @@ 
             if (!$payed) {
                 if ($this->pagantisOrder instanceof \Pagantis\OrdersApiClient\Model\Order) {
                     $status = $this->pagantisOrder->getStatus();
-                } else {
+                }else {
                     $status = '-';
                 }
                 throw new WrongStatusException($status);
             }
-        } else {
+        }else {
             throw new OrderNotFoundException();
         }
     }
@@ -466,12 +466,12 @@ 
         $metadataInfo = '';
         foreach ($metadataOrder as $metadataKey => $metadataValue) {
             if ($metadataKey == 'promotedProduct') {
-                $metadataInfo.= "/Producto promocionado = $metadataValue";
+                $metadataInfo .= "/Producto promocionado = $metadataValue";
             }
         }
 
         $comment = "Pagantis id=$this->pagantisOrderId/Via=".ucfirst($this->origin)."/".$metadataInfo;
-        $query = "insert into ".TABLE_ORDERS_STATUS_HISTORY ."(comments, orders_id, orders_status_id, customer_notified,
+        $query = "insert into ".TABLE_ORDERS_STATUS_HISTORY."(comments, orders_id, orders_status_id, customer_notified,
         date_added) values ('$comment', ".$insert_id.", '2', -1, now() )";
         tep_db_query($query);
 
@@ -501,10 +501,10 @@ 
      */
     private function insertLog($exception = null, $message = null)
     {
-        $logEntry= new LogEntry();
+        $logEntry = new LogEntry();
         if ($exception instanceof \Exception) {
             $logEntryJson = $logEntry->error($exception)->toJson();
-        } else {
+        }else {
             $logEntryJson = $logEntry->info($message)->toJson();
         }
             $query = "insert into ".TABLE_PAGANTIS_LOG."(log) values ('$logEntryJson')";

catalog/includes/modules/header_tags/ht_pagantis.php

Spacing +114 added lines, -114 removed lines

@@ -35,7 +35,7 @@ 
         ) {
             $this->enabled = ((MODULE_HEADER_TAGS_PAGANTIS_STATUS == 'True') &&
                 (MODULE_PAYMENT_PAGANTIS_STATUS == 'True') &&
-                (MODULE_PAYMENT_PAGANTIS_SIMULATOR == 'True')) ;
+                (MODULE_PAYMENT_PAGANTIS_SIMULATOR == 'True'));
         }
 
         $this->extraConfig = $this->getExtraConfig();
@@ -71,7 +71,7 @@ 
      */
     private function getConfig($config = '')
     {
-        $query       = "select * from ".TABLE_CONFIGURATION . " where configuration_key ='" . $config . "'";
+        $query       = "select * from ".TABLE_CONFIGURATION." where configuration_key ='".$config."'";
         $result      = tep_db_query($query);
         $resultArray = tep_db_fetch_array($result);
         return $resultArray['configuration_value'];
@@ -82,7 +82,7 @@ 
      */
     private function getProductPrice()
     {
-        $query       = "select products_price from products where products_id ='" . urlencode($_GET['products_id']) . "'";
+        $query       = "select products_price from products where products_id ='".urlencode($_GET['products_id'])."'";
         $result      = tep_db_query($query);
         $resultArray = tep_db_fetch_array($result);
         return (int)$resultArray['products_price'];
@@ -99,40 +99,40 @@ 
         $productId = $GLOBALS["HTTP_GET_VARS"]["products_id"];
         $checkoutPage = strpos($_SERVER[REQUEST_URI], "checkout_payment.php") > 0;
 
-        if (isset($productId) && $checkoutPage!='1') {
+        if (isset($productId) && $checkoutPage != '1') {
             $productPrice = $this->getProductPrice();
             $pagantisDisplayMinAmount = $this->extraConfig['PAGANTIS_DISPLAY_MIN_AMOUNT'];
             $pagantisDisplayMaxAmount = $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_MAX_AMOUNT'];
-            if (($productPrice > (int)$pagantisDisplayMaxAmount  && (int)$pagantisDisplayMaxAmount != '0') ||
+            if (($productPrice > (int)$pagantisDisplayMaxAmount && (int)$pagantisDisplayMaxAmount != '0') ||
                 $productPrice < (int)$pagantisDisplayMinAmount) {
                 return false;
             }
         }
         //Show promoted html
-        if ($this->isPromoted($productId) && $checkoutPage!='1') {
+        if ($this->isPromoted($productId) && $checkoutPage != '1') {
             echo "<style> #promotedText{margin-left: 10%;} .pmt-no-interest{color: #00c1d5 }</style>";
             echo "<div id='promotedText' style='display:none'><br/>".$this->extraConfig['PAGANTIS_PROMOTED_PRODUCT_CODE']."</div>";
-            echo '<script>'. PHP_EOL;
-            echo '        function loadPromoted()'. PHP_EOL;
-            echo '        {'. PHP_EOL;
-            echo 'var positionSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR']. '\';'. PHP_EOL;
-            echo 'if (positionSelector === \'default\') {'. PHP_EOL;
-            echo 'positionSelector = \'.buttonSet\''. PHP_EOL;
-            echo '}'. PHP_EOL;
+            echo '<script>'.PHP_EOL;
+            echo '        function loadPromoted()'.PHP_EOL;
+            echo '        {'.PHP_EOL;
+            echo 'var positionSelector = \''.$this->extraConfig['PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'].'\';'.PHP_EOL;
+            echo 'if (positionSelector === \'default\') {'.PHP_EOL;
+            echo 'positionSelector = \'.buttonSet\''.PHP_EOL;
+            echo '}'.PHP_EOL;
             echo 'var docFather = document.querySelector(positionSelector);'.PHP_EOL;
-            echo 'if (typeof docFather != \'undefined\') {'. PHP_EOL;
+            echo 'if (typeof docFather != \'undefined\') {'.PHP_EOL;
             echo 'var promotedNode = document.getElementById("promotedText");'.PHP_EOL;
             echo 'docFather.appendChild(promotedNode);'.PHP_EOL;
-            echo 'promotedNode.style.display=""' . PHP_EOL;
-            echo '               clearInterval(window.OSPromotedId);'. PHP_EOL;
-            echo '               return true;'. PHP_EOL;
-            echo '       }'. PHP_EOL;
-            echo '               return false;'. PHP_EOL;
-            echo '       }'. PHP_EOL;
-            echo '       window.OSPromotedId = setInterval(function () {'. PHP_EOL;
-            echo '          loadPromoted();'. PHP_EOL;
-            echo '       }, 2000);'. PHP_EOL;
-            echo '</script>'. PHP_EOL;
+            echo 'promotedNode.style.display=""'.PHP_EOL;
+            echo '               clearInterval(window.OSPromotedId);'.PHP_EOL;
+            echo '               return true;'.PHP_EOL;
+            echo '       }'.PHP_EOL;
+            echo '               return false;'.PHP_EOL;
+            echo '       }'.PHP_EOL;
+            echo '       window.OSPromotedId = setInterval(function () {'.PHP_EOL;
+            echo '          loadPromoted();'.PHP_EOL;
+            echo '       }, 2000);'.PHP_EOL;
+            echo '</script>'.PHP_EOL;
         }
 
         if (isset($productId) || $checkoutPage) {
@@ -145,111 +145,111 @@ 
                 $productId = array_shift($productId);
                 $promotedProduct = $this->isPromoted($productId);
                 if ($promotedProduct) {
-                    $promotedAmount+=number_format(($item['price'] * $item['qty']), 2);
+                    $promotedAmount += number_format(($item['price'] * $item['qty']), 2);
                 }
             }
 
-            echo "<script src='".$this->sdkFile."'></script>". PHP_EOL;
-            echo '<style>#bodyContent>form>div>iframe {float: right; width: 280px !important; margin-right: -90px;} .contentContainer {clear: both;}</style>'. PHP_EOL;
-            echo '<script>'. PHP_EOL;
-            echo '        function loadSimulator()'. PHP_EOL;
-            echo '        {'. PHP_EOL;
-            echo '           if (typeof '.$simulatorCode.' != \'undefined\') {'. PHP_EOL;
-            echo '               var sdk = '.$simulatorCode.';'. PHP_EOL;
-            echo '               var positionSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR']. '\';'. PHP_EOL;
-            echo '               var priceSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR']. '\';'. PHP_EOL;
-            echo '               var checkoutPriceSelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR']. '\';'. PHP_EOL;
-            echo '               var quantitySelector = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR']. '\';'. PHP_EOL;
-            echo '               var checkoutPage =     \'' . $checkoutPage.'\';'. PHP_EOL;
-            echo '               var promotedAmount =     \'' . $promotedAmount.'\';'. PHP_EOL;
-            echo '               var langCode =     \'' . $this->langCode.'\';'. PHP_EOL;
-
-            echo '               if (positionSelector === \'default\') {'. PHP_EOL;
-            echo '                   positionSelector = \'#bodyContent>form>div\''. PHP_EOL;
-            echo '               }'. PHP_EOL;
-
-            echo '               if (priceSelector === \'default\') {'. PHP_EOL;
-            echo '                   priceSelector = \'#bodyContent>form>div>h1:first-child\''. PHP_EOL;
-            echo '               }'. PHP_EOL;
-
-            echo '               if (checkoutPriceSelector == \'default\' && checkoutPage == \'1\')  {'. PHP_EOL;
-            echo '                   priceSelector = \'#columnRight > .infoBoxContainer > .infoBoxContents > tbody > tr:last-child > td\';'. PHP_EOL;
-            echo '               }'. PHP_EOL;
-
-            echo '               product_simulator = {};'. PHP_EOL;
-            echo '               product_simulator.locale = \'' . strtolower($this->langCode) . '\';'. PHP_EOL;
-            echo '               product_simulator.country = \'' . strtolower($this->langCode) . '\';'. PHP_EOL;
-            echo '               product_simulator.publicKey = \'' . $this->pk . '\';'. PHP_EOL;
-            echo '               product_simulator.selector = positionSelector;'. PHP_EOL;
-            echo '               product_simulator.numInstalments = \'' . $this->extraConfig['PAGANTIS_SIMULATOR_START_INSTALLMENTS'] . '\';'. PHP_EOL;
-            echo '               product_simulator.type = ' . $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_TYPE'] . ';'. PHP_EOL;
-            echo '               product_simulator.skin = ' . $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_SKIN'] . ';'. PHP_EOL;
-            echo '               product_simulator.position = ' . $this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'] . ';'. PHP_EOL;
-            echo '               product_simulator.amountParserConfig = {};'. PHP_EOL;
-            echo '               product_simulator.amountParserConfig.thousandSeparator = "' . $this->extraConfig['PAGANTIS_SIMULATOR_THOUSANDS_SEPARATOR'] . '";'. PHP_EOL;
-            echo '               product_simulator.amountParserConfig.decimalSeparator = "' . $this->extraConfig['PAGANTIS_SIMULATOR_DECIMAL_SEPARATOR'] .  '";'. PHP_EOL;
+            echo "<script src='".$this->sdkFile."'></script>".PHP_EOL;
+            echo '<style>#bodyContent>form>div>iframe {float: right; width: 280px !important; margin-right: -90px;} .contentContainer {clear: both;}</style>'.PHP_EOL;
+            echo '<script>'.PHP_EOL;
+            echo '        function loadSimulator()'.PHP_EOL;
+            echo '        {'.PHP_EOL;
+            echo '           if (typeof '.$simulatorCode.' != \'undefined\') {'.PHP_EOL;
+            echo '               var sdk = '.$simulatorCode.';'.PHP_EOL;
+            echo '               var positionSelector = \''.$this->extraConfig['PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'].'\';'.PHP_EOL;
+            echo '               var priceSelector = \''.$this->extraConfig['PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'].'\';'.PHP_EOL;
+            echo '               var checkoutPriceSelector = \''.$this->extraConfig['PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'].'\';'.PHP_EOL;
+            echo '               var quantitySelector = \''.$this->extraConfig['PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR'].'\';'.PHP_EOL;
+            echo '               var checkoutPage =     \''.$checkoutPage.'\';'.PHP_EOL;
+            echo '               var promotedAmount =     \''.$promotedAmount.'\';'.PHP_EOL;
+            echo '               var langCode =     \''.$this->langCode.'\';'.PHP_EOL;
+
+            echo '               if (positionSelector === \'default\') {'.PHP_EOL;
+            echo '                   positionSelector = \'#bodyContent>form>div\''.PHP_EOL;
+            echo '               }'.PHP_EOL;
+
+            echo '               if (priceSelector === \'default\') {'.PHP_EOL;
+            echo '                   priceSelector = \'#bodyContent>form>div>h1:first-child\''.PHP_EOL;
+            echo '               }'.PHP_EOL;
+
+            echo '               if (checkoutPriceSelector == \'default\' && checkoutPage == \'1\')  {'.PHP_EOL;
+            echo '                   priceSelector = \'#columnRight > .infoBoxContainer > .infoBoxContents > tbody > tr:last-child > td\';'.PHP_EOL;
+            echo '               }'.PHP_EOL;
+
+            echo '               product_simulator = {};'.PHP_EOL;
+            echo '               product_simulator.locale = \''.strtolower($this->langCode).'\';'.PHP_EOL;
+            echo '               product_simulator.country = \''.strtolower($this->langCode).'\';'.PHP_EOL;
+            echo '               product_simulator.publicKey = \''.$this->pk.'\';'.PHP_EOL;
+            echo '               product_simulator.selector = positionSelector;'.PHP_EOL;
+            echo '               product_simulator.numInstalments = \''.$this->extraConfig['PAGANTIS_SIMULATOR_START_INSTALLMENTS'].'\';'.PHP_EOL;
+            echo '               product_simulator.type = '.$this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_TYPE'].';'.PHP_EOL;
+            echo '               product_simulator.skin = '.$this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_SKIN'].';'.PHP_EOL;
+            echo '               product_simulator.position = '.$this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'].';'.PHP_EOL;
+            echo '               product_simulator.amountParserConfig = {};'.PHP_EOL;
+            echo '               product_simulator.amountParserConfig.thousandSeparator = "'.$this->extraConfig['PAGANTIS_SIMULATOR_THOUSANDS_SEPARATOR'].'";'.PHP_EOL;
+            echo '               product_simulator.amountParserConfig.decimalSeparator = "'.$this->extraConfig['PAGANTIS_SIMULATOR_DECIMAL_SEPARATOR'].'";'.PHP_EOL;
 
             //Amount in product page
-            echo '               var promotedProduct = \'' . $this->isPromoted($productId) .'\';'. PHP_EOL;
-            echo '               if(checkoutPage != \'1\' ) {'. PHP_EOL;
-            echo '               product_simulator.itemAmountSelector = priceSelector;'. PHP_EOL;
-            echo '                   if(promotedProduct == \'1\') { ' . PHP_EOL;
-            echo '                    product_simulator.itemPromotedAmountSelector = priceSelector;'. PHP_EOL;
-            echo '                   }' . PHP_EOL;
+            echo '               var promotedProduct = \''.$this->isPromoted($productId).'\';'.PHP_EOL;
+            echo '               if(checkoutPage != \'1\' ) {'.PHP_EOL;
+            echo '               product_simulator.itemAmountSelector = priceSelector;'.PHP_EOL;
+            echo '                   if(promotedProduct == \'1\') { '.PHP_EOL;
+            echo '                    product_simulator.itemPromotedAmountSelector = priceSelector;'.PHP_EOL;
+            echo '                   }'.PHP_EOL;
             echo '               }';
 
             //Amount in checkout page
-            echo '               if(checkoutPage == \'1\' ) { ' . PHP_EOL;
-            echo '                  product_simulator.totalAmountSelector = priceSelector;'. PHP_EOL;
-            echo '                  if(promotedAmount != \'0\' && checkoutPage == \'1\' ) { ' . PHP_EOL;
-            echo '                      product_simulator.totalPromotedAmount = promotedAmount;'. PHP_EOL;
-            echo '                  }' . PHP_EOL;
-            echo '                  product_simulator.selector = \'.buttonSet\';' . PHP_EOL;
-            echo '                  product_simulator.type = ' .$this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_TYPE_CHECKOUT'] . PHP_EOL;
-            echo '               }' . PHP_EOL;
-            echo '               sdk.simulator.init(product_simulator);'. PHP_EOL;
-            echo '               clearInterval(window.OSSimulatorId);'. PHP_EOL;
-            echo '               return true;'. PHP_EOL;
-            echo '           }'. PHP_EOL;
-            echo '           return false;'. PHP_EOL;
-            echo '       }'. PHP_EOL;
+            echo '               if(checkoutPage == \'1\' ) { '.PHP_EOL;
+            echo '                  product_simulator.totalAmountSelector = priceSelector;'.PHP_EOL;
+            echo '                  if(promotedAmount != \'0\' && checkoutPage == \'1\' ) { '.PHP_EOL;
+            echo '                      product_simulator.totalPromotedAmount = promotedAmount;'.PHP_EOL;
+            echo '                  }'.PHP_EOL;
+            echo '                  product_simulator.selector = \'.buttonSet\';'.PHP_EOL;
+            echo '                  product_simulator.type = '.$this->extraConfig['PAGANTIS_SIMULATOR_DISPLAY_TYPE_CHECKOUT'].PHP_EOL;
+            echo '               }'.PHP_EOL;
+            echo '               sdk.simulator.init(product_simulator);'.PHP_EOL;
+            echo '               clearInterval(window.OSSimulatorId);'.PHP_EOL;
+            echo '               return true;'.PHP_EOL;
+            echo '           }'.PHP_EOL;
+            echo '           return false;'.PHP_EOL;
+            echo '       }'.PHP_EOL;
 
             //Invoke to main method
-            echo '       window.OSSimulatorId = setInterval(function () {'. PHP_EOL;
-            echo '          loadSimulator();'. PHP_EOL;
-            echo '       }, 2500);'. PHP_EOL;
-            echo '</script>'. PHP_EOL;
+            echo '       window.OSSimulatorId = setInterval(function () {'.PHP_EOL;
+            echo '          loadSimulator();'.PHP_EOL;
+            echo '       }, 2500);'.PHP_EOL;
+            echo '</script>'.PHP_EOL;
 
             //Checkout simulator
             if ($checkoutPage) {
-                echo '<script>' . PHP_EOL;
-
-                echo 'function checkSelected(value)'. PHP_EOL;
-                echo '{ '. PHP_EOL;
-                echo 'var simulator = document.getElementsByClassName("buttonSet");'  . PHP_EOL;
-                echo ' if(simulator == "undefined") { return false;  } '. PHP_EOL;
-                echo 'var pagantisCheckbox = document.querySelector("input[value=\'pagantis\']"); ' . PHP_EOL;
-                echo 'var grandparentNode = pagantisCheckbox.parentNode.parentNode;' . PHP_EOL;
-                echo 'if(grandparentNode == value) { var status="" } ' . PHP_EOL;
-                echo 'else { var status="none";} '. PHP_EOL;
-                echo 'simulator[0].style.display=status; ' . PHP_EOL;
-                echo '}'. PHP_EOL;
-
-                echo 'function showSimulator()'. PHP_EOL;
-                echo '{'. PHP_EOL;
-                echo 'var elements = document.querySelectorAll("tr[class^=\'moduleRow\']");' . PHP_EOL;
-                echo 'if(elements == null) { return false };' . PHP_EOL;
+                echo '<script>'.PHP_EOL;
+
+                echo 'function checkSelected(value)'.PHP_EOL;
+                echo '{ '.PHP_EOL;
+                echo 'var simulator = document.getElementsByClassName("buttonSet");'.PHP_EOL;
+                echo ' if(simulator == "undefined") { return false;  } '.PHP_EOL;
+                echo 'var pagantisCheckbox = document.querySelector("input[value=\'pagantis\']"); '.PHP_EOL;
+                echo 'var grandparentNode = pagantisCheckbox.parentNode.parentNode;'.PHP_EOL;
+                echo 'if(grandparentNode == value) { var status="" } '.PHP_EOL;
+                echo 'else { var status="none";} '.PHP_EOL;
+                echo 'simulator[0].style.display=status; '.PHP_EOL;
+                echo '}'.PHP_EOL;
+
+                echo 'function showSimulator()'.PHP_EOL;
+                echo '{'.PHP_EOL;
+                echo 'var elements = document.querySelectorAll("tr[class^=\'moduleRow\']");'.PHP_EOL;
+                echo 'if(elements == null) { return false };'.PHP_EOL;
                 echo 'for(var i = 0, max = elements.length; i < max; i++) { elements[i].onclick = function() {
                         checkSelected(this);
                     } }' . PHP_EOL;
                 echo 'clearInterval(window.OSdisplayId);';
-                echo 'return true;'. PHP_EOL;
-                echo '};'. PHP_EOL;
+                echo 'return true;'.PHP_EOL;
+                echo '};'.PHP_EOL;
 
-                echo '       window.OSdisplayId = setInterval(function () {'. PHP_EOL;
-                echo '          showSimulator();'. PHP_EOL;
-                echo '       }, 2000);'. PHP_EOL;
-                echo '</script>'. PHP_EOL;
+                echo '       window.OSdisplayId = setInterval(function () {'.PHP_EOL;
+                echo '          showSimulator();'.PHP_EOL;
+                echo '       }, 2000);'.PHP_EOL;
+                echo '</script>'.PHP_EOL;
             }
         }
         $oscTemplate->addBlock(ob_get_clean(), $this->group);
@@ -273,7 +273,7 @@ 
      * install
      */
     function install() {
-        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Enable Pagantis Module', 'MODULE_HEADER_TAGS_PAGANTIS_STATUS', 'True', '', '6', '1', 'tep_cfg_select_option(array(\'True\', \'False\'), ', now())");
+        tep_db_query("insert into ".TABLE_CONFIGURATION." (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Enable Pagantis Module', 'MODULE_HEADER_TAGS_PAGANTIS_STATUS', 'True', '', '6', '1', 'tep_cfg_select_option(array(\'True\', \'False\'), ', now())");
 
     }
 
@@ -281,7 +281,7 @@ 
      * remove
      */
     function remove() {
-        tep_db_query("delete from " . TABLE_CONFIGURATION . " where configuration_key in ('" . implode("', '", $this->keys()) . "')");
+        tep_db_query("delete from ".TABLE_CONFIGURATION." where configuration_key in ('".implode("', '", $this->keys())."')");
     }
 
     /**
@@ -304,7 +304,7 @@ 
 
         if ($this->extraConfig['PAGANTIS_PROMOTION'] == '') {
             $promotedProducts = array();
-        } else {
+        }else {
             $promotedProducts = array_values((array)unserialize($this->extraConfig['PAGANTIS_PROMOTION']));
         }