pagantis / magento-2X

Controller/Payment/Iframe.php

<?php
namespace Pagantis\Pagantis\Controller\Payment;

use Magento\Framework\App\Action\Action;
use Magento\Framework\View\Element\BlockInterface;
use Magento\Framework\App\ResourceConnection;
use Magento\Framework\DB\Ddl\Table;

/**
 * Class Iframe
 * @package Pagantis\Pagantis\Controller\Payment
 */
class Iframe extends Action
{
    /** Concurrency tablename */
    const LOGS_TABLE = 'Pagantis_logs';

    /**
     * @var \Magento\Framework\View\Result\PageFactory
     */
    protected $_pageFactory;

    /** @var ResourceConnection $dbObject */
    protected $dbObject;

    /**
     * Iframe constructor.
     *
     * @param \Magento\Framework\App\Action\Context      $context
     * @param \Magento\Framework\View\Result\PageFactory $pageFactory
     * @param ResourceConnection                         $dbObject
     * @param \Pagantis\Pagantis\Helper\Config           $pagantisConfig
     */
    public function __construct(
        \Magento\Framework\App\Action\Context $context,
        \Magento\Framework\View\Result\PageFactory $pageFactory,
        ResourceConnection $dbObject,
        \Pagantis\Pagantis\Helper\Config $pagantisConfig
    ) {
        $this->_pageFactory = $pageFactory;
        $this->dbObject = $dbObject;
        $this->config = $pagantisConfig->getConfig();

The property config does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return parent::__construct($context);

Are you sure the usage of parent::__construct($context) targeting Magento\Framework\App\Action\Action::__construct() seems to always return null.

    }

    /**
     * @return \Magento\Framework\App\ResponseInterface|\Magento\Framework\Controller\ResultInterface|\Magento\Framework\View\Result\Page
     * @throws \Zend_Db_Exception
     */
    public function execute()
    {
        try {
            $resultPage = $this->_pageFactory->create();
            $orderId = $this->getRequest()->getParam('orderId');
            if ($orderId == '') {
                throw new \Exception('Empty orderId');
            }

            if ($this->config['pagantis_public_key'] == '' || $this->config['pagantis_private_key'] == '') {
                throw new \Exception('Public and Secret Key not found');
            }

            $orderClient = new \Pagantis\OrdersApiClient\Client(
                $this->config['pagantis_public_key'],
                $this->config['pagantis_private_key']
            );

            $order = $orderClient->getOrder($orderId);

            /** @var \Pagantis\Pagantis\Block\Payment\Iframe $block */
            $block = $resultPage->getLayout()->getBlock('pagantis_payment_iframe');
            $block
                ->setEmail($order->getUser()->getEmail())
                ->setOrderUrl($order->getActionUrls()->getForm())
                ->setCheckoutUrl($order->getConfiguration()->getUrls()->getCancel())
            ;

            return $resultPage;
        } catch (\Exception $exception) {
            $this->insertLog($exception);
            die($exception->getMessage());

Using exit here is not recommended.

        }
    }

    /**
     * @return void|\Zend_Db_Statement_Interface
     * @throws \Zend_Db_Exception
     */
    private function checkDbLogTable()
    {
        /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
        $dbConnection = $this->dbObject->getConnection();
        $tableName = $this->dbObject->getTableName(self::LOGS_TABLE);
        if (!$dbConnection->isTableExists($tableName)) {
            $table = $dbConnection
                ->newTable($tableName)
                ->addColumn('id', Table::TYPE_SMALLINT, null, array('nullable'=>false, 'auto_increment'=>true, 'primary'=>true))
                ->addColumn('log', Table::TYPE_TEXT, null, array('nullable'=>false))
                ->addColumn('createdAt', Table::TYPE_TIMESTAMP, null, array('nullable'=>false, 'default'=>TIMESTAMP_INIT));

The constant Pagantis\Pagantis\Controller\Payment\TIMESTAMP_INIT was not found. Maybe you did not declare it correctly or list all dependencies?

            return $dbConnection->createTable($table);
        }

        return;
    }

    /**
     * @param $exceptionMessage
     *
     * @throws \Zend_Db_Exception
     */
    private function insertLog($exceptionMessage)
    {
        if ($exceptionMessage instanceof \Exception) {
            $this->checkDbLogTable();
            $logObject          = new \stdClass();
            $logObject->message = $exceptionMessage->getMessage();
            $logObject->code    = $exceptionMessage->getCode();
            $logObject->line    = $exceptionMessage->getLine();
            $logObject->file    = $exceptionMessage->getFile();
            $logObject->trace   = $exceptionMessage->getTraceAsString();

            /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
            $dbConnection = $this->dbObject->getConnection();
            $tableName    = $this->dbObject->getTableName(self::LOGS_TABLE);
            $dbConnection->insert($tableName, array('log' => json_encode($logObject)));
        }
    }
}