pagantis /
magento-2X
| Conditions | 1 |
| Paths | 3 |
| Total Lines | 81 |
| Code Lines | 47 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 4 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.
There are several approaches to avoid long parameter lists:
| 1 | define( |
||
| 16 | function ($, Component, url, customerData, errorProcessor, fullScreenLoader, quote, pmtClient, selectPaymentMethodAction, checkoutData, totals, priceUtils) { |
||
| 17 | 'use strict'; |
||
| 18 | |||
| 19 | window.checkoutConfig.payment.paylater.guestEmail = quote.guestEmail; |
||
| 20 | |||
| 21 | window.pmtClient = pmtClient; |
||
| 22 | |||
| 23 | return Component.extend({ |
||
| 24 | defaults: { |
||
| 25 | template: 'DigitalOrigin_Pmt/payment/checkout-form' |
||
| 26 | }, |
||
| 27 | |||
| 28 | redirectAfterPlaceOrder: false, |
||
| 29 | |||
| 30 | loadSimulator: function () |
||
| 31 | { |
||
| 32 | setTimeout(function(){ |
||
| 33 | if (window.checkoutConfig.payment.paylater.pmtType !='0' && |
||
|
|
|||
| 34 | window.checkoutConfig.payment.paylater.publicKey!='' && |
||
| 35 | window.checkoutConfig.payment.paylater.secretKey!='') |
||
| 36 | { |
||
| 37 | if (typeof window.pmtClient !== 'undefined') |
||
| 38 | { |
||
| 39 | window.pmtClient.setPublicKey(window.checkoutConfig.payment.paylater.publicKey); |
||
| 40 | window.pmtClient.simulator.reload(); |
||
| 41 | return true; |
||
| 42 | } |
||
| 43 | } |
||
| 44 | }, 3000); |
||
| 45 | }, |
||
| 46 | |||
| 47 | getSubtitle: function () { |
||
| 48 | return window.checkoutConfig.payment.paylater.subtitle |
||
| 49 | }, |
||
| 50 | |||
| 51 | getPmtNumQuota: function () { |
||
| 52 | return window.checkoutConfig.payment.paylater.pmtNumQuota |
||
| 53 | }, |
||
| 54 | |||
| 55 | dataPmtMaxIns: function () { |
||
| 56 | return window.checkoutConfig.payment.paylater.pmtMaxIns |
||
| 57 | }, |
||
| 58 | |||
| 59 | getPmtType: function () { |
||
| 60 | return window.checkoutConfig.payment.paylater.pmtType |
||
| 61 | }, |
||
| 62 | |||
| 63 | getPmtTotal: function () { |
||
| 64 | return priceUtils.formatPrice(totals.totals().grand_total, quote.getPriceFormat()); |
||
| 65 | }, |
||
| 66 | |||
| 67 | getPublicKey: function () { |
||
| 68 | return window.checkoutConfig.payment.paylater.publicKey |
||
| 69 | }, |
||
| 70 | |||
| 71 | getSecretKey: function () { |
||
| 72 | return window.checkoutConfig.payment.paylater.secretKey |
||
| 73 | }, |
||
| 74 | |||
| 75 | getDisplayMode: function () { |
||
| 76 | return window.checkoutConfig.payment.paylater.displayMode |
||
| 77 | }, |
||
| 78 | |||
| 79 | selectPaymentMethod: function() { |
||
| 80 | selectPaymentMethodAction(this.getData()); |
||
| 81 | checkoutData.setSelectedPaymentMethod(this.item.method); |
||
| 82 | return true; |
||
| 83 | }, |
||
| 84 | |||
| 85 | placeOrder: function () { |
||
| 86 | var paymentUrl = url.build('paylater/Payment'); |
||
| 87 | $.post(paymentUrl, { email: window.checkoutConfig.payment.paylater.guestEmail }, 'json') |
||
| 88 | .done(function (response) { |
||
| 89 | window.location.replace(response); |
||
| 90 | }) |
||
| 91 | .fail(function (response) { |
||
| 92 | window.location.replace(response); |
||
| 93 | }) |
||
| 94 | }, |
||
| 95 | }); |
||
| 96 | } |
||
| 97 | ); |
||
| 98 |
Loading history...
This check looks for functions where a
returnstatement is found in some execution paths, but not in all.Consider this little piece of code
The function
isBigwill only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly returnundefined.This behaviour may not be what you had intended. In any case, you can add a
return undefinedto the other execution path to make the return value explicit.