View GitHub Repository magento-2X

Schedule Inspection
Subscribe
Passed
Pull Request — master (#36)
by Cesar
04:52
created
Status
Category
Toggle Patches
Controller/Payment/Log.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -111,7 +111,7 @@
 
 block discarded – undo
111 111 
                     Table::TYPE_TIMESTAMP,
112 112 
                     null,
113 113 
                     array('nullable'=>false,
114 
-                          'default'=>Table::TIMESTAMP_INIT)
114 
+                            'default'=>Table::TIMESTAMP_INIT)
115 115 
                 );
116 116 
             return $dbConnection->createTable($table);
117 117 
         }
Please login to merge, or discard this patch.
Controller/Payment/LogV2.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -111,7 +111,7 @@
 
 block discarded – undo
111 111 
                     Table::TYPE_TIMESTAMP,
112 112 
                     null,
113 113 
                     array('nullable'=>false,
114 
-                          'default'=>Table::TIMESTAMP_INIT)
114 
+                            'default'=>Table::TIMESTAMP_INIT)
115 115 
                 );
116 116 
             return $dbConnection->createTable($table);
117 117 
         }
Please login to merge, or discard this patch.
Test/Buy/PaylaterMgBuyRegisteredTest.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -166,9 +166,9 @@
 
 block discarded – undo
166 166
167 167 
         $body = array('PAGANTIS_TITLE' => 'changed');
168 168 
         $response = Request::post($configUrl)
169 
-                           ->body($body, Mime::FORM)
170 
-                           ->expectsJSON()
171 
-                           ->send();
169 
+                            ->body($body, Mime::FORM)
170 
+                            ->expectsJSON()
171 
+                            ->send();
172 172 
         $title = $response->body->PAGANTIS_TITLE;
173 173 
         $this->assertEquals('changed', $title, "PR62=>".$configUrl." = ".$title);
174 174 
     }
Please login to merge, or discard this patch.
Test/Basic/PaylaterMgBasicTest.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -25,7 +25,7 @@
 
 block discarded – undo
25 25
26 26 
     /**
27 27 
      * testMagentoOpen
28 
-    */
28 
+     */
29 29 
     public function testpagantisMg21BasicTest()
30 30 
     {
31 31 
         $this->webDriver->get($this->configuration['magentoUrl']);
Please login to merge, or discard this patch.
Setup/InstallSchema.php 1 patch
Indentation   +17 added lines, -17 removed lines patch added patch discarded remove patch 
@@ -24,22 +24,22 @@  discard block
 
 block discarded – undo
24 24 
         $installer->startSetup();
25 25
26 26 
         $table = $installer->getConnection()
27 
-                           ->newTable($installer->getTable(self::CONFIG_TABLE))
28 
-                           ->addColumn(
29 
-                               'id',
30 
-                               \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
31 
-                               null,
32 
-                               ['identity' => true, 'unsigned' => true, 'nullable' =>
33 
-                                   false, 'primary' => true],
34 
-                               'Entity ID'
35 
-                           )
36 
-                           ->addColumn(
37 
-                               'config',
38 
-                               \Magento\Framework\DB\Ddl\Table::TYPE_TEXT,
39 
-                               60,
40 
-                               ['nullable' => false],
41 
-                               'Config'
42 
-                           )
27 
+                            ->newTable($installer->getTable(self::CONFIG_TABLE))
28 
+                            ->addColumn(
29 
+                                'id',
30 
+                                \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
31 
+                                null,
32 
+                                ['identity' => true, 'unsigned' => true, 'nullable' =>
33 
+                                    false, 'primary' => true],
34 
+                                'Entity ID'
35 
+                            )
36 
+                            ->addColumn(
37 
+                                'config',
38 
+                                \Magento\Framework\DB\Ddl\Table::TYPE_TEXT,
39 
+                                60,
40 
+                                ['nullable' => false],
41 
+                                'Config'
42 
+                            )
43 43 
                         ->addColumn(
44 44 
                             'value',
45 45 
                             \Magento\Framework\DB\Ddl\Table::TYPE_TEXT,
 
@@ -47,7 +47,7 @@  discard block
 
 block discarded – undo
47 47 
                             ['nullable' => false],
48 48 
                             'Value'
49 49 
                         )
50 
-                           ->setComment('Pagantis config table');
50 
+                            ->setComment('Pagantis config table');
51 51
52 52 
         $installer->getConnection()->createTable($table);
53 53
Please login to merge, or discard this patch.
Controller/Payment/ConfigV2.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch 
@@ -20,20 +20,20 @@
 
 block discarded – undo
20 20 
      * @var array $defaultConfigs
21 21 
      */
22 22 
     public $defaultConfigs = array('PAGANTIS_TITLE'=>'Instant Financing',
23 
-                                   'PAGANTIS_SIMULATOR_DISPLAY_TYPE'=>'pgSDK.simulator.types.SIMPLE',
24 
-                                   'PAGANTIS_SIMULATOR_DISPLAY_SKIN'=>'pgSDK.simulator.skins.BLUE',
25 
-                                   'PAGANTIS_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
26 
-                                   'PAGANTIS_SIMULATOR_START_INSTALLMENTS'=>3,
27 
-                                   'PAGANTIS_SIMULATOR_MAX_INSTALLMENTS'=>12,
28 
-                                   'PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
29 
-                                   'PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'=>'pgSDK.simulator.positions.INNER',
30 
-                                   'PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
31 
-                                   'PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
32 
-                                   'PAGANTIS_FORM_DISPLAY_TYPE'=>0,
33 
-                                   'PAGANTIS_DISPLAY_MIN_AMOUNT'=>1,
34 
-                                   'PAGANTIS_URL_OK'=>'',
35 
-                                   'PAGANTIS_URL_KO'=>'',
36 
-                                   'PAGANTIS_TITLE_EXTRA' => 'Pay up to 12 comfortable installments with Pagantis. Completely online and sympathetic request, and the answer is immediate!'
23 
+                                    'PAGANTIS_SIMULATOR_DISPLAY_TYPE'=>'pgSDK.simulator.types.SIMPLE',
24 
+                                    'PAGANTIS_SIMULATOR_DISPLAY_SKIN'=>'pgSDK.simulator.skins.BLUE',
25 
+                                    'PAGANTIS_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
26 
+                                    'PAGANTIS_SIMULATOR_START_INSTALLMENTS'=>3,
27 
+                                    'PAGANTIS_SIMULATOR_MAX_INSTALLMENTS'=>12,
28 
+                                    'PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
29 
+                                    'PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'=>'pgSDK.simulator.positions.INNER',
30 
+                                    'PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
31 
+                                    'PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
32 
+                                    'PAGANTIS_FORM_DISPLAY_TYPE'=>0,
33 
+                                    'PAGANTIS_DISPLAY_MIN_AMOUNT'=>1,
34 
+                                    'PAGANTIS_URL_OK'=>'',
35 
+                                    'PAGANTIS_URL_KO'=>'',
36 
+                                    'PAGANTIS_TITLE_EXTRA' => 'Pay up to 12 comfortable installments with Pagantis. Completely online and sympathetic request, and the answer is immediate!'
37 37 
     );
38 38
39 39 
     /**
Please login to merge, or discard this patch.
Controller/Payment/Config.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch 
@@ -20,20 +20,20 @@
 
 block discarded – undo
20 20 
      * @var array $defaultConfigs
21 21 
      */
22 22 
     public $defaultConfigs = array('PAGANTIS_TITLE'=>'Instant Financing',
23 
-                                   'PAGANTIS_SIMULATOR_DISPLAY_TYPE'=>'pgSDK.simulator.types.SIMPLE',
24 
-                                   'PAGANTIS_SIMULATOR_DISPLAY_SKIN'=>'pgSDK.simulator.skins.BLUE',
25 
-                                   'PAGANTIS_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
26 
-                                   'PAGANTIS_SIMULATOR_START_INSTALLMENTS'=>3,
27 
-                                   'PAGANTIS_SIMULATOR_MAX_INSTALLMENTS'=>12,
28 
-                                   'PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
29 
-                                   'PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'=>'pgSDK.simulator.positions.INNER',
30 
-                                   'PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
31 
-                                   'PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
32 
-                                   'PAGANTIS_FORM_DISPLAY_TYPE'=>0,
33 
-                                   'PAGANTIS_DISPLAY_MIN_AMOUNT'=>1,
34 
-                                   'PAGANTIS_URL_OK'=>'',
35 
-                                   'PAGANTIS_URL_KO'=>'',
36 
-                                   'PAGANTIS_TITLE_EXTRA' => 'Pay up to 12 comfortable installments with Pagantis. Completely online and sympathetic request, and the answer is immediate!'
23 
+                                    'PAGANTIS_SIMULATOR_DISPLAY_TYPE'=>'pgSDK.simulator.types.SIMPLE',
24 
+                                    'PAGANTIS_SIMULATOR_DISPLAY_SKIN'=>'pgSDK.simulator.skins.BLUE',
25 
+                                    'PAGANTIS_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
26 
+                                    'PAGANTIS_SIMULATOR_START_INSTALLMENTS'=>3,
27 
+                                    'PAGANTIS_SIMULATOR_MAX_INSTALLMENTS'=>12,
28 
+                                    'PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
29 
+                                    'PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'=>'pgSDK.simulator.positions.INNER',
30 
+                                    'PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
31 
+                                    'PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
32 
+                                    'PAGANTIS_FORM_DISPLAY_TYPE'=>0,
33 
+                                    'PAGANTIS_DISPLAY_MIN_AMOUNT'=>1,
34 
+                                    'PAGANTIS_URL_OK'=>'',
35 
+                                    'PAGANTIS_URL_KO'=>'',
36 
+                                    'PAGANTIS_TITLE_EXTRA' => 'Pay up to 12 comfortable installments with Pagantis. Completely online and sympathetic request, and the answer is immediate!'
37 37 
     );
38 38
39 39 
     /**
Please login to merge, or discard this patch.
Controller/Payment/Index.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -234,9 +234,9 @@  discard block
 
 block discarded – undo
234 234 
                 if ($promotedProduct == 'true') {
235 235 
                     $promotedAmount+=$product->getAmount()*$item->getQty();
236 236 
                     $promotedMessage = 'Promoted Item: ' . $item->getName() .
237 
-                                       ' Price: ' . $item->getPrice() .
238 
-                                       ' Qty: ' . $item->getQty() .
239 
-                                       ' Item ID: ' . $item->getItemId();
237 
+                                        ' Price: ' . $item->getPrice() .
238 
+                                        ' Qty: ' . $item->getQty() .
239 
+                                        ' Item ID: ' . $item->getItemId();
240 240 
                     $metadataOrder->addMetadata('promotedProduct', $promotedMessage);
241 241 
                 }
242 242 
             }
 
@@ -401,9 +401,9 @@  discard block
 
 block discarded – undo
401 401 
         $magentoVersion = $this->productMetadataInterface->getVersion();
402 402 
         $moduleInfo = $this->moduleList->getOne('Pagantis_Pagantis');
403 403 
         return array(  'magento' => $magentoVersion,
404 
-                       'pagantis' => $moduleInfo['setup_version'],
405 
-                       'php' => phpversion(),
406 
-                       'curl' => $curlVersion);
404 
+                        'pagantis' => $moduleInfo['setup_version'],
405 
+                        'php' => phpversion(),
406 
+                        'curl' => $curlVersion);
407 407 
     }
408 408
409 409 
     /**
Please login to merge, or discard this patch.
Setup/InstallData.php 1 patch
Indentation   +19 added lines, -19 removed lines patch added patch discarded remove patch 
@@ -16,25 +16,25 @@
 
 block discarded – undo
16 16 
      * @var array $defaultConfigs
17 17 
      */
18 18 
     public $defaultConfigs = array(
19 
-       'PAGANTIS_TITLE'=>'Instant Financing',
20 
-       'PAGANTIS_SIMULATOR_DISPLAY_TYPE'=>'sdk.simulator.types.SIMPLE',
21 
-       'PAGANTIS_SIMULATOR_DISPLAY_SKIN'=>'sdk.simulator.skins.BLUE',
22 
-       'PAGANTIS_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
23 
-       'PAGANTIS_SIMULATOR_START_INSTALLMENTS'=>3,
24 
-       'PAGANTIS_SIMULATOR_MAX_INSTALLMENTS'=>12,
25 
-       'PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
26 
-       'PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'=>'sdk.simulator.positions.INNER',
27 
-       'PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
28 
-       'PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
29 
-       'PAGANTIS_FORM_DISPLAY_TYPE'=>0,
30 
-       'PAGANTIS_DISPLAY_MIN_AMOUNT'=>1,
31 
-       'PAGANTIS_URL_OK'=>'',
32 
-       'PAGANTIS_URL_KO'=>'',
33 
-       'PAGANTIS_TITLE_EXTRA' => 'Pay up to 12 comfortable installments with Pagantis. Completely online and sympathetic request, and the answer is immediate!',
34 
-       'PAGANTIS_ALLOWED_COUNTRIES' => 'a:3:{i:0;s:2:"es";i:1;s:2:"it";i:2;s:2:"fr";}',
35 
-       'PAGANTIS_PROMOTION_EXTRA' => '<p class="promoted">Finance this product <span class="pmt-no-interest">without interest!</span></p>',
36 
-       'PAGANTIS_SIMULATOR_THOUSANDS_SEPARATOR' => '.',
37 
-       'PAGANTIS_SIMULATOR_DECIMAL_SEPARATOR' => ','
19 
+        'PAGANTIS_TITLE'=>'Instant Financing',
20 
+        'PAGANTIS_SIMULATOR_DISPLAY_TYPE'=>'sdk.simulator.types.SIMPLE',
21 
+        'PAGANTIS_SIMULATOR_DISPLAY_SKIN'=>'sdk.simulator.skins.BLUE',
22 
+        'PAGANTIS_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
23 
+        'PAGANTIS_SIMULATOR_START_INSTALLMENTS'=>3,
24 
+        'PAGANTIS_SIMULATOR_MAX_INSTALLMENTS'=>12,
25 
+        'PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
26 
+        'PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'=>'sdk.simulator.positions.INNER',
27 
+        'PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
28 
+        'PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
29 
+        'PAGANTIS_FORM_DISPLAY_TYPE'=>0,
30 
+        'PAGANTIS_DISPLAY_MIN_AMOUNT'=>1,
31 
+        'PAGANTIS_URL_OK'=>'',
32 
+        'PAGANTIS_URL_KO'=>'',
33 
+        'PAGANTIS_TITLE_EXTRA' => 'Pay up to 12 comfortable installments with Pagantis. Completely online and sympathetic request, and the answer is immediate!',
34 
+        'PAGANTIS_ALLOWED_COUNTRIES' => 'a:3:{i:0;s:2:"es";i:1;s:2:"it";i:2;s:2:"fr";}',
35 
+        'PAGANTIS_PROMOTION_EXTRA' => '<p class="promoted">Finance this product <span class="pmt-no-interest">without interest!</span></p>',
36 
+        'PAGANTIS_SIMULATOR_THOUSANDS_SEPARATOR' => '.',
37 
+        'PAGANTIS_SIMULATOR_DECIMAL_SEPARATOR' => ','
38 38 
     );
39 39
40 40 
     /**
Please login to merge, or discard this patch.