pagantis / magento-2X

Controller/Payment/Index.php

Indentation +3 added lines, -3 removed lines

@@ -360,9 +360,9 @@
         $magentoVersion = $this->productMetadataInterface->getVersion();
         $moduleInfo = $this->moduleList->getOne('Pagantis_Pagantis');
         return array(  'magento' => $magentoVersion,
-                       'pagantis' => $moduleInfo['setup_version'],
-                       'php' => phpversion(),
-                       'curl' => $curlVersion);
+                        'pagantis' => $moduleInfo['setup_version'],
+                        'php' => phpversion(),
+                        'curl' => $curlVersion);
     }
 
     /**

Spacing +12 added lines, -12 removed lines

@@ -125,12 +125,12 @@ 
             $customer = $quote->getCustomer();
             $shippingAddress = $quote->getShippingAddress();
 
-            if (isset($params['email']) && $params['email']!='') {
+            if (isset($params['email']) && $params['email'] != '') {
                 $this->session->setEmail($params['email']); //Get guest email after refresh page
                 $customer->setEmail($params['email']);
                 $quote->setCheckoutMethod('guest');
                 $quote->getBillingAddress()->setEmail($params['email']);
-            } elseif ($customer->getEmail()=='') {
+            } elseif ($customer->getEmail() == '') {
                 $customer->setEmail($this->session->getEmail());
                 $quote->setCheckoutMethod('guest');
                 $quote->getBillingAddress()->setEmail($this->session->getEmail());
@@ -141,7 +141,7 @@ 
             $currentQuote->setCustomerEmail($customer->getEmail());
             $this->quoteRepository->save($currentQuote);
 
-            $userAddress =  new Address();
+            $userAddress = new Address();
             $userAddress
                 ->setZipCode($shippingAddress->getPostcode())
                 ->setFullName($shippingAddress->getFirstname()." ".$shippingAddress->getLastname())
@@ -163,7 +163,7 @@ 
                 ->setTaxId($tax_id)
             ;
 
-            $orderBillingAddress =  new Address();
+            $orderBillingAddress = new Address();
             $billingAddress = $quote->getBillingAddress();
             $orderBillingAddress
                 ->setZipCode($billingAddress->getPostcode())
@@ -192,7 +192,7 @@ 
             if ($customer->getDob()) {
                 $orderUser->setDateOfBirth($customer->getDob());
             }
-            if ($customer->getTaxvat()!='') {
+            if ($customer->getTaxvat() != '') {
                 $orderUser->setDni($customer->getTaxvat());
                 $orderBillingAddress->setDni($customer->getTaxvat());
                 $orderShippingAddress->setDni($customer->getTaxvat());
@@ -262,7 +262,7 @@ 
                 ->setType(Channel::ONLINE)
             ;
             
-            $haystack  = $this->store->getLocale();
+            $haystack = $this->store->getLocale();
             $language = strstr($haystack, '_', true);
             $orderConfiguration = new Configuration();
             $orderConfiguration
@@ -280,7 +280,7 @@ 
                 ->setUser($orderUser)
             ;
 
-            if ($this->config['pagantis_public_key']=='' || $this->config['pagantis_private_key']=='') {
+            if ($this->config['pagantis_public_key'] == '' || $this->config['pagantis_private_key'] == '') {
                 throw new \Exception('Public and Secret Key not found');
             }
 
@@ -306,7 +306,7 @@ 
         }
 
         $displayMode = $this->extraConfig['PAGANTIS_FORM_DISPLAY_TYPE'];
-        if ($displayMode==='0') {
+        if ($displayMode === '0') {
             echo $url;
             exit;
         } else {
@@ -328,11 +328,11 @@ 
     private function getOrders($customerId)
     {
         $orderCollection = array();
-        if ($customerId!='') {
+        if ($customerId != '') {
             $this->orderCollection->addAttributeToFilter('customer_id', $customerId)
                             ->addAttributeToFilter(
                                 'status',
-                                ['in' => ['processing','pending','complete']]
+                                ['in' => ['processing', 'pending', 'complete']]
                             )
                             ->load();
             $orderCollection = $this->orderCollection->getData();
@@ -375,7 +375,7 @@ 
         $tableName = $this->dbObject->getTableName(self::ORDERS_TABLE);
         return $dbConnection->insertOnDuplicate(
             $tableName,
-            array('id'=>$quoteId,'order_id'=>$pagantisOrderId),
+            array('id'=>$quoteId, 'order_id'=>$pagantisOrderId),
             array('order_id')
         );
     }
@@ -389,7 +389,7 @@ 
         $curlVersion = $curlInfo['version'];
         $magentoVersion = $this->productMetadataInterface->getVersion();
         $moduleInfo = $this->moduleList->getOne('Pagantis_Pagantis');
-        return array(  'magento' => $magentoVersion,
+        return array('magento' => $magentoVersion,
                        'pagantis' => $moduleInfo['setup_version'],
                        'php' => phpversion(),
                        'curl' => $curlVersion);

Controller/Notify/IndexV2.php

Spacing +7 added lines, -7 removed lines

@@ -262,7 +262,7 @@ 
             $this->checkPagantisStatus(array('AUTHORIZED'));
         } catch (\Exception $e) {
             $this->getMagentoOrderId();
-            if ($this->magentoOrderId!='') {
+            if ($this->magentoOrderId != '') {
                 throw new AlreadyProcessedException();
             } else {
                 throw new WrongStatusException($this->pagantisOrder->getStatus());
@@ -275,7 +275,7 @@ 
      */
     private function checkMerchantOrderStatus()
     {
-        if ($this->quote->getIsActive()=='0') {
+        if ($this->quote->getIsActive() == '0') {
             $this->getMagentoOrderId();
             throw new AlreadyProcessedException();
         }
@@ -397,7 +397,7 @@ 
             $tableName    = $this->dbObject->getTableName(self::CONCURRENCY_TABLE);
             if ($mode == false) {
                 $dbConnection->delete($tableName, "timestamp<".(time() - 5));
-            } elseif ($this->quoteId!='') {
+            } elseif ($this->quoteId != '') {
                 $dbConnection->delete($tableName, "id=".$this->quoteId);
             }
         } catch (Exception $exception) {
@@ -452,7 +452,7 @@ 
             /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
             $dbConnection = $this->dbObject->getConnection();
             $tableName    = $this->dbObject->getTableName(self::ORDERS_TABLE);
-            $pagantisOrderId   = $this->pagantisOrderId;
+            $pagantisOrderId = $this->pagantisOrderId;
 
             $query        = "select mg_order_id from $tableName where id='$this->quoteId' and order_id='$pagantisOrderId'";
             $queryResult  = $dbConnection->fetchRow($query);
@@ -492,7 +492,7 @@ 
             /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
             $dbConnection = $this->dbObject->getConnection();
             $tableName    = $this->dbObject->getTableName(self::ORDERS_TABLE);
-            $pagantisOrderId   = $this->pagantisOrder->getId();
+            $pagantisOrderId = $this->pagantisOrder->getId();
             $dbConnection->update(
                 $tableName,
                 array('mg_order_id' => $this->magentoOrderId),
@@ -525,7 +525,7 @@ 
     {
         //$returnUrl = 'checkout/#payment';
         $returnUrl = $this->_url->getUrl('checkout', ['_fragment' => 'payment']);
-        if ($this->magentoOrderId!='') {
+        if ($this->magentoOrderId != '') {
             /** @var Order $this->magentoOrder */
             $this->magentoOrder = $this->orderRepositoryInterface->get($this->magentoOrderId);
             if (!$this->_objectManager->get(\Magento\Checkout\Model\Session\SuccessValidator::class)->isValid()) {
@@ -542,7 +542,7 @@ 
             $orderStatus    = strtolower($this->magentoOrder->getStatus());
             $acceptedStatus = array('processing', 'completed');
             if (in_array($orderStatus, $acceptedStatus)) {
-                if (isset($this->extraConfig['PAGANTIS_OK_URL']) &&  $this->extraConfig['PAGANTIS_OK_URL']!= '') {
+                if (isset($this->extraConfig['PAGANTIS_OK_URL']) && $this->extraConfig['PAGANTIS_OK_URL'] != '') {
                     $returnUrl = $this->extraConfig['PAGANTIS_OK_URL'];
                 } else {
                     $returnUrl = 'checkout/onepage/success';

Test/PagantisMagentoTest.php

Spacing +9 added lines, -9 removed lines

@@ -150,16 +150,16 @@ 
         $faker = Factory::create();
         $this->configuration['dni'] = $this->getDNI();
         $this->configuration['birthdate'] =
-            $faker->numberBetween(1, 28) . '/' .
-            $faker->numberBetween(1, 12). '/1975'
+            $faker->numberBetween(1, 28).'/'.
+            $faker->numberBetween(1, 12).'/1975'
         ;
         $this->configuration['firstname'] = $faker->firstName;
-        $this->configuration['lastname'] = $faker->lastName . ' ' . $faker->lastName;
+        $this->configuration['lastname'] = $faker->lastName.' '.$faker->lastName;
         $this->configuration['company'] = $faker->company;
         $this->configuration['zip'] = '28'.$faker->randomNumber(3, true);
         $this->configuration['street'] = $faker->streetAddress;
-        $this->configuration['phone'] = '6' . $faker->randomNumber(8);
-        $this->configuration['email'] = date('ymd') . '@pagantis.com';
+        $this->configuration['phone'] = '6'.$faker->randomNumber(8);
+        $this->configuration['email'] = date('ymd').'@pagantis.com';
 
         if (!isset($_SERVER['argv']) ||
             !isset($_SERVER['argv'][4]) ||
@@ -183,12 +183,12 @@ 
      */
     protected function getDNI()
     {
-        $dni = '0000' . rand(pow(10, 4-1), pow(10, 4)-1);
+        $dni = '0000'.rand(pow(10, 4 - 1), pow(10, 4) - 1);
         $value = (int) ($dni / 23);
         $value *= 23;
-        $value= $dni - $value;
-        $letter= "TRWAGMYFPDXBNJZSQVHLCKEO";
-        $dniLetter= substr($letter, $value, 1);
+        $value = $dni - $value;
+        $letter = "TRWAGMYFPDXBNJZSQVHLCKEO";
+        $dniLetter = substr($letter, $value, 1);
         return $dni.$dniLetter;
     }
 

Setup/InstallData.php

Indentation +15 added lines, -15 removed lines

@@ -16,21 +16,21 @@
      * @var array $defaultConfigs
      */
     public $defaultConfigs = array('PAGANTIS_TITLE'=>'Instant Financing',
-                           'PAGANTIS_SIMULATOR_DISPLAY_TYPE'=>'pgSDK.simulator.types.SIMPLE',
-                           'PAGANTIS_SIMULATOR_DISPLAY_SKIN'=>'pgSDK.simulator.skins.BLUE',
-                           'PAGANTIS_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
-                           'PAGANTIS_SIMULATOR_START_INSTALLMENTS'=>3,
-                           'PAGANTIS_SIMULATOR_MAX_INSTALLMENTS'=>12,
-                           'PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
-                           'PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'=>'pgSDK.simulator.positions.INNER',
-                           'PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
-                           'PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
-                           'PAGANTIS_FORM_DISPLAY_TYPE'=>0,
-                           'PAGANTIS_DISPLAY_MIN_AMOUNT'=>1,
-                           'PAGANTIS_URL_OK'=>'',
-                           'PAGANTIS_URL_KO'=>'',
-                           'PAGANTIS_TITLE_EXTRA' => 'Pay up to 12 comfortable installments with Pagantis. Completely online and sympathetic request, and the answer is immediate!',
-                           'PAGANTIS_ALLOWED_COUNTRIES' => 'a:2:{i:0;s:2:"es";i:1;s:2:"it";}'
+                            'PAGANTIS_SIMULATOR_DISPLAY_TYPE'=>'pgSDK.simulator.types.SIMPLE',
+                            'PAGANTIS_SIMULATOR_DISPLAY_SKIN'=>'pgSDK.simulator.skins.BLUE',
+                            'PAGANTIS_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
+                            'PAGANTIS_SIMULATOR_START_INSTALLMENTS'=>3,
+                            'PAGANTIS_SIMULATOR_MAX_INSTALLMENTS'=>12,
+                            'PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
+                            'PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'=>'pgSDK.simulator.positions.INNER',
+                            'PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
+                            'PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
+                            'PAGANTIS_FORM_DISPLAY_TYPE'=>0,
+                            'PAGANTIS_DISPLAY_MIN_AMOUNT'=>1,
+                            'PAGANTIS_URL_OK'=>'',
+                            'PAGANTIS_URL_KO'=>'',
+                            'PAGANTIS_TITLE_EXTRA' => 'Pay up to 12 comfortable installments with Pagantis. Completely online and sympathetic request, and the answer is immediate!',
+                            'PAGANTIS_ALLOWED_COUNTRIES' => 'a:2:{i:0;s:2:"es";i:1;s:2:"it";}'
     );
 
     /**

Observer/PaymentMethodAvailable.php

Spacing +2 added lines, -2 removed lines

@@ -16,7 +16,7 @@ 
     public function execute(\Magento\Framework\Event\Observer $observer)
     {
         try {
-            if ($observer->getEvent()->getMethodInstance()->getCode()=="pagantis") {
+            if ($observer->getEvent()->getMethodInstance()->getCode() == "pagantis") {
                 $checkResult = $observer->getEvent()->getResult();
                 $objectManager = \Magento\Framework\App\ObjectManager::getInstance();
                 $config        = $objectManager->create('Pagantis\Pagantis\Helper\Config')->getConfig();
@@ -27,7 +27,7 @@ 
                 $availableCountry = (in_array(strtolower($locale), $allowedCountries));
                 if (!isset($config['pagantis_public_key']) || $config['pagantis_public_key'] == '' ||
                     !isset($config['pagantis_private_key']) || $config['pagantis_private_key'] == '' ||
-                    !$availableCountry ) {
+                    !$availableCountry) {
                     $checkResult->setData('is_available', false);
                 } else {
                     $checkResult->setData('is_available', true);