ResponseCodeValidator::isSuccessfulTransaction() - Code Metrics - Inspection of "Transfer factory error" - pagantis/magento-2X - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#36)

unknown

created 2019-12-19 11:53 UTC

ResponseCodeValidator::isSuccessfulTransaction() A

↳ Parent: ResponseCodeValidator

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	2
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	4
rs	10

<?php
/**
 * Copyright © 2016 Magento. All rights reserved.
 * See COPYING.txt for license details.
 */
namespace Pagantis\Pagantis\Gateway\Validator;

use Magento\Payment\Gateway\Validator\AbstractValidator;
use Magento\Payment\Gateway\Validator\ResultInterface;
use Pagantis\Pagantis\Gateway\Http\Client\ClientMock;

class ResponseCodeValidator extends AbstractValidator
{
    const RESULT_CODE = 'RESULT_CODE';

    /**
     * Performs validation of result code
     *
     * @param array $validationSubject
     * @return ResultInterface
     */
    public function validate(array $validationSubject)
    {
        if (!isset($validationSubject['response']) || !is_array($validationSubject['response'])) {
            throw new \InvalidArgumentException('Response does not exist');
        }

        $response = $validationSubject['response'];

        if ($this->isSuccessfulTransaction($response)) {
            return $this->createResult(
                true,
                []
            );
        } else {
            return $this->createResult(
                false,
                [__('Gateway rejected the transaction.')]
            );
        }
    }

    /**
     * @param array $response
     * @return bool
     */
    private function isSuccessfulTransaction(array $response)
    {
        return isset($response[self::RESULT_CODE])
        && $response[self::RESULT_CODE] !== ClientMock::FAILURE;
    }
}


1			<?php
2			/**
3			* Copyright © 2016 Magento. All rights reserved.
4			* See COPYING.txt for license details.
5			*/
6			namespace Pagantis\Pagantis\Gateway\Validator;
7
8			use Magento\Payment\Gateway\Validator\AbstractValidator;
9			use Magento\Payment\Gateway\Validator\ResultInterface;
10			use Pagantis\Pagantis\Gateway\Http\Client\ClientMock;
11
12			class ResponseCodeValidator extends AbstractValidator
13			{
14			const RESULT_CODE = 'RESULT_CODE';
15
16			/**
17			* Performs validation of result code
18			*
19			* @param array $validationSubject
20			* @return ResultInterface
21			*/
22			public function validate(array $validationSubject)
23			{
24			if (!isset($validationSubject['response']) \|\| !is_array($validationSubject['response'])) {
25			throw new \InvalidArgumentException('Response does not exist');
26			}
27
28			$response = $validationSubject['response'];
29
30			if ($this->isSuccessfulTransaction($response)) {
31			return $this->createResult(
32			true,
33			[]
34			);
35			} else {
36			return $this->createResult(
37			false,
38			[__('Gateway rejected the transaction.')]
39			);
40			}
41			}
42
43			/**
44			* @param array $response
45			* @return bool
46			*/
47			private function isSuccessfulTransaction(array $response)
48			{
49			return isset($response[self::RESULT_CODE])
50			&& $response[self::RESULT_CODE] !== ClientMock::FAILURE;
51			}
52			}
53

pagantis / magento-2X

Pull Request — master (#36)

ResponseCodeValidator::isSuccessfulTransaction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like