Passed
Push — master ( b4d4a1...8ab257 )
by Cesar
04:12
created
Controller/Notify/Index.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
             $this->checkPagantisStatus(array('AUTHORIZED'));
263 263
         } catch (\Exception $e) {
264 264
             $this->getMagentoOrderId();
265
-            if ($this->magentoOrderId!='') {
265
+            if ($this->magentoOrderId != '') {
266 266
                 throw new AlreadyProcessedException();
267 267
             } else {
268 268
                 throw new WrongStatusException($this->pagantisOrder->getStatus());
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
      */
276 276
     private function checkMerchantOrderStatus()
277 277
     {
278
-        if ($this->quote->getIsActive()=='0') {
278
+        if ($this->quote->getIsActive() == '0') {
279 279
             $this->getMagentoOrderId();
280 280
             throw new AlreadyProcessedException();
281 281
         }
@@ -397,7 +397,7 @@  discard block
 block discarded – undo
397 397
             $tableName    = $this->dbObject->getTableName(self::CONCURRENCY_TABLE);
398 398
             if ($mode == false) {
399 399
                 $dbConnection->delete($tableName, "timestamp<".(time() - 5));
400
-            } elseif ($this->quoteId!='') {
400
+            } elseif ($this->quoteId != '') {
401 401
                 $dbConnection->delete($tableName, "id=".$this->quoteId);
402 402
             }
403 403
         } catch (Exception $exception) {
@@ -452,7 +452,7 @@  discard block
 block discarded – undo
452 452
             /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
453 453
             $dbConnection = $this->dbObject->getConnection();
454 454
             $tableName    = $this->dbObject->getTableName(self::ORDERS_TABLE);
455
-            $pagantisOrderId   = $this->pagantisOrderId;
455
+            $pagantisOrderId = $this->pagantisOrderId;
456 456
 
457 457
             $query        = "select mg_order_id from $tableName where id='$this->quoteId' and order_id='$pagantisOrderId'";
458 458
             $queryResult  = $dbConnection->fetchRow($query);
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
492 492
             /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
493 493
             $dbConnection = $this->dbObject->getConnection();
494 494
             $tableName    = $this->dbObject->getTableName(self::ORDERS_TABLE);
495
-            $pagantisOrderId   = $this->pagantisOrder->getId();
495
+            $pagantisOrderId = $this->pagantisOrder->getId();
496 496
             $dbConnection->update(
497 497
                 $tableName,
498 498
                 array('mg_order_id' => $this->magentoOrderId),
@@ -525,7 +525,7 @@  discard block
 block discarded – undo
525 525
     {
526 526
         //$returnUrl = 'checkout/#payment';
527 527
         $returnUrl = $this->_url->getUrl('checkout', ['_fragment' => 'payment']);
528
-        if ($this->magentoOrderId!='') {
528
+        if ($this->magentoOrderId != '') {
529 529
             /** @var Order $this->magentoOrder */
530 530
             $this->magentoOrder = $this->orderRepositoryInterface->get($this->magentoOrderId);
531 531
             if (!$this->_objectManager->get(\Magento\Checkout\Model\Session\SuccessValidator::class)->isValid()) {
@@ -542,7 +542,7 @@  discard block
 block discarded – undo
542 542
             $orderStatus    = strtolower($this->magentoOrder->getStatus());
543 543
             $acceptedStatus = array('processing', 'completed');
544 544
             if (in_array($orderStatus, $acceptedStatus)) {
545
-                if (isset($this->extraConfig['PAGANTIS_OK_URL']) &&  $this->extraConfig['PAGANTIS_OK_URL']!= '') {
545
+                if (isset($this->extraConfig['PAGANTIS_OK_URL']) && $this->extraConfig['PAGANTIS_OK_URL'] != '') {
546 546
                     $returnUrl = $this->extraConfig['PAGANTIS_OK_URL'];
547 547
                 } else {
548 548
                     $returnUrl = 'checkout/onepage/success';
Please login to merge, or discard this patch.
Controller/Payment/Index.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -360,9 +360,9 @@
 block discarded – undo
360 360
         $magentoVersion = $this->productMetadataInterface->getVersion();
361 361
         $moduleInfo = $this->moduleList->getOne('Pagantis_Pagantis');
362 362
         return array(  'magento' => $magentoVersion,
363
-                       'pagantis' => $moduleInfo['setup_version'],
364
-                       'php' => phpversion(),
365
-                       'curl' => $curlVersion);
363
+                        'pagantis' => $moduleInfo['setup_version'],
364
+                        'php' => phpversion(),
365
+                        'curl' => $curlVersion);
366 366
     }
367 367
 
368 368
     /**
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -107,12 +107,12 @@  discard block
 block discarded – undo
107 107
             $customer = $quote->getCustomer();
108 108
             $shippingAddress = $quote->getShippingAddress();
109 109
 
110
-            if (isset($params['email']) && $params['email']!='') {
110
+            if (isset($params['email']) && $params['email'] != '') {
111 111
                 $this->session->setEmail($params['email']); //Get guest email after refresh page
112 112
                 $customer->setEmail($params['email']);
113 113
                 $quote->setCheckoutMethod('guest');
114 114
                 $quote->getBillingAddress()->setEmail($params['email']);
115
-            } elseif ($customer->getEmail()=='') {
115
+            } elseif ($customer->getEmail() == '') {
116 116
                 $customer->setEmail($this->session->getEmail());
117 117
                 $quote->setCheckoutMethod('guest');
118 118
                 $quote->getBillingAddress()->setEmail($this->session->getEmail());
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
             $currentQuote->setCustomerEmail($customer->getEmail());
124 124
             $this->quoteRepository->save($currentQuote);
125 125
 
126
-            $userAddress =  new Address();
126
+            $userAddress = new Address();
127 127
             $userAddress
128 128
                 ->setZipCode($shippingAddress->getPostcode())
129 129
                 ->setFullName($shippingAddress->getFirstname()." ".$shippingAddress->getLastname())
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
                 ->setMobilePhone($shippingAddress->getTelephone())
144 144
             ;
145 145
 
146
-            $orderBillingAddress =  new Address();
146
+            $orderBillingAddress = new Address();
147 147
             $billingAddress = $quote->getBillingAddress();
148 148
             $orderBillingAddress
149 149
                 ->setZipCode($billingAddress->getPostcode())
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
             if ($customer->getDob()) {
171 171
                 $orderUser->setDateOfBirth($customer->getDob());
172 172
             }
173
-            if ($customer->getTaxvat()!='') {
173
+            if ($customer->getTaxvat() != '') {
174 174
                 $orderUser->setDni($customer->getTaxvat());
175 175
                 $orderBillingAddress->setDni($customer->getTaxvat());
176 176
                 $orderShippingAddress->setDni($customer->getTaxvat());
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
                 ->setUser($orderUser)
251 251
             ;
252 252
 
253
-            if ($this->config['pagantis_public_key']=='' || $this->config['pagantis_private_key']=='') {
253
+            if ($this->config['pagantis_public_key'] == '' || $this->config['pagantis_private_key'] == '') {
254 254
                 throw new \Exception('Public and Secret Key not found');
255 255
             }
256 256
 
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
         }
277 277
 
278 278
         $displayMode = $this->extraConfig['PAGANTIS_FORM_DISPLAY_TYPE'];
279
-        if ($displayMode==='0') {
279
+        if ($displayMode === '0') {
280 280
             echo $url;
281 281
             exit;
282 282
         } else {
@@ -298,11 +298,11 @@  discard block
 block discarded – undo
298 298
     private function getOrders($customerId)
299 299
     {
300 300
         $orderCollection = array();
301
-        if ($customerId!='') {
301
+        if ($customerId != '') {
302 302
             $this->orderCollection->addAttributeToFilter('customer_id', $customerId)
303 303
                             ->addAttributeToFilter(
304 304
                                 'status',
305
-                                ['in' => ['processing','pending','complete']]
305
+                                ['in' => ['processing', 'pending', 'complete']]
306 306
                             )
307 307
                             ->load();
308 308
             $orderCollection = $this->orderCollection->getData();
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
         $tableName = $this->dbObject->getTableName(self::ORDERS_TABLE);
346 346
         return $dbConnection->insertOnDuplicate(
347 347
             $tableName,
348
-            array('id'=>$quoteId,'order_id'=>$pagantisOrderId),
348
+            array('id'=>$quoteId, 'order_id'=>$pagantisOrderId),
349 349
             array('order_id')
350 350
         );
351 351
     }
@@ -359,7 +359,7 @@  discard block
 block discarded – undo
359 359
         $curlVersion = $curlInfo['version'];
360 360
         $magentoVersion = $this->productMetadataInterface->getVersion();
361 361
         $moduleInfo = $this->moduleList->getOne('Pagantis_Pagantis');
362
-        return array(  'magento' => $magentoVersion,
362
+        return array('magento' => $magentoVersion,
363 363
                        'pagantis' => $moduleInfo['setup_version'],
364 364
                        'php' => phpversion(),
365 365
                        'curl' => $curlVersion);
Please login to merge, or discard this patch.
Controller/Notify/IndexV2.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
             $this->checkPagantisStatus(array('AUTHORIZED'));
263 263
         } catch (\Exception $e) {
264 264
             $this->getMagentoOrderId();
265
-            if ($this->magentoOrderId!='') {
265
+            if ($this->magentoOrderId != '') {
266 266
                 throw new AlreadyProcessedException();
267 267
             } else {
268 268
                 throw new WrongStatusException($this->pagantisOrder->getStatus());
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
      */
276 276
     private function checkMerchantOrderStatus()
277 277
     {
278
-        if ($this->quote->getIsActive()=='0') {
278
+        if ($this->quote->getIsActive() == '0') {
279 279
             $this->getMagentoOrderId();
280 280
             throw new AlreadyProcessedException();
281 281
         }
@@ -397,7 +397,7 @@  discard block
 block discarded – undo
397 397
             $tableName    = $this->dbObject->getTableName(self::CONCURRENCY_TABLE);
398 398
             if ($mode == false) {
399 399
                 $dbConnection->delete($tableName, "timestamp<".(time() - 5));
400
-            } elseif ($this->quoteId!='') {
400
+            } elseif ($this->quoteId != '') {
401 401
                 $dbConnection->delete($tableName, "id=".$this->quoteId);
402 402
             }
403 403
         } catch (Exception $exception) {
@@ -452,7 +452,7 @@  discard block
 block discarded – undo
452 452
             /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
453 453
             $dbConnection = $this->dbObject->getConnection();
454 454
             $tableName    = $this->dbObject->getTableName(self::ORDERS_TABLE);
455
-            $pagantisOrderId   = $this->pagantisOrderId;
455
+            $pagantisOrderId = $this->pagantisOrderId;
456 456
 
457 457
             $query        = "select mg_order_id from $tableName where id='$this->quoteId' and order_id='$pagantisOrderId'";
458 458
             $queryResult  = $dbConnection->fetchRow($query);
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
492 492
             /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
493 493
             $dbConnection = $this->dbObject->getConnection();
494 494
             $tableName    = $this->dbObject->getTableName(self::ORDERS_TABLE);
495
-            $pagantisOrderId   = $this->pagantisOrder->getId();
495
+            $pagantisOrderId = $this->pagantisOrder->getId();
496 496
             $dbConnection->update(
497 497
                 $tableName,
498 498
                 array('mg_order_id' => $this->magentoOrderId),
@@ -525,7 +525,7 @@  discard block
 block discarded – undo
525 525
     {
526 526
         //$returnUrl = 'checkout/#payment';
527 527
         $returnUrl = $this->_url->getUrl('checkout', ['_fragment' => 'payment']);
528
-        if ($this->magentoOrderId!='') {
528
+        if ($this->magentoOrderId != '') {
529 529
             /** @var Order $this->magentoOrder */
530 530
             $this->magentoOrder = $this->orderRepositoryInterface->get($this->magentoOrderId);
531 531
             if (!$this->_objectManager->get(\Magento\Checkout\Model\Session\SuccessValidator::class)->isValid()) {
@@ -542,7 +542,7 @@  discard block
 block discarded – undo
542 542
             $orderStatus    = strtolower($this->magentoOrder->getStatus());
543 543
             $acceptedStatus = array('processing', 'completed');
544 544
             if (in_array($orderStatus, $acceptedStatus)) {
545
-                if (isset($this->extraConfig['PAGANTIS_OK_URL']) &&  $this->extraConfig['PAGANTIS_OK_URL']!= '') {
545
+                if (isset($this->extraConfig['PAGANTIS_OK_URL']) && $this->extraConfig['PAGANTIS_OK_URL'] != '') {
546 546
                     $returnUrl = $this->extraConfig['PAGANTIS_OK_URL'];
547 547
                 } else {
548 548
                     $returnUrl = 'checkout/onepage/success';
Please login to merge, or discard this patch.
Setup/InstallData.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -16,20 +16,20 @@
 block discarded – undo
16 16
      * @var array $defaultConfigs
17 17
      */
18 18
     public $defaultConfigs = array('PAGANTIS_TITLE'=>'Instant Financing',
19
-                           'PAGANTIS_SIMULATOR_DISPLAY_TYPE'=>'pgSDK.simulator.types.SIMPLE',
20
-                           'PAGANTIS_SIMULATOR_DISPLAY_SKIN'=>'pgSDK.simulator.skins.BLUE',
21
-                           'PAGANTIS_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
22
-                           'PAGANTIS_SIMULATOR_START_INSTALLMENTS'=>3,
23
-                           'PAGANTIS_SIMULATOR_MAX_INSTALLMENTS'=>12,
24
-                           'PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
25
-                           'PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'=>'pgSDK.simulator.positions.INNER',
26
-                           'PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
27
-                           'PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
28
-                           'PAGANTIS_FORM_DISPLAY_TYPE'=>0,
29
-                           'PAGANTIS_DISPLAY_MIN_AMOUNT'=>1,
30
-                           'PAGANTIS_URL_OK'=>'',
31
-                           'PAGANTIS_URL_KO'=>'',
32
-                           'PAGANTIS_TITLE_EXTRA' => 'Pay up to 12 comfortable installments with Pagantis. Completely online and sympathetic request, and the answer is immediate!'
19
+                            'PAGANTIS_SIMULATOR_DISPLAY_TYPE'=>'pgSDK.simulator.types.SIMPLE',
20
+                            'PAGANTIS_SIMULATOR_DISPLAY_SKIN'=>'pgSDK.simulator.skins.BLUE',
21
+                            'PAGANTIS_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
22
+                            'PAGANTIS_SIMULATOR_START_INSTALLMENTS'=>3,
23
+                            'PAGANTIS_SIMULATOR_MAX_INSTALLMENTS'=>12,
24
+                            'PAGANTIS_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
25
+                            'PAGANTIS_SIMULATOR_DISPLAY_CSS_POSITION'=>'pgSDK.simulator.positions.INNER',
26
+                            'PAGANTIS_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
27
+                            'PAGANTIS_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
28
+                            'PAGANTIS_FORM_DISPLAY_TYPE'=>0,
29
+                            'PAGANTIS_DISPLAY_MIN_AMOUNT'=>1,
30
+                            'PAGANTIS_URL_OK'=>'',
31
+                            'PAGANTIS_URL_KO'=>'',
32
+                            'PAGANTIS_TITLE_EXTRA' => 'Pay up to 12 comfortable installments with Pagantis. Completely online and sympathetic request, and the answer is immediate!'
33 33
     );
34 34
 
35 35
     /**
Please login to merge, or discard this patch.
Test/PagantisMagentoTest.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -150,16 +150,16 @@  discard block
 block discarded – undo
150 150
         $faker = Factory::create();
151 151
         $this->configuration['dni'] = $this->getDNI();
152 152
         $this->configuration['birthdate'] =
153
-            $faker->numberBetween(1, 28) . '/' .
154
-            $faker->numberBetween(1, 12). '/1975'
153
+            $faker->numberBetween(1, 28).'/'.
154
+            $faker->numberBetween(1, 12).'/1975'
155 155
         ;
156 156
         $this->configuration['firstname'] = $faker->firstName;
157
-        $this->configuration['lastname'] = $faker->lastName . ' ' . $faker->lastName;
157
+        $this->configuration['lastname'] = $faker->lastName.' '.$faker->lastName;
158 158
         $this->configuration['company'] = $faker->company;
159 159
         $this->configuration['zip'] = '28'.$faker->randomNumber(3, true);
160 160
         $this->configuration['street'] = $faker->streetAddress;
161
-        $this->configuration['phone'] = '6' . $faker->randomNumber(8);
162
-        $this->configuration['email'] = date('ymd') . '@pagantis.com';
161
+        $this->configuration['phone'] = '6'.$faker->randomNumber(8);
162
+        $this->configuration['email'] = date('ymd').'@pagantis.com';
163 163
 
164 164
         if (!isset($_SERVER['argv']) ||
165 165
             !isset($_SERVER['argv'][4]) ||
@@ -183,12 +183,12 @@  discard block
 block discarded – undo
183 183
      */
184 184
     protected function getDNI()
185 185
     {
186
-        $dni = '0000' . rand(pow(10, 4-1), pow(10, 4)-1);
186
+        $dni = '0000'.rand(pow(10, 4 - 1), pow(10, 4) - 1);
187 187
         $value = (int) ($dni / 23);
188 188
         $value *= 23;
189
-        $value= $dni - $value;
190
-        $letter= "TRWAGMYFPDXBNJZSQVHLCKEO";
191
-        $dniLetter= substr($letter, $value, 1);
189
+        $value = $dni - $value;
190
+        $letter = "TRWAGMYFPDXBNJZSQVHLCKEO";
191
+        $dniLetter = substr($letter, $value, 1);
192 192
         return $dni.$dniLetter;
193 193
     }
194 194
 
Please login to merge, or discard this patch.