pagantis / magento-2X

Test/Buy/PaylaterMgBuyRegisteredTest.php

Spacing +2 added lines, -2 removed lines

@@ -83,7 +83,7 @@ 
         $this->assertNotEmpty($orderUrl);
 
         $orderArray     = explode('/', $orderUrl);
-        $magentoOrderId = (int)$orderArray['8'];
+        $magentoOrderId = (int) $orderArray['8'];
         $this->assertNotEmpty($magentoOrderId);
         $notifyFile = 'index/';
         $quoteId    = ($magentoOrderId) - 1;
@@ -135,7 +135,7 @@ 
     {
         $version = '';
         if (version_compare($this->version, '23') >= 0) {
-            $version    = "V2";
+            $version = "V2";
         }
 
         $logUrl = sprintf(

Test/Common/AbstractMg21Selenium.php

Spacing +5 added lines, -5 removed lines

@@ -77,7 +77,7 @@ 
         $condition = WebDriverExpectedCondition::visibilityOfElementLocated($elementSearch);
         $this->webDriver->wait()->until($condition);
         $otherElement = $this->findById('payment_us_other_payment_methods-head');
-        if ($otherElement->getAttribute('class')!='open') {
+        if ($otherElement->getAttribute('class') != 'open') {
             $otherElement->click();
         }
 
@@ -86,7 +86,7 @@ 
         $this->webDriver->wait()->until($condition);
         $this->assertTrue((bool) $condition, "PR4");
         $pagantisElement = $this->findById('payment_us_pagantis-head');
-        if ($pagantisElement->getAttribute('class')!='open') {
+        if ($pagantisElement->getAttribute('class') != 'open') {
             $pagantisElement->click();
         }
 
@@ -278,7 +278,7 @@ 
         $this->webDriver->get($this->configuration['magentoUrl'].self::CHECKOUT_FOLDER);
         $condition = WebDriverExpectedCondition::titleContains(self::CHECKOUT_TITLE);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool)$condition, $this->configuration['magentoUrl'].self::CHECKOUT_FOLDER);
+        $this->assertTrue((bool) $condition, $this->configuration['magentoUrl'].self::CHECKOUT_FOLDER);
     }
 
     /**
@@ -291,7 +291,7 @@ 
         $this->webDriver->wait()->until($condition);
         $this->assertTrue((bool) $condition);
         $this->assertSame(
-            $this->configuration['firstname'] . ' ' . $this->configuration['lastname'],
+            $this->configuration['firstname'].' '.$this->configuration['lastname'],
             $this->findByClass('FieldsPreview-desc')->getText()
         );
     }
@@ -305,7 +305,7 @@ 
     {
         $condition = WebDriverExpectedCondition::titleContains(self::PAGANTIS_TITLE);
         $this->webDriver->wait(300)->until($condition, $this->webDriver->getCurrentURL());
-        $this->assertTrue((bool)$condition, "PR32");
+        $this->assertTrue((bool) $condition, "PR32");
 
         SeleniumHelper::finishForm($this->webDriver);
     }

Observer/PaymentMethodAvailable.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
     public function execute(\Magento\Framework\Event\Observer $observer)
     {
         try {
-            if ($observer->getEvent()->getMethodInstance()->getCode()=="pagantis") {
+            if ($observer->getEvent()->getMethodInstance()->getCode() == "pagantis") {
                 $checkResult = $observer->getEvent()->getResult();
                 $objectManager = \Magento\Framework\App\ObjectManager::getInstance();
                 $config        = $objectManager->create('Pagantis\Pagantis\Helper\Config')->getConfig();

Model/Adminhtml/Source/ConfigButtonLinkType.php

Spacing +2 added lines, -2 removed lines

@@ -26,9 +26,9 @@
     {
         $originalData = $element->getOriginalData();
         $label = __($originalData['button_label']);
-        $url =   $this->escapeHtml($originalData['button_url']);
+        $url = $this->escapeHtml($originalData['button_url']);
         $labelCredentials = __($originalData['button_credentials_label']);
-        $urlCredentials =   $this->escapeHtml($originalData['button_credentials_url']);
+        $urlCredentials = $this->escapeHtml($originalData['button_credentials_url']);
         return <<<EOD
 <div class="pp-buttons-container">
     <button onclick="javascript:window.open('$url')" class="scalable" type="button" id="bo_pagantis">

Controller/Notify/Index.php

Spacing +7 added lines, -7 removed lines

@@ -262,7 +262,7 @@ 
             $this->checkPagantisStatus(array('AUTHORIZED'));
         } catch (\Exception $e) {
             $this->getMagentoOrderId();
-            if ($this->magentoOrderId!='') {
+            if ($this->magentoOrderId != '') {
                 throw new AlreadyProcessedException();
             } else {
                 throw new WrongStatusException($this->pagantisOrder->getStatus());
@@ -275,7 +275,7 @@ 
      */
     private function checkMerchantOrderStatus()
     {
-        if ($this->quote->getIsActive()=='0') {
+        if ($this->quote->getIsActive() == '0') {
             $this->getMagentoOrderId();
             throw new AlreadyProcessedException();
         }
@@ -397,7 +397,7 @@ 
             $tableName    = $this->dbObject->getTableName(self::CONCURRENCY_TABLE);
             if ($mode == false) {
                 $dbConnection->delete($tableName, "timestamp<".(time() - 5));
-            } elseif ($this->quoteId!='') {
+            } elseif ($this->quoteId != '') {
                 $dbConnection->delete($tableName, "id=".$this->quoteId);
             }
         } catch (Exception $exception) {
@@ -452,7 +452,7 @@ 
             /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
             $dbConnection = $this->dbObject->getConnection();
             $tableName    = $this->dbObject->getTableName(self::ORDERS_TABLE);
-            $pagantisOrderId   = $this->pagantisOrderId;
+            $pagantisOrderId = $this->pagantisOrderId;
 
             $query        = "select mg_order_id from $tableName where id='$this->quoteId' and order_id='$pagantisOrderId'";
             $queryResult  = $dbConnection->fetchRow($query);
@@ -492,7 +492,7 @@ 
             /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
             $dbConnection = $this->dbObject->getConnection();
             $tableName    = $this->dbObject->getTableName(self::ORDERS_TABLE);
-            $pagantisOrderId   = $this->pagantisOrder->getId();
+            $pagantisOrderId = $this->pagantisOrder->getId();
             $dbConnection->update(
                 $tableName,
                 array('mg_order_id' => $this->magentoOrderId),
@@ -525,7 +525,7 @@ 
     {
         //$returnUrl = 'checkout/#payment';
         $returnUrl = $this->_url->getUrl('checkout', ['_fragment' => 'payment']);
-        if ($this->magentoOrderId!='') {
+        if ($this->magentoOrderId != '') {
             /** @var Order $this->magentoOrder */
             $this->magentoOrder = $this->orderRepositoryInterface->get($this->magentoOrderId);
             if (!$this->_objectManager->get(\Magento\Checkout\Model\Session\SuccessValidator::class)->isValid()) {
@@ -542,7 +542,7 @@ 
             $orderStatus    = strtolower($this->magentoOrder->getStatus());
             $acceptedStatus = array('processing', 'completed');
             if (in_array($orderStatus, $acceptedStatus)) {
-                if (isset($this->extraConfig['PAGANTIS_OK_URL']) &&  $this->extraConfig['PAGANTIS_OK_URL']!= '') {
+                if (isset($this->extraConfig['PAGANTIS_OK_URL']) && $this->extraConfig['PAGANTIS_OK_URL'] != '') {
                     $returnUrl = $this->extraConfig['PAGANTIS_OK_URL'];
                 } else {
                     $returnUrl = 'checkout/onepage/success';

Controller/Payment/Log.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
             $secretKey = $this->getRequest()->getParam('secret');
             $privateKey = isset($this->config['pagantis_private_key']) ? $this->config['pagantis_private_key'] : null;
 
-            if ($secretKey!='' && $privateKey!='') {
+            if ($secretKey != '' && $privateKey != '') {
                 $this->checkDbLogTable();
                 /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
                 $dbConnection = $this->dbObject->getConnection();

Controller/Payment/Index.php

Spacing +11 added lines, -11 removed lines

@@ -107,12 +107,12 @@ 
             $customer = $quote->getCustomer();
             $shippingAddress = $quote->getShippingAddress();
 
-            if (isset($params['email']) && $params['email']!='') {
+            if (isset($params['email']) && $params['email'] != '') {
                 $this->session->setEmail($params['email']); //Get guest email after refresh page
                 $customer->setEmail($params['email']);
                 $quote->setCheckoutMethod('guest');
                 $quote->getBillingAddress()->setEmail($params['email']);
-            } elseif ($customer->getEmail()=='') {
+            } elseif ($customer->getEmail() == '') {
                 $customer->setEmail($this->session->getEmail());
                 $quote->setCheckoutMethod('guest');
                 $quote->getBillingAddress()->setEmail($this->session->getEmail());
@@ -123,7 +123,7 @@ 
             $currentQuote->setCustomerEmail($customer->getEmail());
             $this->quoteRepository->save($currentQuote);
 
-            $userAddress =  new Address();
+            $userAddress = new Address();
             $userAddress
                 ->setZipCode($shippingAddress->getPostcode())
                 ->setFullName($shippingAddress->getFirstname()." ".$shippingAddress->getLastname())
@@ -143,7 +143,7 @@ 
                 ->setMobilePhone($shippingAddress->getTelephone())
             ;
 
-            $orderBillingAddress =  new Address();
+            $orderBillingAddress = new Address();
             $billingAddress = $quote->getBillingAddress();
             $orderBillingAddress
                 ->setZipCode($billingAddress->getPostcode())
@@ -170,7 +170,7 @@ 
             if ($customer->getDob()) {
                 $orderUser->setDateOfBirth($customer->getDob());
             }
-            if ($customer->getTaxvat()!='') {
+            if ($customer->getTaxvat() != '') {
                 $orderUser->setDni($customer->getTaxvat());
                 $orderBillingAddress->setDni($customer->getTaxvat());
                 $orderShippingAddress->setDni($customer->getTaxvat());
@@ -250,7 +250,7 @@ 
                 ->setUser($orderUser)
             ;
 
-            if ($this->config['pagantis_public_key']=='' || $this->config['pagantis_private_key']=='') {
+            if ($this->config['pagantis_public_key'] == '' || $this->config['pagantis_private_key'] == '') {
                 throw new \Exception('Public and Secret Key not found');
             }
 
@@ -276,7 +276,7 @@ 
         }
 
         $displayMode = $this->extraConfig['PAGANTIS_FORM_DISPLAY_TYPE'];
-        if ($displayMode==='0') {
+        if ($displayMode === '0') {
             echo $url;
             exit;
         } else {
@@ -298,11 +298,11 @@ 
     private function getOrders($customerId)
     {
         $orderCollection = array();
-        if ($customerId!='') {
+        if ($customerId != '') {
             $this->orderCollection->addAttributeToFilter('customer_id', $customerId)
                             ->addAttributeToFilter(
                                 'status',
-                                ['in' => ['processing','pending','complete']]
+                                ['in' => ['processing', 'pending', 'complete']]
                             )
                             ->load();
             $orderCollection = $this->orderCollection->getData();
@@ -345,7 +345,7 @@ 
         $tableName = $this->dbObject->getTableName(self::ORDERS_TABLE);
         return $dbConnection->insertOnDuplicate(
             $tableName,
-            array('id'=>$quoteId,'order_id'=>$pagantisOrderId),
+            array('id'=>$quoteId, 'order_id'=>$pagantisOrderId),
             array('order_id')
         );
     }
@@ -359,7 +359,7 @@ 
         $curlVersion = $curlInfo['version'];
         $magentoVersion = $this->productMetadataInterface->getVersion();
         $moduleInfo = $this->moduleList->getOne('Pagantis_Pagantis');
-        return array(  'magento' => $magentoVersion,
+        return array('magento' => $magentoVersion,
                        'pagantis' => $moduleInfo['setup_version'],
                        'php' => phpversion(),
                        'curl' => $curlVersion);

Controller/Notify/IndexV2.php

Spacing +7 added lines, -7 removed lines

@@ -262,7 +262,7 @@ 
             $this->checkPagantisStatus(array('AUTHORIZED'));
         } catch (\Exception $e) {
             $this->getMagentoOrderId();
-            if ($this->magentoOrderId!='') {
+            if ($this->magentoOrderId != '') {
                 throw new AlreadyProcessedException();
             } else {
                 throw new WrongStatusException($this->pagantisOrder->getStatus());
@@ -275,7 +275,7 @@ 
      */
     private function checkMerchantOrderStatus()
     {
-        if ($this->quote->getIsActive()=='0') {
+        if ($this->quote->getIsActive() == '0') {
             $this->getMagentoOrderId();
             throw new AlreadyProcessedException();
         }
@@ -397,7 +397,7 @@ 
             $tableName    = $this->dbObject->getTableName(self::CONCURRENCY_TABLE);
             if ($mode == false) {
                 $dbConnection->delete($tableName, "timestamp<".(time() - 5));
-            } elseif ($this->quoteId!='') {
+            } elseif ($this->quoteId != '') {
                 $dbConnection->delete($tableName, "id=".$this->quoteId);
             }
         } catch (Exception $exception) {
@@ -452,7 +452,7 @@ 
             /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
             $dbConnection = $this->dbObject->getConnection();
             $tableName    = $this->dbObject->getTableName(self::ORDERS_TABLE);
-            $pagantisOrderId   = $this->pagantisOrderId;
+            $pagantisOrderId = $this->pagantisOrderId;
 
             $query        = "select mg_order_id from $tableName where id='$this->quoteId' and order_id='$pagantisOrderId'";
             $queryResult  = $dbConnection->fetchRow($query);
@@ -492,7 +492,7 @@ 
             /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
             $dbConnection = $this->dbObject->getConnection();
             $tableName    = $this->dbObject->getTableName(self::ORDERS_TABLE);
-            $pagantisOrderId   = $this->pagantisOrder->getId();
+            $pagantisOrderId = $this->pagantisOrder->getId();
             $dbConnection->update(
                 $tableName,
                 array('mg_order_id' => $this->magentoOrderId),
@@ -525,7 +525,7 @@ 
     {
         //$returnUrl = 'checkout/#payment';
         $returnUrl = $this->_url->getUrl('checkout', ['_fragment' => 'payment']);
-        if ($this->magentoOrderId!='') {
+        if ($this->magentoOrderId != '') {
             /** @var Order $this->magentoOrder */
             $this->magentoOrder = $this->orderRepositoryInterface->get($this->magentoOrderId);
             if (!$this->_objectManager->get(\Magento\Checkout\Model\Session\SuccessValidator::class)->isValid()) {
@@ -542,7 +542,7 @@ 
             $orderStatus    = strtolower($this->magentoOrder->getStatus());
             $acceptedStatus = array('processing', 'completed');
             if (in_array($orderStatus, $acceptedStatus)) {
-                if (isset($this->extraConfig['PAGANTIS_OK_URL']) &&  $this->extraConfig['PAGANTIS_OK_URL']!= '') {
+                if (isset($this->extraConfig['PAGANTIS_OK_URL']) && $this->extraConfig['PAGANTIS_OK_URL'] != '') {
                     $returnUrl = $this->extraConfig['PAGANTIS_OK_URL'];
                 } else {
                     $returnUrl = 'checkout/onepage/success';

Controller/Payment/LogV2.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
             $secretKey = $this->getRequest()->getParam('secret');
             $privateKey = isset($this->config['pagantis_private_key']) ? $this->config['pagantis_private_key'] : null;
 
-            if ($secretKey!='' && $privateKey!='') {
+            if ($secretKey != '' && $privateKey != '') {
                 $this->checkDbLogTable();
                 /** @var \Magento\Framework\DB\Adapter\AdapterInterface $dbConnection */
                 $dbConnection = $this->dbObject->getConnection();