Pagantis\Pagantis\Block\Info

Complexity

Total Complexity

3

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getLabel()	0	3	1
A	getValueView()	0	7	2

<?php

namespace Pagantis\Pagantis\Block;

use Magento\Framework\Phrase;
use Magento\Payment\Block\ConfigurableInfo;
use Pagantis\Pagantis\Gateway\Response\FraudHandler;

/**
 * Class Info
 * @package Pagantis\Pagantis\Block
 */
class Info extends ConfigurableInfo
{
    /**
     * Returns label
     *
     * @param string $field
     * @return Phrase
     */
    protected function getLabel($field)
    {
        return __($field);
    }

    /**
     * Returns value view
     *
     * @param string $field
     * @param string | array $value
     * @return string | Phrase
     */
    protected function getValueView($field, $value)
    {
        switch ($field) {
            case FraudHandler::FRAUD_MSG_LIST:
                return implode('; ', $value);

It seems like $value can also be of type string; however, parameter $pieces of implode() does only seem to accept array, maybe add an additional type check?

        }
        return parent::getValueView($field, $value);

It seems like $value can also be of type array; however, parameter $value of Magento\Payment\Block\ConfigurableInfo::getValueView() does only seem to accept string, maybe add an additional type check?

    }
}