Complex classes like Expectation often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Expectation, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 26 | class Expectation implements ExpectationInterface |
||
| 27 | { |
||
| 28 | /** |
||
| 29 | * Mock object to which this expectation belongs |
||
| 30 | * |
||
| 31 | * @var object |
||
| 32 | */ |
||
| 33 | protected $_mock = null; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * Method name |
||
| 37 | * |
||
| 38 | * @var string |
||
| 39 | */ |
||
| 40 | protected $_name = null; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Arguments expected by this expectation |
||
| 44 | * |
||
| 45 | * @var array |
||
| 46 | */ |
||
| 47 | protected $_expectedArgs = array(); |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Count validator store |
||
| 51 | * |
||
| 52 | * @var array |
||
| 53 | */ |
||
| 54 | protected $_countValidators = array(); |
||
| 55 | |||
| 56 | /** |
||
| 57 | * The count validator class to use |
||
| 58 | * |
||
| 59 | * @var string |
||
| 60 | */ |
||
| 61 | protected $_countValidatorClass = 'Mockery\CountValidator\Exact'; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * Actual count of calls to this expectation |
||
| 65 | * |
||
| 66 | * @var int |
||
| 67 | */ |
||
| 68 | protected $_actualCount = 0; |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Value to return from this expectation |
||
| 72 | * |
||
| 73 | * @var mixed |
||
| 74 | */ |
||
| 75 | protected $_returnValue = null; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * Array of return values as a queue for multiple return sequence |
||
| 79 | * |
||
| 80 | * @var array |
||
| 81 | */ |
||
| 82 | protected $_returnQueue = array(); |
||
| 83 | |||
| 84 | /** |
||
| 85 | * Array of closures executed with given arguments to generate a result |
||
| 86 | * to be returned |
||
| 87 | * |
||
| 88 | * @var array |
||
| 89 | */ |
||
| 90 | protected $_closureQueue = array(); |
||
| 91 | |||
| 92 | /** |
||
| 93 | * Array of values to be set when this expectation matches |
||
| 94 | * |
||
| 95 | * @var array |
||
| 96 | */ |
||
| 97 | protected $_setQueue = array(); |
||
| 98 | |||
| 99 | /** |
||
| 100 | * Integer representing the call order of this expectation |
||
| 101 | * |
||
| 102 | * @var int |
||
| 103 | */ |
||
| 104 | protected $_orderNumber = null; |
||
| 105 | |||
| 106 | /** |
||
| 107 | * Integer representing the call order of this expectation on a global basis |
||
| 108 | * |
||
| 109 | * @var int |
||
| 110 | */ |
||
| 111 | protected $_globalOrderNumber = null; |
||
| 112 | |||
| 113 | /** |
||
| 114 | * Flag indicating that an exception is expected to be throw (not returned) |
||
| 115 | * |
||
| 116 | * @var bool |
||
| 117 | */ |
||
| 118 | protected $_throw = false; |
||
| 119 | |||
| 120 | /** |
||
| 121 | * Flag indicating whether the order of calling is determined locally or |
||
| 122 | * globally |
||
| 123 | * |
||
| 124 | * @var bool |
||
| 125 | */ |
||
| 126 | protected $_globally = false; |
||
| 127 | |||
| 128 | /** |
||
| 129 | * Flag indicating we expect no arguments |
||
| 130 | * |
||
| 131 | * @var bool |
||
| 132 | */ |
||
| 133 | protected $_noArgsExpectation = false; |
||
| 134 | |||
| 135 | /** |
||
| 136 | * Flag indicating if the return value should be obtained from the original |
||
| 137 | * class method instead of returning predefined values from the return queue |
||
| 138 | * |
||
| 139 | * @var bool |
||
| 140 | */ |
||
| 141 | protected $_passthru = false; |
||
| 142 | |||
| 143 | /** |
||
| 144 | * Constructor |
||
| 145 | * |
||
| 146 | * @param \Mockery\MockInterface $mock |
||
| 147 | * @param string $name |
||
| 148 | */ |
||
| 149 | 306 | public function __construct(\Mockery\MockInterface $mock, $name) |
|
| 154 | |||
| 155 | /** |
||
| 156 | * Return a string with the method name and arguments formatted |
||
| 157 | * |
||
| 158 | * @param string $name Name of the expected method |
||
| 159 | * @param array $args List of arguments to the method |
||
| 160 | * @return string |
||
| 161 | */ |
||
| 162 | 45 | public function __toString() |
|
| 166 | |||
| 167 | /** |
||
| 168 | * Verify the current call, i.e. that the given arguments match those |
||
| 169 | * of this expectation |
||
| 170 | * |
||
| 171 | * @param array $args |
||
| 172 | * @return mixed |
||
| 173 | */ |
||
| 174 | 235 | public function verifyCall(array $args) |
|
| 175 | { |
||
| 176 | 235 | $this->validateOrder(); |
|
| 177 | 235 | $this->_actualCount++; |
|
| 178 | 235 | if (true === $this->_passthru) { |
|
| 179 | 3 | return $this->_mock->mockery_callSubjectMethod($this->_name, $args); |
|
| 180 | } |
||
| 181 | |||
| 182 | 233 | $return = $this->_getReturnValue($args); |
|
| 183 | 233 | $this->throwAsNecessary($return); |
|
| 184 | 227 | $this->_setValues(); |
|
| 185 | |||
| 186 | 227 | return $return; |
|
| 187 | } |
||
| 188 | |||
| 189 | /** |
||
| 190 | * Throws an exception if the expectation has been configured to do so |
||
| 191 | * |
||
| 192 | * @throws \Exception|\Throwable |
||
| 193 | * @return void |
||
| 194 | */ |
||
| 195 | 233 | private function throwAsNecessary($return) |
|
| 196 | { |
||
| 197 | 233 | if (!$this->_throw) { |
|
| 198 | 227 | return; |
|
| 199 | } |
||
| 200 | |||
| 201 | 7 | $type = version_compare(PHP_VERSION, '7.0.0') >= 0 |
|
| 202 | 7 | ? "\Throwable" |
|
| 203 | 7 | : "\Exception"; |
|
| 204 | |||
| 205 | 7 | if ($return instanceof $type) { |
|
| 206 | 7 | throw $return; |
|
| 207 | } |
||
| 208 | |||
| 209 | return; |
||
|
|
|||
| 210 | } |
||
| 211 | |||
| 212 | /** |
||
| 213 | * Sets public properties with queued values to the mock object |
||
| 214 | * |
||
| 215 | * @param array $args |
||
| 216 | * @return mixed |
||
| 217 | */ |
||
| 218 | 227 | protected function _setValues() |
|
| 219 | { |
||
| 220 | 227 | foreach ($this->_setQueue as $name => &$values) { |
|
| 221 | 8 | if (count($values) > 0) { |
|
| 222 | 8 | $value = array_shift($values); |
|
| 223 | 8 | $this->_mock->{$name} = $value; |
|
| 224 | 8 | } |
|
| 225 | 227 | } |
|
| 226 | 227 | } |
|
| 227 | |||
| 228 | /** |
||
| 229 | * Fetch the return value for the matching args |
||
| 230 | * |
||
| 231 | * @param array $args |
||
| 232 | * @return mixed |
||
| 233 | */ |
||
| 234 | 233 | protected function _getReturnValue(array $args) |
|
| 235 | { |
||
| 236 | 233 | if (count($this->_closureQueue) > 1) { |
|
| 237 | return call_user_func_array(array_shift($this->_closureQueue), $args); |
||
| 238 | 233 | } elseif (count($this->_closureQueue) > 0) { |
|
| 239 | 1 | return call_user_func_array(current($this->_closureQueue), $args); |
|
| 240 | 232 | } elseif (count($this->_returnQueue) > 1) { |
|
| 241 | 5 | return array_shift($this->_returnQueue); |
|
| 242 | 231 | } elseif (count($this->_returnQueue) > 0) { |
|
| 243 | 93 | return current($this->_returnQueue); |
|
| 244 | } |
||
| 245 | |||
| 246 | 139 | return $this->_mock->mockery_returnValueForMethod($this->_name); |
|
| 247 | } |
||
| 248 | |||
| 249 | /** |
||
| 250 | * Checks if this expectation is eligible for additional calls |
||
| 251 | * |
||
| 252 | * @return bool |
||
| 253 | */ |
||
| 254 | 273 | public function isEligible() |
|
| 263 | |||
| 264 | /** |
||
| 265 | * Check if there is a constraint on call count |
||
| 266 | * |
||
| 267 | * @return bool |
||
| 268 | */ |
||
| 269 | public function isCallCountConstrained() |
||
| 273 | |||
| 274 | /** |
||
| 275 | * Verify call order |
||
| 276 | * |
||
| 277 | * @return void |
||
| 278 | */ |
||
| 279 | 235 | public function validateOrder() |
|
| 289 | |||
| 290 | /** |
||
| 291 | * Verify this expectation |
||
| 292 | * |
||
| 293 | * @return bool |
||
| 294 | */ |
||
| 295 | 144 | public function verify() |
|
| 301 | |||
| 302 | /** |
||
| 303 | * Check if the registered expectation is a MultiArgumentClosureExpectation. |
||
| 304 | * @return bool |
||
| 305 | */ |
||
| 306 | 116 | private function isMultiArgumentClosureExpectation() |
|
| 310 | |||
| 311 | /** |
||
| 312 | * Check if passed arguments match an argument expectation |
||
| 313 | * |
||
| 314 | * @param array $args |
||
| 315 | * @return bool |
||
| 316 | */ |
||
| 317 | 279 | public function matchArgs(array $args) |
|
| 338 | |||
| 339 | /** |
||
| 340 | * Check if passed argument matches an argument expectation |
||
| 341 | * |
||
| 342 | * @param mixed $expected |
||
| 343 | * @param mixed &$actual |
||
| 344 | * @return bool |
||
| 345 | */ |
||
| 346 | 108 | protected function _matchArg($expected, &$actual) |
|
| 379 | |||
| 380 | /** |
||
| 381 | * Expected argument setter for the expectation |
||
| 382 | * |
||
| 383 | * @param mixed ... |
||
| 384 | * @return self |
||
| 385 | */ |
||
| 386 | 130 | public function with() |
|
| 390 | |||
| 391 | /** |
||
| 392 | * Expected arguments for the expectation passed as an array |
||
| 393 | * |
||
| 394 | * @param array $arguments |
||
| 395 | * @return self |
||
| 396 | */ |
||
| 397 | 139 | private function withArgsInArray(array $arguments) |
|
| 406 | |||
| 407 | /** |
||
| 408 | * Expected arguments have to be matched by the given closure. |
||
| 409 | * |
||
| 410 | * @param Closure $closure |
||
| 411 | * @return self |
||
| 412 | */ |
||
| 413 | 6 | private function withArgsMatchedByClosure(Closure $closure) |
|
| 419 | |||
| 420 | /** |
||
| 421 | * Expected arguments for the expectation passed as an array or a closure that matches each passed argument on |
||
| 422 | * each function call. |
||
| 423 | * |
||
| 424 | * @param array|Closure $argsOrClosure |
||
| 425 | * @return self |
||
| 426 | */ |
||
| 427 | 146 | public function withArgs($argsOrClosure) |
|
| 439 | |||
| 440 | /** |
||
| 441 | * Set with() as no arguments expected |
||
| 442 | * |
||
| 443 | * @return self |
||
| 444 | */ |
||
| 445 | 7 | public function withNoArgs() |
|
| 451 | |||
| 452 | /** |
||
| 453 | * Set expectation that any arguments are acceptable |
||
| 454 | * |
||
| 455 | * @return self |
||
| 456 | */ |
||
| 457 | 3 | public function withAnyArgs() |
|
| 463 | |||
| 464 | /** |
||
| 465 | * Set a return value, or sequential queue of return values |
||
| 466 | * |
||
| 467 | * @param mixed ... |
||
| 468 | * @return self |
||
| 469 | */ |
||
| 470 | 106 | public function andReturn() |
|
| 475 | |||
| 476 | /** |
||
| 477 | * Set a return value, or sequential queue of return values |
||
| 478 | * |
||
| 479 | * @param mixed ... |
||
| 480 | * @return self |
||
| 481 | */ |
||
| 482 | public function andReturns() |
||
| 486 | |||
| 487 | /** |
||
| 488 | * Return this mock, like a fluent interface |
||
| 489 | * |
||
| 490 | * @return self |
||
| 491 | */ |
||
| 492 | 1 | public function andReturnSelf() |
|
| 496 | |||
| 497 | /** |
||
| 498 | * Set a sequential queue of return values with an array |
||
| 499 | * |
||
| 500 | * @param array $values |
||
| 501 | * @return self |
||
| 502 | */ |
||
| 503 | 2 | public function andReturnValues(array $values) |
|
| 508 | |||
| 509 | /** |
||
| 510 | * Set a closure or sequence of closures with which to generate return |
||
| 511 | * values. The arguments passed to the expected method are passed to the |
||
| 512 | * closures as parameters. |
||
| 513 | * |
||
| 514 | * @param callable ... |
||
| 515 | * @return self |
||
| 516 | */ |
||
| 517 | 1 | public function andReturnUsing() |
|
| 522 | |||
| 523 | /** |
||
| 524 | * Return a self-returning black hole object. |
||
| 525 | * |
||
| 526 | * @return self |
||
| 527 | */ |
||
| 528 | 1 | public function andReturnUndefined() |
|
| 533 | |||
| 534 | /** |
||
| 535 | * Return null. This is merely a language construct for Mock describing. |
||
| 536 | * |
||
| 537 | * @return self |
||
| 538 | */ |
||
| 539 | 1 | public function andReturnNull() |
|
| 543 | |||
| 544 | 1 | public function andReturnFalse() |
|
| 548 | |||
| 549 | 1 | public function andReturnTrue() |
|
| 553 | |||
| 554 | /** |
||
| 555 | * Set Exception class and arguments to that class to be thrown |
||
| 556 | * |
||
| 557 | * @param string|\Exception $exception |
||
| 558 | * @param string $message |
||
| 559 | * @param int $code |
||
| 560 | * @param \Exception $previous |
||
| 561 | * @return self |
||
| 562 | */ |
||
| 563 | 6 | public function andThrow($exception, $message = '', $code = 0, \Exception $previous = null) |
|
| 573 | |||
| 574 | /** |
||
| 575 | * Set Exception classes to be thrown |
||
| 576 | * |
||
| 577 | * @param array $exceptions |
||
| 578 | * @return self |
||
| 579 | */ |
||
| 580 | 2 | public function andThrowExceptions(array $exceptions) |
|
| 590 | |||
| 591 | /** |
||
| 592 | * Register values to be set to a public property each time this expectation occurs |
||
| 593 | * |
||
| 594 | * @param string $name |
||
| 595 | * @param mixed $value |
||
| 596 | * @return self |
||
| 597 | */ |
||
| 598 | 8 | public function andSet($name, $value) |
|
| 605 | |||
| 606 | /** |
||
| 607 | * Alias to andSet(). Allows the natural English construct |
||
| 608 | * - set('foo', 'bar')->andReturn('bar') |
||
| 609 | * |
||
| 610 | * @param string $name |
||
| 611 | * @param mixed $value |
||
| 612 | * @return self |
||
| 613 | */ |
||
| 614 | 3 | public function set($name, $value) |
|
| 618 | |||
| 619 | /** |
||
| 620 | * Indicates this expectation should occur zero or more times |
||
| 621 | * |
||
| 622 | * @return self |
||
| 623 | */ |
||
| 624 | 2 | public function zeroOrMoreTimes() |
|
| 628 | |||
| 629 | /** |
||
| 630 | * Indicates the number of times this expectation should occur |
||
| 631 | * |
||
| 632 | * @param int $limit |
||
| 633 | * @throws InvalidArgumentException |
||
| 634 | * @return self |
||
| 635 | */ |
||
| 636 | 158 | public function times($limit = null) |
|
| 648 | |||
| 649 | /** |
||
| 650 | * Indicates that this expectation is never expected to be called |
||
| 651 | * |
||
| 652 | * @return self |
||
| 653 | */ |
||
| 654 | 38 | public function never() |
|
| 658 | |||
| 659 | /** |
||
| 660 | * Indicates that this expectation is expected exactly once |
||
| 661 | * |
||
| 662 | * @return self |
||
| 663 | */ |
||
| 664 | 108 | public function once() |
|
| 668 | |||
| 669 | /** |
||
| 670 | * Indicates that this expectation is expected exactly twice |
||
| 671 | * |
||
| 672 | * @return self |
||
| 673 | */ |
||
| 674 | 19 | public function twice() |
|
| 678 | |||
| 679 | /** |
||
| 680 | * Sets next count validator to the AtLeast instance |
||
| 681 | * |
||
| 682 | * @return self |
||
| 683 | */ |
||
| 684 | 14 | public function atLeast() |
|
| 689 | |||
| 690 | /** |
||
| 691 | * Sets next count validator to the AtMost instance |
||
| 692 | * |
||
| 693 | * @return self |
||
| 694 | */ |
||
| 695 | 7 | public function atMost() |
|
| 700 | |||
| 701 | /** |
||
| 702 | * Shorthand for setting minimum and maximum constraints on call counts |
||
| 703 | * |
||
| 704 | * @param int $minimum |
||
| 705 | * @param int $maximum |
||
| 706 | */ |
||
| 707 | public function between($minimum, $maximum) |
||
| 711 | |||
| 712 | /** |
||
| 713 | * Indicates that this expectation must be called in a specific given order |
||
| 714 | * |
||
| 715 | * @param string $group Name of the ordered group |
||
| 716 | * @return self |
||
| 717 | */ |
||
| 718 | 17 | public function ordered($group = null) |
|
| 728 | |||
| 729 | /** |
||
| 730 | * Indicates call order should apply globally |
||
| 731 | * |
||
| 732 | * @return self |
||
| 733 | */ |
||
| 734 | 1 | public function globally() |
|
| 739 | |||
| 740 | /** |
||
| 741 | * Setup the ordering tracking on the mock or mock container |
||
| 742 | * |
||
| 743 | * @param string $group |
||
| 744 | * @param object $ordering |
||
| 745 | * @return int |
||
| 746 | */ |
||
| 747 | 17 | protected function _defineOrdered($group, $ordering) |
|
| 760 | |||
| 761 | /** |
||
| 762 | * Return order number |
||
| 763 | * |
||
| 764 | * @return int |
||
| 765 | */ |
||
| 766 | 1 | public function getOrderNumber() |
|
| 770 | |||
| 771 | /** |
||
| 772 | * Mark this expectation as being a default |
||
| 773 | * |
||
| 774 | * @return self |
||
| 775 | */ |
||
| 776 | 25 | public function byDefault() |
|
| 784 | |||
| 785 | /** |
||
| 786 | * Return the parent mock of the expectation |
||
| 787 | * |
||
| 788 | * @return \Mockery\MockInterface |
||
| 789 | */ |
||
| 790 | 29 | public function getMock() |
|
| 794 | |||
| 795 | /** |
||
| 796 | * Flag this expectation as calling the original class method with the |
||
| 797 | * any provided arguments instead of using a return value queue. |
||
| 798 | * |
||
| 799 | * @return self |
||
| 800 | */ |
||
| 801 | 3 | public function passthru() |
|
| 812 | |||
| 813 | /** |
||
| 814 | * Cloning logic |
||
| 815 | * |
||
| 816 | */ |
||
| 817 | 9 | public function __clone() |
|
| 826 | |||
| 827 | 6 | public function getName() |
|
| 831 | } |
||
| 832 |