Complex classes like Expectation often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Expectation, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
26 | class Expectation implements ExpectationInterface |
||
27 | { |
||
28 | /** |
||
29 | * Mock object to which this expectation belongs |
||
30 | * |
||
31 | * @var object |
||
32 | */ |
||
33 | protected $_mock = null; |
||
34 | |||
35 | /** |
||
36 | * Method name |
||
37 | * |
||
38 | * @var string |
||
39 | */ |
||
40 | protected $_name = null; |
||
41 | |||
42 | /** |
||
43 | * Arguments expected by this expectation |
||
44 | * |
||
45 | * @var array |
||
46 | */ |
||
47 | protected $_expectedArgs = array(); |
||
48 | |||
49 | /** |
||
50 | * Count validator store |
||
51 | * |
||
52 | * @var array |
||
53 | */ |
||
54 | protected $_countValidators = array(); |
||
55 | |||
56 | /** |
||
57 | * The count validator class to use |
||
58 | * |
||
59 | * @var string |
||
60 | */ |
||
61 | protected $_countValidatorClass = 'Mockery\CountValidator\Exact'; |
||
62 | |||
63 | /** |
||
64 | * Actual count of calls to this expectation |
||
65 | * |
||
66 | * @var int |
||
67 | */ |
||
68 | protected $_actualCount = 0; |
||
69 | |||
70 | /** |
||
71 | * Value to return from this expectation |
||
72 | * |
||
73 | * @var mixed |
||
74 | */ |
||
75 | protected $_returnValue = null; |
||
76 | |||
77 | /** |
||
78 | * Array of return values as a queue for multiple return sequence |
||
79 | * |
||
80 | * @var array |
||
81 | */ |
||
82 | protected $_returnQueue = array(); |
||
83 | |||
84 | /** |
||
85 | * Array of closures executed with given arguments to generate a result |
||
86 | * to be returned |
||
87 | * |
||
88 | * @var array |
||
89 | */ |
||
90 | protected $_closureQueue = array(); |
||
91 | |||
92 | /** |
||
93 | * Array of values to be set when this expectation matches |
||
94 | * |
||
95 | * @var array |
||
96 | */ |
||
97 | protected $_setQueue = array(); |
||
98 | |||
99 | /** |
||
100 | * Integer representing the call order of this expectation |
||
101 | * |
||
102 | * @var int |
||
103 | */ |
||
104 | protected $_orderNumber = null; |
||
105 | |||
106 | /** |
||
107 | * Integer representing the call order of this expectation on a global basis |
||
108 | * |
||
109 | * @var int |
||
110 | */ |
||
111 | protected $_globalOrderNumber = null; |
||
112 | |||
113 | /** |
||
114 | * Flag indicating that an exception is expected to be throw (not returned) |
||
115 | * |
||
116 | * @var bool |
||
117 | */ |
||
118 | protected $_throw = false; |
||
119 | |||
120 | /** |
||
121 | * Flag indicating whether the order of calling is determined locally or |
||
122 | * globally |
||
123 | * |
||
124 | * @var bool |
||
125 | */ |
||
126 | protected $_globally = false; |
||
127 | |||
128 | /** |
||
129 | * Flag indicating we expect no arguments |
||
130 | * |
||
131 | * @var bool |
||
132 | */ |
||
133 | protected $_noArgsExpectation = false; |
||
134 | |||
135 | /** |
||
136 | * Flag indicating if the return value should be obtained from the original |
||
137 | * class method instead of returning predefined values from the return queue |
||
138 | * |
||
139 | * @var bool |
||
140 | */ |
||
141 | protected $_passthru = false; |
||
142 | |||
143 | /** |
||
144 | * Constructor |
||
145 | * |
||
146 | * @param \Mockery\MockInterface $mock |
||
147 | * @param string $name |
||
148 | */ |
||
149 | 305 | public function __construct(\Mockery\MockInterface $mock, $name) |
|
154 | |||
155 | /** |
||
156 | * Return a string with the method name and arguments formatted |
||
157 | * |
||
158 | * @param string $name Name of the expected method |
||
159 | * @param array $args List of arguments to the method |
||
160 | * @return string |
||
161 | */ |
||
162 | 45 | public function __toString() |
|
166 | |||
167 | /** |
||
168 | * Verify the current call, i.e. that the given arguments match those |
||
169 | * of this expectation |
||
170 | * |
||
171 | * @param array $args |
||
172 | * @return mixed |
||
173 | */ |
||
174 | 234 | public function verifyCall(array $args) |
|
188 | |||
189 | /** |
||
190 | * Sets public properties with queued values to the mock object |
||
191 | * |
||
192 | * @param array $args |
||
|
|||
193 | * @return mixed |
||
194 | */ |
||
195 | 226 | protected function _setValues() |
|
204 | |||
205 | /** |
||
206 | * Fetch the return value for the matching args |
||
207 | * |
||
208 | * @param array $args |
||
209 | * @return mixed |
||
210 | */ |
||
211 | 232 | protected function _getReturnValue(array $args) |
|
212 | { |
||
213 | 232 | if (count($this->_closureQueue) > 1) { |
|
214 | return call_user_func_array(array_shift($this->_closureQueue), $args); |
||
215 | 232 | } elseif (count($this->_closureQueue) > 0) { |
|
216 | 1 | return call_user_func_array(current($this->_closureQueue), $args); |
|
217 | 231 | } elseif (count($this->_returnQueue) > 1) { |
|
218 | 5 | return array_shift($this->_returnQueue); |
|
219 | 230 | } elseif (count($this->_returnQueue) > 0) { |
|
220 | 92 | return current($this->_returnQueue); |
|
221 | } |
||
222 | |||
223 | 139 | return $this->_mock->mockery_returnValueForMethod($this->_name); |
|
224 | } |
||
225 | |||
226 | /** |
||
227 | * Checks if this expectation is eligible for additional calls |
||
228 | * |
||
229 | * @return bool |
||
230 | */ |
||
231 | 272 | public function isEligible() |
|
232 | { |
||
233 | 272 | foreach ($this->_countValidators as $validator) { |
|
234 | 139 | if (!$validator->isEligible($this->_actualCount)) { |
|
235 | 22 | return false; |
|
236 | } |
||
237 | 269 | } |
|
238 | 269 | return true; |
|
239 | } |
||
240 | |||
241 | /** |
||
242 | * Check if there is a constraint on call count |
||
243 | * |
||
244 | * @return bool |
||
245 | */ |
||
246 | public function isCallCountConstrained() |
||
247 | { |
||
248 | return (count($this->_countValidators) > 0); |
||
249 | } |
||
250 | |||
251 | /** |
||
252 | * Verify call order |
||
253 | * |
||
254 | * @return void |
||
255 | */ |
||
256 | 234 | public function validateOrder() |
|
266 | |||
267 | /** |
||
268 | * Verify this expectation |
||
269 | * |
||
270 | * @return bool |
||
271 | */ |
||
272 | 144 | public function verify() |
|
278 | |||
279 | /** |
||
280 | * Check if the registered expectation is a MultiArgumentClosureExpectation. |
||
281 | * @return bool |
||
282 | */ |
||
283 | 116 | private function isMultiArgumentClosureExpectation() |
|
287 | |||
288 | /** |
||
289 | * Check if passed arguments match an argument expectation |
||
290 | * |
||
291 | * @param array $args |
||
292 | * @return bool |
||
293 | */ |
||
294 | 278 | public function matchArgs(array $args) |
|
315 | |||
316 | /** |
||
317 | * Check if passed argument matches an argument expectation |
||
318 | * |
||
319 | * @param mixed $expected |
||
320 | * @param mixed &$actual |
||
321 | * @return bool |
||
322 | */ |
||
323 | 108 | protected function _matchArg($expected, &$actual) |
|
324 | { |
||
325 | 108 | if ($expected === $actual) { |
|
326 | 30 | return true; |
|
327 | } |
||
328 | 90 | if (!is_object($expected) && !is_object($actual) && $expected == $actual) { |
|
329 | return true; |
||
330 | } |
||
331 | 90 | if (is_string($expected) && !is_array($actual) && !is_object($actual)) { |
|
332 | # push/pop an error handler here to to make sure no error/exception thrown if $expected is not a regex |
||
333 | 6 | set_error_handler(function () { |
|
334 | 6 | }); |
|
335 | 6 | $result = preg_match($expected, (string) $actual); |
|
336 | 6 | restore_error_handler(); |
|
337 | |||
338 | 6 | if ($result) { |
|
339 | 3 | return true; |
|
340 | } |
||
341 | 3 | } |
|
342 | 89 | if (is_string($expected) && is_object($actual)) { |
|
343 | 1 | $result = $actual instanceof $expected; |
|
344 | 1 | if ($result) { |
|
345 | 1 | return true; |
|
346 | } |
||
347 | } |
||
348 | 88 | if ($expected instanceof \Mockery\Matcher\MatcherAbstract) { |
|
349 | 67 | return $expected->match($actual); |
|
350 | } |
||
351 | 21 | if ($expected instanceof \Hamcrest\Matcher || $expected instanceof \Hamcrest_Matcher) { |
|
352 | 3 | return $expected->matches($actual); |
|
353 | } |
||
354 | 18 | return false; |
|
355 | } |
||
356 | |||
357 | /** |
||
358 | * Expected argument setter for the expectation |
||
359 | * |
||
360 | * @param mixed ... |
||
361 | * @return self |
||
362 | */ |
||
363 | 130 | public function with() |
|
367 | |||
368 | /** |
||
369 | * Expected arguments for the expectation passed as an array |
||
370 | * |
||
371 | * @param array $arguments |
||
372 | * @return self |
||
373 | */ |
||
374 | 138 | private function withArgsInArray(array $arguments) |
|
383 | |||
384 | /** |
||
385 | * Expected arguments have to be matched by the given closure. |
||
386 | * |
||
387 | * @param Closure $closure |
||
388 | * @return self |
||
389 | */ |
||
390 | 6 | private function withArgsMatchedByClosure(Closure $closure) |
|
396 | |||
397 | /** |
||
398 | * Expected arguments for the expectation passed as an array or a closure that matches each passed argument on |
||
399 | * each function call. |
||
400 | * |
||
401 | * @param array|Closure $argsOrClosure |
||
402 | * @return self |
||
403 | */ |
||
404 | 145 | public function withArgs($argsOrClosure) |
|
416 | |||
417 | /** |
||
418 | * Set with() as no arguments expected |
||
419 | * |
||
420 | * @return self |
||
421 | */ |
||
422 | 6 | public function withNoArgs() |
|
428 | |||
429 | /** |
||
430 | * Set expectation that any arguments are acceptable |
||
431 | * |
||
432 | * @return self |
||
433 | */ |
||
434 | 2 | public function withAnyArgs() |
|
439 | |||
440 | /** |
||
441 | * Set a return value, or sequential queue of return values |
||
442 | * |
||
443 | * @param mixed ... |
||
444 | * @return self |
||
445 | */ |
||
446 | 105 | public function andReturn() |
|
451 | |||
452 | /** |
||
453 | * Set a return value, or sequential queue of return values |
||
454 | * |
||
455 | * @param mixed ... |
||
456 | * @return self |
||
457 | */ |
||
458 | public function andReturns() |
||
459 | { |
||
460 | return call_user_func_array([$this, 'andReturn'], func_get_args()); |
||
461 | } |
||
462 | |||
463 | /** |
||
464 | * Return this mock, like a fluent interface |
||
465 | * |
||
466 | * @return self |
||
467 | */ |
||
468 | 1 | public function andReturnSelf() |
|
469 | { |
||
470 | 1 | return $this->andReturn($this->_mock); |
|
471 | } |
||
472 | |||
473 | /** |
||
474 | * Set a sequential queue of return values with an array |
||
475 | * |
||
476 | * @param array $values |
||
477 | * @return self |
||
478 | */ |
||
479 | 2 | public function andReturnValues(array $values) |
|
480 | { |
||
481 | 2 | call_user_func_array(array($this, 'andReturn'), $values); |
|
482 | 2 | return $this; |
|
483 | } |
||
484 | |||
485 | /** |
||
486 | * Set a closure or sequence of closures with which to generate return |
||
487 | * values. The arguments passed to the expected method are passed to the |
||
488 | * closures as parameters. |
||
489 | * |
||
490 | * @param callable ... |
||
491 | * @return self |
||
492 | */ |
||
493 | 1 | public function andReturnUsing() |
|
498 | |||
499 | /** |
||
500 | * Return a self-returning black hole object. |
||
501 | * |
||
502 | * @return self |
||
503 | */ |
||
504 | 1 | public function andReturnUndefined() |
|
505 | { |
||
506 | 1 | $this->andReturn(new \Mockery\Undefined); |
|
507 | 1 | return $this; |
|
508 | } |
||
509 | |||
510 | /** |
||
511 | * Return null. This is merely a language construct for Mock describing. |
||
512 | * |
||
513 | * @return self |
||
514 | */ |
||
515 | 1 | public function andReturnNull() |
|
516 | { |
||
517 | 1 | return $this; |
|
518 | } |
||
519 | |||
520 | 1 | public function andReturnFalse() |
|
521 | { |
||
522 | 1 | return $this->andReturn(false); |
|
523 | } |
||
524 | |||
525 | 1 | public function andReturnTrue() |
|
526 | { |
||
527 | 1 | return $this->andReturn(true); |
|
528 | } |
||
529 | |||
530 | /** |
||
531 | * Set Exception class and arguments to that class to be thrown |
||
532 | * |
||
533 | * @param string|\Exception $exception |
||
534 | * @param string $message |
||
535 | * @param int $code |
||
536 | * @param \Exception $previous |
||
537 | * @return self |
||
538 | */ |
||
539 | 6 | public function andThrow($exception, $message = '', $code = 0, \Exception $previous = null) |
|
540 | { |
||
541 | 6 | $this->_throw = true; |
|
542 | 6 | if (is_object($exception)) { |
|
543 | 2 | $this->andReturn($exception); |
|
544 | 2 | } else { |
|
545 | 4 | $this->andReturn(new $exception($message, $code, $previous)); |
|
546 | } |
||
547 | 6 | return $this; |
|
548 | } |
||
549 | |||
550 | /** |
||
551 | * Set Exception classes to be thrown |
||
552 | * |
||
553 | * @param array $exceptions |
||
554 | * @return self |
||
555 | */ |
||
556 | 2 | public function andThrowExceptions(array $exceptions) |
|
557 | { |
||
558 | 2 | $this->_throw = true; |
|
559 | 2 | foreach ($exceptions as $exception) { |
|
560 | 2 | if (!is_object($exception)) { |
|
561 | 1 | throw new Exception('You must pass an array of exception objects to andThrowExceptions'); |
|
562 | } |
||
563 | 1 | } |
|
564 | 1 | return $this->andReturnValues($exceptions); |
|
565 | } |
||
566 | |||
567 | /** |
||
568 | * Register values to be set to a public property each time this expectation occurs |
||
569 | * |
||
570 | * @param string $name |
||
571 | * @param mixed $value |
||
572 | * @return self |
||
573 | */ |
||
574 | 8 | public function andSet($name, $value) |
|
575 | { |
||
576 | 8 | $values = func_get_args(); |
|
577 | 8 | array_shift($values); |
|
578 | 8 | $this->_setQueue[$name] = $values; |
|
579 | 8 | return $this; |
|
580 | } |
||
581 | |||
582 | /** |
||
583 | * Alias to andSet(). Allows the natural English construct |
||
584 | * - set('foo', 'bar')->andReturn('bar') |
||
585 | * |
||
586 | * @param string $name |
||
587 | * @param mixed $value |
||
588 | * @return self |
||
589 | */ |
||
590 | 3 | public function set($name, $value) |
|
594 | |||
595 | /** |
||
596 | * Indicates this expectation should occur zero or more times |
||
597 | * |
||
598 | * @return self |
||
599 | */ |
||
600 | 2 | public function zeroOrMoreTimes() |
|
601 | { |
||
602 | 2 | $this->atLeast()->never(); |
|
603 | 2 | } |
|
604 | |||
605 | /** |
||
606 | * Indicates the number of times this expectation should occur |
||
607 | * |
||
608 | * @param int $limit |
||
609 | * @throws InvalidArgumentException |
||
610 | * @return self |
||
611 | */ |
||
612 | 158 | public function times($limit = null) |
|
613 | { |
||
614 | 158 | if (is_null($limit)) { |
|
615 | return $this; |
||
616 | } |
||
617 | 158 | if (!is_int($limit)) { |
|
618 | 1 | throw new \InvalidArgumentException('The passed Times limit should be an integer value'); |
|
619 | } |
||
620 | 157 | $this->_countValidators[] = new $this->_countValidatorClass($this, $limit); |
|
621 | 157 | $this->_countValidatorClass = 'Mockery\CountValidator\Exact'; |
|
622 | 157 | return $this; |
|
623 | } |
||
624 | |||
625 | /** |
||
626 | * Indicates that this expectation is never expected to be called |
||
627 | * |
||
628 | * @return self |
||
629 | */ |
||
630 | 38 | public function never() |
|
631 | { |
||
632 | 38 | return $this->times(0); |
|
633 | } |
||
634 | |||
635 | /** |
||
636 | * Indicates that this expectation is expected exactly once |
||
637 | * |
||
638 | * @return self |
||
639 | */ |
||
640 | 108 | public function once() |
|
641 | { |
||
642 | 108 | return $this->times(1); |
|
643 | } |
||
644 | |||
645 | /** |
||
646 | * Indicates that this expectation is expected exactly twice |
||
647 | * |
||
648 | * @return self |
||
649 | */ |
||
650 | 19 | public function twice() |
|
654 | |||
655 | /** |
||
656 | * Sets next count validator to the AtLeast instance |
||
657 | * |
||
658 | * @return self |
||
659 | */ |
||
660 | 14 | public function atLeast() |
|
665 | |||
666 | /** |
||
667 | * Sets next count validator to the AtMost instance |
||
668 | * |
||
669 | * @return self |
||
670 | */ |
||
671 | 7 | public function atMost() |
|
672 | { |
||
673 | 7 | $this->_countValidatorClass = 'Mockery\CountValidator\AtMost'; |
|
674 | 7 | return $this; |
|
675 | } |
||
676 | |||
677 | /** |
||
678 | * Shorthand for setting minimum and maximum constraints on call counts |
||
679 | * |
||
680 | * @param int $minimum |
||
681 | * @param int $maximum |
||
682 | */ |
||
683 | public function between($minimum, $maximum) |
||
687 | |||
688 | /** |
||
689 | * Indicates that this expectation must be called in a specific given order |
||
690 | * |
||
691 | * @param string $group Name of the ordered group |
||
692 | * @return self |
||
693 | */ |
||
694 | 17 | public function ordered($group = null) |
|
704 | |||
705 | /** |
||
706 | * Indicates call order should apply globally |
||
707 | * |
||
708 | * @return self |
||
709 | */ |
||
710 | 1 | public function globally() |
|
715 | |||
716 | /** |
||
717 | * Setup the ordering tracking on the mock or mock container |
||
718 | * |
||
719 | * @param string $group |
||
720 | * @param object $ordering |
||
721 | * @return int |
||
722 | */ |
||
723 | 17 | protected function _defineOrdered($group, $ordering) |
|
736 | |||
737 | /** |
||
738 | * Return order number |
||
739 | * |
||
740 | * @return int |
||
741 | */ |
||
742 | 1 | public function getOrderNumber() |
|
746 | |||
747 | /** |
||
748 | * Mark this expectation as being a default |
||
749 | * |
||
750 | * @return self |
||
751 | */ |
||
752 | 25 | public function byDefault() |
|
760 | |||
761 | /** |
||
762 | * Return the parent mock of the expectation |
||
763 | * |
||
764 | * @return \Mockery\MockInterface |
||
765 | */ |
||
766 | 29 | public function getMock() |
|
770 | |||
771 | /** |
||
772 | * Flag this expectation as calling the original class method with the |
||
773 | * any provided arguments instead of using a return value queue. |
||
774 | * |
||
775 | * @return self |
||
776 | */ |
||
777 | 3 | public function passthru() |
|
788 | |||
789 | /** |
||
790 | * Cloning logic |
||
791 | * |
||
792 | */ |
||
793 | 9 | public function __clone() |
|
802 | |||
803 | 6 | public function getName() |
|
807 | } |
||
808 |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.
Consider the following example. The parameter
$italy
is not defined by the methodfinale(...)
.The most likely cause is that the parameter was removed, but the annotation was not.