padosoft /
tessera-sanitaria
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like ValidateHelper often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ValidateHelper, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 8 | class ValidateHelper |
||
| 9 | { |
||
| 10 | use traits\Errorable; |
||
| 11 | |||
| 12 | private $objPartitaIVA = null; |
||
| 13 | private $objCFChecker = null; |
||
| 14 | |||
| 15 | /**+ |
||
| 16 | * ValidateHelper constructor. |
||
| 17 | * |
||
| 18 | * @param \fdisotto\PartitaIVA $objPartitaIVA |
||
| 19 | * @param \CodiceFiscale\Checker $objCFChecker |
||
| 20 | */ |
||
| 21 | public function __construct(\fdisotto\PartitaIVA $objPartitaIVA, \CodiceFiscale\Checker $objCFChecker) |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @param $codice |
||
| 30 | * @param $codice_nome |
||
| 31 | * @param array $arrCodiciValidi |
||
| 32 | * @param $codice_len |
||
| 33 | */ |
||
| 34 | public function checkCodice($codice, $codice_nome, array $arrCodiciValidi, $codice_len) |
||
| 35 | { |
||
| 36 | if($codice==''){ |
||
| 37 | $this->addError("$codice_nome mancante"); |
||
| 38 | }else{ |
||
| 39 | if( is_int($codice_len) && ($codice_len>0) && strlen($codice) != $codice_len){ |
||
| 40 | $this->addError("<b>".$codice."</b> - Il $codice_nome deve essere lungo $codice_len caratteri"); |
||
| 41 | } |
||
| 42 | |||
| 43 | if(!in_array($codice, $arrCodiciValidi)){ |
||
| 44 | $this->addError("<b>".$codice."</b> - $codice_nome non valido. Codici validi: ".implode(", ",$arrCodiciValidi)); |
||
| 45 | } |
||
| 46 | } |
||
| 47 | } |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @param $codiceRegione |
||
| 51 | */ |
||
| 52 | public function checkCodiceRegione($codiceRegione) |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @param $codiceSSA |
||
| 59 | */ |
||
| 60 | public function checkCodiceSSA($codiceSSA) |
||
| 64 | |||
| 65 | /** |
||
| 66 | * @param $dateStr |
||
| 67 | * |
||
| 68 | * @return bool |
||
| 69 | */ |
||
| 70 | private function IsoDateValidate($dateStr) |
||
| 78 | |||
| 79 | /**+ |
||
| 80 | * @param $arrVociSpesa |
||
| 81 | */ |
||
| 82 | public function checkArrVociSpesa($arrVociSpesa) |
||
| 102 | |||
| 103 | /** |
||
| 104 | * @param $arrSpesa |
||
| 105 | */ |
||
| 106 | public function checkArrSpesa($arrSpesa) |
||
| 125 | |||
| 126 | /** |
||
| 127 | * @param $pIva |
||
| 128 | */ |
||
| 129 | public function checkPIva($pIva) |
||
| 140 | |||
| 141 | /** |
||
| 142 | * @param $cfProprietario |
||
| 143 | */ |
||
| 144 | public function checkCfProprietario($cfProprietario) |
||
| 155 | |||
| 156 | /** |
||
| 157 | * @param $codiceAsl |
||
| 158 | */ |
||
| 159 | public function checkCodiceAsl($codiceAsl) |
||
| 163 | |||
| 164 | /** |
||
| 165 | * @param $campo |
||
| 166 | * @param $valore |
||
| 167 | */ |
||
| 168 | private function checkDataValida($campo, $valore) |
||
| 178 | |||
| 179 | /** |
||
| 180 | * @param $campo |
||
| 181 | * @param $valore |
||
| 182 | * @param $arrTipiSpesaPermessi |
||
| 183 | */ |
||
| 184 | private function checkTipoSpesa($campo, $valore, $arrTipiSpesaPermessi) |
||
| 190 | |||
| 191 | /** |
||
| 192 | * @param $campo |
||
| 193 | * @param $valore |
||
| 194 | */ |
||
| 195 | private function checkImporto($campo, $valore) |
||
| 201 | |||
| 202 | /** |
||
| 203 | * @param $valore |
||
| 204 | * @param $campo |
||
| 205 | */ |
||
| 206 | private function checkRequiredField($valore, $campo) |
||
| 212 | |||
| 213 | /** |
||
| 214 | * @param $campo |
||
| 215 | * @param $valore |
||
| 216 | */ |
||
| 217 | private function checkDataEmissione($campo, $valore) |
||
| 223 | |||
| 224 | /** |
||
| 225 | * @param $campo |
||
| 226 | * @param $valore |
||
| 227 | * @param $arrFlagOperazione |
||
| 228 | */ |
||
| 229 | private function checkFlagOperazione($campo, $valore, $arrFlagOperazione) |
||
| 235 | |||
| 236 | /** |
||
| 237 | * @param $campo |
||
| 238 | * @param $valore |
||
| 239 | */ |
||
| 240 | private function checkCfCittadino($campo, $valore) |
||
| 246 | |||
| 247 | /** |
||
| 248 | * @param $campo |
||
| 249 | * @param $valore |
||
| 250 | */ |
||
| 251 | private function checkDispositivo($campo, $valore) |
||
| 257 | |||
| 258 | /** |
||
| 259 | * @param $campo |
||
| 260 | * @param $valore |
||
| 261 | */ |
||
| 262 | private function checkNumDocumento($campo, $valore) |
||
| 268 | |||
| 269 | /** |
||
| 270 | * @param $rigaSpesa |
||
| 271 | * @param $arrFlagOperazione |
||
| 272 | */ |
||
| 273 | private function checkRigaSPesa($rigaSpesa, $arrFlagOperazione) |
||
| 290 | |||
| 291 | } |
||
| 292 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.