Padosoft\Uploadable\Helpers\RequestHelper

Complexity

Total Complexity

10

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	currentRequestHasFiles()	0	4	1
A	requestHasFiles()	0	4	3
A	isValidCurrentRequestUploadFile()	0	4	1
A	isValidUploadFile()	0	10	2
A	getCurrentRequestFileSafe()	0	4	1
A	getFileSafe()	0	9	2

<?php

namespace Padosoft\Uploadable\Helpers;

use Illuminate\Http\Request;

/**
 * Illuminate\Http\Request helper
 * @package Padosoft\Uploadable\Helpers
 */
class RequestHelper
{
    /**
     * Check if the current request has at least one file
     * @return bool
     */
    public static function currentRequestHasFiles() : bool
    {
        return RequestHelper::requestHasFiles(request());
    }

    /**
     * Check if the passed request has at least one file
     * @param Request $request
     * @return bool
     */
    public static function requestHasFiles(Request $request) : bool
    {
        return ($request && $request->allFiles() && count($request->allFiles()) > 0);
    }

    /**
     * Check if uploaded File in current request is valid and has a valid Mime Type.
     * Return true is all ok, otherwise return false.
     * @param string $uploadField
     * @param array $arrMimeType
     * @return bool
     */
    public static function isValidCurrentRequestUploadFile(string $uploadField, array $arrMimeType = array()) : bool
    {
        return RequestHelper::isValidUploadFile($uploadField, $arrMimeType, request());
    }

    /**
     * Check if uploaded File is valid and has a valid Mime Type.
     * Return true is all ok, otherwise return false.
     * @param string $uploadField
     * @param array $arrMimeType
     * @param Request $request
     * @return bool
     */
    public static function isValidUploadFile(string $uploadField, array $arrMimeType = array(), Request $request) : bool
    {
        if (!$request) {
            return false;
        }

        $uploadedFile = $request->file($uploadField);

        return UploadedFileHelper::isValidUploadFile($arrMimeType, $uploadedFile);

It seems like $uploadedFile defined by $request->file($uploadField) on line 58 can also be of type array or null; however, Padosoft\Uploadable\Helpers\UploadedFileHelper::isValidUploadFile() does only seem to accept object<Illuminate\Http\UploadedFile>, maybe add an additional type check?

    }

    /**
     * Return File in Current Request if ok, otherwise return null
     * @param string $uploadField
     * @param array $arrMimeType
     * @return null|UploadedFile
     */
    public static function getCurrentRequestFileSafe(string $uploadField, array $arrMimeType = array()) : UploadedFile
    {
        return RequestHelper::getFileSafe($uploadField, $arrMimeType, request());
    }

    /**
     * Return File in passed request if ok, otherwise return null
     * @param string $uploadField
     * @param array $arrMimeType
     * @param Request $request
     * @return null|UploadedFile
     */
    public static function getFileSafe(string $uploadField, array $arrMimeType = array(), Request $request) : UploadedFile
    {
        // Check if uploaded File is valid
        if (!RequestHelper::isValidUploadFile($uploadField, $arrMimeType, $request)) {
            return null;
        }

        return $request->file($uploadField);
    }
}